Page MenuHomePhabricator
Create Task
Maniphest T4018

Allow bin/config to affect database configuration and migrate between local and database configuration
Closed, ResolvedPublic
Actions

Description

Three major use cases:

  • Understanding effective configured values.
  • Removing database configuration which has become locked after it was set (T5949).
  • Migrating old local configuration to the database (original issue here).

Specifically:

  • bin/config get should read and return values from the database. Currently, it does not.
  • bin/config delete and bin/config set should have a --database flag which affects the database instead of the local config. bin/config set --database should refuse to set locked values.
  • bin/config migrate should copy all existent, not-locked local config values to the database.
  • Ideally, we should not respect locked configuration values that are set in the database, although this is potentially a big backward compatibility break.

Currently we still have a lot of config sitting in "conf/custom/myconfig.conf.php". Since Phabricator is moving away from this form of configuration, it'd be good to have a tool to migrate the configuration sitting in the myconfig.conf.php to local.conf / DB.

Revisions and Commits

rP Phabricator
D10490rPc0848bca6d91 Allow bin/config to affect database configuration and migrate between local and…

Related Objects

Event Timeline

hach-que created this task.Oct 23 2013, 12:06 PM
hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Phabricator.
hach-que added subscribers: hach-que, Unknown Object (User).
epriestley triaged this task as Wishlist priority.Apr 24 2014, 12:40 PM

This would still be nice to build, but few installs have run into issues with it and I'd expect to have fewer issues over time, since new installs are probably mostly not using config files.

epriestley added a subscriber: GMTA.Aug 25 2014, 2:43 AM

◀ Merged tasks: T5949.

epriestley renamed this task from Tool to migrate default.conf.php to local.json / DB to Allow bin/config to affect database configuration and migrate between local and database configuration.Aug 25 2014, 2:48 AM
epriestley reassigned this task from epriestley to btrahan.
epriestley raised the priority of this task from Wishlist to Normal.
epriestley updated the task description. (Show Details)
epriestley added a subscriber: epriestley.

Two other related issues have cropped up since this was filed. I updated the description to reflect the state of the world.

btrahan added a revision: D10490: Allow bin/config to affect database configuration and migrate between local and database configuration.Sep 12 2014, 7:45 PM
epriestley added a project: Support Impact.Oct 3 2014, 4:24 AM

Support Impact Addresses various support issues with multiple occurrences.

joshuaspence added a subscriber: joshuaspence.Oct 8 2014, 8:34 PM
btrahan closed this task as Resolved.Oct 8 2014, 11:09 PM
btrahan added a commit: rPc0848bca6d91: Allow bin/config to affect database configuration and migrate between local and….

Closed by commit rPc0848bca6d91.

btrahan added a comment.Oct 8 2014, 11:10 PM

Note that the other potential issue identified here - https://secure.phabricator.com/D10490#90899 - is not fixed by these changes. "bin/migrate" started to feel a bit crazy magical to me and otherwise I think we can deal with this unaddressed problem if / when we create it.

Phabricator · Built by Phacility