Page MenuHomePhabricator
Create Task
Maniphest T6336

Revision stuck in importing (after phabricator upgrade)
Closed, ResolvedPublic
Actions

Description

After a phabricator upgrade this morning, commits are no longer importing. We were running a commit from about a month ago previously. We are using phabricator hosted git repositories with Herald rules triggered on commit.

I see no errors since daemon start in /var/tmp/phd/log/daemons.log. All checkboxes green on repository status page. Forcing a repository update does not help.

./bin/repository importing ZU shows:
rZU68059b3473d53c28e4ddffb3cd0bac79ed719fbb Herald
rZU011a6af20dac1cae5efc9ab191645248f315e85e Herald

Not sure how to get them unstuck from that state.

Revisions and Commits

rP Phabricator
D10723rPba2963ecb3bb Diffusion - fix commits not importing fully

Related Objects

Event Timeline

austinf created this task.Oct 16 2014, 6:26 PM
austinf raised the priority of this task from to Needs Triage.
austinf updated the task description. (Show Details)
austinf added a subscriber: austinf.
austinf added a comment.Oct 16 2014, 6:35 PM

The Herald rule appears to have completed fine as well.

Actions Taken
Trigger an Audit by: Everest
Conditions were met for H1 Everest Review·Outcome: Triggered an audit.
Rule Details
Everest Review
✓ Condition: Repository's projects include all of Everest
✓ Condition: Differential revision does not exist
✓ Condition: Commit's branches contains master
PASSAll conditions matched.

chad added a subscriber: chad.Oct 16 2014, 8:39 PM

Is it a single revision or any new commit? What is your update workflow, do you use our scripts?

austinf added a comment.Oct 16 2014, 8:46 PM

Looks like any new commit. Adapted your script from here https://secure.phabricator.com/book/phabricator/article/installation_guide/#updating-phabricator to work on our system. We use systemd to manage stopping and starting daemons is the only difference.

chad added a comment.Oct 16 2014, 10:57 PM

Can you try --trace and paste the output?

richardvanvelzen added a subscriber: richardvanvelzen.Oct 17 2014, 9:44 AM
mclion added a subscriber: mclion.Oct 17 2014, 1:50 PM
chad added a project: Support Impact.Oct 17 2014, 1:55 PM

Support Impact several people have has issues this week after upgrading.

btrahan claimed this task.Oct 17 2014, 3:31 PM

we seem to reproduce this here now on at least a few commits.

btrahan added a comment.Oct 17 2014, 3:58 PM

Does anyone have any errors in their log?

./bin/phd log
./bin/phd log --limit 10000  #look back further if nothing useful

iiam

austinf added a comment.Oct 17 2014, 4:11 PM

No errors in log there either, running ./bin/repository importing ZU --trace just gives the query:

>>> [2] <connect> phabricator_repository
<<< [2] <connect> 1,219 us
>>> [3] <query> SELECT * FROM `repository` r  WHERE (r.callsign IN ('ZU')) ORDER BY r.id DESC
<<< [3] <query> 385 us
>>> [4] <query> SELECT repositoryID, commitIdentifier, importStatus FROM `repository_commit`
        WHERE repositoryID IN (333) AND (importStatus & 15) != 15
<<< [4] <query> 2,382 us
rZU68059b3473d53c28e4ddffb3cd0bac79ed719fbb Herald
rZU011a6af20dac1cae5efc9ab191645248f315e85e Herald
btrahan added a revision: D10723: Diffusion - fix commits not importing fully.Oct 17 2014, 4:23 PM
btrahan added a comment.Oct 17 2014, 4:24 PM

Well, I think I solved the mystery... See D10723.

btrahan closed this task as Resolved.Oct 17 2014, 4:35 PM
btrahan added a commit: rPba2963ecb3bb: Diffusion - fix commits not importing fully.

Closed by commit rPba2963ecb3bb.

austinf added a comment.Oct 17 2014, 4:36 PM

Awesome, thanks for the quick fix. Can you tell me how to make it re-parse commits that are stuck?

btrahan added a comment.Oct 17 2014, 4:39 PM

This is now fixed. See rPe6d946661ddf296d44063f12e44925a35271cc6f for an example that was broken on this install and subsequently fixed.

If you have any commits impacted by this, please run

scripts/repository/reparse.php --herald rXnnnnn

to fix it. Note you will see some duplicate transactions but at least the commit will be fully imported.

Phabricator · Built by Phacility