Maniphest T5693

Matching of "Differential Revision" domain names is impossible to debug
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Jul 23 2014, 10:19 PM

Tags

Referenced Files

None

Subscribers

Description

An install hit an issue where a stray config file set the base URI to http://domain.com instead of https://domain.com. This took over 95 hours of work to debug.

We should ignore the protocol, port, etc., when making this comparison -- http and https are the same install.
Per T4767, this should be explicitly walked through in the UI. This failure mode is horrible and not remotely obvious.

Revisions and Commits

rP Phabricator
	Closed		D10489 Increase clarity when closing a revision in response to a commit
		D10701	rPaf4ebc67c66f Differental - match "Revision ID:" uri value on domain only

Related Objects
Search...

		Status	Assigned	Task
				Restricted Maniphest Task
		Resolved	epriestley	T4767 Autoclose and "Fixes/Ref" are too difficult for users to debug
		Resolved	btrahan	T5693 Matching of "Differential Revision" domain names is impossible to debug

Event Timeline

epriestley created this task.Jul 23 2014, 10:19 PM

epriestley raised the priority of this task from to Normal.

epriestley updated the task description. (Show Details)

epriestley added a project: Differential.

epriestley added subscribers: epriestley, nharkins.

• miz added a subscriber: • miz.Jul 24 2014, 1:27 AM

• miz removed a subscriber: • miz.

epriestley mentioned this in D10489: Increase clarity when closing a revision in response to a commit.Sep 14 2014, 2:37 PM

This is probably worth folding into D10489 since I think it's only a few lines off the main path.

Support Impact Support cost for the in-the-wild instance of this was seriously more than an hour.

btrahan added a revision: D10489: Increase clarity when closing a revision in response to a commit.Oct 13 2014, 8:01 PM

btrahan added a revision: D10701: Differental - match "Revision ID:" uri value on domain only.Oct 14 2014, 12:00 AM

Closed by commit rPaf4ebc67c66f.

epriestley mentioned this in T6483: Diffusion doesn't recognize commit landing w/ `Signed-off-by:` line.Nov 6 2014, 3:51 PM