HomePhabricator

Move ported inlines which appear on nonvisible lines backward so they show up

Tags
None
Referenced Files
F377733: Screen_Shot_2015-04-21_at_6.54.57_AM.png
Apr 21 2015, 6:08 PM
F377732: missing.png
Apr 21 2015, 6:08 PM
Subscribers
None

Description

Move ported inlines which appear on nonvisible lines backward so they show up

Summary:
Ref T7447. Ref T7870. See T7870 for a detailed description of this issue.

NOTE: Replying to these inlines from the UI still does the wrong thing, because we use the database line number, not the UI line number.

Test Plan:
Before:

missing.png (935×1 px, 165 KB)

After:

Screen_Shot_2015-04-21_at_6.54.57_AM.png (754×817 px, 78 KB)

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7447, T7870

Differential Revision: https://secure.phabricator.com/D12491