Page MenuHomePhabricator

Make "Reply" on ghost inlines work correctly (or, at least, consistently)
ClosedPublic

Authored by epriestley on Apr 21 2015, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 7:02 PM
Unknown Object (File)
Tue, Mar 12, 8:49 AM
Unknown Object (File)
Mon, Mar 4, 4:50 PM
Unknown Object (File)
Fri, Mar 1, 10:46 PM
Unknown Object (File)
Fri, Mar 1, 12:50 PM
Unknown Object (File)
Feb 17 2024, 4:37 PM
Unknown Object (File)
Feb 13 2024, 9:15 PM
Unknown Object (File)
Feb 8 2024, 2:07 PM
Subscribers

Details

Summary

Ref T7447. Ref T7870. When you "reply" to a ghost inline, make it work properly.

This exact behavior is arguable. In particular, when you reply to a ghost inline, we could put the reply on the same diff as the original.

I suspect it aligns better with user exepectation to put the new inline on the current (visible) diff instead, and generally for inlines to flow forward through time and all of the ghosts to pretty much be older than all of the non-ghosts in most cases. We can see how it feels and adjust things if this turns out to not make sense.

Test Plan
  • Replied to ghost inlines, got new inlines on the proper display line.
  • Replied to normal inlines, got normal behavior.
  • Made some new inlines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make "Reply" on ghost inlines work correctly (or, at least, consistently).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

I think the best behavior would probably be to have it show up in both places. That way its like comments are this threaded thing that ghostly moves around as a unit.

This revision is now accepted and ready to land.Apr 21 2015, 5:36 PM

Yeah, it will show up in both places with either approach.

With this approach, it will show up in the "submitted" colors when looking at the diff it was added to, and the "ghostly" colors when looking at the older diff.

With the other approach, it would show up with "ghostly" colors when looking at the diff it was added to, and "submitted" colors when looking at the older diff.

There might be a good reason to switch later, but adding a comment and having it immediately turn into a ghost feels weird to me in the absence of a compelling reason to do that.

Yeah, it will show up in both places with either approach.

With this approach, it will show up in the "submitted" colors when looking at the diff it was added to, and the "ghostly" colors when looking at the older diff.

With the other approach, it would show up with "ghostly" colors when looking at the diff it was added to, and "submitted" colors when looking at the older diff.

There might be a good reason to switch later, but adding a comment and having it immediately turn into a ghost feels weird to me in the absence of a compelling reason to do that.

Oh, gotchya.

This revision was automatically updated to reflect the committed changes.