HomePhabricator

Make Differential timeline aware of ghostly inlines

Tags
None
Referenced Files
F378106: samepage.png
Apr 21 2015, 10:32 PM
Subscribers
None

Description

Make Differential timeline aware of ghostly inlines

Summary:
Ref T7447. Ref T7870.

When a ghostly inline appears on the page, the timeline isn't currently aware that it's present, so it links elsewhere.

Instead, apply adjustments before rendering the timeline.

Ref T5030. This makes the behaviors in T5030 irrelevant most of the time.

Test Plan:
Before:

samepage.png (584×1 px, 65 KB)

After:

  • Inlines visible on page are linked directly.
  • Inlines which we can't port (e.g., on files not present on current page) are still linked off-page.
  • Used "Show Older" to page through and verify consistent rendering.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: yelirekim, epriestley

Maniphest Tasks: T5030, T7870, T7447

Differential Revision: https://secure.phabricator.com/D12497