Page MenuHomePhabricator

Prefer left-side for old comments in new-vs-new diff of diffs
ClosedPublic

Authored by epriestley on Apr 21 2015, 1:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 12:50 PM
Unknown Object (File)
Thu, Mar 14, 2:57 AM
Unknown Object (File)
Feb 8 2024, 5:28 PM
Unknown Object (File)
Feb 3 2024, 3:22 AM
Unknown Object (File)
Dec 27 2023, 6:09 AM
Unknown Object (File)
Dec 23 2023, 5:02 PM
Unknown Object (File)
Dec 21 2023, 1:08 PM
Unknown Object (File)
Dec 20 2023, 7:21 AM
Subscribers

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prefer left-side for old comments in new-vs-new diff of diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

T7870 has a detailed description of the underlying issue here.

src/applications/differential/controller/DifferentialChangesetViewController.php
324–333

This also hopefully explains it.

btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/controller/DifferentialChangesetViewController.php
324–332

s/briging/bringing

328

"human" is a bit too broad I think. e.g. I believe japanese is read right to left

This revision is now accepted and ready to land.Apr 21 2015, 5:32 PM

Well, human users of Differential, where the old diff is always displayed on the left.

epriestley edited edge metadata.
  • Spelling fix.
  • Increase cultural awareness.
This revision was automatically updated to reflect the committed changes.
chad added inline comments.
src/applications/differential/controller/DifferentialChangesetViewController.php
328

I don't think Japanese is an RTL language on the web. (sorry just wanted to test a reply).