Page MenuHomePhabricator

Track ghostly inlines across file moves
ClosedPublic

Authored by epriestley on Apr 21 2015, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 8:48 PM
Unknown Object (File)
Tue, Mar 5, 5:59 PM
Unknown Object (File)
Feb 12 2024, 12:48 PM
Unknown Object (File)
Feb 7 2024, 1:44 PM
Unknown Object (File)
Feb 3 2024, 3:23 AM
Unknown Object (File)
Dec 27 2023, 6:09 AM
Unknown Object (File)
Dec 26 2023, 3:18 PM
Unknown Object (File)
Dec 22 2023, 8:05 PM
Subscribers

Details

Summary

Ref T7447. Ref T7870.

  • Forward: When rendering some file "B" which was moved from "A", port ghosts for both "A" and "B" to it.
  • Backward: When porting a comment on "X" which was moved from some "Y", allow it to port to a file named "Y" if it can't find a file named "X".
Test Plan

Before:

move.png (618×1 px, 100 KB)

After:

Screen_Shot_2015-04-21_at_8.33.57_AM.png (885×1 px, 118 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Track ghostly inlines across file moves.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:38 PM
This revision was automatically updated to reflect the committed changes.