Page MenuHomePhabricator
Differential D12493

Track ghostly inlines across file moves
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 3:34 PM.
Tags
None
Referenced Files
F18907486: D12493.id29997.diff
Sat, Nov 8, 11:48 PM
F18798663: D12493.id.diff
Oct 17 2025, 7:33 AM
F18657379: D12493.id29988.diff
Sep 23 2025, 1:32 AM
F18624207: D12493.id29988.diff
Sep 15 2025, 7:17 PM
F18603542: D12493.diff
Sep 13 2025, 5:27 PM
F18600930: D12493.diff
Sep 13 2025, 11:01 AM
F18591870: D12493.diff
Sep 12 2025, 10:20 AM
F18505451: D12493.id.diff
Sep 5 2025, 12:40 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7447: Bring inline comments forward across revision updates
T7870: List of cases where ghost comments end up somewhere confusing or unexpected
Commits
Restricted Diffusion Commit
rP8c39885076b5: Track ghostly inlines across file moves
Summary

Ref T7447. Ref T7870.

  • Forward: When rendering some file "B" which was moved from "A", port ghosts for both "A" and "B" to it.
  • Backward: When porting a comment on "X" which was moved from some "Y", allow it to port to a file named "Y" if it can't find a file named "X".
Test Plan

Before:

move.png (618×1 px, 100 KB)

After:

Screen_Shot_2015-04-21_at_8.33.57_AM.png (885×1 px, 118 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29988.Apr 21 2015, 3:34 PM
epriestley retitled this revision from to Track ghostly inlines across file moves.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7870: List of cases where ghost comments end up somewhere confusing or unexpected, T7447: Bring inline comments forward across revision updates.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 3:34 PM
epriestley edited the test plan for this revision. (Show Details)Apr 21 2015, 3:34 PM
epriestley mentioned this in T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
btrahan accepted this revision.Apr 21 2015, 5:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:38 PM
Closed by commit rP8c39885076b5: Track ghostly inlines across file moves (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
differential/
controller/
77 lines

Diff 29997

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
Phabricator · Built by Phacility