Page MenuHomePhabricator
Differential D12495

Let ghostly inlines automatically expand changesets in enormous diffs
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 7:57 PM.
Tags
None
Referenced Files
F15467525: D12495.id.diff
Thu, Apr 3, 3:51 PM
F15466652: D12495.id30002.diff
Thu, Apr 3, 7:57 AM
F15465681: D12495.diff
Wed, Apr 2, 9:51 PM
F15409839: D12495.id30006.diff
Wed, Mar 19, 5:40 AM
F15400324: D12495.diff
Mon, Mar 17, 11:00 AM
F15387139: D12495.id30002.diff
Sat, Mar 15, 1:54 AM
F15386793: D12495.id.diff
Sat, Mar 15, 1:18 AM
F15334200: D12495.diff
Sat, Mar 8, 7:30 AM
View All Files
Subscribers
epriestley
yelirekim

Details

Reviewers
btrahan
Maniphest Tasks
T7447: Bring inline comments forward across revision updates
T7870: List of cases where ghost comments end up somewhere confusing or unexpected
Commits
Restricted Diffusion Commit
rPa4a65bd5f1d6: Let ghostly inlines automatically expand changesets in enormous diffs
Summary

Ref T7447. Ref T7870. When a diff affects more than 100 files, we collapse files by default, then expand files with inlines.

Ghostly inlines currently don't cause files to expand, but reasonably should.

Test Plan

Before:

expdn.png (713×1 px, 74 KB)

After:

Screen_Shot_2015-04-21_at_12.51.44_PM.png (1×1 px, 160 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
215 lines
39 lines
query/
188 lines

Diff 30006

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialInlineCommentQuery.php

Loading...
Phabricator · Built by Phacility