Page MenuHomePhabricator

Make Differential timeline aware of ghostly inlines
ClosedPublic

Authored by epriestley on Apr 21 2015, 8:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 7:48 AM
Unknown Object (File)
Sun, Apr 28, 1:00 AM
Unknown Object (File)
Thu, Apr 25, 1:59 AM
Unknown Object (File)
Wed, Apr 24, 2:47 AM
Unknown Object (File)
Thu, Apr 11, 8:17 PM
Unknown Object (File)
Sun, Apr 7, 7:03 PM
Unknown Object (File)
Apr 2 2024, 9:35 PM
Unknown Object (File)
Mar 31 2024, 8:50 PM

Details

Summary

Ref T7447. Ref T7870.

When a ghostly inline appears on the page, the timeline isn't currently aware that it's present, so it links elsewhere.

Instead, apply adjustments before rendering the timeline.

Ref T5030. This makes the behaviors in T5030 irrelevant most of the time.

Test Plan

Before:

samepage.png (584×1 px, 65 KB)

After:

  • Inlines visible on page are linked directly.
  • Inlines which we can't port (e.g., on files not present on current page) are still linked off-page.
  • Used "Show Older" to page through and verify consistent rendering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make Differential timeline aware of ghostly inlines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 10:16 PM
This revision was automatically updated to reflect the committed changes.