Paths

Table of Contentst

In Remarkup, prevent "%%%" on a line from self-terminating the literal block
a900d7b63e95
Actions

Description

In Remarkup, prevent "%%%" on a line from self-terminating the literal block

Summary:
Fixes T12621. Currently, %%% on a line by itself can both start and terminate a literal block. This is silly and presumably not what anyone ever intends.

Instead, if %%% started a block, don't let it terminate the block.

Test Plan:

Added a failing test.
Made it pass.

Screen Shot 2017-04-23 at 5.56.18 AM.png (489×440 px, 28 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12621

Differential Revision: https://secure.phabricator.com/D17772

Details

Provenance

epriestley	Authored on Apr 22 2017, 4:10 PM
epriestley	Pushed on Apr 23 2017, 6:25 PM

Reviewer

chad

Differential Revision

D17772: In Remarkup, prevent "%%%" on a line from self-terminating the literal block

Parents

rPHUd78271470210: Stabilize sort order for Remarkup block rules

Branches

Unknown

Tags

Unknown

Tasks

T12621: remarkup literal block requires text on beginning line

Build Status

Buildable 16682
Build 22249: Run Core Tests

Event Timeline

epriestley committed rPHUa900d7b63e95: In Remarkup, prevent "%%%" on a line from self-terminating the literal block (authored by epriestley).Apr 23 2017, 6:25 PM

epriestley added a task: T12621: remarkup literal block requires text on beginning line.

Harbormaster completed building B16682: rPHUa900d7b63e95: In Remarkup, prevent "%%%" on a line from self-terminating the literal block.Apr 23 2017, 6:26 PM

epriestley mentioned this in 2017 Week 17 (Very Late April).Apr 29 2017, 11:56 AM

epriestley mentioned this in 2017 Week 18 (Early May).May 6 2017, 12:33 AM

joshuaspence mentioned this in T12689: Mail is still received after resigning from a revision.May 8 2017, 10:37 PM

mormegil mentioned this in T12701: Harbormaster does not ignore additional whitespace in HTTP URLs, making invalid HTTP requests.May 10 2017, 10:17 AM

ry mentioned this in T12703: When integrated, CircleCI and Harbormaster can send redundant notifications.May 11 2017, 5:49 PM

franziskus mentioned this in T12705: Set visibility through arc diff.May 12 2017, 5:38 PM

epriestley mentioned this in 2017 Week 19 (Mid May).May 14 2017, 10:12 PM

QuietJoon mentioned this in T12719: Query: Active Repository shows wrong HEAD commit.May 17 2017, 7:23 AM

atul.agrawal9911 mentioned this in T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).May 19 2017, 9:52 AM

mcorteel mentioned this in T12728: Newly created Phriction document doesn't appear in hierarchy.May 19 2017, 1:54 PM

epriestley mentioned this in 2017 Week 20 (Late May).May 19 2017, 10:17 PM

chaseh mentioned this in T12735: InvalidArgumentException when viewing a room you haven't joined from Safari.May 19 2017, 11:28 PM

• Basheer mentioned this in T12741: Phabricator IP address or Mac Address level Blocking Issue..May 22 2017, 3:28 PM

jcox mentioned this in T12753: Pagination breaks when a task is tagged with two subprojects that have a mutual ancestor.May 24 2017, 6:34 PM

epriestley mentioned this in 2017 Week 21 (Very Late May).May 26 2017, 11:04 PM

reed mentioned this in T12766: Can't use `differential.createcomment` with message and action.May 27 2017, 12:56 AM

epriestley mentioned this in 2017 Week 22 (Very Early June).Jun 2 2017, 8:19 PM

daishi mentioned this in T12818: Phriction/Wiki "Move Document" results in "Documents must have content".Jun 9 2017, 10:45 PM

aravindh mentioned this in T11138: mail is not delivered if metamta.placeholder-to-recipient is null.Jun 15 2017, 7:32 PM

shuLhan mentioned this in T12886: Cannot upload file from Firefox (Android).Jun 30 2017, 4:45 AM

chad mentioned this in T12939: Ponder seems to ignore all email settings.Jul 26 2017, 11:44 PM

Changes (2)

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

percent-block-solo.txt

remarkup/

blockrule/

PhutilRemarkupLiteralBlockRule.php

rPHUa900d7b63e95

View Options

src/markup/engine/tests/remarkup/percent-block-solo.txt