Page MenuHomePhabricator

In Remarkup, prevent "%%%" on a line from self-terminating the literal block
ClosedPublic

Authored by epriestley on Apr 23 2017, 1:01 PM.
Tags
None
Referenced Files
F15573882: D17772.id42753.diff
Mon, May 5, 10:29 PM
F15573607: D17772.id.diff
Mon, May 5, 9:20 PM
F15536430: D17772.id42735.diff
Thu, Apr 24, 9:40 AM
F15532193: D17772.id42735.diff
Wed, Apr 23, 2:41 PM
F15519394: D17772.diff
Sat, Apr 19, 10:32 PM
F15484154: D17772.id42753.diff
Apr 9 2025, 4:43 PM
F15482824: D17772.id42735.diff
Apr 9 2025, 8:20 AM
F15478627: D17772.diff
Apr 8 2025, 1:23 AM
Subscribers
None

Details

Summary

Fixes T12621. Currently, %%% on a line by itself can both start and terminate a literal block. This is silly and presumably not what anyone ever intends.

Instead, if %%% started a block, don't let it terminate the block.

Test Plan
  • Added a failing test.
  • Made it pass.

Screen Shot 2017-04-23 at 5.56.18 AM.png (489×440 px, 28 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 23 2017, 6:20 PM
This revision was automatically updated to reflect the committed changes.