Page MenuHomePhabricator

In Remarkup, prevent "%%%" on a line from self-terminating the literal block
ClosedPublic

Authored by epriestley on Apr 23 2017, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 5 2025, 10:29 PM
Unknown Object (File)
May 5 2025, 9:20 PM
Unknown Object (File)
Apr 24 2025, 9:40 AM
Unknown Object (File)
Apr 23 2025, 2:41 PM
Unknown Object (File)
Apr 19 2025, 10:32 PM
Unknown Object (File)
Apr 9 2025, 4:43 PM
Unknown Object (File)
Apr 9 2025, 8:20 AM
Unknown Object (File)
Apr 8 2025, 1:23 AM
Subscribers
None

Details

Summary

Fixes T12621. Currently, %%% on a line by itself can both start and terminate a literal block. This is silly and presumably not what anyone ever intends.

Instead, if %%% started a block, don't let it terminate the block.

Test Plan
  • Added a failing test.
  • Made it pass.

Screen Shot 2017-04-23 at 5.56.18 AM.png (489×440 px, 28 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 23 2017, 6:20 PM
This revision was automatically updated to reflect the committed changes.