Page MenuHomePhabricator

In Remarkup, prevent "%%%" on a line from self-terminating the literal block
ClosedPublic

Authored by epriestley on Apr 23 2017, 1:01 PM.

Details

Summary

Fixes T12621. Currently, %%% on a line by itself can both start and terminate a literal block. This is silly and presumably not what anyone ever intends.

Instead, if %%% started a block, don't let it terminate the block.

Test Plan
  • Added a failing test.
  • Made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 23 2017, 1:01 PM
chad accepted this revision.Apr 23 2017, 6:20 PM

such reg, much ex.

This revision is now accepted and ready to land.Apr 23 2017, 6:20 PM
This revision was automatically updated to reflect the committed changes.