Page MenuHomePhabricator
Feed All Stories

Jul 3 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jul 3 2020, 6:39 PM · Arcanist
epriestley added a comment to T13551: "debug.time-limit" no longer functions in PHP7.

A sometimes-suitable replacement would be some bin/request mechanism which simulates a web request in process. There are some limits to how authentic this can be, but for some substantial subset of hangs it may still be useful.

Jul 3 2020, 6:02 PM · Infrastructure

Jul 1 2020

epriestley triaged T13551: "debug.time-limit" no longer functions in PHP7 as Wishlist priority.
Jul 1 2020, 7:32 PM · Infrastructure
epriestley added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

PHI1776 is another report of this behavior.

Jul 1 2020, 7:05 PM · Bug Report, Diffusion
epriestley created P2145 Command-Line Input.
Jul 1 2020, 12:26 PM
epriestley created P2144 Command-Line Input.
Jul 1 2020, 12:25 PM

Jun 30 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 10:24 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 10:01 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 9:55 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 8:20 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 7:57 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 7:54 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 6:58 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Restricted Differential Revision.
Jun 30 2020, 5:55 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 5:47 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

A related issue is that it is difficult to identify the set of "published" hashes in the general case. We would like arc branches to show all unpublished history, but stop at published history.

Jun 30 2020, 4:48 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 1:41 PM · Arcanist

Jun 28 2020

tkho updated tkho.
Jun 28 2020, 4:27 PM

Jun 24 2020

aklapper created T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.
Jun 24 2020, 10:28 AM · Typeahead, Feature Request

Jun 18 2020

epriestley added a comment to T13546: Modernize the "arc land" workflow.

The major issue I'm trying to deal with now is that if you have a tree like this:

Jun 18 2020, 6:10 PM · Arcanist

Jun 17 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:37 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:34 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:33 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:31 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 2:50 PM · Arcanist
epriestley edited P2143 reach.php.
Jun 17 2020, 2:50 PM

Jun 15 2020

epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

P2143 has some graph reachability code that I don't actually need yet, but may by the time I get here.

Jun 15 2020, 3:15 PM · Restricted Project, Restricted Project, Arcanist
epriestley created P2143 reach.php.
Jun 15 2020, 3:15 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 15 2020, 3:09 PM · Arcanist

Jun 14 2020

tycho.tatitscheff awarded T13107: Git, Slowly and Painfully a Like token.
Jun 14 2020, 9:15 PM · Guides

Jun 12 2020

epriestley triaged T13549: Use "sapi_windows_set_ctrl_handler()" under PHP 7.4 to handle ^C on Windows as Low priority.
Jun 12 2020, 9:00 PM · Arcanist, Windows

Jun 11 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 11 2020, 5:39 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 11 2020, 2:48 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 11 2020, 1:36 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 11 2020, 1:29 PM · Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: Unknown Object (Differential Revision).
Jun 11 2020, 12:08 AM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 11 2020, 12:08 AM · Arcanist

Jun 10 2020

epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: Unknown Object (Differential Revision).
Jun 10 2020, 11:18 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 10 2020, 11:18 PM · Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: Unknown Object (Differential Revision).
Jun 10 2020, 10:36 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 10 2020, 10:36 PM · Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: Unknown Object (Differential Revision).
Jun 10 2020, 10:13 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 10 2020, 10:13 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

The current ls-remote script as written does not actually work; I think it only returns branches in the remote that:

Jun 10 2020, 10:04 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

The actual extension is a 100-line Python script...
The real Pandora's box this opens...

Jun 10 2020, 9:29 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 10 2020, 5:16 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 10 2020, 5:12 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 10 2020, 4:19 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

The real Pandora's box this opens is that now that arc is exposed to whatever issues arise with the raw Python/Mercurial API, there's a much weaker argument against not writing more extensions.

Jun 10 2020, 3:49 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I put the extension in phabricator/ earlier by accident, but that was just me goofing my local paths. The extension is purely client side: hg can do ls-remote just fine (it's just "do hg pull, but stop half way through"), there's just no UI command for it.

Jun 10 2020, 3:42 PM · Mercurial, Arcanist
cspeckmim added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

Would the use of an extension make additional setup necessary for observed repositories vs. hosted repositories, or are observed repositories out of scope for these set of changes?

Jun 10 2020, 3:35 PM · Mercurial, Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: Unknown Object (Differential Revision).
Jun 10 2020, 3:30 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 10 2020, 3:30 PM · Arcanist

Jun 9 2020

epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I am considering reviving the command server since I don't remember it having any critical failures, but offhand:

Jun 9 2020, 5:44 PM · Mercurial, Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: Unknown Object (Differential Revision).
Jun 9 2020, 5:27 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 9 2020, 5:27 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I'm going to try writing a Mercurial extension instead.

Jun 9 2020, 4:23 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I believe this is roughly the form we end up with, which is completely ridiculous and extremely difficult to test or have any confidence in:

Jun 9 2020, 3:27 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

As a tool developer, this kind of thing is infuriating:

Jun 9 2020, 3:14 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

This is also made more complicated because Mercurial branches and bookmarks are all in a single shared namespace to some degree. I'm not sure what happens if you try to fetch a bookmark that conflicts with a local branch name (presumably: it renames it as "divergent"?) or try to fetch a branch which conflicts with a local bookmark name (presumably: fails in a way that's hard to detect?).

Jun 9 2020, 2:14 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

When the user specifies arc land --onto marker, I'd like to identify whether marker is a bookmark or branch.

Jun 9 2020, 1:58 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 9 2020, 1:35 PM · Arcanist
epriestley moved T13214: When there is no remote Mercurial URI, `hg paths default` exits with an error code from Backlog to arc land on the Arcanist board.
Jun 9 2020, 1:07 PM · Mercurial, Arcanist
epriestley moved T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark" from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Guides, Arcanist
epriestley moved T13545: Upgrading: Mid 2020 Changes to "arc diff" from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist, Guides
epriestley moved T13544: Modernize the "arc diff" workflow from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist
epriestley moved T13490: Upgrade all "classic" Arcanist workflows to Toolsets from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist
epriestley closed T13488: Upgrading: Early 2020 Changes to Arcanist as Resolved.

See T13545, T13547, T13548, for the next round.

Jun 9 2020, 2:09 AM · Arcanist, Installing & Upgrading
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`, as Resolved.
Jun 9 2020, 12:32 AM · Prioritized, Restricted Project, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked, as Resolved.
Jun 9 2020, 12:32 AM · Differential, Arcanist, Feature Request
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T6072: Improve usability of `arc diff`, as Resolved.
Jun 9 2020, 12:32 AM · Restricted Project, Documentation, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist as Resolved.

This approximately exists now via T11968.

Jun 9 2020, 12:32 AM · Restricted Project, Prioritized, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`, as Resolved.
Jun 9 2020, 12:32 AM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley closed T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote as Resolved.

I'm not 100% sure I got this, but all of these seem to work now:

Jun 9 2020, 12:29 AM · Arcanist

Jun 8 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 11:56 PM · Arcanist
epriestley closed T13380: `git push` fatals when CWD does not exist as Resolved by committing Restricted Diffusion Commit.
Jun 8 2020, 11:26 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

Screen Shot 2020-06-08 at 4.23.04 PM.png (1×1 px, 932 KB)

Jun 8 2020, 11:24 PM · Arcanist
epriestley closed T5420: Pipe output to a pager as Resolved by committing Restricted Diffusion Commit.
Jun 8 2020, 11:22 PM · Arcanist, libphutil
epriestley closed T12876: Improve initial arc land experience when destination repo is empty as Resolved by committing Restricted Diffusion Commit.
Jun 8 2020, 11:20 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 11:16 PM · Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 8 2020, 10:54 PM · Guides, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 10:42 PM · Arcanist
epriestley edited the content of Changelog.
Jun 8 2020, 9:55 PM
epriestley created an object: 2020 Week 22 (Early June).
Jun 8 2020, 9:54 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 9:53 PM · Arcanist
epriestley closed T2928: "arc start" / "arc feature" / "arc push" Discussion as Resolved.

After D12336:

Jun 8 2020, 9:44 PM · Arcanist, Maniphest, Phrequent
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jun 8 2020, 9:42 PM · Guides, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 9:36 PM · Arcanist
epriestley added a revision to T2928: "arc start" / "arc feature" / "arc push" Discussion: Unknown Object (Differential Revision).
Jun 8 2020, 9:23 PM · Arcanist, Maniphest, Phrequent
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 9:23 PM · Arcanist
epriestley renamed T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark" from Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" to Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jun 8 2020, 7:34 PM · Guides, Arcanist
epriestley triaged T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark" as Normal priority.
Jun 8 2020, 7:34 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 8 2020, 6:40 PM · Guides, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 6:35 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 5:40 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 5:30 PM · Arcanist
epriestley moved T2928: "arc start" / "arc feature" / "arc push" Discussion from Backlog to arc land on the Arcanist board.
Jun 8 2020, 5:21 PM · Arcanist, Maniphest, Phrequent
epriestley removed a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T9457: arc diff crashes when trying to stash submodule diffs.
Jun 8 2020, 1:50 PM · Arcanist, Differential
epriestley removed a parent task for T9457: arc diff crashes when trying to stash submodule diffs: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Jun 8 2020, 1:50 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 8 2020, 1:40 PM · Arcanist