Page MenuHomePhabricator
Feed All Stories

Aug 16 2019

epriestley added a comment to T13367: Phortune "enterprise" update errata.

This is sort-of-quasi-intentional

Aug 16 2019, 5:42 PM · Phortune, Phacility
epriestley added a comment to T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading.

A related issue is that when object A returns object B as an extended policy check and the user fails the extended policy check, the "PolicyException" dialog is misleading. It reads like this:

Aug 16 2019, 5:27 PM · Policy
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Restricted Differential Revision.
Aug 16 2019, 5:08 PM · Phortune, Phacility
epriestley triaged T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading as Wishlist priority.
Aug 16 2019, 5:04 PM · Policy
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 16 2019, 4:38 PM · Phortune, Phacility
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 16 2019, 3:18 PM · Phortune, Phacility

Aug 15 2019

epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 15 2019, 11:16 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 11:00 PM · Phortune, Phacility
epriestley triaged T13380: `git push` fatals when CWD does not exist as Low priority.
Aug 15 2019, 8:02 PM · Arcanist
epriestley closed T13379: Query panels executing bucketed queries with limits have unclear behavior as Wontfix.

Actually, since the modern behavior is reasonable by default (the "Limit" field is not required, and defaults to empty, and the panel works properly if "Limit" is left blank), users have to explicitly set a limit to get any unintuitive behavior here. If they do, they still get a "View All Results" hint.

Aug 15 2019, 7:47 PM · Dashboards
epriestley added a comment to T13379: Query panels executing bucketed queries with limits have unclear behavior.

The bucket limit is currently implemented like this:

Aug 15 2019, 7:43 PM · Dashboards
epriestley closed T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Resolved by committing Restricted Diffusion Commit.
Aug 15 2019, 7:22 PM · Projects
epriestley triaged T13379: Query panels executing bucketed queries with limits have unclear behavior as Low priority.
Aug 15 2019, 7:21 PM · Dashboards
epriestley added a revision to T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging: Unknown Object (Differential Revision).
Aug 15 2019, 7:02 PM · Projects
epriestley triaged T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Low priority.
Aug 15 2019, 7:00 PM · Projects
epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

It would also be nice to figure out Phortune permissions better here since this is a good opportunity to vet everything.

Aug 15 2019, 6:49 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 5:54 PM · Phortune, Phacility
avivey awarded T13376: Write about "add more logging / monitoring / tests" a Manufacturing Defect? token.
Aug 15 2019, 5:26 PM · Guides
epriestley triaged T13377: Write about "how to solve problems with program behavior" as Wishlist priority.
Aug 15 2019, 4:54 PM · Guides
epriestley triaged T13376: Write about "add more logging / monitoring / tests" as Wishlist priority.
Aug 15 2019, 4:42 PM · Guides

Aug 13 2019

jcox awarded Changelog a Love token.
Aug 13 2019, 4:30 PM

Aug 12 2019

epriestley added a revision to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: Unknown Object (Differential Revision).
Aug 12 2019, 10:58 PM · Phortune, Phacility
epriestley closed T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Resolved by committing Restricted Diffusion Commit.
Aug 12 2019, 7:46 PM · Daemons
epriestley added a revision to T13369: When a large number of commits are pushed to a repository, import them at lower priority: Restricted Differential Revision.
Aug 12 2019, 7:09 PM · Daemons, Diffusion
epriestley added a revision to T13373: Clarify some messaging in `bin/config`: Unknown Object (Differential Revision).
Aug 12 2019, 6:22 PM · Setup, Config
epriestley added a revision to T13374: Daemons summary table is missing a cell in the "Temporary Failures" row: Unknown Object (Differential Revision).
Aug 12 2019, 6:12 PM · Daemons
epriestley added a comment to T731: Allow revisions to have alternate acceptance conditions.

See PHI1378, which is interested in "at least N", for N = 2.

Aug 12 2019, 5:42 PM · Restricted Project, Restricted Project, Differential
epriestley closed T13371: When instances change up/down status, start or stop their daemons as Resolved.

There was one issue with this: bin/host stop --instance X (which is rarely used, and has no prior automated callers) used --force, which stops all daemons on the host. The recent changes to the --force flag in D20601 also had an indirect impact here. I fixed this and redeployed the repo tier.

Aug 12 2019, 3:19 PM · Phacility
epriestley triaged T13375: Treat "'to'" address failures as permanent in Mailgun adapter as Low priority.
Aug 12 2019, 3:14 PM · Mail

Aug 11 2019

epriestley triaged T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Low priority.
Aug 11 2019, 8:24 PM · Daemons
epriestley edited the content of Changelog.
Aug 11 2019, 4:50 PM
epriestley created an object: 2019 Week 32 (Early August).
Aug 11 2019, 4:48 PM
epriestley updated the task description for T13371: When instances change up/down status, start or stop their daemons.
Aug 11 2019, 4:40 PM · Phacility
epriestley added a revision to T13371: When instances change up/down status, start or stop their daemons: Unknown Object (Differential Revision).
Aug 11 2019, 4:38 PM · Phacility
epriestley added a revision to T13371: When instances change up/down status, start or stop their daemons: Unknown Object (Differential Revision).
Aug 11 2019, 4:35 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Aug 11 2019, 4:19 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Aug 11 2019, 4:10 PM · Ops, Restricted Project, Phacility
epriestley closed T13372: Permanently remove references to "phd.bots" in "core/" as Resolved by committing Restricted Diffusion Commit.
Aug 11 2019, 3:57 PM · Phacility
epriestley added a revision to T13372: Permanently remove references to "phd.bots" in "core/": Unknown Object (Differential Revision).
Aug 11 2019, 3:55 PM · Phacility
epriestley triaged T13373: Clarify some messaging in `bin/config` as Low priority.
Aug 11 2019, 3:45 PM · Setup, Config
epriestley triaged T13372: Permanently remove references to "phd.bots" in "core/" as Low priority.
Aug 11 2019, 3:40 PM · Phacility
epriestley triaged T13371: When instances change up/down status, start or stop their daemons as Normal priority.
Aug 11 2019, 3:39 PM · Phacility

Aug 9 2019

avivey awarded T13369: When a large number of commits are pushed to a repository, import them at lower priority a Piece of Eight token.
Aug 9 2019, 6:46 PM · Daemons, Diffusion

Aug 8 2019

epriestley created P2122 synthace.js.
Aug 8 2019, 7:05 PM
epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: Unknown Object (Differential Revision).
Aug 8 2019, 5:37 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

See downstream https://phabricator.wikimedia.org/T230001 for a similar issue on project pages.

Aug 8 2019, 5:31 PM · Feed
epriestley closed T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges as Resolved by committing Restricted Diffusion Commit.
Aug 8 2019, 5:19 PM · Badges
epriestley closed T13368: Correct several issues with "Move to Project..." on Workboards as Resolved by committing Restricted Diffusion Commit.
Aug 8 2019, 5:18 PM · Workboards
epriestley added a revision to T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges: Unknown Object (Differential Revision).
Aug 8 2019, 5:16 PM · Badges
epriestley added a comment to T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges.

The repro case is something like:

Aug 8 2019, 5:14 PM · Badges
epriestley triaged T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges as Low priority.
Aug 8 2019, 5:11 PM · Badges
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 8 2019, 2:27 PM · Harbormaster
Yomi updated Yomi.
Aug 8 2019, 8:40 AM

Aug 7 2019

epriestley triaged T13369: When a large number of commits are pushed to a repository, import them at lower priority as Low priority.
Aug 7 2019, 5:03 PM · Daemons, Diffusion
epriestley added a comment to T13123: Plans: Improve SSH key parsing and handling.

This thread suggests that some version of ssh-keygen is sensitive to trailing whitespace in private keys:

Aug 7 2019, 4:42 PM · Plans, Auth
fabe added a comment to T13358: Generate PDFs for Phortune invoices.

you can add libreoffice/soffice to your list. last time we had to do sth like this we used soffice --headless --convert-to pdf
not really better than running a browser though... in our use case we needed to use merchant uploaded doc/docx templates in combination with our data. so even less options.
but yeah most options around pdf generation are clunky.

Aug 7 2019, 4:30 PM · Phortune, Phacility
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: Unknown Object (Differential Revision).
Aug 7 2019, 4:20 PM · Workboards
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: Unknown Object (Differential Revision).
Aug 7 2019, 4:18 PM · Workboards
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: Unknown Object (Differential Revision).
Aug 7 2019, 4:10 PM · Workboards
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: Unknown Object (Differential Revision).
Aug 7 2019, 4:08 PM · Workboards
epriestley triaged T13368: Correct several issues with "Move to Project..." on Workboards as Low priority.
Aug 7 2019, 4:06 PM · Workboards
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

Yeah, I'm really hoping to not require us to run an entire browser or depend on an external service to generate PDFs. The approaches I found in my research were:

Aug 7 2019, 3:36 PM · Phortune, Phacility
magnetik added a comment to T13358: Generate PDFs for Phortune invoices.

Just my two cents here, but chrome has an headless mode that allows to "print to pdf" : https://developers.google.com/web/updates/2017/04/headless-chrome

Aug 7 2019, 3:11 PM · Phortune, Phacility
seporaitis updated seporaitis.
Aug 7 2019, 12:31 PM

Aug 5 2019

ztas updated ztas.
Aug 5 2019, 10:44 PM
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

When I apt-get install wkhtmltopdf (or something like that) on aux001, which is Ubuntu 14, I get this:

Aug 5 2019, 12:33 AM · Phortune, Phacility

Aug 4 2019

avivey added a comment to T13358: Generate PDFs for Phortune invoices.

I've worked with wkhtmltopdf several times, and I don't remember it actually requiring any special setup - in all cases, I basically dropped the binary in the machine (Although it's possible all my machines had X11 built in for some reason? I've never intentionally installed X11).

Aug 4 2019, 7:02 PM · Phortune, Phacility

Aug 2 2019

epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

Just some observations after popping open PDF invoices which have shown up in my inbox recently:

Aug 2 2019, 11:18 PM · Phortune, Phacility
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

See PHI1367, which featured a specific case where git repack unambiguously did something good instead of being magic fairy dust that we sprinkle around to ward off demons.

Aug 2 2019, 10:07 PM · Phacility, Diffusion
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 2 2019, 6:55 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 2 2019, 6:52 PM · Phortune, Phacility
epriestley triaged T13367: Phortune "enterprise" update errata as Low priority.
Aug 2 2019, 6:49 PM · Phortune, Phacility
epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

This is also more "while I'm here", but there's no web UI way to void an invoice right now. It would be nice to have a "Void Invoice" button for staff instead of requiring database fiddling, since this comes up occasionally.

Aug 2 2019, 6:37 PM · Phortune, Phacility
epriestley closed T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22, a subtask of T13366: Update Phortune to work better with "enterprise" billing/accounts departments, as Resolved.
Aug 2 2019, 5:51 PM · Phortune, Phacility
epriestley closed T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22 as Resolved by committing Restricted Diffusion Commit.
Aug 2 2019, 5:51 PM · Phortune, Phacility
epriestley added a revision to T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22: Unknown Object (Differential Revision).
Aug 2 2019, 5:48 PM · Phortune, Phacility
epriestley added a comment to T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22.

Per T13366, I'm just going to get rid of this behavior for now, with the expectation that we'll soon begin generating side-channel emails for "Billing Department Email Address" under the umbrella of T8389 and could put "Merchant Emails" on a similar channel if we want.

Aug 2 2019, 5:43 PM · Phortune, Phacility
epriestley added a parent task for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T7607: Invoicing emails probably need some work: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T13358: Generate PDFs for Phortune invoices: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added subtasks for T13366: Update Phortune to work better with "enterprise" billing/accounts departments: T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22, T13358: Generate PDFs for Phortune invoices, T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, T7607: Invoicing emails probably need some work.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley triaged T13366: Update Phortune to work better with "enterprise" billing/accounts departments as Normal priority.
Aug 2 2019, 5:40 PM · Phortune, Phacility
epriestley added a revision to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases: Unknown Object (Differential Revision).
Aug 2 2019, 4:42 PM · Diffusion, Conduit
epriestley closed T8830: `bin/remove destroy` is dangerous and leaves dangling edges as Resolved by committing Restricted Diffusion Commit.
Aug 2 2019, 4:31 PM · Infrastructure, Restricted Project
epriestley closed T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation as Resolved by committing Restricted Diffusion Commit.
Aug 2 2019, 4:30 PM · Diffusion, Policy, Documentation
epriestley added a revision to T8830: `bin/remove destroy` is dangerous and leaves dangling edges: Unknown Object (Differential Revision).
Aug 2 2019, 4:23 PM · Infrastructure, Restricted Project
epriestley added a revision to T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation: Unknown Object (Differential Revision).
Aug 2 2019, 4:23 PM · Diffusion, Policy, Documentation
epriestley triaged T13365: Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit" as Low priority.
Aug 2 2019, 1:58 PM · Diffusion

Aug 1 2019

epriestley triaged T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation as Low priority.
Aug 1 2019, 9:53 PM · Diffusion, Policy, Documentation
aklapper awarded T13255: transaction.search should accept user PHIDs as constraints a Love token.
Aug 1 2019, 8:32 PM · Conduit, Transactions
epriestley added a comment to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.

See also https://phabricator.wikimedia.org/T197935.

Aug 1 2019, 7:55 PM · Diffusion, Conduit
epriestley closed T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Resolved by committing Restricted Diffusion Commit.
Aug 1 2019, 7:25 PM · Quicksand
epriestley added a revision to T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog: Unknown Object (Differential Revision).
Aug 1 2019, 7:06 PM · Quicksand
epriestley triaged T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Normal priority.
Aug 1 2019, 6:59 PM · Quicksand
epriestley triaged T13362: Push the "Config" application UI out to full-width as Low priority.
Aug 1 2019, 6:53 PM · Design, Config
epriestley triaged T13361: Get rid of the "Actions" dropdown in Diffusion as Low priority.
Aug 1 2019, 6:10 PM · Design, Diffusion
epriestley triaged T13360: Document the pull and push logs in Diffusion as Low priority.
Aug 1 2019, 6:05 PM · Documentation, Diffusion
epriestley triaged T13359: Phacility deploy workflow should not conflate versions-for-deployment with "latest stable release" as Low priority.
Aug 1 2019, 5:48 PM · Phacility, Ops
epriestley added a revision to T13358: Generate PDFs for Phortune invoices: Unknown Object (Differential Revision).
Aug 1 2019, 5:37 PM · Phortune, Phacility