Page MenuHomePhabricator
Feed All Stories

Jan 27 2018

zhzhqcdu added a member for Transactions: zhzhqcdu.
Jan 27 2018, 3:30 PM
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

My plan is to pick those to stable, then compact-edges here on secure, then compact-edges on the affected 130GB instance. There's some value in doing this sooner rather than later because the backups for 130GB of edge data are having some issues. The instance is a free test instance so this isn't a huge concern, but I'd sleep better if it was running smoothly. If you don't run compact-edges I think the worst those changes could really do is cause some kind of temporary display bug with new transactions, so the risk should be pretty small.

Jan 27 2018, 2:52 PM · Transactions, Ops, Phacility
epriestley added a revision to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs: Unknown Object (Differential Revision).
Jan 27 2018, 2:19 PM · Transactions, Ops, Phacility
epriestley added a revision to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs: Restricted Differential Revision.
Jan 27 2018, 1:56 PM · Transactions, Ops, Phacility
epriestley added a revision to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs: Unknown Object (Differential Revision).
Jan 27 2018, 1:30 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

Bad news: data still has one reader/writer in the Asana-to-Revision linking implementation. So we can't completely get rid of that yet.

Jan 27 2018, 1:25 PM · Transactions, Ops, Phacility
epriestley updated the task description for T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.
Jan 27 2018, 1:21 PM · Transactions, Ops, Phacility
epriestley updated the task description for T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.
Jan 27 2018, 1:03 PM · Transactions, Ops, Phacility
epriestley triaged T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs as Normal priority.
Jan 27 2018, 12:59 PM · Transactions, Ops, Phacility

Jan 26 2018

epriestley closed T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald as Resolved.
Jan 26 2018, 11:29 PM · Herald
epriestley edited the content of Changelog.
Jan 26 2018, 11:24 PM
epriestley edited the content of Changelog.
Jan 26 2018, 11:23 PM
epriestley created 2018 Week 4 (Late January).
Jan 26 2018, 11:23 PM
epriestley closed T13050: 2018 Week 4 pre-release deploy issues on secure.phabricator.com as Resolved.

this can probably be figured out by examining the 2.16.0 release notes

Jan 26 2018, 9:43 PM · Phacility, Ops
epriestley added a revision to T13050: 2018 Week 4 pre-release deploy issues on secure.phabricator.com: Unknown Object (Differential Revision).
Jan 26 2018, 9:43 PM · Phacility, Ops
epriestley added a revision to T13050: 2018 Week 4 pre-release deploy issues on secure.phabricator.com: Unknown Object (Differential Revision).
Jan 26 2018, 9:37 PM · Phacility, Ops
epriestley triaged T13050: 2018 Week 4 pre-release deploy issues on secure.phabricator.com as Normal priority.
Jan 26 2018, 9:33 PM · Phacility, Ops
epriestley closed T11112: Herald allows setting multiple values in fields that should only accept one value as Resolved by committing Restricted Diffusion Commit.
Jan 26 2018, 9:23 PM · Herald, Bug Report
epriestley renamed T13046: Surface repository pull logs in the web UI from Improve repository pull logs to Surface repository pull logs in the web UI.
Jan 26 2018, 8:44 PM · Diffusion
epriestley renamed T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support from Update bulk editor to Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support.
Jan 26 2018, 6:18 PM · Transactions, ApplicationEditor
epriestley closed T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support as Resolved.

T4675 survives this, because rendering policy controls on the client is very complicated.

Jan 26 2018, 6:17 PM · Transactions, ApplicationEditor
epriestley closed T13032: Upgrading: Git LFS as Resolved.
Jan 26 2018, 5:57 PM · Diffusion, Git, Installing & Upgrading
epriestley closed T13046: Surface repository pull logs in the web UI as Resolved.

T13049 is a followup about generalizing exporters.

Jan 26 2018, 5:57 PM · Diffusion
epriestley renamed T13047: Plans: Symbol Indexes from Figure out the state of affairs on symbol indexing to Plans: Symbol Indexes.
Jan 26 2018, 5:55 PM · Plans, Symbols
epriestley moved T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald from Backlog to Next on the Herald board.
Jan 26 2018, 5:53 PM · Herald
epriestley moved T11112: Herald allows setting multiple values in fields that should only accept one value from Backlog to Next on the Herald board.
Jan 26 2018, 5:53 PM · Herald, Bug Report
epriestley moved T8644: Herald template / recipe book / examples / quick-create tool from Future to Guidance on the Herald board.
Jan 26 2018, 5:53 PM · Restricted Project, Herald
epriestley moved T11566: Provide more complete guidance on using regular expressions in Herald from Backlog to Guidance on the Herald board.
Jan 26 2018, 5:53 PM · Herald, Documentation
epriestley moved T13039: Support numeric fields in Herald from Backlog to Far Future on the Herald board.
Jan 26 2018, 5:52 PM · Herald
epriestley moved T4971: Add support for "Added filenames" and "Removed filenames" in Herald from Backlog to Future on the Herald board.
Jan 26 2018, 5:52 PM · Restricted Project, Herald
epriestley moved T8644: Herald template / recipe book / examples / quick-create tool from Backlog to Future on the Herald board.
Jan 26 2018, 5:52 PM · Restricted Project, Herald
epriestley moved T7804: Implement an "Acting User" Herald condition from Next to Far Future on the Herald board.
Jan 26 2018, 5:52 PM · Restricted Project, Herald, Mail
epriestley moved T6207: Add a "Can Use Herald Rules" application permission from Next to Far Future on the Herald board.
Jan 26 2018, 5:52 PM · Restricted Project, Policy, Herald
epriestley moved T9149: Flagging commits via Herald no longer generates flag note from Backlog to Future on the Herald board.
Jan 26 2018, 5:51 PM · Restricted Project, Flags, Herald
epriestley moved T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated from Backlog to Far Future on the Herald board.
Jan 26 2018, 5:50 PM · Diffusion, Herald
epriestley closed T11349: Herald has the wrong list of "Author's Projects" as Invalid.

This is quite old and I have no idea how to reproduce it and thus no idea how to fix it. Locally, I tried a few things and wasn't able to identify a case where the Herald field value differed from my actual project list.

Jan 26 2018, 5:49 PM · Restricted Project, Herald, Bug Report
epriestley added a revision to T11112: Herald allows setting multiple values in fields that should only accept one value: Unknown Object (Differential Revision).
Jan 26 2018, 5:42 PM · Herald, Bug Report
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 26 2018, 5:42 PM · Herald
epriestley renamed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules from Herald should not show actions for uninstalled applications to In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.
Jan 26 2018, 5:33 PM · Applications, Herald
epriestley renamed T8952: Hide "Herald added subscribers..." stories from feed completely from herald showing as cause of feed item to Hide "Herald added subscribers..." stories from feed completely.
Jan 26 2018, 5:32 PM · Feed, Herald
epriestley closed T5954: Modularize "Export to Excel" as a feature of ApplicationSearch, a subtask of T5391: Support custom fields in 'Export to Excel', as Resolved.
Jan 26 2018, 4:59 PM · Data Exporters
epriestley closed T5954: Modularize "Export to Excel" as a feature of ApplicationSearch as Resolved.

I'm rolling this forward into T13049. See also D18919.

Jan 26 2018, 4:59 PM · Custom Fields, ApplicationSearch
epriestley closed T5954: Modularize "Export to Excel" as a feature of ApplicationSearch, a subtask of T3461: Improve documentation around Maniphest Excel exports, as Resolved.
Jan 26 2018, 4:59 PM · Maniphest
epriestley closed T5954: Modularize "Export to Excel" as a feature of ApplicationSearch, a subtask of T5151: Allow to export query results from Phrequent, as Resolved.
Jan 26 2018, 4:59 PM · Phrequent
epriestley edited projects for T5391: Support custom fields in 'Export to Excel', added: Data Exporters; removed Maniphest.
Jan 26 2018, 4:58 PM · Data Exporters
epriestley triaged T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.) as Normal priority.
Jan 26 2018, 4:57 PM · Plans, Data Exporters
epriestley created Data Exporters.
Jan 26 2018, 4:42 PM
epriestley added a comment to T8533: Allow Diviner to fall back to (or link directly to) the Symbol index.

I think a reasonable path forward here is for Diviner to have a {symbol} sort of syntax which executes a symbol index query. The symbol index can already be configured to know how to offer links to external documentation.

Jan 26 2018, 3:14 PM · Restricted Project, Symbols, Diviner
epriestley renamed T8533: Allow Diviner to fall back to (or link directly to) the Symbol index from Allow linking to external documentation to Allow Diviner to fall back to (or link directly to) the Symbol index.
Jan 26 2018, 3:07 PM · Restricted Project, Symbols, Diviner
epriestley added a revision to T13047: Plans: Symbol Indexes: Unknown Object (Differential Revision).
Jan 26 2018, 2:45 PM · Plans, Symbols
epriestley added a revision to T13047: Plans: Symbol Indexes: Unknown Object (Differential Revision).
Jan 26 2018, 2:34 PM · Plans, Symbols
epriestley updated the task description for T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald.
Jan 26 2018, 3:41 AM · Herald
epriestley added a revision to T13047: Plans: Symbol Indexes: Unknown Object (Differential Revision).
Jan 26 2018, 3:22 AM · Plans, Symbols
epriestley added a revision to T13047: Plans: Symbol Indexes: Unknown Object (Differential Revision).
Jan 26 2018, 2:59 AM · Plans, Symbols
epriestley added a revision to T13046: Surface repository pull logs in the web UI: Unknown Object (Differential Revision).
Jan 26 2018, 2:00 AM · Diffusion
epriestley added a revision to T13046: Surface repository pull logs in the web UI: Unknown Object (Differential Revision).
Jan 26 2018, 1:21 AM · Diffusion

Jan 25 2018

epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 7:31 PM · Herald
epriestley lowered the priority of T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated from Low to Wishlist.

Rename the field to "Reviewer (Legacy)", or move it to a "Legacy" category -- maybe improves things, but really just punts this.

Jan 25 2018, 6:29 PM · Diffusion, Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 6:29 PM · Herald
epriestley added a revision to T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated: Unknown Object (Differential Revision).
Jan 25 2018, 6:29 PM · Diffusion, Herald
epriestley updated the task description for T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald.
Jan 25 2018, 6:20 PM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 6:19 PM · Herald
epriestley added a comment to T7148: Allow users to export their data from Phacility.

In PHI311, I think we hit a race like this:

Jan 25 2018, 6:16 PM · Phacility
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 5:52 PM · Herald
epriestley added a revision to T13043: Improve authentication revocation behaviors: Unknown Object (Differential Revision).
Jan 25 2018, 2:56 PM · Phacility, Auth, Security
epriestley added a revision to T13043: Improve authentication revocation behaviors: Unknown Object (Differential Revision).
Jan 25 2018, 2:44 PM · Phacility, Auth, Security
franjesus awarded T5024: Provide a dedicated page for viewing a single workboard column a Love token.
Jan 25 2018, 2:35 PM · Restricted Project, Workboards
franjesus awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Jan 25 2018, 2:34 PM · Workboards (v3), Restricted Project
franjesus awarded T7907: Ability to filter/search Maniphest tasks based on Workboard column position a Love token.
Jan 25 2018, 2:33 PM · Maniphest, Workboards
epriestley added a revision to T6203: Adjust nullability of various questionable columns: Unknown Object (Differential Revision).
Jan 25 2018, 4:28 AM · Infrastructure
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 4:28 AM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 4:10 AM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 3:42 AM · Herald
epriestley updated the task description for T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald.
Jan 25 2018, 3:32 AM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 25 2018, 3:28 AM · Herald
epriestley triaged T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald as Normal priority.
Jan 25 2018, 3:24 AM · Herald
epriestley closed T13036: Fix issues with recent Mercurial wire protocol versions as Resolved.

Presuming this is resolved since we've seen at least some confirmation that it fixed issues and aren't aware of any remaining outstanding problems.

Jan 25 2018, 2:56 AM · Mercurial
kfsone added a comment to T5358: Make "Self Actions" default value a setting.

Worth noting that the desirability of self-notifs is highly contextual. We use gmail, I was shocked to find there is no way to get gmail to let me see my own posts. But then I'm one of the few people using a local mail client, and it is actually kind of annoying when I have to slog thru the copies of the self-notifs on my phone to try and get to the one comment in the midst of potentially dozens of self-notifs.

Jan 25 2018, 12:18 AM · User Preferences

Jan 24 2018

epriestley closed T5965: Mirroring an empty repository causes errors in the daemon log every minute. as Resolved by committing Restricted Diffusion Commit.
Jan 24 2018, 11:50 PM · Daemons
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 24 2018, 11:29 PM · Transactions, ApplicationEditor
epriestley added a revision to T5965: Mirroring an empty repository causes errors in the daemon log every minute. : Unknown Object (Differential Revision).
Jan 24 2018, 8:30 PM · Daemons
epriestley added a member for Community: mikenicholson.
Jan 24 2018, 8:18 PM
epriestley added a member for Blessed Committers: mikenicholson.
Jan 24 2018, 8:17 PM
partofthething edited the content of Organizations Using Phabricator.
Jan 24 2018, 8:08 PM
partofthething edited the content of Organizations Using Phabricator.
Jan 24 2018, 6:05 PM
epriestley added a project to T7960: Jumping to symbols from Differential doesn't work well on mobile: Symbols.
Jan 24 2018, 5:39 PM · Symbols, Mobile, Differential
epriestley moved T3130: Improve recognition of symbols in Java from Backlog to Language Support on the Symbols board.
Jan 24 2018, 5:38 PM · Symbols, libphutil
epriestley triaged T13047: Plans: Symbol Indexes as Normal priority.
Jan 24 2018, 5:18 PM · Plans, Symbols
epriestley updated the task description for T13047: Plans: Symbol Indexes.
Jan 24 2018, 5:16 PM · Plans, Symbols
epriestley closed T9424: Commit hash links to symbol lookup as Resolved.

See PHI185. This was fixed by D18753 but didn't get linked up.

Jan 24 2018, 4:46 PM · Symbols, Differential
epriestley closed T9424: Commit hash links to symbol lookup, a subtask of T13047: Plans: Symbol Indexes, as Resolved.
Jan 24 2018, 4:46 PM · Plans, Symbols
epriestley closed T8302: Maybe allow ctrl-click to search for any symbol? as Resolved.

Maybe this works now?

Jan 24 2018, 4:44 PM · Symbols
epriestley closed T8302: Maybe allow ctrl-click to search for any symbol?, a subtask of T13047: Plans: Symbol Indexes, as Resolved.
Jan 24 2018, 4:44 PM · Plans, Symbols
epriestley closed T8235: Update symbol documentation, a subtask of T13047: Plans: Symbol Indexes, as Wontfix.
Jan 24 2018, 4:43 PM · Plans, Symbols
epriestley closed T8235: Update symbol documentation as Wontfix.

I'm going to roll this up into T13047 since this stuff needs a rebuild in general.

Jan 24 2018, 4:43 PM · Restricted Project, Documentation
epriestley closed T8536: Merge symbols and Diviner, a subtask of T4558: Make Diviner useful for third-parties, as Wontfix.
Jan 24 2018, 4:42 PM · Diviner
epriestley closed T8536: Merge symbols and Diviner as Wontfix.

Per above, I think the pathway forward here is probably "tighter integration", not "merge/replace", i.e. tools for Diviner to automatically update Symbols, too. I'm just going to conceptually roll this up into T13047.

Jan 24 2018, 4:41 PM · Symbols, Diviner
epriestley closed T8536: Merge symbols and Diviner, a subtask of T13047: Plans: Symbol Indexes, as Wontfix.
Jan 24 2018, 4:41 PM · Plans, Symbols
epriestley closed T8536: Merge symbols and Diviner, a subtask of T8533: Allow Diviner to fall back to (or link directly to) the Symbol index, as Wontfix.
Jan 24 2018, 4:41 PM · Restricted Project, Symbols, Diviner
epriestley closed T8349: PHP external symbols uses php from server, a subtask of T13047: Plans: Symbol Indexes, as Wontfix.
Jan 24 2018, 4:40 PM · Plans, Symbols