Page MenuHomePhabricator
Create Task
Maniphest T5965

Mirroring an empty repository causes errors in the daemon log every minute.
Closed, ResolvedPublic
Actions

Description

If you set up a mirror on an empty repository, every minute when it tries to push to the mirror it gets an error.

P1248 (An Untitled Masterwork)
1[2014-08-20 16:51:32] PHLOG: 'Unexpected output while updating repository "rACC": [2014-08-20 16:51:32] EXCEPTION: (PhutilProxyException) Error while pushing "ACC" repository to mirrors. {>} (PhutilAggregateException) Exceptions occurred while mirroring the "ACC" repository.
2 - CommandException: Command failed with error #1!
3 COMMAND
4 git push --verbose --mirror -- 'xxxxx'
5
6 STDOUT
7 (empty)
8
9 STDERR
10 Pushing to ssh://******/~/repositories/Accounting
11 Warning: Permanently added '*****,*****' (RSA) to the list of known hosts.
12 No refs in common and none specified; doing nothing.
13 Perhaps you should specify a branch such as 'master'.
14 fatal: The remote end hung up unexpectedly
15 error: failed to push some refs to 'ssh://*****/~/repositories/Accounting'
16 at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php:31]
17 #0 PhabricatorRepositoryMirrorEngine::pu...' at [/opt/phabricator/phabricator/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:345]
18 #0 phlog(string) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:345]
19 #1 PhabricatorRepositoryPullLocalDaemon::resolveUpdateFuture(PhabricatorRepository, ExecFuture, integer) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:198]
20 #2 PhabricatorRepositoryPullLocalDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:84]
21 #3 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:111]

Specifically:

No refs in common and none specified; doing nothing.
Perhaps you should specify a branch such as 'master'.
fatal: The remote end hung up unexpectedly

This makes sense, since both are empty, there is nothing in common and git should return an error, but it would be nice if Phabricator handled this case.

I'm not positive how to implement this in a way that it wouldn't silence actual errors though. Perhaps before we mirror, we could check if we actually have any commits, and if we don't, don't try to push to the mirror.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

bluehawk created this task.Aug 25 2014, 7:47 PM
bluehawk raised the priority of this task from to Needs Triage.
bluehawk updated the task description. (Show Details)
bluehawk updated the task description. (Show Details)
bluehawk added a subscriber: bluehawk.
chad triaged this task as Normal priority.Sep 2 2014, 8:37 PM
chad added a project: Daemons.
epriestley mentioned this in T11665: repo002.phacility.net is heavily loaded.Sep 20 2016, 4:39 PM
epriestley added a revision: Restricted Differential Revision.Jan 24 2018, 8:30 PM
Herald added a subscriber: eadler. · View Herald TranscriptJan 24 2018, 8:30 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 24 2018, 11:50 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility