Page MenuHomePhabricator
Feed All Stories

Jun 27 2017

amckinley created T12876: Improve initial arc land experience when destination repo is empty.
Jun 27 2017, 7:48 PM · Arcanist
epriestley moved T8783: Unprototype Nuance (v1) from Backlog to Now on the Nuance board.
Jun 27 2017, 7:42 PM · Nuance, Restricted Project
epriestley moved T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support from Backlog to Now on the Nuance board.
Jun 27 2017, 7:42 PM · Nuance
epriestley archived Nuance (v1).
Jun 27 2017, 7:41 PM
epriestley added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

At HEAD of master:

Jun 27 2017, 7:37 PM · Maniphest, Bug Report
epriestley closed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities, a subtask of T12845: Convert remaining ancient configuration type classes to modern modular type classes, as Resolved.
Jun 27 2017, 7:35 PM · Infrastructure, Config
epriestley closed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities as Resolved by committing Restricted Diffusion Commit.
Jun 27 2017, 7:35 PM · Maniphest, Bug Report
epriestley renamed T12845: Convert remaining ancient configuration type classes to modern modular type classes from Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default to Convert remaining ancient configuration type classes to modern modular type classes.
Jun 27 2017, 7:12 PM · Infrastructure, Config
epriestley placed T12845: Convert remaining ancient configuration type classes to modern modular type classes up for grabs.

This is "fixed" by the associated series of diffs, in the sense that the actual problem (being unable to delete web UI config) is fixed. This is remaining work:

Jun 27 2017, 7:11 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 27 2017, 5:05 PM · Infrastructure, Config
jcarrillo7 added a comment to T12872: Disable Mac autocorrect on some text fields.

@chad yes it is but I don’t want to disable it everywhere. It’s quite useful. Most websites just disable it selectively in places like search bars. I would also recommend disabling on form input like settings. Especially anywhere where phabricator autocompletes to some object like a project/user for access control etc. I hit this a lot while modifying many repositories visibility policies.

Jun 27 2017, 4:19 PM · Bug Report
epriestley closed T12875: How to see all user keys uploaded as Invalid.

See T12874. Your account will be disabled if you continue creating tasks like this. Follow the instructions you were given.

Jun 27 2017, 4:14 PM · Feature Request
marcoscorvalan created T12875: How to see all user keys uploaded .
Jun 27 2017, 3:34 PM · Feature Request
chad added a comment to T12874: HOw to see ALL user Keys uploaded.

See Support Resources

Jun 27 2017, 3:23 PM · Feature Request
chad closed T12874: HOw to see ALL user Keys uploaded as Invalid.
Jun 27 2017, 3:22 PM · Feature Request
marcoscorvalan created T12874: HOw to see ALL user Keys uploaded.
Jun 27 2017, 3:18 PM · Feature Request
epriestley added a revision to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities: Unknown Object (Differential Revision).
Jun 27 2017, 3:15 PM · Maniphest, Bug Report
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 27 2017, 3:15 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 27 2017, 1:59 PM · Infrastructure, Config
janitorial awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Burninate token.
Jun 27 2017, 1:21 PM · Workboards (v3), Restricted Project
benjumanji asked Q630: I'd like to use the snazzy eye icon for a mattermost webhook, but it's served rather indirectly..
Jun 27 2017, 12:53 PM
chad closed T12872: Disable Mac autocorrect on some text fields as Resolved.
Jun 27 2017, 12:11 PM · Bug Report
epriestley added a comment to T4444: "NOT" filter for all applicable lines in a Query.

You can find tasks with no owner by searching for "No Owner", like this:

Jun 27 2017, 11:50 AM · Projects, Custom Fields, Maniphest
chad added a revision to T12872: Disable Mac autocorrect on some text fields: Restricted Differential Revision.
Jun 27 2017, 11:29 AM · Bug Report
earthian added a comment to T4444: "NOT" filter for all applicable lines in a Query.

This is something that is needed every day, e.g. find tickets which are not yet assigned..

Jun 27 2017, 10:57 AM · Projects, Custom Fields, Maniphest
chad added a comment to T12873: Ability to display custom message during externally linked login prompt.

/config/edit/translation.override/ then add the string, and what you want it to say instead. That's the quickest path here. Merging into the other request.

Jun 27 2017, 10:53 AM · Feature Request
chad merged T12873: Ability to display custom message during externally linked login prompt into T11514: Authentication should have a way to customize the credentials name.
Jun 27 2017, 10:50 AM · Auth, LDAP, Feature Request
chad merged task T12873: Ability to display custom message during externally linked login prompt into T11514: Authentication should have a way to customize the credentials name.
Jun 27 2017, 10:50 AM · Feature Request
chad added a comment to T12873: Ability to display custom message during externally linked login prompt.

Can you be more specific here? If you just want to rename "LDAP Login" you can already do that with the translation framework.

Jun 27 2017, 10:39 AM · Feature Request
benjumanji awarded T12873: Ability to display custom message during externally linked login prompt a Love token.
Jun 27 2017, 9:28 AM · Feature Request
StingRayZA created T12873: Ability to display custom message during externally linked login prompt.
Jun 27 2017, 9:18 AM · Feature Request
vpavlushkov awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jun 27 2017, 8:52 AM · Workboards (v3), Restricted Project
chad added a comment to T12872: Disable Mac autocorrect on some text fields.

I believe that's a Safari feature that you can disable?

Jun 27 2017, 7:50 AM · Bug Report

Jun 26 2017

jcarrillo7 created T12872: Disable Mac autocorrect on some text fields.
Jun 26 2017, 10:30 PM · Bug Report
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

They already --prune when pulling:

Jun 26 2017, 9:26 PM · Restricted Project, Restricted Project, Arcanist
csilvers added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

We've run into this same problem, but in the phabricator daemons. They also, apparently, run commands like:

git branch --verbose --no-abbrev --contains <sha> --
Jun 26 2017, 9:13 PM · Restricted Project, Restricted Project, Arcanist
cguenther awarded T4853: A "tracked time per project" would be really usefull for project manager. a Love token.
Jun 26 2017, 6:27 PM · Phrequent
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 5:27 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 5:15 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 4:57 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 4:34 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 4:08 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 3:52 PM · Infrastructure, Config
epriestley added a subtask for T12845: Convert remaining ancient configuration type classes to modern modular type classes: T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Jun 26 2017, 2:04 PM · Infrastructure, Config
epriestley added a parent task for T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities: T12845: Convert remaining ancient configuration type classes to modern modular type classes.
Jun 26 2017, 2:04 PM · Maniphest, Bug Report
epriestley lowered the priority of T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out from Normal to Low.

For private reasons affecting the reporting install, this no longer has customer impact.

Jun 26 2017, 2:02 PM · Policy, Dashboards, Bug Report
mrthomasbrix edited the content of Organizations Using Phabricator.
Jun 26 2017, 11:21 AM

Jun 24 2017

avivey edited the content of Organizations Using Phabricator.
Jun 24 2017, 6:45 PM
• crankie01 edited the content of Organizations Using Phabricator.
Jun 24 2017, 10:45 AM
• edwardmanuma added a comment to F5010119: Selection_208.png.

OOOFFFAAHHH

Jun 24 2017, 5:23 AM
cspeckmim added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

This might not be totally related but

  1. I really love being able to see the filename while scrolling through files
  2. It would be useful to have something similar to Diffusion's File Search on a Differential revision, to quickly jump to files based on name. The f sidebar helps a little but it's organized in a file-system layout which means the folder location needs to be known.
Jun 24 2017, 12:17 AM · Inline Comments, Installing & Upgrading, Differential

Jun 23 2017

epriestley edited the content of Changelog.
Jun 23 2017, 11:55 PM
epriestley created 2017 Week 25 (Late June).
Jun 23 2017, 11:54 PM
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

That sounds like a bug, but my guess is that the investigation would probably turn up "wow you are dumb at writing software" in about 3 minutes and not really get us much closer to a fix, which is probably "rewrite arc patch to fix 200 problems".

Jun 23 2017, 11:40 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it's currently expected, yes. We don't create branches for dependencies in Git either, currently. I don't think this is terribly unreasonable, but I'm also not sure it's terribly useful (does it just help you keep track of which commits are part of the leaf?) and it makes cleanup more difficult by creating more total branch/bookmark artifacts in the local working copy.

Jun 23 2017, 11:39 PM · Arcanist, Mercurial, Feature Request
cspeckmim added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

Also, I've noticed that when applying dependent revisions like this, it seems that usually all of the commits will apply cleanly (without prompting) except for the last one, which will always fail to locate the commit to apply on and prompt whether to apply to current working copy state. Based on what I think arcanist is doing I would expect all patches to prompt whether to apply to working copy (since all patches will be given new commit IDs) -- it seems strange that all will apply cleanly except the last one. Does that sound like a bug or am I misunderstanding what's happening? I can try to investigate/debug if you think it might be a bug.

Jun 23 2017, 11:37 PM · Arcanist, Mercurial, Bug Report
cspeckmim added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it is expected to not apply bookmarks to dependency changesets that are applied as part of the patch issued? When patched one-by-one they would each obtain their bookmark.

Jun 23 2017, 11:29 PM · Arcanist, Mercurial, Feature Request
epriestley closed T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 7:29 PM · Feed, Bug Report
epriestley triaged T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out as Normal priority.
Jun 23 2017, 7:16 PM · Policy, Dashboards, Bug Report
epriestley added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

D18152 should improve this: we'll still select the item as the default item, but will now render the navigation normally so the user can click other items:

Jun 23 2017, 7:15 PM · Policy, Dashboards, Bug Report
epriestley added a revision to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out: Unknown Object (Differential Revision).
Jun 23 2017, 7:11 PM · Policy, Dashboards, Bug Report
epriestley claimed T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jun 23 2017, 6:59 PM · Policy, Dashboards, Bug Report
xp500 created T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jun 23 2017, 6:56 PM · Policy, Dashboards, Bug Report
epriestley renamed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities from Prioritys are wrong to Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Jun 23 2017, 6:20 PM · Maniphest, Bug Report
epriestley added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

Specifically, the issue is that multiple different priorities used the same keywords ("low", "high").

Jun 23 2017, 6:19 PM · Maniphest, Bug Report
mcorteel added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Sorry, I should have led with a screenshot! I'm the biggest nitpicker, I know.

Jun 23 2017, 5:48 PM · Remarkup, Feature Request
Luke081515.2 added a project to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities: Maniphest.
Jun 23 2017, 5:36 PM · Maniphest, Bug Report
Luke081515.2 added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

This looks like the update changed the behaviour, not sure if this is intended, but it broke configs, that worked before. I currently fixed this by chaning my config to:

{
  "100": {
    "name": "Unbreak Now!",
    "short": "Unbreak!",
    "color": "pink",
    "keywords": [
      "unbreak"
    ]
  },
  "90": {
    "name": "Needs Triage",
    "short": "Triage",
    "color": "violet",
    "keywords": [
      "triage"
    ]
  },
  "80": {
    "name": "High",
    "short": "High",
    "color": "red",
    "keywords": [
      "high"
    ]
  },
  "70": {
    "name": "Higher than normal",
    "short": "Higher than normal",
    "color": "orange",
    "keywords": [
      "high-than-normal"
    ]
  },
  "50": {
    "name": "Normal",
    "short": "Normal",
    "color": "yellow",
    "keywords": [
      "normal"
    ]
  },
  "25": {
    "name": "Lower than normal",
    "short": "Lower than normal",
    "color": "green",
    "keywords": [
      "lower-than-normal"
    ]
  },
  "1": {
    "name": "Low",
    "short": "Low",
    "color": "sky",
    "keywords": [
      "low"
    ]
  },
  "0": {
    "name": "Wishlist",
    "short": "Wishlist",
    "color": "skyblue",
    "keywords": [
      "wishlist"
    ]
  }
}
Jun 23 2017, 5:34 PM · Maniphest, Bug Report
aklapper added a comment to T8363: Include reply action ("!action") hints in outbound email.

I think that these use to exist and were moved to a help document somewhere.

Jun 23 2017, 5:31 PM · llvm, Restricted Project, Mail
Luke081515.2 added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

I was able to track this down: This is happening since {rP8008ade9af46d417aec187f4213118d220077b32}.

Jun 23 2017, 5:30 PM · Maniphest, Bug Report
Luke081515.2 created T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Jun 23 2017, 5:30 PM · Maniphest, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

(That is, our behavior seems clearly incorrect.)

Jun 23 2017, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

This just looks unambiguously wrong to me.

Jun 23 2017, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12845: Convert remaining ancient configuration type classes to modern modular type classes.

I'm going to modularize this, but not before the release cut.

Jun 23 2017, 4:48 PM · Infrastructure, Config
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

Some of the (3), (2), (1) stuff is that we're trying to pick a single behavior which addresses most use cases reasonably well. For example, if we use "natural" bookmark names that will tend to make things much worse for users in bucket (3).

Jun 23 2017, 4:48 PM · Arcanist, Mercurial, Feature Request
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I can verify this fixes it! Thanks for this guys.

Jun 23 2017, 4:47 PM · Remarkup, Bug Report
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Thanks, that's much more clear than the original description!

Jun 23 2017, 4:42 PM · Remarkup, Feature Request
mcorteel added a comment to T12865: Strikethrough for icons in checked remarkup list items.

No they're not. I know it's a tiny difference, but look at this closely (left is my proposal, right is the current state):

Spectacle.eD1745.png (147×463 px, 9 KB)

Jun 23 2017, 4:41 PM · Remarkup, Feature Request
epriestley triaged T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Low priority.

(I think D18132 should fix this once someone gets a chance to look at it.)

Jun 23 2017, 4:22 PM · Feed, Bug Report
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Unknown Object (Differential Revision).
Jun 23 2017, 4:21 PM · Infrastructure
epriestley triaged T12866: Batch repository editing or repository groups for shared access control settings as Low priority.
Jun 23 2017, 4:18 PM · Diffusion, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

Jun 23 2017, 4:18 PM · Remarkup, Feature Request
epriestley added a project to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Infrastructure.
Jun 23 2017, 3:54 PM · Infrastructure
epriestley added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

This should now be fixed in HEAD of master, and promote to stable within about 12 hours. Thanks for the report! Let us know if you run into anything else.

Jun 23 2017, 3:43 PM · Remarkup, Bug Report
epriestley closed T12867: Youtube remarkup rule fails to parse "ambiguous URI" as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 3:43 PM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I’m fine waiting for the fix. Thanks @epriestley

Jun 23 2017, 3:42 PM · Remarkup, Bug Report
epriestley closed T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 3:14 PM · Drydock, Differential
epriestley added a revision to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: Unknown Object (Differential Revision).
Jun 23 2017, 3:10 PM · Drydock, Differential
epriestley added a revision to T12867: Youtube remarkup rule fails to parse "ambiguous URI": Unknown Object (Differential Revision).
Jun 23 2017, 2:37 PM · Remarkup, Bug Report
epriestley renamed T12867: Youtube remarkup rule fails to parse "ambiguous URI" from Daemon fails to parse "ambiguous URI" to Youtube remarkup rule fails to parse "ambiguous URI".
Jun 23 2017, 2:30 PM · Remarkup, Bug Report
epriestley added projects to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: Differential, Drydock.
Jun 23 2017, 2:24 PM · Drydock, Differential
epriestley added a project to T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: Customer Impact.

A related issue surfaced recently. Actual use case (forensically reconstructed):

Jun 23 2017, 2:22 PM · Customer Impact, Maniphest, Differential
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

Oh, this is actually the Mercurial flavor of this action. We have this one in the Git flavor, which is why I was surprised:

Jun 23 2017, 2:02 PM · Drydock, Differential
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

My expectation is that this action can never appear -- this is the pre-Drydock hacky temporary action -- so something troubling is afoot.

Jun 23 2017, 2:01 PM · Drydock, Differential
epriestley created T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.
Jun 23 2017, 1:59 PM · Drydock, Differential
epriestley added a comment to T12866: Batch repository editing or repository groups for shared access control settings.

See also T10005 (bulk editors for all applications) and T6722.

Jun 23 2017, 1:38 PM · Diffusion, Feature Request
epriestley claimed T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I think a minimal reproduction case which is typical of this example is:

Jun 23 2017, 1:35 PM · Remarkup, Bug Report
wordpress edited the content of Organizations Using Phabricator.
Jun 23 2017, 12:40 PM
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

Looks to be just the presence of the "?" in the text

Jun 23 2017, 6:47 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

"XXX://123456 XXX XXX XXX://123456 XXX XXX"

Jun 23 2017, 6:47 AM · Remarkup, Bug Report