Page MenuHomePhabricator
Feed All Stories

Aug 3 2016

markwei merged task T11192: Differential should have a "Not done comments" section. into T8250: Would like to see all comments and their status in a list.
Aug 3 2016, 6:59 PM · Feature Request
markwei added a comment to T8250: Would like to see all comments and their status in a list.

That looks really useful. With such a view, perhaps the existence of inline comments that are Not Done can be a blocker for arc land.

Aug 3 2016, 6:58 PM · Inline Comments, Prioritized, Restricted Project, Differential
avivey added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

In my jenkins setup, I wanted to keep auth, so I did this:

  • Disable all the Build With Tokens options
  • Enabled Jenkins SSH-CLI plugin (Which lets you SSH into it and run commands)
  • Wrote my own "start a build" command, which is also returns enough information to keep track of the build (Queue ID, which the http-invoke method does)
  • Wrote a JenkinsSSHBuildStepImplementation that uses that build via SSH, and has a funny JSON field for the arguments.
Aug 3 2016, 6:47 PM · Restricted Project, Harbormaster
eadler added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

this relies on the "run with token as root" extension (https://wiki.jenkins-ci.org/display/JENKINS/Build+Token+Root+Plugin) which mostly bypasses other authentication mechanisms. This isn't that much of a problem in our environment, but is clearly non-optimal

Aug 3 2016, 6:36 PM · Restricted Project, Harbormaster
eadler added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

yeah, there is an option to enable building via a specific URL and a GET request. Cool

Aug 3 2016, 6:30 PM · Restricted Project, Harbormaster
eadler added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

after a deeper look it seems there might be an option to use a token for this. Let me play around with this a bit more

Aug 3 2016, 6:26 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

I think this is a perfectly reasonable capability to want in the general case, I just want to make sure that this isn't a big fancy solution to a problem that could also be solved by checking a checkbox or making a one-line change to the build or whatever. Definitely possible that most Jenkins users are just doing very basic stuff with it, though.

Aug 3 2016, 6:16 PM · Restricted Project, Harbormaster
eadler added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

I suspect that others don't need parameters in the kickoff process? Let me look into it. Maybe we have not explored Jenkins in detail.

Aug 3 2016, 6:14 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

I'm not super familiar with Jenkins -- what makes this job require parameters in the body? Other users seem to be using Jenkins successfully without requiring this capability on the Phabricator side, as far as I know.

Aug 3 2016, 6:05 PM · Restricted Project, Harbormaster
eadler added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

We're targeting jenkins. We just need to kick off a jenkins job.

Aug 3 2016, 6:03 PM · Restricted Project, Harbormaster
chad updated images of M1466: Phriction v3.
Aug 3 2016, 6:02 PM
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

Ah, that one's easier.

Aug 3 2016, 6:00 PM · Restricted Project, Harbormaster
eadler added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

plain old www-url-normal-web-form-encoded

Aug 3 2016, 5:56 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

@eadler, does your use case need a fancy content type like application/json, or just plain old www-url-normal-web-form-encoded?

Aug 3 2016, 5:32 PM · Restricted Project, Harbormaster
eadler added a project to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml): Restricted Project.
Aug 3 2016, 5:31 PM · Restricted Project, Harbormaster
epriestley merged T11422: support sending a body in harbormaster build steps into T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Aug 3 2016, 5:30 PM · Restricted Project, Harbormaster
epriestley merged task T11422: support sending a body in harbormaster build steps into T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Aug 3 2016, 5:30 PM · Harbormaster, Restricted Project, Feature Request
eadler created T11422: support sending a body in harbormaster build steps.
Aug 3 2016, 5:26 PM · Harbormaster, Restricted Project, Feature Request
em added a comment to T11420: Stable sort project tags in query results.

Ah, I didn't even notice there was a sorting criterion.

Aug 3 2016, 3:20 PM · Projects, Feature Request
epriestley added a comment to T11420: Stable sort project tags in query results.

I don't think this is a sort stability issue: we're preserving the order which the user who entered the tags originally used (in this particular UI it looks like we actually use reverse order, which I'd consider a bug, but other UIs like the "Tags" in the rightmost column and when editing the tags via "Edit Task" we use the original order).

Aug 3 2016, 3:09 PM · Projects, Feature Request
epriestley added a member for Blessed Committers: fooishbar.
Aug 3 2016, 2:45 PM
epriestley added a member for Community: fooishbar.
Aug 3 2016, 2:45 PM
• mdchristoffer updated the question details for Q457: How should "aliases" work in the .arcconfig file?.
Aug 3 2016, 1:59 PM
chad added a comment to T11419: Changing the project name removes old additional hashtags.

The reason we require it upfront is that it's a large support burden to ask for this information. It costs Phacility money. If users provide it upfront, we spend less time on support and more time building Phabricator. If you're a frequent contributor, this obviously compounds and make providing support even more cost effective. We just want to be able to provide everyone with free support. See also T9212 for longer discussion.

Aug 3 2016, 1:57 PM · Projects, Bug Report
chad added a comment to T11419: Changing the project name removes old additional hashtags.

I don't know if this is a bug report or feature request. It's missing information for both. Please read and follow Contributing Bug Reports and Contributing Feature Requests for how to file stuff into the upstream. How can we make it more clear this information is always required?

Aug 3 2016, 1:53 PM · Projects, Bug Report
chad closed T11419: Changing the project name removes old additional hashtags as Invalid.
Aug 3 2016, 1:46 PM · Projects, Bug Report
chad renamed T11420: Stable sort project tags in query results from Stable sort project tags in Maniphest query results to Stable sort project tags in query results.
Aug 3 2016, 1:41 PM · Projects, Feature Request
• mdchristoffer updated Q457: How should "aliases" work in the .arcconfig file? from to How should "aliases" work in the .arcconfig file?.
Aug 3 2016, 1:38 PM
chad merged T11421: Show task points in Maniphest query result view into T418: Integrate CustomField into more interfaces.
Aug 3 2016, 1:26 PM · Restricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields
chad merged task T11421: Show task points in Maniphest query result view into T418: Integrate CustomField into more interfaces.
Aug 3 2016, 1:26 PM · Maniphest, Feature Request
fooishbar updated the task description for T11421: Show task points in Maniphest query result view.
Aug 3 2016, 1:16 PM · Maniphest, Feature Request
fooishbar added a comment to T4316: Allow a comment to be added on the Maniphest edit interface.

The comment should be merged into the same row if you perform an edit and then leave a comment, as long as it takes you less than 2-3 minutes to write your comment and no intervening activity takes place.

Aug 3 2016, 12:48 PM · Maniphest
fooishbar created T11421: Show task points in Maniphest query result view.
Aug 3 2016, 12:42 PM · Maniphest, Feature Request
em created T11420: Stable sort project tags in query results.
Aug 3 2016, 9:23 AM · Projects, Feature Request
Danny_B created T11419: Changing the project name removes old additional hashtags.
Aug 3 2016, 8:57 AM · Projects, Bug Report
davidhodeffi added a comment to T8298: Fix Windows Escaping.

@hach-que I have understood that Windows is not the best OS for development, on the other hand you cannot ignore users that use this OS.
Anyway, what can be done in order to fix that ? what do you want me to do ? please be practical. I don't have any budget from the company right now so paying Phacility is not an option right now. I am very talented developer :)

Aug 3 2016, 8:31 AM · Windows
chad merged T6284: Allow manual reordering of documents in the document hierarchy into T8552: Increase user control over document hierarchy in Phriction.
Aug 3 2016, 4:48 AM · Phriction, Restricted Project
chad merged task T6284: Allow manual reordering of documents in the document hierarchy into T8552: Increase user control over document hierarchy in Phriction.
Aug 3 2016, 4:48 AM · Phriction
chad added a comment to T5254: Allow top-level wiki doc to display entire document hierarchy instead of only 2 levels.

We're going to likely move the hierarchy and give you control over what it shows. Merging in favor or T8552

Aug 3 2016, 4:27 AM · Phriction
chad merged T5254: Allow top-level wiki doc to display entire document hierarchy instead of only 2 levels into T8552: Increase user control over document hierarchy in Phriction.
Aug 3 2016, 4:26 AM · Phriction, Restricted Project
chad merged task T5254: Allow top-level wiki doc to display entire document hierarchy instead of only 2 levels into T8552: Increase user control over document hierarchy in Phriction.
Aug 3 2016, 4:26 AM · Phriction

Aug 2 2016

chad added a comment to T11418: Ability to attach subproject to different parent project.

Ah thanks, thought we did but couldn't find it since "subproject" was spelled "sub-project"

Aug 2 2016, 10:35 PM · Projects, Feature Request
milimetric added a comment to T10915: Allow story points to just be task count.

Just to be completely sure I understand this:

Since the switch to the point limit, we haven't been able to do that.

You can do this by noticing that X is greater than Z, right? You'd just prefer that the UI turn red too? Or am I still misunderstanding, and there's some actual information missing beyond the red color?

Aug 2 2016, 10:32 PM · Restricted Project, Feature Request
chad merged task T11418: Ability to attach subproject to different parent project into T11102: Supporting moving projects.
Aug 2 2016, 10:32 PM · Projects, Feature Request
chad merged T11418: Ability to attach subproject to different parent project into T11102: Supporting moving projects.
Aug 2 2016, 10:32 PM · Projects, Restricted Project, Feature Request
chad renamed T11102: Supporting moving projects from Supporting moving SubProjects between projects (in the ui) to Supporting moving projects.
Aug 2 2016, 10:32 PM · Projects, Restricted Project, Feature Request
eadler added a comment to T11418: Ability to attach subproject to different parent project.

T11102 is identical

Aug 2 2016, 10:30 PM · Projects, Feature Request
ksmith added a comment to T10915: Allow story points to just be task count.

I have no idea what percentage of phabricator current or future users will be task-count-centric rather than story-point-centric. Speaking generally, the Kanban ideal would use task counts, not points. (As compared to the Scrum and XP ideals, which would use points.)

Aug 2 2016, 10:01 PM · Restricted Project, Feature Request
epriestley added a comment to T10915: Allow story points to just be task count.

Just to be completely sure I understand this:

Aug 2 2016, 9:39 PM · Restricted Project, Feature Request
milimetric added a comment to T10915: Allow story points to just be task count.

@epriestley, I'd like to add a bit of extra support for this request. We used to use the column limit to see when we had too many tasks in a certain column. Since the switch to the point limit, we haven't been able to do that.

Aug 2 2016, 9:33 PM · Restricted Project, Feature Request
chad added a comment to T11418: Ability to attach subproject to different parent project.

What about using the batch editor instead?

Aug 2 2016, 8:51 PM · Projects, Feature Request
epriestley merged task T11417: Update Diff title and summary when commit message is changed into T2386: When users edit commit message information and run "arc diff" without --verbatim, warn them.
Aug 2 2016, 8:42 PM · Feature Request
epriestley merged T11417: Update Diff title and summary when commit message is changed into T2386: When users edit commit message information and run "arc diff" without --verbatim, warn them.
Aug 2 2016, 8:42 PM · Restricted Project, Arcanist
epriestley added a comment to T11417: Update Diff title and summary when commit message is changed.

You can use --verbatim to cause this update.

Aug 2 2016, 8:42 PM · Feature Request
epriestley added a comment to T10915: Allow story points to just be task count.

Just to clarify, workboard columns with a limit should currently show text like this in the header:

Aug 2 2016, 8:36 PM · Restricted Project, Feature Request
Danny_B created T11418: Ability to attach subproject to different parent project.
Aug 2 2016, 7:39 PM · Projects, Feature Request
rabahmeradi created T11417: Update Diff title and summary when commit message is changed.
Aug 2 2016, 7:28 PM · Feature Request
ksmith added a comment to T10915: Allow story points to just be task count.

The specific request of the WMF teams is for the workboard column WIP limit to be measured in task count rather than story points. We have been directed to this task for that request, although it's not clear to me that they are actually the same thing. We really don't want to treat tasks as if they had a story point value of 1.

Aug 2 2016, 7:12 PM · Restricted Project, Feature Request
chad closed T11416: fixed-width-text remarkup blocks lost max-width as Resolved by committing Restricted Diffusion Commit.
Aug 2 2016, 6:46 PM · PHUI, Bug Report
chad added a revision to T11416: fixed-width-text remarkup blocks lost max-width: Unknown Object (Differential Revision).
Aug 2 2016, 6:24 PM · PHUI, Bug Report
chad added a project to T11416: fixed-width-text remarkup blocks lost max-width: PHUI.
Aug 2 2016, 6:22 PM · PHUI, Bug Report
epriestley closed T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail.. as Resolved.

If you can identify why sudo was broken and what you did to fix it, we can probably add a setup warning to test for this problem. However, since we haven't seen other users with broken sudo and we couldn't help users resolve the issue with available information even if we did detect it, I don't think pursuing a check in the upstream is worthwhile.

Aug 2 2016, 6:18 PM · Diffusion, Bug Report
chad added a comment to T10915: Allow story points to just be task count.

You should talk to whoever administrates your install. They may have it locked.

Aug 2 2016, 6:18 PM · Restricted Project, Feature Request
ggellerman added a comment to T10915: Allow story points to just be task count.

@chad Thanks! And thanks to @epriestley, too. When I tried that, I got error "You do not have permission to configure forms for this application"

Aug 2 2016, 6:16 PM · Restricted Project, Feature Request
chad added a comment to T10915: Allow story points to just be task count.

You can set a global default in Edit Task → Configure Form → Edit Form Configuration → Change Default Values → Type Some Number → Save Defaults.

Aug 2 2016, 6:08 PM · Restricted Project, Feature Request
ggellerman added a comment to T10915: Allow story points to just be task count.

There has been some discussion about this request in T120042. It would be very useful to some teams that I work with as an Agile Coach for them to have the ability to limit work in process in columns by number of tasks rather than points. That is their workflow which Phab used to support, and the change has led to some confusion about how much work is in process.

Aug 2 2016, 6:01 PM · Restricted Project, Feature Request
chad updated the task description for T11416: fixed-width-text remarkup blocks lost max-width.
Aug 2 2016, 5:45 PM · PHUI, Bug Report
chad added a comment to T11416: fixed-width-text remarkup blocks lost max-width.
Usage Exception: Linter 'versions' specifies invalid type 'libversion'. Available linters are: csharp, chmod, composer, filename, xhpast, csslint, gjslint, coffeelint, cppcheck, cpplint, flake8, golint, hlint, jshint, jsonlint, jscs, lessc, pep8, php, phpcs, puppet-lint, pyflakes, pylint, rubocop, ruby, generated, json, merge-conflict, nolint, phutil-library, script-and-regex, spelling, text, xml, checkstyle.
Aug 2 2016, 5:44 PM · PHUI, Bug Report
chad added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

Usage Exception: Linter 'versions' specifies invalid type 'libversion'. Available linters are: csharp, chmod, composer, filename, xhpast, csslint, gjslint, coffeelint, cppcheck, cpplint, flake8, golint, hlint, jshint, jsonlint, jscs, lessc, pep8, php, phpcs, puppet-lint, pyflakes, pylint, rubocop, ruby, generated, json, merge-conflict, nolint, phutil-library, script-and-regex, spelling, text, xml, checkstyle.

Aug 2 2016, 5:44 PM · PHUI, Bug Report
avivey added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

MSIE behaves better:

pasted_file (987×1 px, 96 KB)

Aug 2 2016, 5:20 PM · PHUI, Bug Report
chad added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

thanks, that clears it up for me!

Aug 2 2016, 5:20 PM · PHUI, Bug Report
avivey added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

Feed, from here:

pasted_file (1×1 px, 196 KB)

Aug 2 2016, 5:19 PM · PHUI, Bug Report
chad added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

Is this only on /feed/ or on other pages as well

Aug 2 2016, 5:17 PM · PHUI, Bug Report
avivey added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

Regular comments and inlines in differential, and records in Feed.
Does not reproduce in Maniphest.

Aug 2 2016, 5:17 PM · PHUI, Bug Report
chad added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

maybe you can post screenshots so I don't have to guess what we're talking about.

Aug 2 2016, 5:16 PM · PHUI, Bug Report
avivey added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

Yeah, inlines too

Aug 2 2016, 5:16 PM · PHUI, Bug Report
chad added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

So regular comments on the feed page, nothing to do with differential or inline comments?

Aug 2 2016, 5:16 PM · PHUI, Bug Report
avivey added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

Regular comments, not inline comments (Although I haven't checked those yet).

Aug 2 2016, 5:14 PM · PHUI, Bug Report
chad added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

So feed and differential inline comments?

Aug 2 2016, 5:14 PM · PHUI, Bug Report
CodeMouse92 added a comment to T9640: Make Phabricator compatible with PHP7.

@michaeljs1990, is was actually not possible to install PHP5 on Ubuntu 16.04 through a safe means (an apt repository or similar) for some time.

Aug 2 2016, 5:01 PM · Prioritized, Restricted Project, Infrastructure
avivey added a comment to T11416: fixed-width-text remarkup blocks lost max-width.

Ha! It's bad in the feed page.

Aug 2 2016, 5:00 PM · PHUI, Bug Report
avivey added a comment to T11416: fixed-width-text remarkup blocks lost max-width.
Usage Exception: Linter 'versions' specifies invalid type 'libversion'. Available linters are: csharp, chmod, composer, filename, xhpast, csslint, gjslint, coffeelint, cppcheck, cpplint, flake8, golint, hlint, jshint, jsonlint, jscs, lessc, pep8, php, phpcs, puppet-lint, pyflakes, pylint, rubocop, ruby, generated, json, merge-conflict, nolint, phutil-library, script-and-regex, spelling, text, xml, checkstyle.
Aug 2 2016, 4:59 PM · PHUI, Bug Report
avivey created T11416: fixed-width-text remarkup blocks lost max-width.
Aug 2 2016, 4:58 PM · PHUI, Bug Report
chad added a project to T11414: Clicking on mock inline comment preview doesn't display the correct image: Pholio.
Aug 2 2016, 4:50 PM · Restricted Project, Pholio, Bug Report
chad edited projects for T11411: Commits to github branch close Differential revision, added: Diffusion, Documentation; removed Bug Report.
Aug 2 2016, 4:50 PM · Documentation, Diffusion
chad added projects to T11407: Make is possible to react to commits being parsed: Diffusion, Herald.
Aug 2 2016, 4:49 PM · Herald, Diffusion, Feature Request
chad added a project to T11402: Garbage collect and/or compress/archive harbormaster build unit messages: Harbormaster.
Aug 2 2016, 4:49 PM · Restricted Project, Harbormaster, Feature Request
chad added a project to T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail..: Diffusion.

Sounds like this is resolved? Or should we attempt to catch this case?

Aug 2 2016, 4:49 PM · Diffusion, Bug Report
chad added a project to T11415: Would like people who can't edit Harbormaster plans to be able to run them: Harbormaster.
Aug 2 2016, 4:47 PM · Restricted Project, Harbormaster, Feature Request
djehuti added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

Or are you just concerned that they may make mistakes

Aug 2 2016, 4:39 PM · Restricted Project, Harbormaster, Feature Request
fabe added a comment to T5055: Distribution mechanism for arc extensions.

The whole "identify the packager problem" with composer is indeed a big one and i'm not suggesting you use composer in any way for the arcanist/phabricator packages! Generally i agree that i want to primarily trust the packager and not the developer. This is the way this is handled with os packages (rpm/deb) and companies are used to the workflow: Getting new packages from a somewhat trusted/signed source (e.g. redhat/canonical), testing them yourself, signing them with your own key as well and then distributing to the internal repositories and "end users" only trust your own internal key.

Aug 2 2016, 4:18 PM · Arcanist
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

(You can't write "Run Build Plans: ..." personal rules, but you can write them in object rules, which isn't too much different.)

Aug 2 2016, 4:02 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

It's also probably bad/inconsistent that you can run builds via Herald which you could not run via the web UI.

Aug 2 2016, 4:00 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

I have mixed feelings about relaxing this. I think there are basically two parts to this:

Aug 2 2016, 3:57 PM · Restricted Project, Harbormaster, Feature Request
djehuti created T11415: Would like people who can't edit Harbormaster plans to be able to run them.
Aug 2 2016, 3:36 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: Unknown Object (Differential Revision).
Aug 2 2016, 3:32 PM · Documentation, Herald
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

I generally expect all signing to be external, at least for the foreseeable future.

Aug 2 2016, 3:22 PM · Arcanist
fabe added a comment to T5055: Distribution mechanism for arc extensions.

It might be beneficial to generally support gpg signed commits / tags in phabricators git repos and then use the same mechanism for the arcanist packages.
Since github recently started pushing this feature a bit (https://github.com/blog/2144-gpg-signature-verification) quite a few library maintainers started signing their release tags.
And i just recently spoke to a lib maintainer about extending composer to verify all packages (on install or upgrade) against a list of authors trusted by the user (or an enterprise wide list).

Aug 2 2016, 1:46 PM · Arcanist
enckse added a comment to T9640: Make Phabricator compatible with PHP7.

It seems likely, as well, until php 7.1 is officially supported that you probably don't want to sign-up for some potential pain points by choosing to roll the dice.

Aug 2 2016, 12:35 PM · Prioritized, Restricted Project, Infrastructure
michaeloa added a comment to T11409: harbormaster.buildquery fatals on short array syntax in older PHP.

Thanks. Appreciate the quick fix on this.

Aug 2 2016, 12:18 PM · Lint, Harbormaster, Bug Report