Page MenuHomePhabricator

harbormaster.buildquery fatals on short array syntax in older PHP
Closed, ResolvedPublic

Description

We run a fairly bleeding edge Phabricator server (updated every day via Chef). This morning, when running "arc diff", we encounter the following error.

$ arc diff --trace
 ARGV  '/usr/local/include/php/arcanist/bin/../scripts/arcanist.php' 'diff' '--trace'
 LOAD  Loaded "phutil" from "/usr/local/include/php/libphutil/src".
 LOAD  Loaded "arcanist" from "/usr/local/include/php/arcanist/src".
Config: Reading user configuration file "/home/michaeloa/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: Reading .arcconfig from "/disk1/MetNo/metapi/.arcconfig".
Working Copy: Path "/disk1/MetNo/metapi" is part of `git` working copy "/disk1/MetNo/metapi".
Working Copy: Project root is at "/disk1/MetNo/metapi".
Config: Did not find local configuration at "/disk1/MetNo/metapi/.git/arc/config".
>>> [0] <conduit> conduit.connect() <bytes = 451>
>>> [1] <http> https://phab.met.no/api/conduit.connect
<<< [1] <http> 109,330 us
<<< [0] <conduit> 109,966 us

[2016-08-01 11:08:56] EXCEPTION: (HTTPFutureHTTPResponseStatus) [HTTP/500] Internal Server Error
>>> UNRECOVERABLE FATAL ERROR <<<

syntax error, unexpected &#039;[&#039;

/opt/phabricator/phabricator/src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php:59


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻ at [<phutil>/src/future/http/BaseHTTPFuture.php:339]
arcanist(head=master, ref.master=06c641f92c65), phutil(head=master, ref.master=d0daa2b343e4)
  #0 BaseHTTPFuture::parseRawHTTPResponse(string) called at [<phutil>/src/future/http/HTTPSFuture.php:418]
  #1 HTTPSFuture::isReady() called at [<phutil>/src/future/Future.php:37]
  #2 Future::resolve(NULL) called at [<phutil>/src/future/FutureProxy.php:34]
  #3 FutureProxy::resolve() called at [<phutil>/src/conduit/ConduitClient.php:64]
  #4 ConduitClient::callMethodSynchronous(string, array) called at [<arcanist>/src/workflow/ArcanistWorkflow.php:370]
  #5 ArcanistWorkflow::authenticateConduit() called at [<arcanist>/scripts/arcanist.php:356]

This is with (AFAIK) the latest version of Arcanist (ran an arc upgrade prior to this).

Bug? Any leads on what we might do to fix this if not?