Page MenuHomePhabricator
Feed All Stories

Jul 1 2016

epriestley created P1997 undo_transactions.php.
Jul 1 2016, 12:47 PM
claassen added a comment to T11250: New Herald rule: "Differential revision accepted by".

At our company, we have several interns employed. We want them to learn from each other, as well as from us, so we've tried to set up a workflow that makes the interns review each other. When an intern accepts the reviews, we want the supervisor of the author to have another look and give the final go.

Jul 1 2016, 11:03 AM · Feature Request
chad added a comment to T11250: New Herald rule: "Differential revision accepted by".

Oh, the group could be a non-blocking reviewer. I think moving a post-check to Herald doesn't solve the underlying problem of reviews being marked as accepted that shouldn't be. Can you go into more detail on what's going on there so we can identify the core problem?

Jul 1 2016, 7:25 AM · Feature Request
chad added a comment to T11250: New Herald rule: "Differential revision accepted by".

Someone else who's not in the group could've accepted, and the group could be a non-blocking reviewer.

Jul 1 2016, 7:18 AM · Feature Request
chad added a comment to T11250: New Herald rule: "Differential revision accepted by".

Why are we pushing this check to Herald? Shouldn't the fact that it's accepted mean it's accepted?

Jul 1 2016, 7:13 AM · Feature Request
claassen created T11250: New Herald rule: "Differential revision accepted by".
Jul 1 2016, 7:07 AM · Feature Request
cwlin0416 created T11249: Request to add Traditional Chinese locale.
Jul 1 2016, 5:21 AM · Localization, Feature Request
featherless awarded T11244: Identify additional tokens to add to Phabricator a Doubloon token.
Jul 1 2016, 5:14 AM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

First 16 are done and out for review. Next 8 are sent off to the designer, should have them next week. Can explore another set of 8 if needed after that.

Jul 1 2016, 4:28 AM · Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Jul 1 2016, 4:27 AM · Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Jul 1 2016, 4:24 AM · Celerity, Tokens
chad added a revision to T11244: Identify additional tokens to add to Phabricator: Unknown Object (Differential Revision).
Jul 1 2016, 4:11 AM · Celerity, Tokens
hach-que updated the task description for T11248: ArcanistLinter's addLintMessage incorrectly normalizes path on Windows.
Jul 1 2016, 3:03 AM · Windows, Bug Report
hach-que created T11248: ArcanistLinter's addLintMessage incorrectly normalizes path on Windows.
Jul 1 2016, 3:02 AM · Windows, Bug Report
eadler added a comment to T11244: Identify additional tokens to add to Phabricator.

We need a platypus. It is objectively the best animal.

Jul 1 2016, 2:49 AM · Celerity, Tokens
swisspol closed T11246: Commit stuck importing on Phacility as Resolved.

I was away for dinner and indeed, it was imported when I got back and everything seems good.!

Jul 1 2016, 1:54 AM · Bug Report
epriestley added a comment to T11246: Commit stuck importing on Phacility.

Looks like it imported before I got to it. Still seeing an issue?

Jul 1 2016, 1:48 AM · Bug Report
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

(I also added you to Community, granting you tremendous new power to tidy up around here.)

Jul 1 2016, 1:11 AM · Bug Report
epriestley added a member for Community: timhirsh.
Jul 1 2016, 1:10 AM
epriestley closed T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service as Resolved.

Ah! That makes sense. Originally we were more strict about which repositories we would update (which would have caught this) but this created some worse/more-confusing effects in the "enroll" direction (see T10940).

Jul 1 2016, 1:10 AM · Bug Report
timhirsh added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

No, there's no load balancer. In DarkConsole under Request -> Machine I'm seeing the same IP for both cases. But repo002 is configured to share the db from repo001.

Jul 1 2016, 1:01 AM · Bug Report
hach-que updated the task description for T11247: Support linters where linter names aren't known ahead of time.
Jul 1 2016, 12:55 AM · Feature Request
hach-que closed T11247: Support linters where linter names aren't known ahead of time as Resolved.

I managed to work around this for now by just doing this manually:

Jul 1 2016, 12:55 AM · Feature Request
hach-que created T11247: Support linters where linter names aren't known ahead of time.
Jul 1 2016, 12:50 AM · Feature Request
swisspol created T11246: Commit stuck importing on Phacility.
Jul 1 2016, 12:38 AM · Bug Report
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jul 1 2016, 12:17 AM · Restricted Project, Differential
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jul 1 2016, 12:01 AM · Restricted Project, Differential

Jun 30 2016

epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jun 30 2016, 11:44 PM · Restricted Project, Differential
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

You can also check Request → Machine in DarkConsole to see which host served things, if the Load Balancer / web node thing might be part of the explanation.

Jun 30 2016, 11:42 PM · Bug Report
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

(When I toggle between cluster/no-cluster locally with --service / --remove-service, everything appears to be working properly, although I didn't precisely reproduce your setup.)

Jun 30 2016, 11:39 PM · Bug Report
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

Just to rule this out, are repo001 and repo002 also web nodes which may receive traffic directly? That is, could this be explained this way?

Jun 30 2016, 11:37 PM · Bug Report
timhirsh created T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.
Jun 30 2016, 11:16 PM · Bug Report
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jun 30 2016, 11:11 PM · Restricted Project, Differential
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jun 30 2016, 11:01 PM · Restricted Project, Differential
bjshively added a comment to T11244: Identify additional tokens to add to Phabricator.

Humbly suggesting any/all of the following: gun, bomb, skull and cross bones. I find that I type :skull: :gun: on slack a lot (a common side effect of support ops work.)

Jun 30 2016, 9:57 PM · Celerity, Tokens
chad awarded T11244: Identify additional tokens to add to Phabricator a The World Burns token.
Jun 30 2016, 9:26 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

These will be images in Phabricator, not emoji.

Jun 30 2016, 9:19 PM · Celerity, Tokens
avivey added a comment to T11244: Identify additional tokens to add to Phabricator.
In T11244#183049, @chad wrote:
Jun 30 2016, 9:19 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

http://emojipedia.org/upside-down-face/

Jun 30 2016, 9:16 PM · Celerity, Tokens
avivey added a comment to T11244: Identify additional tokens to add to Phabricator.

Is the last one supposed to be a cube? Windows is 🐗 ing

pasted_file (164×66 px, 2 KB)

Jun 30 2016, 9:16 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

need some food / drinks

Jun 30 2016, 9:15 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

added dat boi

Jun 30 2016, 9:15 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

ohh, its boaring

Jun 30 2016, 9:14 PM · Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Jun 30 2016, 9:14 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.

I think only frogs are allowed to be memes.

Jun 30 2016, 9:11 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.

I wish :(

Jun 30 2016, 9:11 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

is that from a dank meme i'm not aware of?

Jun 30 2016, 9:08 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.
  • 🐗 For when something is boring.
Jun 30 2016, 9:06 PM · Celerity, Tokens
epriestley added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.

Thanks for the report! The primary issue should be resolved at HEAD of master, and promote to stable within about 48 hours.

Jun 30 2016, 9:05 PM · Files, Bug Report
chad created T11244: Identify additional tokens to add to Phabricator.
Jun 30 2016, 9:04 PM · Celerity, Tokens
epriestley closed T11242: MIME type detection does not run on files large enough to activate the chunking engine as Resolved by committing Restricted Diffusion Commit.
Jun 30 2016, 8:57 PM · Files, Bug Report
avivey created T11243: User Guide links should open in a new tab.
Jun 30 2016, 8:41 PM · Documentation, Feature Request
epriestley added a revision to T11242: MIME type detection does not run on files large enough to activate the chunking engine: Unknown Object (Differential Revision).
Jun 30 2016, 8:33 PM · Files, Bug Report
bjshively added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.
In T11242#183007, @chad wrote:

{F1706803}

This timely comment saved me a great deal of effort in exporting a high-resolution video of my cat with music and effects or something to get it big enough.

Jun 30 2016, 8:30 PM · Files, Bug Report
epriestley added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.
In T11242#183007, @chad wrote:

{F1706803}

Jun 30 2016, 8:29 PM · Files, Bug Report
bjshively added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.

Thanks for the ridiculously fast triage. Not an urgent issue for us, just wanted to make sure you were aware of it.

Jun 30 2016, 8:19 PM · Files, Bug Report
chad added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.

{F1706803}

Jun 30 2016, 8:16 PM · Files, Bug Report
chad added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.

Appears to only occur when a file needs chunked. Small files work fine.

Jun 30 2016, 8:14 PM · Files, Bug Report
epriestley renamed T11242: MIME type detection does not run on files large enough to activate the chunking engine from Loss of mime type when file is uploaded via drag-and-drop uploader to MIME type detection does not run on files large enough to activate the chunking engine.
Jun 30 2016, 8:13 PM · Files, Bug Report
epriestley added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.

Several behaviors are interacting here. First, here's how MIME types work:

Jun 30 2016, 8:12 PM · Files, Bug Report
bjshively updated the task description for T11242: MIME type detection does not run on files large enough to activate the chunking engine.
Jun 30 2016, 8:01 PM · Files, Bug Report
chad updated the task description for T9360: Unbeta Phame.
Jun 30 2016, 7:57 PM · Phame
bjshively created T11242: MIME type detection does not run on files large enough to activate the chunking engine.
Jun 30 2016, 7:56 PM · Files, Bug Report
epriestley closed T10703: Merge Duplicate Tasks should maybe default to All Open, a subtask of T7805: Use ApplicationSearch in the ObjectSelector dialog, as Resolved.
Jun 30 2016, 6:51 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley closed T10703: Merge Duplicate Tasks should maybe default to All Open as Resolved by committing Restricted Diffusion Commit.
Jun 30 2016, 6:51 PM · Maniphest, Feature Request
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jun 30 2016, 6:50 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
eadler added a project to T11227: Support including files by shebang in .arclint: Restricted Project.
Jun 30 2016, 6:40 PM · Restricted Project, Lint, Feature Request
eadler added a project to T11235: Threaded comments: Restricted Project.
Jun 30 2016, 6:40 PM · Restricted Project, Differential, Feature Request
eadler added a project to T11239: Add ability to flag user to not trigger notifications: Restricted Project.
Jun 30 2016, 6:40 PM · Restricted Project, Wikimedia, Feature Request
chad merged T11241: herald rule for comments and/or @ mentions into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Jun 30 2016, 6:33 PM · Customer Impact, Restricted Project, Mail
chad merged task T11241: herald rule for comments and/or @ mentions into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Jun 30 2016, 6:33 PM · Herald, Feature Request
danielberger created T11241: herald rule for comments and/or @ mentions.
Jun 30 2016, 6:30 PM · Herald, Feature Request
epriestley closed T11240: Expandable menus are not greyed out, even if all options are not useable, a subtask of T4788: Allow "Edit Dependencies" both ways (blocking and depending), as Resolved.
Jun 30 2016, 5:57 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley closed T11240: Expandable menus are not greyed out, even if all options are not useable as Resolved by committing Restricted Diffusion Commit.
Jun 30 2016, 5:57 PM · Bug Report
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jun 30 2016, 5:56 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a revision to T10703: Merge Duplicate Tasks should maybe default to All Open: Unknown Object (Differential Revision).
Jun 30 2016, 5:56 PM · Maniphest, Feature Request
epriestley added a revision to T11240: Expandable menus are not greyed out, even if all options are not useable: Unknown Object (Differential Revision).
Jun 30 2016, 5:24 PM · Bug Report
epriestley added a subtask for T7805: Use ApplicationSearch in the ObjectSelector dialog: T10703: Merge Duplicate Tasks should maybe default to All Open.
Jun 30 2016, 5:08 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a parent task for T10703: Merge Duplicate Tasks should maybe default to All Open: T7805: Use ApplicationSearch in the ObjectSelector dialog.
Jun 30 2016, 5:08 PM · Maniphest, Feature Request
epriestley updated subscribers of T11236: Regression: side-by-side diffs: very long lines overflow in diffusion.

@csilvers, I think you ran into this too although I wasn't around at the time. Likely fixed in HEAD of master.

Jun 30 2016, 5:06 PM · Bug Report
epriestley added a subtask for T4788: Allow "Edit Dependencies" both ways (blocking and depending): T11240: Expandable menus are not greyed out, even if all options are not useable.
Jun 30 2016, 4:55 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a parent task for T11240: Expandable menus are not greyed out, even if all options are not useable: T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Jun 30 2016, 4:55 PM · Bug Report
Luke081515.2 created T11240: Expandable menus are not greyed out, even if all options are not useable.
Jun 30 2016, 4:51 PM · Bug Report
epriestley merged T11233: Allow customizing the update message template into T6072: Improve usability of `arc diff`.
Jun 30 2016, 3:59 PM · Restricted Project, Documentation, Arcanist
epriestley merged task T11233: Allow customizing the update message template into T6072: Improve usability of `arc diff`.
Jun 30 2016, 3:59 PM · Feature Request
epriestley added a comment to T11233: Allow customizing the update message template.

I'm going to merge this into T6072, which discusses some of these issues in greater detail.

Jun 30 2016, 3:59 PM · Feature Request
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

There is now a Edit Related Tasks → Close as Duplicate action next to the existing Edit Related Tasks → Merge Duplicates In action in the related tasks submenu. This change is live on this install:

Jun 30 2016, 3:49 PM · Restricted Project, User Delight, Maniphest
epriestley closed T7820: Add "Closed, Duplicate" option to Status Action in Maniphest, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jun 30 2016, 3:35 PM · Maniphest
epriestley closed T7820: Add "Closed, Duplicate" option to Status Action in Maniphest as Resolved by committing Restricted Diffusion Commit.
Jun 30 2016, 3:35 PM · Restricted Project, User Delight, Maniphest
tide added a comment to T11237: Mobile action menus are "undefined".

Happens on test account too

Jun 30 2016, 3:14 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a comment to T11237: Mobile action menus are "undefined".

I tried a couple of other devices in the simulator but couldn't get a repro -- can you try this to get a JS trace?

Jun 30 2016, 2:35 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T11237: Mobile action menus are "undefined".

Let me try my spam account.

Jun 30 2016, 2:30 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T11237: Mobile action menus are "undefined".

Image.png (1×750 px, 108 KB)

Jun 30 2016, 2:27 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T11237: Mobile action menus are "undefined".

Nothing unusual. Latest iPhone/iOS

Jun 30 2016, 2:26 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a comment to T11237: Mobile action menus are "undefined".

I can't immediately reproduce this in iOS Simulator or on my physical iPhone 4s. What hardware/OS version are you seeing it on?

Jun 30 2016, 2:24 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a comment to T11237: Mobile action menus are "undefined".

image.jpg (960×640 px, 108 KB)

Jun 30 2016, 2:23 PM · Chad's House, Mobile, Safari, Bug Report
epriestley claimed T11237: Mobile action menus are "undefined".
Jun 30 2016, 2:20 PM · Chad's House, Mobile, Safari, Bug Report
chad added Q425: Any way to select the "correct answer" (Answer 413).
Jun 30 2016, 2:04 PM
chad added a comment to T11239: Add ability to flag user to not trigger notifications.

Please see Contributing Feature Requests and Describing Root Problems to better understand what we consider to be valid feature requests. Specifically we need to know the root problem that occurred that prompted this request to begin with. Right now all we have for information is that too much email was sent out during some operation. There might be other solutions depending what exactly happened and why, to solve this core problem.

Jun 30 2016, 2:01 PM · Restricted Project, Wikimedia, Feature Request
chad added a comment to T11239: Add ability to flag user to not trigger notifications.

The concern here, though well intended, is that it circumvents the audit-ability we build into Phabticator on purpose. We don't know why users have requested to receive notifications,

Jun 30 2016, 1:52 PM · Restricted Project, Wikimedia, Feature Request