Regression: side-by-side diffs: very long lines overflow in diffusion
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	20after4
	Jun 30 2016, 1:11 AM

Description

Set diffs to side-by-side on the above-linked commit.

I think this is happening because the innermost span is set to display: inline-block

The problem goes away when I disable this css rule:

.remarkup-code td span { display: inline-block }

rP Phabricator
	D16198	rP922822bd2dc3 Wrap really long text properly in diffs

Mentioned In: T12163: Long lines overflow in Diffusion browser
Mentioned Here: T10959: Hard-coded diff line height interacts poorly with large custom font sizes
D15905: Remove hard-coding of diff line height

This is unrelated to prose diffs.

It was introduced in D15905 to resolve T10959 (custom monospaced fonts like "Impact 12px/36px" not working well).

proooobably can just sneak word-break: break-all; in there, but needs some testing.

@chad: indeed, word-break: break-all on the .differential-diff td element seems to do the trick.

@csilvers, I think you ran into this too although I wasn't around at the time. Likely fixed in HEAD of master.