Page MenuHomePhabricator

Regression: side-by-side diffs: very long lines overflow in diffusion
Closed, ResolvedPublic

Description

Downstream bug report

https://phabricator.wikimedia.org/T137394

URL that exhibits the bug:

https://phabricator.wikimedia.org/rOPUPa660414f0a1af1963b23b6b02ff6e57794d8756f

How to reproduce

Set diffs to side-by-side on the above-linked commit.

What I see

diff-overflow.png (206×993 px, 77 KB)

Observations

I think this is happening because the innermost span is set to display: inline-block

The problem goes away when I disable this css rule:

.remarkup-code td span { display: inline-block }

Event Timeline

This is unrelated to prose diffs.

It was introduced in D15905 to resolve T10959 (custom monospaced fonts like "Impact 12px/36px" not working well).

proooobably can just sneak word-break: break-all; in there, but needs some testing.

@chad: indeed, word-break: break-all on the .differential-diff td element seems to do the trick.

@csilvers, I think you ran into this too although I wasn't around at the time. Likely fixed in HEAD of master.