Page MenuHomePhabricator
Feed All Stories

Sat, Sep 4

cspeckmim requested review of D21717: Remove history query from DiffusionRepositoryController as it is unused.
Sat, Sep 4, 5:56 AM
cspeckmim updated the task description for T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Sat, Sep 4, 5:49 AM · Diffusion
cspeckmim requested review of D21716: Update ArcanistMercurialAPI to support getting the current commit ref.
Sat, Sep 4, 4:56 AM
cspeckmim added a revision to T13665: The "arc amend" workflow does not work on Mercurial repositories: D21716: Update ArcanistMercurialAPI to support getting the current commit ref.
Sat, Sep 4, 4:56 AM · Mercurial, Arcanist

Fri, Sep 3

cspeckmim claimed T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Fri, Sep 3, 10:26 PM · Diffusion
cspeckmim added a comment to D21715: Add support to marking commits as UNREACHABLE for Mercurial.

I attempted to load the repository page and saw an exception due to a missing commit.

I don't think this is expected behavior but I'll make a new task for it since it's outside the scope of this change.

Created T13666

Fri, Sep 3, 10:26 PM
cspeckmim updated the task description for T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Fri, Sep 3, 10:26 PM · Diffusion
cspeckmim renamed T13365: Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit" from Conduit API method "diffusion.historyquery" fatals if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit".
Fri, Sep 3, 10:24 PM · Diffusion
cspeckmim renamed T13365: Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit" from Conduit API method "diffusion.historyquery" fatals under Git if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals if passed a bad "commit".
Fri, Sep 3, 10:24 PM · Diffusion
cspeckmim triaged T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations as Low priority.
Fri, Sep 3, 10:23 PM · Diffusion
cspeckmim added a comment to D21715: Add support to marking commits as UNREACHABLE for Mercurial.

I attempted to load the repository page and saw an exception due to a missing commit.

I don't think this is expected behavior but I'll make a new task for it since it's outside the scope of this change.

Fri, Sep 3, 10:08 PM
cspeckmim updated the task description for T13665: The "arc amend" workflow does not work on Mercurial repositories.
Fri, Sep 3, 9:47 PM · Mercurial, Arcanist
cspeckmim updated the test plan for D21715: Add support to marking commits as UNREACHABLE for Mercurial.
Fri, Sep 3, 9:45 PM
cspeckmim published D21715: Add support to marking commits as UNREACHABLE for Mercurial for review.
Fri, Sep 3, 9:44 PM
cspeckmim added a project to T13665: The "arc amend" workflow does not work on Mercurial repositories: Mercurial.
Fri, Sep 3, 2:25 PM · Mercurial, Arcanist
cspeckmim added a project to T13665: The "arc amend" workflow does not work on Mercurial repositories: Arcanist.
Fri, Sep 3, 2:25 PM · Mercurial, Arcanist
cspeckmim triaged T13665: The "arc amend" workflow does not work on Mercurial repositories as Wishlist priority.
Fri, Sep 3, 2:24 PM · Mercurial, Arcanist
cspeckmim added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

In Mercurial, I'm not exactly sure how wide this window is. Since you normally can't strip commits in the remote by pushing (AFAIK?)

This is true, though it does change a bit if we enable evolve server-side. Then when commits/branches are pruned when pushing/pulling those obsolete markers will also be transferred, allowing similar disappearing commits (retrievable via —hidden). However I believe by default mercurial does not allow pruning public changesets (would require forcibly changing phases on client/server, or running a server/branch in non-publishing mode). Supporting evolve/topics server-side is probably large enough that it would be its own big project. So I think this assumption holds up well.

Fri, Sep 3, 3:57 AM · Diffusion
epriestley added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

(D21715 is still a draft, but I left a couple of more specific comments there.)

Fri, Sep 3, 3:39 AM · Diffusion
epriestley added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

Does this refer to when multiple dependent commits are pushed and then stripped from the on-disk state?

Fri, Sep 3, 3:35 AM · Diffusion
cspeckmim added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

Another caveat here is that if you destroy commits directly in Phabricator's working copy in certain states, it's possible it won't be able to trace ancestry to find all the commits you destroyed in order to mark them unreachable. However, this window is narrow. For Git, you can bin/repository mark-reachable to rebuild reachability if you know you've done a bunch of dangerous mutations to the on-disk state.

Fri, Sep 3, 3:02 AM · Diffusion
cspeckmim updated the task description for T13634: Support marking commits as UNREACHABLE in Mercurial.
Fri, Sep 3, 2:58 AM · Diffusion
cspeckmim added a revision to T13634: Support marking commits as UNREACHABLE in Mercurial: D21715: Add support to marking commits as UNREACHABLE for Mercurial.
Fri, Sep 3, 2:55 AM · Diffusion

Aug 20 2021

0 added a comment to D21714: Fix subtype extension support check.

Thank you for figuring out the appropriate change!

Aug 20 2021, 10:51 PM
0 closed T13663: TypeError when editing calendar import as Resolved by committing rP1965b78b34f1: Fix subtype extension support check.
Aug 20 2021, 10:49 PM · Calendar
0 closed D21714: Fix subtype extension support check.
Aug 20 2021, 10:49 PM
0 committed rP1965b78b34f1: Fix subtype extension support check (authored by 0).
Fix subtype extension support check
Aug 20 2021, 10:49 PM
epriestley accepted D21714: Fix subtype extension support check.

Thanks!

Aug 20 2021, 1:52 PM
0 published D21714: Fix subtype extension support check for review.
Aug 20 2021, 6:15 AM
0 added a revision to T13663: TypeError when editing calendar import: D21714: Fix subtype extension support check.
Aug 20 2021, 6:12 AM · Calendar

Aug 19 2021

epriestley updated the task description for T13664: SSRF and Phabricator.
Aug 19 2021, 5:07 PM · Security, Guides
epriestley triaged T13664: SSRF and Phabricator as Low priority.
Aug 19 2021, 4:41 PM · Security, Guides
epriestley added a comment to T13663: TypeError when editing calendar import.

I think this is probably the cleanest fix, but I only tested event imports (which now appear to work). If you want to test Maniphest with subtypes configured (to make sure it doesn't break) and send me a revision with this change, I'll review it. Otherwise, I'll do that testing when I get a chance and land this if nothing crops up.

Aug 19 2021, 4:07 PM · Calendar
0 updated subscribers of T13663: TypeError when editing calendar import.
Aug 19 2021, 2:31 AM · Calendar
0 created T13663: TypeError when editing calendar import.
Aug 19 2021, 2:27 AM · Calendar

Aug 18 2021

epriestley removed a member for Phacility High Command: amckinley.
Aug 18 2021, 7:31 PM

Aug 17 2021

cspeckmim awarded T13133: Phabricator Query Layer Overview a Mountain of Wealth token.
Aug 17 2021, 12:14 AM · Guides

Aug 2 2021

epriestley committed rP8daaf5ef2145: Pass a real context object to Phriction previews, fixing mentions (authored by epriestley).
Pass a real context object to Phriction previews, fixing mentions
Aug 2 2021, 3:36 PM
epriestley closed T13662: Mentions break Phriction preview as Resolved by committing rP8daaf5ef2145: Pass a real context object to Phriction previews, fixing mentions.
Aug 2 2021, 3:36 PM · Phriction
epriestley closed D21709: Pass a real context object to Phriction previews, fixing mentions.
Aug 2 2021, 3:36 PM
epriestley closed D21708: Fix Phriction document previews for the root document ("/") with Apache option "MergeSlashes On".
Aug 2 2021, 3:36 PM
epriestley committed rPc7550dbee9b1: Fix Phriction document previews for the root document ("/") with Apache option… (authored by epriestley).
Fix Phriction document previews for the root document ("/") with Apache option…
Aug 2 2021, 3:36 PM
epriestley added a comment to T13652: Notes on Ardunio CNC drivers.

I found this channel incredibly helpful for repairing/replacing components on boards:

Aug 2 2021, 4:19 AM

Aug 1 2021

0 accepted D21709: Pass a real context object to Phriction previews, fixing mentions.
Aug 1 2021, 7:11 PM
epriestley added a comment to D21709: Pass a real context object to Phriction previews, fixing mentions.

You can render remarkup using this rule without having a meaningful relative base URI, e.g. on some other object type or via remarkup.process in the API. This isn't necessarily a meaningful operation and the result may not be useful, but remarkup generally tries not to fail loudly: if you copy/paste a block of text from somewhere that happens to have some substrings which aren't valid, the desired behavior is generally for your text to be processed in some best-guess-at-sensible way -- and usually emitted unmodified (see also discussion in D21713).

Aug 1 2021, 7:06 PM
0 added inline comments to D21709: Pass a real context object to Phriction previews, fixing mentions.
Aug 1 2021, 6:51 PM
0 accepted D21708: Fix Phriction document previews for the root document ("/") with Apache option "MergeSlashes On".

This also fixes root document preview in lighttpd, which seems to have mandatory slash merging.

Aug 1 2021, 6:08 PM

Jul 29 2021

epriestley committed rPdbe2fb466fed: Add an "eval" rule to Remarkup (authored by epriestley).
Add an "eval" rule to Remarkup
Jul 29 2021, 11:47 PM
epriestley closed D21713: Add an "eval" rule to Remarkup.
Jul 29 2021, 11:47 PM
epriestley added inline comments to D21713: Add an "eval" rule to Remarkup.
Jul 29 2021, 8:31 PM
cspeckmim accepted D21713: Add an "eval" rule to Remarkup.
Jul 29 2021, 8:30 PM
epriestley updated the diff for D21713: Add an "eval" rule to Remarkup.
  • For now, just return the literal input if we fail to evaluate an expression.
Jul 29 2021, 8:18 PM
epriestley added a comment to D21713: Add an "eval" rule to Remarkup.

When intent is ambiguous (the user might or might not be trying to invoke a Remarkup rule), I try to make the output of an "invalid" input exactly the same as the input, so (for example) copy/pasting text into Phabricator doesn't mangle it into a big blob of nonsense just because you happened to have some magic words in there.

Jul 29 2021, 3:57 PM
cspeckmim added a comment to D21713: Add an "eval" rule to Remarkup.

I think _() is the pht() of Gnu "gettext". Modern programers may mostly be more familiar with Python than with gettext, of course.

Oh yea that's right. A long time ago I worked on a python web application that used this was probably confusing it.

Jul 29 2021, 1:03 AM
cspeckmim planned changes to D21712: Trying out removing "Phabricator" from some user-visible text.

I'll plan to get this on a test instance and get some screenshots

Jul 29 2021, 1:01 AM
cspeckmim added inline comments to D21713: Add an "eval" rule to Remarkup.
Jul 29 2021, 12:57 AM
cspeckmim updated the diff for D21712: Trying out removing "Phabricator" from some user-visible text.

Try escaping the ${{{

Jul 29 2021, 12:54 AM
epriestley added a comment to D21713: Add an "eval" rule to Remarkup.

I suspect escaping things in PHP will be pretty rare and that the "collides with PHP strings" downside will be very small.

Jul 29 2021, 12:24 AM

Jul 28 2021

cspeckmim added a comment to D21713: Add an "eval" rule to Remarkup.

You can either escape ${{{strings.x.y}}} as \${{{strings.x.y}}} or suggest a different syntax for the "eval" rule --- I'm not married to ${{{...}}}.

I think this format makes sense to me. Nothing else really comes to mind. The squiggles are keeping consistency with other remarkup rules like figlet and cowsay. I think I've seen $ used in other places (and languages) with some relation to string substitution. I think python convention uses _, so another possibility could be _{{{...}}}.

Jul 28 2021, 10:18 PM
epriestley added a comment to D21712: Trying out removing "Phabricator" from some user-visible text.

Ah, yeah, the build issue is that ${...} in a PHP double-quoted string is semantic, so PHP is trying to do something with ${{{...}}} and failing with a syntax exception during parsing. You can either escape ${{{strings.x.y}}} as \${{{strings.x.y}}} or suggest a different syntax for the "eval" rule --- I'm not married to ${{{...}}}.

Jul 28 2021, 5:13 AM
epriestley added a comment to D21712: Trying out removing "Phabricator" from some user-visible text.

That build failure may be related to recent changes to T13072, or something else server-side -- I don't expect build failures to look like that in Harbormaster. Let me see if I can reproduce it locally.

Jul 28 2021, 5:09 AM
cspeckmim added a comment to D21680: An assortment of fixes and updates to using arc-land with mercurial.

I’ve used this a few times in the past week and the behavior is overall better for my own case. I had one other developer upgrade to master branch and also reported better behavior, though his setup is very similar to my own.

Jul 28 2021, 4:22 AM
cspeckmim added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

Adding some feedback regarding these changes (I should’ve made a task for this first). Last week I had two developers separately approach me with issues they ran into with arc diff. I had them upgrade to the master branch and this resolved their issues.

Jul 28 2021, 4:20 AM
cspeckmim added inline comments to D21712: Trying out removing "Phabricator" from some user-visible text.
Jul 28 2021, 4:07 AM
cspeckmim planned changes to D21712: Trying out removing "Phabricator" from some user-visible text.

I'll investigate the build failures -- I suspect it's the use of the new remarkup rule. At the moment I'm working from a Windows system and haven't been able to get xhpast or unit tests running properly.

Jul 28 2021, 4:01 AM
Harbormaster failed remote builds in B25527: Diff 51727 for D21712: Trying out removing "Phabricator" from some user-visible text!
Jul 28 2021, 3:59 AM
cspeckmim updated the diff for D21712: Trying out removing "Phabricator" from some user-visible text.

Minor corrections

Jul 28 2021, 3:59 AM
Harbormaster failed remote builds in B25526: Diff 51726 for D21712: Trying out removing "Phabricator" from some user-visible text!
Jul 28 2021, 3:55 AM
cspeckmim updated the diff for D21712: Trying out removing "Phabricator" from some user-visible text.

Preferring "installation" as a generic term, where possible

Jul 28 2021, 3:54 AM
cspeckmim accepted D21713: Add an "eval" rule to Remarkup.
Jul 28 2021, 3:11 AM
cspeckmim added a comment to D21713: Add an "eval" rule to Remarkup.

This looks pretty cool and will be useful for maintaining existing text that goes through remarkup. Really useful doc on PhutilRemarkupBlockStorage btw.

Jul 28 2021, 3:10 AM

Jul 27 2021

epriestley requested review of D21713: Add an "eval" rule to Remarkup.
Jul 27 2021, 9:08 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21713: Add an "eval" rule to Remarkup.
Jul 27 2021, 9:07 PM
epriestley committed rPcc8cbed02941: Make "DifferentialDiff->properties" a proper "attachable" property (authored by epriestley).
Make "DifferentialDiff->properties" a proper "attachable" property
Jul 27 2021, 8:39 PM
epriestley closed D21710: Make "DifferentialDiff->properties" a proper "attachable" property.
Jul 27 2021, 8:39 PM
epriestley requested changes to D21712: Trying out removing "Phabricator" from some user-visible text.

These generally look reasonable to me, some thoughts inline. In some of these cases I think we can probably just remove extra references to "this install", "this install of Phabricator on this server", etc., and let it be implied by context.

Jul 27 2021, 8:36 PM
cspeckmim published D21712: Trying out removing "Phabricator" from some user-visible text for review.

This is just trying out some changes that modify the language to reduce instances of "Phabricator" from user-visible text. I went through the auth provider implementations to try out using "platform", "server", "service", and in one case I think just "instance".

Jul 27 2021, 12:51 AM
cspeckmim added a revision to T13658: How to rebrand Phabricator: D21712: Trying out removing "Phabricator" from some user-visible text.
Jul 27 2021, 12:44 AM

Jul 26 2021

epriestley committed rARC82016c00e132: Name extension as "arc-hg", not "arg-hg" (authored by epriestley).
Name extension as "arc-hg", not "arg-hg"
Jul 26 2021, 7:27 PM
epriestley closed D21711: Name extension as "arc-hg", not "arg-hg".
Jul 26 2021, 7:27 PM
epriestley updated the summary of D21708: Fix Phriction document previews for the root document ("/") with Apache option "MergeSlashes On".
Jul 26 2021, 7:27 PM
cspeckmim accepted D21711: Name extension as "arc-hg", not "arg-hg".

argh

Jul 26 2021, 6:52 PM
epriestley closed T13659: `arc land` may fail with missing rebase extension as Resolved.

I caught one cosmetic issue in D21711, but this works properly for me locally now. Thanks!

Jul 26 2021, 6:49 PM · Arcanist, Mercurial
epriestley requested review of D21711: Name extension as "arc-hg", not "arg-hg".
Jul 26 2021, 6:49 PM
epriestley added a revision to T13659: `arc land` may fail with missing rebase extension: D21711: Name extension as "arc-hg", not "arg-hg".
Jul 26 2021, 6:49 PM · Arcanist, Mercurial
epriestley requested review of D21710: Make "DifferentialDiff->properties" a proper "attachable" property.
Jul 26 2021, 6:45 PM
epriestley requested review of D21709: Pass a real context object to Phriction previews, fixing mentions.
Jul 26 2021, 6:33 PM
epriestley added a revision to T13662: Mentions break Phriction preview: D21709: Pass a real context object to Phriction previews, fixing mentions.
Jul 26 2021, 6:32 PM · Phriction
epriestley requested review of D21708: Fix Phriction document previews for the root document ("/") with Apache option "MergeSlashes On".
Jul 26 2021, 6:18 PM
epriestley added a revision to T13662: Mentions break Phriction preview: D21708: Fix Phriction document previews for the root document ("/") with Apache option "MergeSlashes On".
Jul 26 2021, 6:17 PM · Phriction
epriestley added a comment to T13662: Mentions break Phriction preview.

I ran into this while trying to reproduce the issue:

Jul 26 2021, 6:13 PM · Phriction
epriestley claimed T13662: Mentions break Phriction preview.
Jul 26 2021, 5:56 PM · Phriction

Jul 22 2021

0 updated subscribers of T13662: Mentions break Phriction preview.
Jul 22 2021, 4:23 AM · Phriction
0 created T13662: Mentions break Phriction preview.
Jul 22 2021, 4:20 AM · Phriction

Jul 21 2021

epriestley added a comment to T13648: Transaction publishing may stall during mail expansion of package recipients.

The stalled transactions on this host published after I deployed the update.

Jul 21 2021, 11:39 PM · Transactions
epriestley removed a reviewer for D21498: Fix error handler on PHP 8: Unknown Object (Owners Package).
Jul 21 2021, 11:36 PM
epriestley removed a reviewer for D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__: Unknown Object (Owners Package).
Jul 21 2021, 11:34 PM
epriestley committed rP387d3b4983d7: Resolve deleted packages properly as having no mailable members (authored by epriestley).
Resolve deleted packages properly as having no mailable members
Jul 21 2021, 9:50 PM
epriestley closed D21707: Resolve deleted packages properly as having no mailable members.
Jul 21 2021, 9:50 PM
epriestley closed T13648: Transaction publishing may stall during mail expansion of package recipients as Resolved by committing rP387d3b4983d7: Resolve deleted packages properly as having no mailable members.
Jul 21 2021, 9:50 PM · Transactions