Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F18255194: D21714.id.diff
Thu, Aug 21, 11:18 PM
F18106595: D21714.diff
Sun, Aug 10, 11:09 PM
F18081170: D21714.id51734.diff
Mon, Aug 4, 10:50 PM
F18078494: D21714.diff
Mon, Aug 4, 8:10 PM
F17862816: D21714.diff
Jul 28 2025, 12:21 AM
Unknown Object (File)
Jul 5 2025, 11:21 AM
Unknown Object (File)
Jun 28 2025, 10:44 AM
Unknown Object (File)
Jun 18 2025, 11:01 AM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable