Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 5, 11:21 AM
Unknown Object (File)
Sat, Jun 28, 10:44 AM
Unknown Object (File)
Wed, Jun 18, 11:01 AM
Unknown Object (File)
Wed, Jun 18, 4:52 AM
Unknown Object (File)
Jun 6 2025, 12:01 PM
Unknown Object (File)
May 28 2025, 7:28 PM
Unknown Object (File)
May 28 2025, 12:04 PM
Unknown Object (File)
May 9 2025, 8:28 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable