Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 4:00 AM
Unknown Object (File)
Mon, Nov 11, 12:47 AM
Unknown Object (File)
Wed, Nov 6, 1:34 AM
Unknown Object (File)
Mon, Nov 4, 1:58 PM
Unknown Object (File)
Mon, Nov 4, 5:26 AM
Unknown Object (File)
Fri, Nov 1, 11:17 AM
Unknown Object (File)
Fri, Nov 1, 11:17 AM
Unknown Object (File)
Fri, Nov 1, 10:58 AM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable