Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 30, 3:22 AM
Unknown Object (File)
Mon, Jun 22, 3:49 PM
Unknown Object (File)
Mon, Jun 22, 11:25 AM
Unknown Object (File)
Mon, Jun 22, 4:04 AM
Unknown Object (File)
Sat, Jun 20, 1:12 AM
Unknown Object (File)
Sat, Jun 13, 1:25 AM
Unknown Object (File)
Thu, Jun 4, 4:30 AM
Unknown Object (File)
Apr 6 2026, 2:37 AM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable