Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 12:17 AM
Unknown Object (File)
Thu, Jan 9, 7:43 AM
Unknown Object (File)
Tue, Dec 24, 11:52 PM
Unknown Object (File)
Tue, Dec 24, 3:08 AM
Unknown Object (File)
Wed, Dec 18, 8:14 AM
Unknown Object (File)
Dec 14 2024, 2:55 PM
Unknown Object (File)
Dec 14 2024, 2:18 AM
Unknown Object (File)
Dec 7 2024, 8:20 AM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable