Paths

Table of Contentst

Differential D21714

Fix subtype extension support check
ClosedPublic
Actions

Authored by 0 on Aug 20 2021, 6:12 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13663: TypeError when editing calendar import

Commits

rP1965b78b34f1: Fix subtype extension support check

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan

Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
Changed task subtypes using Change Subtype action and batch editor.
Changed task and project subtypes using Conduit.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

0 created this revision.Aug 20 2021, 6:12 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 20 2021, 6:12 AM

Harbormaster completed remote builds in B25533: Diff 51733.Aug 20 2021, 6:13 AM

0 published this revision for review.Aug 20 2021, 6:15 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 20 2021, 6:15 AM

Thanks!

This revision is now accepted and ready to land.Aug 20 2021, 1:52 PM

Closed by commit rP1965b78b34f1: Fix subtype extension support check (authored by 0). · Explain WhyAug 20 2021, 10:49 PM

This revision was automatically updated to reflect the committed changes.

0 added a commit: rP1965b78b34f1: Fix subtype extension support check.

Thank you for figuring out the appropriate change!

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

engineextension/

PhabricatorSubtypeEditEngineExtension.php

2 lines

Diff 51734

src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php

Loading...