Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F15187775: D21714.diff
Fri, Feb 21, 11:29 AM
Unknown Object (File)
Wed, Feb 19, 3:17 PM
Unknown Object (File)
Wed, Feb 19, 3:17 PM
Unknown Object (File)
Wed, Feb 19, 3:17 PM
Unknown Object (File)
Sun, Feb 16, 10:43 PM
Unknown Object (File)
Fri, Feb 14, 5:03 AM
Unknown Object (File)
Sun, Feb 9, 2:12 PM
Unknown Object (File)
Wed, Feb 5, 3:25 AM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable