Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F19921167: D21714.id51734.diff
Mon, Apr 6, 2:37 AM
F19911076: D21714.diff
Thu, Apr 2, 10:46 AM
F19889719: D21714.diff
Tue, Mar 24, 8:18 PM
F19889717: D21714.diff
Tue, Mar 24, 8:18 PM
F19889437: D21714.diff
Tue, Mar 24, 1:47 PM
F19881526: D21714.id.diff
Wed, Mar 18, 10:52 PM
F19811568: D21714.diff
Mar 4 2026, 1:40 AM
F19763314: D21714.diff
Feb 18 2026, 7:51 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable