Page MenuHomePhabricator
Feed Advanced Search

Jun 5 2015

epriestley added a comment to T8434: Accommodate the "Security" workflow.

How would you like the flow where you give permission to new users to work? In T4411, @chasemp expressed some concerns about using CC/Subscribers for this (particularly, that users can add other users to CC). Do you share those concerns, or is adding users to CC to give them rights satisfactory for you?

Jun 5 2015, 1:37 PM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 1:19 PM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

unless the Nuance entry was basically just a special task, where we could have to option to continue as normal while including the reporter

Jun 5 2015, 12:49 PM · Wikimedia, Policy, Prioritized
epriestley updated subscribers of T8376: Develop Spaces (v1).

Development Log

Jun 5 2015, 12:02 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8434: Accommodate the "Security" workflow.

Yeah, the "Security" use case is letting users see objects in a Space they normally don't have access to because they have some special relationship to those objects (for example, giving users access to security tasks if they reported them).

Jun 5 2015, 11:38 AM · Wikimedia, Policy, Prioritized
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jun 5 2015, 11:03 AM · libphutil, Arcanist
joshuaspence updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jun 5 2015, 10:42 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
joshuaspence merged task T8435: How to get all commits attached to a task via conduit into T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jun 5 2015, 10:42 AM · Conduit
joshuaspence added a revision to T8433: Destroying a Diviner book is very slow: Unknown Object (Differential Revision).
Jun 5 2015, 7:51 AM · Diviner
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 3:49 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 3:06 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 2:56 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 2:19 AM · Wikimedia, Policy, Prioritized
epriestley created T8434: Accommodate the "Security" workflow.
Jun 5 2015, 2:18 AM · Wikimedia, Policy, Prioritized
epriestley deleted Nerdjumbo.
Jun 5 2015, 1:57 AM
epriestley deleted M2Q.
Jun 5 2015, 1:57 AM
epriestley moved T8424: Integrate Spaces into the core policy infrastructure from Backlog to Unprototype (v1) on the Spaces board.
Jun 5 2015, 1:48 AM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T7114: $_SERVER stuff from the preamble is getting overwritten in PhabricatorStartup as Resolved by committing Restricted Diffusion Commit.
Jun 5 2015, 12:27 AM · Setup
epriestley closed T8326: Scripts may try to access PhabricatorStartup, but can not as Resolved by committing Restricted Diffusion Commit.
Jun 5 2015, 12:26 AM · Infrastructure
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 5 2015, 12:21 AM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8433: Destroying a Diviner book is very slow.

Looks like the feed_storynotification queries are the slowest ones; there's no objectPHID key on that table.

Jun 5 2015, 12:17 AM · Diviner
joshuaspence created T8433: Destroying a Diviner book is very slow.
Jun 5 2015, 12:05 AM · Diviner

Jun 4 2015

joshuaspence closed T7458: Diviner should integrate with main search, a subtask of T4558: Make Diviner useful for third-parties, as Resolved.
Jun 4 2015, 10:07 PM · Diviner
joshuaspence closed T7458: Diviner should integrate with main search as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 10:07 PM · Diviner
joshuaspence created T8430: Support emoticons.
Jun 4 2015, 9:45 PM · Restricted Project, Remarkup
joshuaspence added a comment to T4245: Make repository URIs slightly prettier.

Can we get a fund initiative for making Fund work like Kickstarter? :P

Jun 4 2015, 9:43 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T4245: Make repository URIs slightly prettier.

Note that it takes your money immediately -- not when a specific goal is reached (so it's not like Kickstarter) -- but I'll, uh, do this proportionately sooner relative to how much funding I3 gets I guess, unless someone wants to separately prioritize making Fund work like Kickstarter.

Jun 4 2015, 9:38 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
joshuaspence closed T8401: Unable to query Diviner atoms by PHID as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 9:23 PM · Diviner
joshuaspence added a revision to T8401: Unable to query Diviner atoms by PHID: Unknown Object (Differential Revision).
Jun 4 2015, 9:04 PM · Diviner
epriestley added a comment to T8401: Unable to query Diviner atoms by PHID.

Yeah, that seems reasonable to me.

Jun 4 2015, 8:54 PM · Diviner
joshuaspence added a comment to T8401: Unable to query Diviner atoms by PHID.

@epriestley, could we simply invert the logic of DivinerAtomQuery so that it returns undocumentable atoms by default (and add withExcludeUndocumentable(true) to all existing callsites?

Jun 4 2015, 8:53 PM · Diviner
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 8:45 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8428: Allow packages to be disabled.
Jun 4 2015, 8:32 PM · Owners
epriestley added a comment to T8427: Make owners typeahead browsable so installs can have more than 100 packages.

Unclear if this is really a 100-package limit, but some kind of limiting is probably happening.

Jun 4 2015, 8:31 PM · Owners
epriestley created T8427: Make owners typeahead browsable so installs can have more than 100 packages.
Jun 4 2015, 8:30 PM · Owners
epriestley renamed T8424: Integrate Spaces into the core policy infrastructure from '"><img src=x onerror=alert(1);> to Integrate Spaces into the core policy infrastructure.
Jun 4 2015, 7:55 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 7:49 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 7:36 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 7:19 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7114: $_SERVER stuff from the preamble is getting overwritten in PhabricatorStartup: Unknown Object (Differential Revision).
Jun 4 2015, 6:59 PM · Setup
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 6:59 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8331: phlog can be improved as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 6:49 PM · Infrastructure
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 6:49 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8326: Scripts may try to access PhabricatorStartup, but can not: Unknown Object (Differential Revision).
Jun 4 2015, 6:49 PM · Infrastructure
epriestley created T8424: Integrate Spaces into the core policy infrastructure.
Jun 4 2015, 6:44 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

They're a function of an individual commit instead of being a function of the repository as a whole, so we'd have to do a lot more work to support them (it's not meaningful to, say, "list all tags in the repository", as it is with Git), and I suspect they're not used much in the wild because of how they work. I'm not sure if this is true or not.

Jun 4 2015, 5:29 PM · Mercurial, Diffusion
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 4 2015, 5:03 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8415: Transaction requires a handle that it did not load as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 1:05 PM · Transactions
epriestley claimed T8331: phlog can be improved.

Hitting this again.

Jun 4 2015, 12:46 PM · Infrastructure
epriestley added a comment to T8415: Transaction requires a handle that it did not load.

T8415

Jun 4 2015, 12:42 PM · Transactions
epriestley added a comment to T8415: Transaction requires a handle that it did not load.

I think you need to add a mention.

Jun 4 2015, 12:42 PM · Transactions
epriestley added a comment to T8415: Transaction requires a handle that it did not load.

Thanks, looking at this now.

Jun 4 2015, 12:42 PM · Transactions
epriestley updated subscribers of T8362: Set date time account preferences.
Jun 4 2015, 12:30 PM · User Preferences, Calendar
epriestley merged task T8414: Dates are rendered incorrectly for Australia/Melbourne timezone into T8362: Set date time account preferences.
Jun 4 2015, 12:30 PM
joshuaspence created T8415: Transaction requires a handle that it did not load.
Jun 4 2015, 7:33 AM · Transactions
joshuaspence added a comment to T8401: Unable to query Diviner atoms by PHID.

https://secure.phabricator.com/differential/diff/31781/ seems to fix this, although I doubt this is the correct solution.

Jun 4 2015, 7:31 AM · Diviner
joshuaspence added a comment to T8401: Unable to query Diviner atoms by PHID.

Adding PhutilArgumentParser and --trace gives me the following output:

Jun 4 2015, 7:21 AM · Diviner
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users as Resolved.

See T8398 for any followup issues.

Jun 4 2015, 2:43 AM · FreeBSD, Mailing Lists, Mail
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users, a subtask of T6367: Send email with recipient's language and access levels, not sender's, as Resolved.
Jun 4 2015, 2:43 AM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T8398: Upgrading: Changes to Mailing Lists.

This migrated cleanly on this install, although we only had one real mailing list plus a handful of old invalid test lists (although these errored out correctly). If you run into problems with the migration or otherwise, let me know.

Jun 4 2015, 2:41 AM · Installing & Upgrading, People, Mail, Guides
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

These changes were fairly sweeping, so please let me know if you see anything suspicious with mail/feed/notifications.

Jun 4 2015, 2:40 AM · Wikimedia, Security, Localization, Mail
epriestley closed T6367: Send email with recipient's language and access levels, not sender's as Resolved.

This seems to be working correctly in HEAD. In particular:

Jun 4 2015, 2:31 AM · Wikimedia, Security, Localization, Mail
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T7047: Add user preference for diffs in emails, as Resolved.
Jun 4 2015, 2:31 AM · Restricted Project, Differential, Mail, Diffusion
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T8377: Build the core "Spaces" Application, as Resolved.
Jun 4 2015, 2:31 AM · Spaces, Wikimedia, Policy
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T5791: Write Herald rules for outbound mail, as Resolved.
Jun 4 2015, 2:31 AM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley closed T8408: Test Bug as Resolved.

Can't find any problems.

Jun 4 2015, 2:24 AM · Unknown Object (Project)
epriestley added a project to T8408: Test Bug: Unknown Object (Project).
Jun 4 2015, 2:08 AM · Unknown Object (Project)
epriestley added a comment to T8408: Test Bug.

NOW I AM TESTING

Jun 4 2015, 2:07 AM · Unknown Object (Project)
epriestley added a comment to T8408: Test Bug.

I like testing.

Jun 4 2015, 2:05 AM · Unknown Object (Project)
epriestley created T8408: Test Bug.
Jun 4 2015, 2:05 AM · Unknown Object (Project)
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 1:43 AM · FreeBSD, Mailing Lists, Mail
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users, a subtask of T6367: Send email with recipient's language and access levels, not sender's, as Resolved.
Jun 4 2015, 1:43 AM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T8392: Enable Captcha on LDAP.
In T8392#118222, @chad wrote:

Why don't we fix the Recaptcha module to work on LDAP?

Jun 4 2015, 1:40 AM

Jun 3 2015

epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

You can also use "Return to Subscription" from an invoice/order directly, although it's in a sort of unusual place (upper right corner) that we don't use very often in other applications. My intent was to make it more visible, but maybe it's actually less visible.

Jun 3 2015, 11:59 PM · Phacility, Phortune
epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

You can get here via Billing > Subscriptions > Instance.

Jun 3 2015, 11:57 PM · Phacility, Phortune
epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

Some screenshots if that wasn't clear:

Jun 3 2015, 11:49 PM · Phacility, Phortune
epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

If you don't have automatic payment set up, choose a different payment method the next time you manually pay the invoice.

Jun 3 2015, 11:46 PM · Phacility, Phortune
joshuaspence added a project to T8404: Running the cpplint linter through arcanist no longer works: Lint.
Jun 3 2015, 11:29 PM · Lint, Arcanist
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 3 2015, 9:24 PM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

As far as I can tell, we're missing these:

Jun 3 2015, 9:23 PM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

One thing I caught is that things which use Transactions now need to implement ApplicationTransactionInterface. At least one object (PhameBlog) does not. I'll check the rest of the codebase and see if there are any more.

Jun 3 2015, 9:13 PM · Wikimedia, Security, Localization, Mail
joshuaspence created T8401: Unable to query Diviner atoms by PHID.
Jun 3 2015, 9:08 PM · Diviner
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 3 2015, 9:03 PM · Wikimedia, Security, Localization, Mail
epriestley removed a reviewer for D13093: a new commit and test phabricator: Blessed Reviewers.
Jun 3 2015, 7:46 PM
epriestley updated the task description for T8398: Upgrading: Changes to Mailing Lists.
Jun 3 2015, 7:04 PM · Installing & Upgrading, People, Mail, Guides
epriestley updated subscribers of T8398: Upgrading: Changes to Mailing Lists.

@carlsverre, this probably impacts you, too.

Jun 3 2015, 6:51 PM · Installing & Upgrading, People, Mail, Guides
epriestley added a comment to T8394: Calendar list view should smartly limit the number of total displayed events to 1000..

Here's a rough sketchy of my thinking:

Jun 3 2015, 4:54 PM · Calendar
epriestley added a comment to T8336: Make a workflow that integrates nicely with list based email/patch reviews.

I don't plan to give mailing lists their own Email Preferences panel

Jun 3 2015, 3:13 PM · llvm, FreeBSD, Herald
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 3 2015, 3:11 PM · FreeBSD, Mailing Lists, Mail
epriestley added a comment to T8387: Convert Mailing Lists into special users, similar to bot users.

(Note that this stuff isn't in HEAD yet, but will likely land today.)

Jun 3 2015, 3:08 PM · FreeBSD, Mailing Lists, Mail
epriestley added a comment to T8387: Convert Mailing Lists into special users, similar to bot users.

T8398 has guidance on what to expect when you upgrade.

Jun 3 2015, 3:08 PM · FreeBSD, Mailing Lists, Mail
epriestley created T8398: Upgrading: Changes to Mailing Lists.
Jun 3 2015, 3:07 PM · Installing & Upgrading, People, Mail, Guides
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 3 2015, 2:28 PM · FreeBSD, Mailing Lists, Mail
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 3 2015, 2:24 PM · FreeBSD, Mailing Lists, Mail
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 3 2015, 2:16 PM · Wikimedia, Security, Localization, Mail
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 3 2015, 2:16 PM · FreeBSD, Mailing Lists, Mail
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 3 2015, 2:04 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a project to T8376: Develop Spaces (v1): Prioritized.

Since this is a relatively large task that's likely to end up with a hundred thousand subtasks, I'll try to summarize progress here periodically.

Jun 3 2015, 2:02 PM · Prioritized, Policy, Wikimedia, Spaces
joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 3 2015, 1:19 PM · Diviner
joshuaspence added a project to T8396: projects autofill text box: Typeahead.
Jun 3 2015, 1:16 PM · Typeahead