Page MenuHomePhabricator
Feed Advanced Search

Jun 3 2015

joshuaspence added a project to T8397: application context is ignored: Maniphest.
Jun 3 2015, 1:16 PM · Maniphest
epriestley updated subscribers of T8387: Convert Mailing Lists into special users, similar to bot users.

@klimek, heads up about these changes since I know you're a big mailing list user, too. I'll publish guidance for installs soon (likely in the "Upgrading" section of the weekly Changelog).

Jun 3 2015, 12:55 PM · FreeBSD, Mailing Lists, Mail
anda awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jun 3 2015, 8:38 AM · Workboards (v3), Restricted Project
epriestley closed T8393: Disabled users should not be Available as Wontfix.

"Available" means "not in a meeting", which he isn't.

Jun 3 2015, 1:25 AM · People
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 3 2015, 12:02 AM · Wikimedia, Security, Localization, Mail
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

Looks like --background is six times faster though: https://secure.phabricator.com/xhprof/profile/PHID-FILE-zy56ub2hhqqmrsgelvdl/

Jun 3 2015, 12:00 AM · Search

Jun 2 2015

epriestley added a comment to T8387: Convert Mailing Lists into special users, similar to bot users.

I'm going to evaluate giving administrators access to the "Language" and "Email Preferences" panels if they aren't too much of a mess to implement the user/viewer split on, but I think that's all that remains here.

Jun 2 2015, 10:34 PM · FreeBSD, Mailing Lists, Mail
epriestley updated subscribers of T2943: Users can't delete or disable themselves.
Jun 2 2015, 10:29 PM · People, User Preferences
epriestley added a revision to T8377: Build the core "Spaces" Application: Unknown Object (Differential Revision).
Jun 2 2015, 10:28 PM · Spaces, Wikimedia, Policy
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 2 2015, 10:26 PM · FreeBSD, Mailing Lists, Mail
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 2 2015, 10:19 PM · FreeBSD, Mailing Lists, Mail
joshuaspence added a revision to T8042: PhutilUnitTestEngine can't execute a single test path: Unknown Object (Differential Revision).
Jun 2 2015, 9:16 PM · Arcanist
epriestley updated subscribers of T6367: Send email with recipient's language and access levels, not sender's.
Jun 2 2015, 8:57 PM · Wikimedia, Security, Localization, Mail
epriestley merged task T8390: one-mail-per-recipient not honored for some reason into T6367: Send email with recipient's language and access levels, not sender's.
Jun 2 2015, 8:57 PM · Mail
epriestley added a comment to T8390: one-mail-per-recipient not honored for some reason.

Is that not what this option should allow me to configure?

Jun 2 2015, 8:57 PM · Mail
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

Here's a profile: https://secure.phabricator.com/xhprof/profile/PHID-FILE-6qploks2cyzbwune3vki/

Jun 2 2015, 8:57 PM · Search
epriestley added a comment to T8390: one-mail-per-recipient not honored for some reason.

When the option is set we'll just bypass policies when generating mail. I'll slap a giant warning on the setting and lock it down, but I think there isn't really an alternative (other than removing it, but installs might reasonably want to choose better mailing list support over policy correctness, and the policy violation is usually not large).

Jun 2 2015, 8:47 PM · Mail
• jazzdan awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Like token.
Jun 2 2015, 7:54 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 2 2015, 6:59 PM · FreeBSD, Mailing Lists, Mail
epriestley added a comment to T8387: Convert Mailing Lists into special users, similar to bot users.

(It's supposed to say "Restricted Revision" instead; there's a bug for that somewhere.)

Jun 2 2015, 6:57 PM · FreeBSD, Mailing Lists, Mail
epriestley added a comment to T8387: Convert Mailing Lists into special users, similar to bot users.

It's in closed-source (Phacility) code, and makes the "import into phacility.com" tools aware that they shouldn't try to import mailing lists.

Jun 2 2015, 6:57 PM · FreeBSD, Mailing Lists, Mail
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 2 2015, 6:39 PM · FreeBSD, Mailing Lists, Mail
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 2 2015, 6:28 PM · FreeBSD, Mailing Lists, Mail
epriestley added a comment to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.

(If "finance department" is approximately "a single human with an existing account", you can just add them to the payment account to achieve the same effect -- but they'll have total control over the instance.)

Jun 2 2015, 5:45 PM · Phortune, Phacility
epriestley added a comment to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.

How do you currently handle this with other services? I don't recall seeing a way to CC an arbitrary address in other SAAS products, but maybe I just haven't looked carefully enough.

Jun 2 2015, 5:43 PM · Phortune, Phacility
epriestley requested changes to D10480: Filter by active users.

I rolled this into D13122.

Jun 2 2015, 5:28 PM · People
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 2 2015, 5:27 PM · FreeBSD, Mailing Lists, Mail
epriestley added a revision to T8387: Convert Mailing Lists into special users, similar to bot users: Unknown Object (Differential Revision).
Jun 2 2015, 3:37 PM · FreeBSD, Mailing Lists, Mail
epriestley updated subscribers of T8387: Convert Mailing Lists into special users, similar to bot users.
Jun 2 2015, 3:03 PM · FreeBSD, Mailing Lists, Mail
epriestley updated subscribers of T8387: Convert Mailing Lists into special users, similar to bot users.
Jun 2 2015, 3:00 PM · FreeBSD, Mailing Lists, Mail
epriestley closed T4361: Allow objects (projects, repositories) to act as mailing lists as Wontfix.

This basically works (projects now act as lists, approximately) but we haven't seen other use cases for it.

Jun 2 2015, 2:59 PM · Mail
epriestley updated subscribers of T8387: Convert Mailing Lists into special users, similar to bot users.
Jun 2 2015, 2:58 PM · FreeBSD, Mailing Lists, Mail
epriestley merged task T4877: "Mailing lists" are not documented into T8387: Convert Mailing Lists into special users, similar to bot users.
Jun 2 2015, 2:58 PM · Documentation
epriestley added a comment to T4877: "Mailing lists" are not documented.

I currently plan to convert mailing lists into users so we can policy check mail which is sent to them. That change will largely obsolete this. I'll update the "User Roles" document to explain the new behavior.

Jun 2 2015, 2:58 PM · Documentation
epriestley created T8387: Convert Mailing Lists into special users, similar to bot users.
Jun 2 2015, 2:53 PM · FreeBSD, Mailing Lists, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

I suppose using a logged-out viewer might be fine, since we'll use the omnipotent viewer if metamta.one-mail-per-recipient is not set, and essentially all installs that use mailing lists probably have this setting configured off.

Jun 2 2015, 2:42 PM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

This change is potentially going to make mailing lists useless for nonpublic installs. Our immediate options are:

Jun 2 2015, 2:39 PM · Wikimedia, Security, Localization, Mail
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 2 2015, 2:11 PM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

Not actually meaningfully stateful:

Jun 2 2015, 12:54 PM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

These Editors are the only ones with state properties:

Jun 2 2015, 12:19 PM · Wikimedia, Security, Localization, Mail
joshuaspence closed T8379: ArcanistFormattedStringXHPASTLinterRule fails as Resolved by committing Restricted Diffusion Commit.
Jun 2 2015, 12:13 PM · Lint, XHPAST
joshuaspence added a revision to T8379: ArcanistFormattedStringXHPASTLinterRule fails: Unknown Object (Differential Revision).
Jun 2 2015, 12:06 PM · Lint, XHPAST
joshuaspence added a comment to T8165: Investigate high CPU usage.

cache.png (469×1 px, 54 KB)

Jun 2 2015, 12:02 PM · Performance
epriestley closed T8385: AA as Invalid.
Jun 2 2015, 11:59 AM
epriestley updated subscribers of T5391: Support custom fields in 'Export to Excel'.
Jun 2 2015, 11:58 AM · Data Exporters
epriestley merged task T8373: Reporting all custom fields in the report into T5391: Support custom fields in 'Export to Excel'.
Jun 2 2015, 11:58 AM · Maniphest
epriestley added a comment to T8165: Investigate high CPU usage.

Is /config/cache/ showing significant cache fullness?

Jun 2 2015, 11:57 AM · Performance
joshuaspence added a comment to T8379: ArcanistFormattedStringXHPASTLinterRule fails.

The same thing applies to ArcanistDuplicateKeysInArrayXHPASTLinterRule.

Jun 2 2015, 8:50 AM · Lint, XHPAST
joshuaspence closed T8383: User reporting empty comment-action dropdown as Invalid.

Nevermind, this was some weird local issue.

Jun 2 2015, 7:59 AM · Differential
joshuaspence added a comment to T8383: User reporting empty comment-action dropdown.

OK. Apparently it also happens on this install as well.

Jun 2 2015, 6:55 AM · Differential
joshuaspence added a comment to T8383: User reporting empty comment-action dropdown.

This happens in Maniphest as well.

Jun 2 2015, 6:53 AM · Differential
joshuaspence added a comment to T8383: User reporting empty comment-action dropdown.

The user's user agent string is Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.81 Safari/537.36

Jun 2 2015, 6:52 AM · Differential
joshuaspence created T8383: User reporting empty comment-action dropdown.
Jun 2 2015, 6:51 AM · Differential
joshuaspence added a comment to T8165: Investigate high CPU usage.

I turned on XHPROF sampling and grabbed some data:

Jun 2 2015, 6:23 AM · Performance
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

Sorta... My issue isn't that indexing ElasticSearch is slow, rather my issue is that queueing tasks into the daemons seems to be slow (this shouldn't be touching ElasticSearch, also I believe this issue existed when we were using MySQL indexes as well).

Jun 2 2015, 2:54 AM · Search
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 2 2015, 12:57 AM · Wikimedia, Security, Localization, Mail
epriestley claimed T6367: Send email with recipient's language and access levels, not sender's.
Jun 2 2015, 12:43 AM · Wikimedia, Security, Localization, Mail
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

It might be worth noting that I am running the ./bin/search index command on the same machine that is running our daemons.

Jun 2 2015, 12:38 AM · Search
joshuaspence created T8380: Queueing search indexers is very slow.
Jun 2 2015, 12:38 AM · Search

Jun 1 2015

epriestley added a subtask for T8377: Build the core "Spaces" Application: T6367: Send email with recipient's language and access levels, not sender's.
Jun 1 2015, 11:04 PM · Spaces, Wikimedia, Policy
epriestley added a parent task for T6367: Send email with recipient's language and access levels, not sender's: T8377: Build the core "Spaces" Application.
Jun 1 2015, 11:04 PM · Wikimedia, Security, Localization, Mail
epriestley added a revision to T7703: Policy checks may execute incompletely for non-viewers: Unknown Object (Differential Revision).
Jun 1 2015, 9:44 PM · Policy, Herald, Flags
joshuaspence claimed T8379: ArcanistFormattedStringXHPASTLinterRule fails.
Jun 1 2015, 9:43 PM · Lint, XHPAST
joshuaspence created T8379: ArcanistFormattedStringXHPASTLinterRule fails.
Jun 1 2015, 9:42 PM · Lint, XHPAST
epriestley added a parent task for T7703: Policy checks may execute incompletely for non-viewers: T8377: Build the core "Spaces" Application.
Jun 1 2015, 9:37 PM · Policy, Herald, Flags
epriestley added a subtask for T8377: Build the core "Spaces" Application: T7703: Policy checks may execute incompletely for non-viewers.
Jun 1 2015, 9:37 PM · Spaces, Wikimedia, Policy
nateguchi2 awarded T8377: Build the core "Spaces" Application a Like token.
Jun 1 2015, 9:24 PM · Spaces, Wikimedia, Policy
epriestley added a revision to T8377: Build the core "Spaces" Application: Unknown Object (Differential Revision).
Jun 1 2015, 7:02 PM · Spaces, Wikimedia, Policy
epriestley added a revision to T8377: Build the core "Spaces" Application: Unknown Object (Differential Revision).
Jun 1 2015, 6:54 PM · Spaces, Wikimedia, Policy
epriestley moved T8377: Build the core "Spaces" Application from Backlog to Unprototype (v1) on the Spaces board.
Jun 1 2015, 6:08 PM · Spaces, Wikimedia, Policy
epriestley moved T8376: Develop Spaces (v1) from Backlog to Unprototype (v1) on the Spaces board.
Jun 1 2015, 6:08 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley created T8377: Build the core "Spaces" Application.
Jun 1 2015, 6:06 PM · Spaces, Wikimedia, Policy
epriestley created T8376: Develop Spaces (v1).
Jun 1 2015, 5:36 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8368: Navigating to a deprecated instance of a ghost recurring event should display user-friendly messaging..

Just redirecting to the concrete ghost might be OK, too.

Jun 1 2015, 5:29 PM · Calendar
epriestley closed T8372: Resource cache as Resolved by committing Restricted Diffusion Commit.
Jun 1 2015, 4:04 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Awesome, thanks for testing! We'll get this upstreamed shortly.

Jun 1 2015, 3:48 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Probably a silly question, but did you restart Apache or php-fpm after applying the patch?

Jun 1 2015, 3:38 PM · Aphront, Celerity
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

At HEAD, each inline can now be individually hidden:

Jun 1 2015, 3:36 PM · Prioritized, Differential
epriestley added a comment to T8370: Index "TODO" comments and other references present in source code.

Tracking moves and fixes of these things seems like the hard part: it would maybe be nicer to see "all places in the codebase a task is currently mentioned", not necessarily "all places a task has ever been mentioned". But maybe this isn't actually that important.

Jun 1 2015, 3:34 PM · Transactions, Diffusion
epriestley added a comment to T8370: Index "TODO" comments and other references present in source code.

Another (not necessarily good) attack on this would be to extract these with a linter (similar to the TODO linter), and then maybe, uh, let lint messages have an object PHID on them? I guess? This feels real sketchy but maybe there are some other reasonable things we could do which could justify it.

Jun 1 2015, 3:29 PM · Transactions, Diffusion
epriestley added a comment to T8373: Reporting all custom fields in the report.

Can you explain what you mean in more detail? I don't know what you mean by "the report", or which application you're using, or which custom fields are working.

Jun 1 2015, 3:24 PM · Maniphest
epriestley added a revision to T7703: Policy checks may execute incompletely for non-viewers: Unknown Object (Differential Revision).
Jun 1 2015, 2:44 PM · Policy, Herald, Flags
epriestley closed T8375: The "phabricator:20150503.repositorysymbols.2.php" migration triggers a notice as Resolved by committing Restricted Diffusion Commit.
Jun 1 2015, 1:56 PM · Diffusion
epriestley closed T8374: Wrong message, when create diff with untracked changes as Resolved by committing Restricted Diffusion Commit.
Jun 1 2015, 1:51 PM · Arcanist
epriestley added a revision to T8375: The "phabricator:20150503.repositorysymbols.2.php" migration triggers a notice: Unknown Object (Differential Revision).
Jun 1 2015, 1:44 PM · Diffusion
epriestley added a revision to T8374: Wrong message, when create diff with untracked changes: Unknown Object (Differential Revision).
Jun 1 2015, 1:31 PM · Arcanist
epriestley added a comment to T8372: Resource cache.

Pretty sure D13095 will fix this.

Jun 1 2015, 1:27 PM · Aphront, Celerity
epriestley added a revision to T8372: Resource cache: Unknown Object (Differential Revision).
Jun 1 2015, 1:27 PM · Aphront, Celerity
epriestley added a comment to T8331: phlog can be improved.

I think it was that phlog($ex) gives us the stack trace of the phlog() call, but if we have to pick one stack trace, the stack trace of the exception is more useful.

Jun 1 2015, 1:21 PM · Infrastructure
joshuaspence placed T8331: phlog can be improved up for grabs.

Having a look at this and I can't actually remember what the issue is.

Jun 1 2015, 1:17 PM · Infrastructure
epriestley added a comment to T8372: Resource cache.

Do you have a full stack trace in your error log? Usually /var/log/apache2/error_log or something like that, depending on exactly which webserver/OS you're running.

Jun 1 2015, 1:16 PM · Aphront, Celerity
joshuaspence closed T7603: Remove the deprecated "Repositories" application as Resolved by committing Restricted Diffusion Commit.
Jun 1 2015, 5:40 AM · Repositories, Diffusion
avivey awarded T8370: Index "TODO" comments and other references present in source code a Like token.
Jun 1 2015, 4:42 AM · Transactions, Diffusion
epriestley added a comment to T4558: Make Diviner useful for third-parties.

Probably a prerequisite for implementing anything like arc diviner, or whatever, too. That said, it's probably also quite a lot of work.

Jun 1 2015, 2:17 AM · Diviner
joshuaspence added a comment to T4558: Make Diviner useful for third-parties.

Diviner updates over Conduit would be awesome!

Jun 1 2015, 2:16 AM · Diviner
joshuaspence created T8370: Index "TODO" comments and other references present in source code.
Jun 1 2015, 2:15 AM · Transactions, Diffusion
epriestley added a comment to T4558: Make Diviner useful for third-parties.

Implementing transactions. I think that this would be messy given that (currently) no user would really ever interact with Diviner, it is always the omnipotent user.

Jun 1 2015, 2:14 AM · Diviner
joshuaspence added a comment to T4558: Make Diviner useful for third-parties.

(There's also a uri.source in Books which should probably get an implicit value if the repository is set but uri.source is not.)

Jun 1 2015, 2:10 AM · Diviner
joshuaspence added a comment to T8345: Add task tabs for "Mentions" and "Merged".

Yeah, it definitely is a weaker relationship than the current "blocking tasks" relationship. FWIW, I think that JIRA has a "related issue" field (I could be wrong, I've never actually used JIRA).

Jun 1 2015, 2:08 AM · Restricted Project, FreeBSD, Maniphest
epriestley added a comment to T8352: Link Diviner books to repositories.

I think that's reasonable.

Jun 1 2015, 2:07 AM · Diviner