Here, I changed line 7:

Ah, I got some of them to port forward.

Given your experience with GitHub Enterprise, would you expect the comments on the pull requests I linked above to be porting across updates if GitHub had behavior equivalent to GHE?

Chad's comment on the diff view didn't port into the file, and didn't port forward when I updated the diff.

None of the comments are visible on this view, either:

Can someone show me how to use this feature on GitHub? For example, my comment here:

We should be running the same code on both, so this might be a specific mail client's quoting conventions, as @chad suggests. There's no standard way for us to strip off quoted text or signatures from email so we kind of do a collection of things that usually work and just add more rules as we run into cases we don't handle correctly.

Ah, nice. Happy to accept a diff to stub out getCommitHookMode() for a few months if anyone still has a use case.

• Other, more useful applications (Maniphest, Differential) don't currently do this.
  • PhabricatorApplicationTransactionFeedStory doesn't really support doing this the right way.
    • Audit implements it OK.
    • Pholio and Ponder implement it but sort of show the wrong data (the description at view-time, not at create-time, which is misleading).

This is probably not meaningfully distinguishable from T8097, I'm just going to merge it into that.

We don't plan to implement this. Generally, we don't let any users remove data.

The most promising way to implement these capabilities is to more fully proxy the Git protocol, as we do to some degree for Mercurial and SVN, so I plan to evaluate that first.

The bug reporting guide suggests this as a "Common Fix":

Well, I guess an old version of PHUIObjectItemView.php, to be precise.

Specifically, APC cached an old version of PhabricatorSearchResultView.php, and restarting cleared the cache.

Restart Apache (if using apache) or fpm (if using nginx + php-fpm), and let me know if that fixes it?

I occasionally want this, too. I think giving the full-Conpherence interface a secondary "Preview -> Post" workflow might be reasonable, so you can either post directly or review a modal preview on your way.

As a goofy workaround you can probably write some dummy file

We don't currently decode base85 in diff form, so pasting a git diff --binary diff into Phabricator doesn't produce the exact same diff as running arc diff. Particularly, in base85 we just note "this binary file was added"; via arc diff we would show the actual file.

I'd expect it to work on relatively up-to-date Phabricator. You may still need to have some valid-ish ~/.arcrc file, which we might be reading and then ignoring. I'll check that and fix it if it's the case -- we shouldn't require a ~/.arcrc if you specify --conduit-token.

Things that still use Arcanist Projects:

I can sorta understand symbol sources, but why do we need to manually mark symbol languages? Can't we just use whatever languages have been indexed?

Yeah that sounds reasonable.

I think it would be reasonable to leave getCommitHookMode() around as a stub which just emits a deprecation warning and does return false; -- I believe none of the other changed APIs are likely to be used by third-party stuff which isn't materially affected by the changes.

After T5378, most links should be external (because internal links would be converted into Remarkup objects).