Page MenuHomePhabricator
Create Task
Maniphest T5866

Crash when viewing a build, whose build plan has had steps deleted
Closed, ResolvedPublic
Actions

Description

We get:

Argument 1 passed to HarbormasterBuildTarget::attachBuildStep() must be an instance of HarbormasterBuildStep, null given, called in /srv/phabricator/phabricator/src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php on line 93 and defined

when viewing a build whose build plan has had steps deleted. I'm not sure what the best course of action is here; maybe just displaying a message that says "This build has steps that have been deleted" or something of that nature and omitting any targets that are missing?

Revisions and Commits

rP Phabricator
ClosedD10361 Prevent crash when build step has been deleted on build plan

Related Objects
Search...

Event Timeline

hach-que created this task.Aug 13 2014, 6:21 AM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Harbormaster.
hach-que added subscribers: hach-que, epriestley.
epriestley added a comment.Aug 13 2014, 1:05 PM

I haven't looked at how hard this is specifically, but my general preference is:

  • show the targets with a message ("this target's step has been deleted")
  • hide/deactivate any functionality which takes a bunch of work to show/activate

If that's a pain, and showing "this build has steps which have been deleted" and just hiding the targets is a decent bit easier, that's totally fine too.

hach-que added a comment.Aug 13 2014, 1:16 PM

Yeah, I think the HarbormasterBuildTargetQuery should maybe attach a null value in this case when the step doesn't exist? Then any logic using the step can just skip over it.

epriestley added a parent task: T8096: Improve Harbormaster UI/UX (v1).May 6 2015, 3:33 PM
epriestley moved this task from Backlog to v1 on the Harbormaster board.
hach-que closed this task as Resolved.May 6 2015, 9:26 PM
hach-que claimed this task.
hach-que added a revision: D10361: Prevent crash when build step has been deleted on build plan.

This has since been fixed.

Phabricator · Built by Phacility