Page MenuHomePhabricator

Two-up inline row scaffold must have at most two inline views
Closed, ResolvedPublic

Description

Saw this in our PHP error logs:

[17-Mar-2015 17:13:00 Australia/Sydney] [2015-03-17 17:13:00] EXCEPTION: (Exception) Two-up inline row scaffold must have at most two inline views. at [<phabricator>/src/infrastructure/diff/view/PHUIDiffTwoUpInlineCommentRowScaffold.php:21]
[17-Mar-2015 17:13:00 Australia/Sydney] arcanist(head=master, ref.master=b961869edac9), phabricator(head=master, ref.master=98899c822eb9), phlab(head=master, ref.master=dddf486a2aec), phutil(head=master, ref.master=ce3959b4046f)
[17-Mar-2015 17:13:00 Australia/Sydney]   #0 PHUIDiffTwoUpInlineCommentRowScaffold::render() called at [<phabricator>/src/view/AphrontView.php:159]
[17-Mar-2015 17:13:00 Australia/Sydney]   #1 AphrontView::producePhutilSafeHTML() called at [<phutil>/src/markup/render.php:132]
[17-Mar-2015 17:13:00 Australia/Sydney]   #2 phutil_escape_html(PHUIDiffTwoUpInlineCommentRowScaffold) called at [<phutil>/src/markup/render.php:186]
[17-Mar-2015 17:13:00 Australia/Sydney]   #3 phutil_implode_html(string, array) called at [<phabricator>/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:298]
[17-Mar-2015 17:13:00 Australia/Sydney]   #4 DifferentialChangesetTwoUpRenderer::renderTextChange(integer, integer, integer) called at [<phabricator>/src/applications/ifferential/parser/DifferentialChangesetParser.php:1046]
[17-Mar-2015 17:13:00 Australia/Sydney]   #5 DifferentialChangesetParser::render(NULL, NULL, array) called at [<phabricator>/src/applications/differential/parser/ifferentialChangesetParser.php:64]
[17-Mar-2015 17:13:00 Australia/Sydney]   #6 DifferentialChangesetParser::renderChangeset() called at [<phabricator>/src/applications/differential/controller/ifferentialChangesetViewController.php:219]
[17-Mar-2015 17:13:00 Australia/Sydney]   #7 DifferentialChangesetViewController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
[17-Mar-2015 17:13:00 Australia/Sydney]   #8 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:196]
[17-Mar-2015 17:13:00 Australia/Sydney]   #9 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:121]
[17-Mar-2015 17:13:00 Australia/Sydney]   #10 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:19]