Page MenuHomePhabricator
Feed Advanced Search

Nov 7 2020

epriestley closed T13298: Improve Herald profiling information available in transcripts as Resolved.

The profiling in D20566 seems satisfactory, and has been useful in resolving or understanding a few performance-related issues.

Nov 7 2020, 12:09 AM · Herald

Nov 3 2020

epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: Unknown Object (Differential Revision).
Nov 3 2020, 8:50 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
  • There is no way to pull custom field values with *.search. See above.
    • There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
    • There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
      • As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
    • There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
Nov 3 2020, 8:49 PM · Conduit, Harbormaster
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: Unknown Object (Differential Revision).
Nov 3 2020, 8:46 PM · Conduit, Harbormaster
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
Nov 3 2020, 8:45 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.

HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").

Nov 3 2020, 8:18 PM · Conduit, Harbormaster
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
Nov 3 2020, 8:17 PM · Conduit, Harbormaster
epriestley renamed T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values from PCRE segfaults readily with default "pcre.backtrace_limit" and "pcre.recursion_limit" values to PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.
Nov 3 2020, 7:36 PM · Phacility
epriestley closed T13584: Shallow Git clones fail under recent versions of Git as Resolved.

This appears fixed by D21484 (and @20after4 confirmed the fix on rPc0414732 -- thanks!) so I'm going to mark it as resolved.

Nov 3 2020, 7:04 PM · Diffusion
epriestley added a revision to T2312: Modifying PHP: Unknown Object (Differential Revision).
Nov 3 2020, 6:37 PM · Infrastructure
epriestley added a comment to T2312: Modifying PHP.

See https://discourse.phabricator-community.org/t/strpos-throwing-in-phabricatorauthpasswordengine/4335, and D21477.

Nov 3 2020, 6:19 PM · Infrastructure

Oct 24 2020

epriestley triaged T13584: Shallow Git clones fail under recent versions of Git as Low priority.
Oct 24 2020, 11:05 PM · Diffusion

Oct 19 2020

epriestley edited the content of Changelog.
Oct 19 2020, 7:05 PM
epriestley created an object: 2020 Week 42.
Oct 19 2020, 7:04 PM
epriestley added a revision to T13491: Why does Arcanist require "--"?: Unknown Object (Differential Revision).
Oct 19 2020, 6:54 PM · Guides

Oct 16 2020

epriestley added a revision to T13583: Support reasonable guardrails against mismatched data retention policies in comment content: Unknown Object (Differential Revision).
Oct 16 2020, 8:29 PM · Herald
epriestley triaged T13583: Support reasonable guardrails against mismatched data retention policies in comment content as Normal priority.
Oct 16 2020, 8:27 PM · Herald
epriestley added a revision to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool: Unknown Object (Differential Revision).
Oct 16 2020, 7:31 PM · Daemons

Sep 30 2020

epriestley added a member for Community: bootstraponline.
Sep 30 2020, 3:07 PM
epriestley added a member for Blessed Committers: bootstraponline.
Sep 30 2020, 3:07 PM

Sep 28 2020

epriestley added a revision to T13564: Remarkup tables should show all content when printed to PDF: Unknown Object (Differential Revision).
Sep 28 2020, 4:22 PM · Google Chrome, Remarkup

Sep 18 2020

epriestley edited the content of Changelog.
Sep 18 2020, 7:03 PM
epriestley created an object: 2020 Week 37 (Mid September).
Sep 18 2020, 6:55 PM

Sep 17 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 17 2020, 8:52 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 17 2020, 8:38 PM · Differential
epriestley added a revision to T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring: Unknown Object (Differential Revision).
Sep 17 2020, 8:19 PM · Arcanist, Conduit
epriestley triaged T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring as Low priority.
Sep 17 2020, 8:17 PM · Arcanist, Conduit
epriestley added a comment to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool.

This synthetic script demonstrates the conceptual problem with FutureIterator:

Sep 17 2020, 7:49 PM · Daemons

Sep 16 2020

epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.
Sep 16 2020, 12:44 AM · Differential
epriestley closed T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Resolved by committing Restricted Diffusion Commit.
Sep 16 2020, 12:37 AM · Daemons
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: Unknown Object (Differential Revision).
Sep 16 2020, 12:24 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: Unknown Object (Differential Revision).
Sep 16 2020, 12:20 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: Unknown Object (Differential Revision).
Sep 16 2020, 12:19 AM · Differential
epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.
Sep 16 2020, 12:16 AM · Differential

Sep 15 2020

epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly, a subtask of T13570: Amazon is retiring SMTP V3 Signatures, as Resolved.
Sep 15 2020, 8:03 PM · Mail
epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly as Resolved by committing Restricted Diffusion Commit.
Sep 15 2020, 8:03 PM · Mail
epriestley added a comment to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.

I've marked D21461 as resolving this, since the new errors surface the particulars:

Sep 15 2020, 4:19 PM · Mail
epriestley added a revision to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: Unknown Object (Differential Revision).
Sep 15 2020, 4:15 PM · Mail
epriestley added a revision to T13570: Amazon is retiring SMTP V3 Signatures: Unknown Object (Differential Revision).
Sep 15 2020, 4:15 PM · Mail
epriestley edited the content of Dependencies.
Sep 15 2020, 4:08 PM
epriestley added a subtask for T13570: Amazon is retiring SMTP V3 Signatures: T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.
Sep 15 2020, 4:08 PM · Mail
epriestley added a parent task for T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: T13570: Amazon is retiring SMTP V3 Signatures.
Sep 15 2020, 4:08 PM · Mail

Sep 8 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 8 2020, 8:42 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 8 2020, 8:16 PM · Differential
epriestley added a revision to T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail: Unknown Object (Differential Revision).
Sep 8 2020, 8:15 PM · Daemons
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 8 2020, 7:55 PM · Differential
epriestley triaged T13580: Make "fully imported" a separate commit bit or standalone flag, not a complex bitmask operation as Wishlist priority.
Sep 8 2020, 7:49 PM · Diffusion
epriestley closed T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Resolved.
  • D21457 fixes approximately 20 additional errors identified by the linter in phabricator/.
Sep 8 2020, 6:48 PM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 8 2020, 3:55 PM · Arcanist

Sep 5 2020

epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.
  • D21454 fixes the specific issue in HTTPSFuture.
Sep 5 2020, 12:32 AM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 5 2020, 12:32 AM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 5 2020, 12:26 AM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 5 2020, 12:09 AM · Arcanist
epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.

Check if arc lint catches this.

Sep 5 2020, 12:09 AM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 5 2020, 12:07 AM · Arcanist

Sep 4 2020

epriestley added a revision to T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()": Unknown Object (Differential Revision).
Sep 4 2020, 11:39 PM · Daemons
epriestley triaged T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()" as Normal priority.
Sep 4 2020, 11:38 PM · Daemons
epriestley added a revision to T13573: When printing, render dates in an absolute, context-free format: Unknown Object (Differential Revision).
Sep 4 2020, 11:25 PM · Infrastructure
epriestley renamed T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Include "Moved/Copied" gutter in 1-up diffs, and add aural cues to Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Sep 4 2020, 5:56 PM · Accessibility, Differential
epriestley triaged T13578: Provide `bin/user approve` to approve an account from the CLI as Wishlist priority.
Sep 4 2020, 5:52 PM · Setup, Auth
epriestley triaged T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Low priority.
Sep 4 2020, 5:49 PM · Arcanist
epriestley triaged T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history as Normal priority.
Sep 4 2020, 5:46 PM · Arcanist

Aug 24 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

New user is told "install dinosaurs, you can trust epriestley.

Aug 24 2020, 4:49 PM · Arcanist

Aug 21 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

Distribution would just be zip/tgz files for each package

Aug 21 2020, 5:01 PM · Arcanist
alexnb awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
Aug 21 2020, 8:31 AM · Differential, Quick Look

Aug 20 2020

epriestley added a project to T13575: PHP built-in webserver fails on POST: Infrastructure.
Aug 20 2020, 6:48 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I wonder if maintaining support for the builtin webserver is worthwhile -- I never use it, and I feel like I only see it referenced when users report bugs like this in the vein of "PHP builtin webserver has been completely broken for 13 years", which suggests it's probably not seeing very much use in the wild, either.

Aug 20 2020, 6:47 PM · Infrastructure

Aug 17 2020

epriestley added a subtask for T13574: Make responsive UI elements respond to container width, not window width: T13521: FormationView could do more Javascript magic around device layouts and header elements.
Aug 17 2020, 3:52 PM · Design
epriestley added a parent task for T13521: FormationView could do more Javascript magic around device layouts and header elements: T13574: Make responsive UI elements respond to container width, not window width.
Aug 17 2020, 3:52 PM · Differential
epriestley triaged T13574: Make responsive UI elements respond to container width, not window width as Low priority.
Aug 17 2020, 3:52 PM · Design
epriestley added a comment to T13573: When printing, render dates in an absolute, context-free format.

See also T9854: Support date/time reformatting in Remarkup for a related change, although I think neither feature directly impacts the other.

Aug 17 2020, 3:34 PM · Infrastructure
epriestley updated the task description for T13573: When printing, render dates in an absolute, context-free format.
Aug 17 2020, 3:33 PM · Infrastructure
epriestley triaged T13573: When printing, render dates in an absolute, context-free format as Normal priority.
Aug 17 2020, 3:32 PM · Infrastructure
epriestley triaged T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool as Low priority.
Aug 17 2020, 3:17 PM · Daemons

Aug 13 2020

epriestley triaged T13571: When viewing LFS files in Differential or Diffusion, show blob content where reasonable as Normal priority.
Aug 13 2020, 8:12 PM · Diffusion, Differential
epriestley claimed T13570: Amazon is retiring SMTP V3 Signatures.

I think every other AWS interaction already uses v4, since D14978 (January 2016).

Aug 13 2020, 4:00 PM · Mail

Aug 12 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 9:19 PM · Differential
epriestley triaged T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Wishlist priority.
Aug 12 2020, 8:32 PM · Daemons
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 8:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 7:42 PM · Differential
epriestley added a comment to T11827: ssh-auth hangs on FreeBSD.

Internally, see also PHI1785.

Aug 12 2020, 7:22 PM · Diffusion, Bug Report
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Restricted Differential Revision.
Aug 12 2020, 7:11 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 7:08 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 7:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 6:41 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 6:32 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 4:31 PM · Differential
epriestley triaged T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate as Low priority.
Aug 12 2020, 4:02 PM · Arcanist
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 3:54 PM · Differential

Aug 11 2020

epriestley triaged T13567: Arcanist does not decode unicode filenames in Git before passing them to linters as Low priority.
Aug 11 2020, 6:38 PM · Arcanist
epriestley renamed T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits from Improve fallback behavior for "arc branches/bookmarks" to Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits.
Aug 11 2020, 6:34 PM · Arcanist
epriestley triaged T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits as Normal priority.
Aug 11 2020, 6:34 PM · Arcanist
epriestley triaged T13565: Filesystem write failure error messages lack tailoring, notably in DeferredLog as Normal priority.
Aug 11 2020, 6:04 PM · Infrastructure
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Aug 11 2020, 5:47 PM · Windows, Arcanist
epriestley added a comment to T13564: Remarkup tables should show all content when printed to PDF.

Adding overflow-wrap: anywhere appears to fix this without breaking anything.

Aug 11 2020, 5:35 PM · Google Chrome, Remarkup
epriestley triaged T13564: Remarkup tables should show all content when printed to PDF as Normal priority.
Aug 11 2020, 5:17 PM · Google Chrome, Remarkup
epriestley triaged T13563: On Windows, Arcanist tries and fails to set stdin nonblocking while reading the stream as Low priority.
Aug 11 2020, 5:06 PM · Windows, Arcanist
epriestley triaged T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions as Normal priority.
Aug 11 2020, 5:02 PM · Windows, Arcanist
epriestley added a revision to T9924: Add support for git worktree: Unknown Object (Differential Revision).
Aug 11 2020, 4:45 PM · FreeBSD, Restricted Project, Arcanist, Feature Request
epriestley updated the task description for T13561: Allow the daemons to generate tasks dynamically at runtime.
Aug 11 2020, 3:26 PM · Daemons