Page MenuHomePhabricator
Feed Advanced Search

Aug 11 2020

epriestley triaged T13561: Allow the daemons to generate tasks dynamically at runtime as Normal priority.
Aug 11 2020, 3:15 PM · Daemons
epriestley added a comment to T13125: Plans: Code coverage reporting.

PHI1816 would also like dimensional coverage: coverage by language; coverage by team/owner. This is perhaps worth considering in how coverage is aggregated.

Aug 11 2020, 2:54 PM · Diffusion, Plans
epriestley triaged T11372: Multiple coverage columns for different types of code coverage as Wishlist priority.
Aug 11 2020, 2:49 PM · Diffusion, Restricted Project
epriestley updated the task description for T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:48 PM · Diffusion, Plans
epriestley added subtasks for T13125: Plans: Code coverage reporting: T11372: Multiple coverage columns for different types of code coverage, T9524: Show aggregate subdirectory coverage in Diffusion browse views.
Aug 11 2020, 2:47 PM · Diffusion, Plans
epriestley added a parent task for T9524: Show aggregate subdirectory coverage in Diffusion browse views: T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:47 PM · Diffusion, Restricted Project
epriestley added a parent task for T11372: Multiple coverage columns for different types of code coverage: T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:47 PM · Diffusion, Restricted Project

Aug 10 2020

epriestley triaged T13560: "Large number of changes" transaction timeline banner may hide a single change as Wishlist priority.
Aug 10 2020, 8:38 PM · Design
epriestley added a project to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: Accessibility.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting as Wishlist priority.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13558: Duration computation on user profiles is silly as Wishlist priority.
Aug 10 2020, 8:15 PM · Design

Aug 8 2020

epriestley edited the content of Changelog.
Aug 8 2020, 2:39 AM
epriestley created an object: 2020 Week 31 (Early August).
Aug 8 2020, 2:38 AM

Aug 5 2020

epriestley updated the task description for T13241: Guide: SMS is Insecure.
Aug 5 2020, 7:22 PM · Security, Guides
epriestley triaged T13557: Unified diffs could do a better job of rendering omitted trailing newlines as Wishlist priority.
Aug 5 2020, 5:07 PM · Differential

Jul 28 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 28 2020, 6:15 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 28 2020, 5:08 PM · Differential

Jul 27 2020

epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 27 2020, 6:06 PM · Guides, Arcanist

Jul 25 2020

epriestley edited the content of Changelog.
Jul 25 2020, 3:26 PM
epriestley created an object: 2020 Week 29 (Late July).
Jul 25 2020, 3:25 PM

Jul 24 2020

epriestley added a comment to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.

In D21426, I removed phd.trace and phd.verbose.

Jul 24 2020, 12:18 AM · Daemons

Jul 23 2020

epriestley added a revision to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes: Unknown Object (Differential Revision).
Jul 23 2020, 7:22 PM · Daemons
epriestley claimed T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.
Jul 23 2020, 6:05 PM · Daemons
epriestley triaged T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes as Wishlist priority.
Jul 23 2020, 6:05 PM · Daemons
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: Unknown Object (Differential Revision).
Jul 23 2020, 5:40 PM · Daemons
epriestley added a comment to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall.

The call sequence here is approximately:

Jul 23 2020, 5:11 PM · Daemons
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: Unknown Object (Differential Revision).
Jul 23 2020, 5:09 PM · Daemons
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: Unknown Object (Differential Revision).
Jul 23 2020, 5:07 PM · Daemons
epriestley triaged T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall as Normal priority.
Jul 23 2020, 2:58 PM · Daemons
epriestley closed T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Resolved by committing Restricted Diffusion Commit.
Jul 23 2020, 2:46 PM · Infrastructure
epriestley added a revision to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()": Unknown Object (Differential Revision).
Jul 23 2020, 2:40 PM · Infrastructure
epriestley added a comment to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()".

This is a PCRE backtracking issue. It reproduces on an input corpus of length 3,277 bytes with only "x", " " (space), and "\n" (newline) characters, and disappears if I increase pcre.backtrack_limit.

Jul 23 2020, 2:36 PM · Infrastructure
epriestley triaged T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Low priority.
Jul 23 2020, 1:41 PM · Infrastructure

Jul 22 2020

epriestley added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

Please use Discourse to discuss Phabricator.

Jul 22 2020, 11:49 PM · Arcanist, Guides

Jul 21 2020

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 21 2020, 6:24 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 21 2020, 6:24 PM · Guides, Arcanist
epriestley triaged T13553: Creating a milestone via the API fails when accessing the project's parent as Normal priority.
Jul 21 2020, 5:54 PM · Transactions, Projects

Jul 20 2020

epriestley removed a member for Phacility Core Access: amckinley.
Jul 20 2020, 5:23 PM
epriestley removed a member for Phacility: amckinley.
Jul 20 2020, 5:23 PM
epriestley defrocked amckinley.
Jul 20 2020, 5:23 PM

Jul 17 2020

epriestley added a revision to T2495: Improve whitespace expansion of tab literals: Unknown Object (Differential Revision).
Jul 17 2020, 10:07 PM · Restricted Project, FreeBSD, Diffusion, Differential

Jul 16 2020

epriestley added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Please use Discourse to discuss Phabricator. (And please don't bump unrelated tasks from five and a half years ago.)

Jul 16 2020, 3:11 PM · Harbormaster

Jul 12 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 12 2020, 9:26 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 12 2020, 7:45 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 12 2020, 6:03 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 12 2020, 5:44 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 12 2020, 4:25 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 12 2020, 4:16 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 12 2020, 3:41 PM · Differential

Jul 11 2020

epriestley edited the content of Changelog.
Jul 11 2020, 4:33 PM
epriestley created an object: 2020 Week 27 (Mid July).
Jul 11 2020, 4:32 PM

Jul 10 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 6:44 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 6:20 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 5:56 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 5:48 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 4:25 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 4:20 PM · Differential
Krinkle awarded T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags a Orange Medal token.
Jul 10 2020, 4:17 PM · Mail
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 4:16 PM · Differential
epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

The broader structural issue here is:

Jul 10 2020, 4:11 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 10 2020, 4:05 PM · Differential

Jul 9 2020

epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

A second issue is that some of the "publish" behavior depends on the commit/revision relationship. This can still be sequenced correctly entirely in the publish daemon, but "close related revisions" and "publish the commit" are not entirely independent.

Jul 9 2020, 10:24 PM · Differential
epriestley triaged T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Normal priority.
Jul 9 2020, 10:13 PM · Differential
epriestley renamed T13361: Get rid of the "Actions" dropdown in Diffusion from Get rid of the "Actions" dropdown in in Diffusion to Get rid of the "Actions" dropdown in Diffusion.
Jul 9 2020, 9:37 PM · Design, Diffusion
epriestley closed T13369: When a large number of commits are pushed to a repository, import them at lower priority as Resolved.

This appears stable.

Jul 9 2020, 9:36 PM · Daemons, Diffusion

Jul 6 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jul 6 2020, 10:29 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

See PHI1807. At time of writing, arc land can delete the local master if you land it onto itself. This isn't a big deal (it gives you the command to get it back), but not intended and undesirable. Although it isn't recommended, arc land is supposed to support working in master and landing master into itself.

Jul 6 2020, 10:00 PM · Arcanist

Jul 3 2020

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 3 2020, 8:19 PM · Guides, Arcanist
epriestley edited the content of Changelog.
Jul 3 2020, 8:13 PM
epriestley created an object: 2020 Week 26 (Early July).
Jul 3 2020, 8:11 PM
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:46 PM · Guides, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:45 PM · Guides, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:43 PM · Guides, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jul 3 2020, 6:39 PM · Arcanist
epriestley added a comment to T13551: "debug.time-limit" no longer functions in PHP7.

A sometimes-suitable replacement would be some bin/request mechanism which simulates a web request in process. There are some limits to how authentic this can be, but for some substantial subset of hangs it may still be useful.

Jul 3 2020, 6:02 PM · Infrastructure

Jul 1 2020

epriestley triaged T13551: "debug.time-limit" no longer functions in PHP7 as Wishlist priority.
Jul 1 2020, 7:32 PM · Infrastructure
epriestley added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

PHI1776 is another report of this behavior.

Jul 1 2020, 7:05 PM · Bug Report, Diffusion
epriestley created P2145 Command-Line Input.
Jul 1 2020, 12:26 PM
epriestley created P2144 Command-Line Input.
Jul 1 2020, 12:25 PM

Jun 30 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 10:24 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 10:01 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 9:55 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 8:20 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 7:57 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 7:54 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 6:58 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Restricted Differential Revision.
Jun 30 2020, 5:55 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 5:47 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

A related issue is that it is difficult to identify the set of "published" hashes in the general case. We would like arc branches to show all unpublished history, but stop at published history.

Jun 30 2020, 4:48 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 30 2020, 1:41 PM · Arcanist

Jun 18 2020

epriestley added a comment to T13546: Modernize the "arc land" workflow.

The major issue I'm trying to deal with now is that if you have a tree like this:

Jun 18 2020, 6:10 PM · Arcanist

Jun 17 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:37 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:34 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:33 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 5:31 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 17 2020, 2:50 PM · Arcanist
epriestley edited P2143 reach.php.
Jun 17 2020, 2:50 PM

Jun 15 2020

epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

P2143 has some graph reachability code that I don't actually need yet, but may by the time I get here.

Jun 15 2020, 3:15 PM · Restricted Project, Restricted Project, Arcanist
epriestley created P2143 reach.php.
Jun 15 2020, 3:15 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 15 2020, 3:09 PM · Arcanist