Page MenuHomePhabricator
Feed Advanced Search

Jun 23 2017

epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Thanks, that's much more clear than the original description!

Jun 23 2017, 4:42 PM · Remarkup, Feature Request
mcorteel added a comment to T12865: Strikethrough for icons in checked remarkup list items.

No they're not. I know it's a tiny difference, but look at this closely (left is my proposal, right is the current state):

Spectacle.eD1745.png (147×463 px, 9 KB)

Jun 23 2017, 4:41 PM · Remarkup, Feature Request
epriestley triaged T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Low priority.

(I think D18132 should fix this once someone gets a chance to look at it.)

Jun 23 2017, 4:22 PM · Feed, Bug Report
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Unknown Object (Differential Revision).
Jun 23 2017, 4:21 PM · Infrastructure
epriestley triaged T12866: Batch repository editing or repository groups for shared access control settings as Low priority.
Jun 23 2017, 4:18 PM · Diffusion, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

Jun 23 2017, 4:18 PM · Remarkup, Feature Request
epriestley added a project to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Infrastructure.
Jun 23 2017, 3:54 PM · Infrastructure
epriestley added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

This should now be fixed in HEAD of master, and promote to stable within about 12 hours. Thanks for the report! Let us know if you run into anything else.

Jun 23 2017, 3:43 PM · Remarkup, Bug Report
epriestley closed T12867: Youtube remarkup rule fails to parse "ambiguous URI" as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 3:43 PM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I’m fine waiting for the fix. Thanks @epriestley

Jun 23 2017, 3:42 PM · Remarkup, Bug Report
epriestley closed T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 3:14 PM · Drydock, Differential
epriestley added a revision to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: Unknown Object (Differential Revision).
Jun 23 2017, 3:10 PM · Drydock, Differential
epriestley added a revision to T12867: Youtube remarkup rule fails to parse "ambiguous URI": Unknown Object (Differential Revision).
Jun 23 2017, 2:37 PM · Remarkup, Bug Report
epriestley renamed T12867: Youtube remarkup rule fails to parse "ambiguous URI" from Daemon fails to parse "ambiguous URI" to Youtube remarkup rule fails to parse "ambiguous URI".
Jun 23 2017, 2:30 PM · Remarkup, Bug Report
epriestley added projects to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: Differential, Drydock.
Jun 23 2017, 2:24 PM · Drydock, Differential
epriestley added a project to T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: Customer Impact.

A related issue surfaced recently. Actual use case (forensically reconstructed):

Jun 23 2017, 2:22 PM · Customer Impact, Maniphest, Differential
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

Oh, this is actually the Mercurial flavor of this action. We have this one in the Git flavor, which is why I was surprised:

Jun 23 2017, 2:02 PM · Drydock, Differential
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

My expectation is that this action can never appear -- this is the pre-Drydock hacky temporary action -- so something troubling is afoot.

Jun 23 2017, 2:01 PM · Drydock, Differential
epriestley created T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.
Jun 23 2017, 1:59 PM · Drydock, Differential
epriestley added a comment to T12866: Batch repository editing or repository groups for shared access control settings.

See also T10005 (bulk editors for all applications) and T6722.

Jun 23 2017, 1:38 PM · Diffusion, Feature Request
epriestley claimed T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I think a minimal reproduction case which is typical of this example is:

Jun 23 2017, 1:35 PM · Remarkup, Bug Report
wordpress edited the content of Organizations Using Phabricator.
Jun 23 2017, 12:40 PM
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

Looks to be just the presence of the "?" in the text

Jun 23 2017, 6:47 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

"XXX://123456 XXX XXX XXX://123456 XXX XXX"

Jun 23 2017, 6:47 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

You and me both. I am super confused.

Jun 23 2017, 6:46 AM · Remarkup, Bug Report
chad added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

Well the stack trace says PhabricatorYoutubeRemarkupRule, so I'm confused what the issue is.

Jun 23 2017, 6:44 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

LOL @chad Literally reproduced this issue here by trying to paste the above line without the back ticks. It refuses to let me comment.

Jun 23 2017, 6:42 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I'm not sure how without giving you the entire commit message which I cannot. I think key would be a having a commit with a line (probably the first one) that looks like this "XXX://123456 XXX XXX XXX? XXX://123456 XXX XXX XXX"

Jun 23 2017, 6:42 AM · Remarkup, Bug Report
chad merged T12868: Highlight and link URI's in review titles into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jun 23 2017, 6:29 AM · Remarkup
chad merged task T12868: Highlight and link URI's in review titles into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jun 23 2017, 6:29 AM · Diffusion, Differential, Feature Request
jcarrillo7 created T12868: Highlight and link URI's in review titles.
Jun 23 2017, 6:25 AM · Diffusion, Differential, Feature Request
chad added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

How can we reproduce this issue locally?

Jun 23 2017, 6:18 AM · Remarkup, Bug Report
jcarrillo7 updated subscribers of T12867: Youtube remarkup rule fails to parse "ambiguous URI".
Jun 23 2017, 6:13 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

There also seems like there may be an issue with the current parsing logic since the "detected URI" has spaces which I do not think are valid in a uri and it should have been detected as two separate URI's with some stuff in the middle.

Jun 23 2017, 6:12 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

The URI that is ambiguous is a URI to a company App on MacOS. The only part of the URI that matters is the xxx://123456. The rest is just the title of the item referenced by this URI and this title contains a "?" which mixed with T12526 may be causing this issue. There may also be a place you now need to catch exceptions thanks to URI parsing logic changes. Just guessing here from what I can tell in the code.

Jun 23 2017, 6:07 AM · Remarkup, Bug Report
zhoudan_dan added a comment to Q628: Daemon is waitting (Answer 552).
Jun 23 2017, 6:07 AM
jcarrillo7 created T12867: Youtube remarkup rule fails to parse "ambiguous URI".
Jun 23 2017, 5:57 AM · Remarkup, Bug Report
zhoudan_dan added a comment to Q628: Daemon is waitting (Answer 552).

Yes ,Emails are not always sent ?This is one of the problems.

Jun 23 2017, 1:13 AM

Jun 22 2017

mavit added a comment to T12856: Evaluate various "infrastructure-as-code" products.

You probably don't want to put much value in advice from passing Internet strangers, but... Having used Ansible for configuration management for a while, it certainly has a "worse is better" feeling to it. You folks seem like you might be more of a "better is better" outfit. Contrast, for example, your approach to upstreaming user-written linters versus their approach to upstreaming user-written modules.

Jun 22 2017, 9:27 PM · Ops, Phacility
avivey added a subtask for T9287: Working with many repositories: T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:26 PM · Restricted Project, Restricted Project, Diffusion
avivey added a parent task for T12866: Batch repository editing or repository groups for shared access control settings: T9287: Working with many repositories.
Jun 22 2017, 7:26 PM · Diffusion, Feature Request
chad updated the task description for T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 7:25 PM · Remarkup, Feature Request
jcarrillo7 updated the task description for T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:20 PM · Diffusion, Feature Request
jcarrillo7 added a project to T12866: Batch repository editing or repository groups for shared access control settings: Diffusion.
Jun 22 2017, 7:19 PM · Diffusion, Feature Request
jcarrillo7 created T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:19 PM · Diffusion, Feature Request
epriestley closed T12859: Some means of updating builtin images without a manual purge as Resolved.

Ah, alright. Yeah, behavior is:

Jun 22 2017, 6:24 PM · Design
chad added a comment to T12859: Some means of updating builtin images without a manual purge.

This is great for testing!

Jun 22 2017, 6:21 PM · Design
chad added a comment to T12859: Some means of updating builtin images without a manual purge.

I'm fine with 7 days, I didn't think we had any auto-update.

Jun 22 2017, 6:21 PM · Design
epriestley reopened T12859: Some means of updating builtin images without a manual purge as "Open".
Jun 22 2017, 6:20 PM · Design
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Oh, maybe I misunderstood. I thought you wanted an easier way to test changes in a development environment, but it sounds like you actually want end users to immediately get the new images instead of needing to wait 7 days for them?

Jun 22 2017, 6:20 PM · Design
chad added a comment to T12859: Some means of updating builtin images without a manual purge.

I was wanted something I could trigger like celerity, generate a map hash or something. I presume users still need to run this command?

Jun 22 2017, 6:18 PM · Design
epriestley closed T12859: Some means of updating builtin images without a manual purge as Resolved by committing Restricted Diffusion Commit.
Jun 22 2017, 6:14 PM · Design
• 1 added a comment to T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 6:11 PM · Remarkup, Feature Request
epriestley closed T12860: Search by tag does not work in Phriction as Resolved by committing Restricted Diffusion Commit.
Jun 22 2017, 6:01 PM · Phriction, Bug Report
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

A slightly more aggressive fix would be to make these have a 5 second TTL in development or something (or hash the file modification time into the builtin key? But that's a bit tricky...) so you'd never have to purge the cache, but I think this arises rarely enough that it isn't too valuable.

Jun 22 2017, 5:58 PM · Design
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Strictly speaking, you still have to do a "manual purge" (with bin/cache ...) after D18146, but I assume you just didn't want to have to fish around in the DB.

Jun 22 2017, 5:57 PM · Design
epriestley added a revision to T12859: Some means of updating builtin images without a manual purge: Unknown Object (Differential Revision).
Jun 22 2017, 5:56 PM · Design
epriestley added a revision to T12859: Some means of updating builtin images without a manual purge: Unknown Object (Differential Revision).
Jun 22 2017, 5:44 PM · Design
epriestley added a revision to T12860: Search by tag does not work in Phriction: Unknown Object (Differential Revision).
Jun 22 2017, 5:26 PM · Phriction, Bug Report
chad added Q628: Daemon is waitting (Answer 552).
Jun 22 2017, 2:20 PM
vpavlushkov asked Q629: Default empty value for custom "select" field.
Jun 22 2017, 1:01 PM
zhoudan_dan asked Q628: Daemon is waitting.
Jun 22 2017, 12:33 PM
chad closed T12864: Notifications User Guide: Setup and Configuration needs npm init as Invalid.

No problem, without knowing how to reproduce an issue or see it locally, we can't really move forward here. Will close out and if it comes up again with another user and reproduction steps, we can re-visit. Thanks!

Jun 22 2017, 8:27 AM · Documentation
swanshonknice added a comment to T12864: Notifications User Guide: Setup and Configuration needs npm init.

Sorry Chad,

Jun 22 2017, 8:25 AM · Documentation
mcorteel created T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 8:24 AM · Remarkup, Feature Request
chad added a comment to T12864: Notifications User Guide: Setup and Configuration needs npm init.

See Contributing Bug Reports, specifically we need a full set of steps the upstream can reproduce to see the issue locally. I've installed Phabricator dozens of times on various platforms and never needed this command.

Jun 22 2017, 8:23 AM · Documentation
swanshonknice created T12864: Notifications User Guide: Setup and Configuration needs npm init.
Jun 22 2017, 8:04 AM · Documentation
chad renamed T12859: Some means of updating builtin images without a manual purge from Some means of purging/updating builtin images to Some means of updating builtin images without a manual purge.
Jun 22 2017, 7:13 AM · Design
chad added a comment to T12863: adasdasdasdasd.

nyancat

Jun 22 2017, 7:12 AM · Feature Request (Needs Information), Bug Report
avivey closed T12863: adasdasdasdasd as Spite.
Jun 22 2017, 6:46 AM · Feature Request (Needs Information), Bug Report
utsav.kakadiya created T12863: adasdasdasdasd.
Jun 22 2017, 6:27 AM · Feature Request (Needs Information), Bug Report

Jun 21 2017

eugeneegbe created P2061 Diff of Wikispeech lexicon project changes to check for value in $currentUtterrance .
Jun 21 2017, 11:06 PM · Diffusion
chad added a comment to T12859: Some means of updating builtin images without a manual purge.

So simple

Jun 21 2017, 8:24 PM · Design
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.
$engine = new PhabricatorDestructionEngine();
$engine->destroyObject($file);
Jun 21 2017, 8:13 PM · Design
chad added a revision to T12859: Some means of updating builtin images without a manual purge: Unknown Object (Differential Revision).
Jun 21 2017, 8:07 PM · Design
chad added a comment to T12859: Some means of updating builtin images without a manual purge.
In T12859#227762, @chad wrote:

image.png (288×1 px, 47 KB)

Jun 21 2017, 7:54 PM · Design
amckinley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

I think we should have our crontabs in version control regardless of whether or not we add tmpreaper to them, so I'll make a task for that.

Jun 21 2017, 7:26 PM · Diffusion, Ops, Daemons, Phacility
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Also not sure how to "retire" ones from Projects I don't intend to replace (low value).

Jun 21 2017, 6:57 PM · Design
chad added a comment to T12859: Some means of updating builtin images without a manual purge.

image.png (288×1 px, 47 KB)

Jun 21 2017, 6:45 PM · Design
chad added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Just to clarify, Phacility is the paid hosted version of Phabricator. If you installed Phabricator locally, we cannot help you with this request via Phacility. You'll need to follow Support Resources for your self-hosted installation.

Jun 21 2017, 6:35 PM · Phacility, Feature Request
epriestley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

If you want to move forward with that:

Jun 21 2017, 6:35 PM · Diffusion, Ops, Daemons, Phacility
epriestley added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Great! Please mail support at support@phacility.com and identify which instance you're paying us for, then we're happy to help you. We won't help you here, since this isn't the right way for customers to get support.

Jun 21 2017, 6:27 PM · Phacility, Feature Request
amckinley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

This should do the trick. It runs off atime by default. We could just set the time period to several days if we wanted to. Alternatively, if the filenames for extremely long-running jobs are predictable, there's a --protect '<shell_pattern>' argument we could use to avoid cleaning up those files.

Jun 21 2017, 6:04 PM · Diffusion, Ops, Daemons, Phacility
epriestley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

Every repo host is equally affected, so I'd like to deploy crontabs as part of the regular deployment process if we use them as part of the approach here. That would require first codifying a handful of custom crontabs, including one on secure which regenerates documentation daily on only one host. This codification should happen anyway eventually, but it's a little bit of work, and wasted effort if we're switching to Chef/Salt/Ansible/etc soon anyway.

Jun 21 2017, 5:57 PM · Diffusion, Ops, Daemons, Phacility
sencho added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Yes,we are Phacility customer And I deployed it on a Ubuntu server,Thank you.

Jun 21 2017, 5:42 PM · Phacility, Feature Request
amckinley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

Should we just add a crontab entry to clean /tmp to paper this over until we get it fixed for real?

Jun 21 2017, 5:27 PM · Diffusion, Ops, Daemons, Phacility
epriestley merged T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Restricted Project, Diffusion, Feature Request
epriestley merged task T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Diffusion, Feature Request
epriestley closed T12861: How to intergrate Infer's analysis result into Phabricator? as Invalid.

If you're a Phacility customer, please mail support at support@phacility.com (and identify your instance).

Jun 21 2017, 5:22 PM · Phacility, Feature Request
bhchandra added a project to T12862: Diffusion: change to a flat project structure view: Diffusion.
Jun 21 2017, 5:18 PM · Diffusion, Feature Request
sencho added a project to T12861: How to intergrate Infer's analysis result into Phabricator?: Phacility.
Jun 21 2017, 5:17 PM · Phacility, Feature Request
bhchandra created T12862: Diffusion: change to a flat project structure view.
Jun 21 2017, 5:17 PM · Diffusion, Feature Request
sencho created T12861: How to intergrate Infer's analysis result into Phabricator?.
Jun 21 2017, 5:15 PM · Phacility, Feature Request
epriestley added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

Why is git diff --no-index being used instead of and diff, and why is --no-prefix being used?

Jun 21 2017, 4:59 PM · Arcanist, Bug Report
Pawka added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

@epriestley git diff --no-index --no-prefix -U2000 $old_file_path $new_file_path

Jun 21 2017, 4:51 PM · Arcanist, Bug Report
• tomekj2ee awarded T7924: Unprototype Calendar (v1) a Love token.
Jun 21 2017, 4:14 PM · Restricted Project, Prioritized, Calendar
ivo created T12860: Search by tag does not work in Phriction.
Jun 21 2017, 12:47 PM · Phriction, Bug Report
chad created T12859: Some means of updating builtin images without a manual purge.
Jun 21 2017, 12:36 PM · Design
chad renamed T4: Phabricator should send emails no matter who the actor is from test to Phabricator should send emails no matter who the actor is.
Jun 21 2017, 12:27 PM
• divo renamed T4: Phabricator should send emails no matter who the actor is from Phabricator should send emails no matter who the actor is to test.
Jun 21 2017, 12:08 PM