Page MenuHomePhabricator
Feed Advanced Search

Feb 28 2017

chad added a comment to T10319: Generate unique? profile images for each new user.

I'm going to get this to being able to build a real file, and hand it over unless you think the rest is trivial. Not sure how this would need to work in the NUX case. Generate an image when PhabricatorUser is triggered? What about old defaults?

Feb 28 2017, 2:18 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

crc32 would be fine in this use case too since the requirements are so lax. My version isn't particularly robust either, but should get the job done.

Feb 28 2017, 2:16 AM · Feature Request, People
gregprice added a project to T12328: "Watching Projects" doc section seems wrong: Restricted Project.
Feb 28 2017, 2:08 AM · Restricted Project, Documentation, Bug Report
gregprice created T12328: "Watching Projects" doc section seems wrong.
Feb 28 2017, 2:08 AM · Restricted Project, Documentation, Bug Report
20after4 awarded T12314: Support formal task subtypes (like "bug" vs "feature") a Love token.
Feb 28 2017, 1:59 AM · EditEngine, Maniphest, Custom Fields, Feature Request
chad added a comment to T10319: Generate unique? profile images for each new user.

Works great!

Feb 28 2017, 1:59 AM · Feature Request, People
20after4 added a comment to T12326: Long tag names can break out of hovercards.

This actually seems a little difficult to fix...maybe just make it truncate with an ellipsis?

Feb 28 2017, 1:47 AM · Bug Report, Hovercards, PHUI
20after4 added a comment to T12326: Long tag names can break out of hovercards.

heh nice. And I didn't even have to cheat by using U+00A0.

Feb 28 2017, 1:41 AM · Bug Report, Hovercards, PHUI
chad added a comment to T10319: Generate unique? profile images for each new user.

Oh is crc32 bad?

Feb 28 2017, 1:10 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.
diff --git a/src/infrastructure/util/PhabricatorHash.php b/src/infrastructure/util/PhabricatorHash.php
index 00d7cca63c..5dfbbe2617 100644
--- a/src/infrastructure/util/PhabricatorHash.php
+++ b/src/infrastructure/util/PhabricatorHash.php
@@ -78,6 +78,22 @@ final class PhabricatorHash extends Phobject {
     return $result;
   }
Feb 28 2017, 1:08 AM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

Actually, may have found something on "the google". bbs

Feb 28 2017, 12:28 AM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

Since I'm not a real programmer, getting stuck on how to assign something by username. I presume we want every chad to get the same pre-built avatar if possible. I could just randomize it, but that seems not really beneficial.

Feb 28 2017, 12:26 AM · Feature Request, People
epriestley merged T12327: ArcanistPuppetLintLinter doesn't work with puppet-lint 2.1.0 or later into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Feb 28 2017, 12:06 AM · Lint, Arcanist
epriestley merged task T12327: ArcanistPuppetLintLinter doesn't work with puppet-lint 2.1.0 or later into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Feb 28 2017, 12:06 AM · Bug Report

Feb 27 2017

chrisbolt created T12327: ArcanistPuppetLintLinter doesn't work with puppet-lint 2.1.0 or later.
Feb 27 2017, 11:58 PM · Bug Report
chad added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Yeah, that's a reasonable starting point. I'm sure noone has 99+ task edit forms..... ⛈

Feb 27 2017, 11:40 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

And the pencil icon on workboards, the pencil icon on the list view, and the "Edit Task" action from task detail pages would default to "Edit Plant Task", yeah. The workboard change would only pertain to creating new tasks directly on a workboard.

Feb 27 2017, 11:38 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Right now, this menu always says "Create Task..."

Feb 27 2017, 11:37 PM · EditEngine, Maniphest, Custom Fields, Feature Request
chad added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

For now, we either don't change workboards or just put all the global options into the menu, probably?

Feb 27 2017, 11:32 PM · EditEngine, Maniphest, Custom Fields, Feature Request
chad updated subscribers of T12326: Long tag names can break out of hovercards.

@20after4 😆

Feb 27 2017, 11:15 PM · Bug Report, Hovercards, PHUI
chad created T12326: Long tag names can break out of hovercards.
Feb 27 2017, 11:15 PM · Bug Report, Hovercards, PHUI
epriestley removed reviewers for D17414: Test: Blessed Reviewers, • dbansal-snk.
Feb 27 2017, 10:14 PM
epriestley closed T12319: Investigate an Owners-related performance issue on revision detail pages as Resolved.

Calling this resolved since the page is now tolerably bad (~5s) which more or less pulls this out of the realm of critical scaling issues.

Feb 27 2017, 9:46 PM · Owners, Differential, Performance
chad renamed T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...' from Dashboards that contain a restricted panels have all query panels stuck in 'Loading...' to Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.
Feb 27 2017, 9:34 PM · Dashboards, Bug Report
chad renamed T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...' from Dashboards that contain a PhabricatorSearchApplicationSearchEngine panel have all query panels stuck in 'Loading...' to Dashboards that contain a restricted panels have all query panels stuck in 'Loading...'.
Feb 27 2017, 9:34 PM · Dashboards, Bug Report
epriestley renamed T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension from Allow to control units shown in countdowns to Dynamically adjust the display precision of countdowns to increase dramatic tension.
Feb 27 2017, 9:28 PM · Customer Impact, Countdown, Feature Request
chad added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

I added the panel back as an option. I'll leave this open until we see if anyone else hits a similar case.

Feb 27 2017, 9:12 PM · Dashboards, Bug Report
ivo added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Feed shows stuff that is happening to items with a certain tag. We want to list the items themselves, not what is happening to them.

Feb 27 2017, 9:02 PM · Dashboards, Bug Report
chad added a revision to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...': Unknown Object (Differential Revision).
Feb 27 2017, 8:41 PM · Dashboards, Bug Report
chad added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Instead of Feed?

Feb 27 2017, 8:37 PM · Dashboards, Bug Report
swisspol added a comment to T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension.

I like that, sounds like a very good compromise.

Feb 27 2017, 8:35 PM · Customer Impact, Countdown, Feature Request
ivo added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Yes, we were using the panel to show all items (tasks, revisions, wiki pages, et cetera) tagged with a certain tag.

Feb 27 2017, 8:29 PM · Dashboards, Bug Report
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 8:11 PM · Owners, Differential, Performance
epriestley added a comment to T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension.
  • If the date is a day or more in the future, show days + hours + minutes.
    • If the date is an hour or more in the future, show hours + minutes + seconds.
    • Otherwise, show minutes + seconds with THRILLING TENTHS OF A SECOND.
Feb 27 2017, 8:05 PM · Customer Impact, Countdown, Feature Request
swisspol created T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension.
Feb 27 2017, 8:01 PM · Customer Impact, Countdown, Feature Request
chad added a comment to T10319: Generate unique? profile images for each new user.

Ok, first part is checked in and seems reasonable. https://secure.phabricator.com/uiexample/view/PhabricatorFilesComposeAvatarExample/

Feb 27 2017, 7:30 PM · Feature Request, People
epriestley added a member for Community: jmeador.
Feb 27 2017, 7:27 PM
epriestley closed T12323: Revisions show in Other Revisions when acceptance status is unclear as Resolved by committing Restricted Diffusion Commit.
Feb 27 2017, 6:47 PM · KDE, Differential, Bug Report
epriestley closed T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit as Resolved by committing Restricted Diffusion Commit.
Feb 27 2017, 6:47 PM · Audit, KDE
epriestley closed T12316: Phacility Deploy Log 2017 Week 8, a subtask of T12217: Reduce the hardware cost of Phacility free instances, as Resolved.
Feb 27 2017, 6:46 PM · Ops, Phacility
epriestley closed T12316: Phacility Deploy Log 2017 Week 8 as Resolved.
Feb 27 2017, 6:46 PM · Phacility, Ops
epriestley closed T12321: Create Task form not Editable. as Invalid.

This does not describe a bug in Phabricator. I've reviewed the documentation and believe it is already sufficiently clear in describing how to accomplish what you're trying to accomplish. Particularly, I don't see anything in the documentation which is misleading, or suggests that the workflow you're using is the correct way to accomplish your goal -- it isn't, and the documentation describes the correct workflow. See Support Resources for other support resources.

Feb 27 2017, 6:45 PM · Bug Report
epriestley added a revision to T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit: Unknown Object (Differential Revision).
Feb 27 2017, 6:35 PM · Audit, KDE
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

(They could also go into the existing "Waiting on Review" bucket, but I dislike mixing authored and non-authored revisions in that bucket.)

Feb 27 2017, 6:18 PM · KDE, Differential, Bug Report
epriestley added a revision to T12323: Revisions show in Other Revisions when acceptance status is unclear: Unknown Object (Differential Revision).
Feb 27 2017, 6:17 PM · KDE, Differential, Bug Report
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

The actual reproduction instructions are slightly more involved:

Feb 27 2017, 6:14 PM · KDE, Differential, Bug Report
chad added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

I can make a fix so this doesn't fail and grandfather these in if they were in use, but I'd also like to know if people are using these as panels, so I can revert that change if needed.

Feb 27 2017, 6:13 PM · Dashboards, Bug Report
chad added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Is that a panel you were using?

Feb 27 2017, 6:12 PM · Dashboards, Bug Report
ivo added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Reading through the diff you mention (D17341 I think?) I see that the query type was probably called "Fulltext Results". Basically the query panel version of this page: https://secure.phabricator.com/search/query/advanced/

Feb 27 2017, 6:05 PM · Dashboards, Bug Report
20after4 added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

For wikimedia's "scap" tool we built a feature called "checks" which are configurable commands that run on each target machine and confirm if the desired commands were successful.

Feb 27 2017, 6:00 PM · Ops, Phacility
chad added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Specifically, "Wiki Documents" and "Legalpad Documents" both still are available, but "Documentation Atoms" from Diviner are not.

Feb 27 2017, 5:59 PM · Dashboards, Bug Report
chad added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Can you clarify the steps to reproduce please? I don't know what "Documents" query type is, even reading through the diff that restricted useless panel types.

Feb 27 2017, 5:58 PM · Dashboards, Bug Report
ivo created T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.
Feb 27 2017, 5:53 PM · Dashboards, Bug Report
20after4 added a comment to T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit.

This is something I've wished for a few times. Along with just searching for repositories in general.

Feb 27 2017, 5:30 PM · Audit, KDE
20after4 awarded T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit a Love token.
Feb 27 2017, 5:30 PM · Audit, KDE
20after4 awarded T10319: Generate unique? profile images for each new user a Love token.
Feb 27 2017, 5:29 PM · Feature Request, People
epriestley added a comment to T12319: Investigate an Owners-related performance issue on revision detail pages.

@jmeador, I believe this is now resolved at HEAD. Let us know if you're still seeing issues after upgrading?

Feb 27 2017, 5:13 PM · Owners, Differential, Performance
chad added a comment to T12270: Unbeta Badges.

thedude

Feb 27 2017, 4:30 PM · Badges (v0)
epriestley added a comment to T12270: Unbeta Badges.

After D17422, I used bin/lipsum to generate about 20,000 badges. (They all have USERS permission so the permission checks are about as fast as possible.)

Feb 27 2017, 4:10 PM · Badges (v0)
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 4:05 PM · Owners, Differential, Performance
chad added Q574: How to add large files into Phabricator? (Answer 515).
Feb 27 2017, 3:52 PM
remusvrm updated Q574: How to add large files into Phabricator? from to How to add large files into Phabricator?.
Feb 27 2017, 3:47 PM · Files
epriestley added a comment to T12319: Investigate an Owners-related performance issue on revision detail pages.

After implementing PHP7 support for XHProf and updating Lipsum, I used bin/lipsum to generate 4,000 packages owning 150,000 paths. I think I have an approximately-reasonable reproduction case locally now, which generates this profile (6.5s for a change affecting about 100 files):

Feb 27 2017, 3:47 PM · Owners, Differential, Performance
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 3:39 PM · Owners, Differential, Performance
chad changed the image for Image Macro "thedude".
Feb 27 2017, 3:38 PM
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

I did the last deploy (T12316) with Phage again and things went much more smoothly after the various bugfixes and improvements.

Feb 27 2017, 3:10 PM · Ops, Phacility
epriestley added a comment to T5508: Add branch name parameter to Harbormaster "Make HTTP Request" build step.

See Planning for information on timelines and priorities.

Feb 27 2017, 2:25 PM · Restricted Project, Harbormaster
scweang added a comment to T5508: Add branch name parameter to Harbormaster "Make HTTP Request" build step.

I'm using phabricator to do continuously integeration. I need to judge which branch is updated when jenkins receives the http request.

Feb 27 2017, 2:21 PM · Restricted Project, Harbormaster
epriestley added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Feb 27 2017, 1:18 PM · Badges (v0)
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 1:18 PM · Owners, Differential, Performance
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 1:14 PM · Owners, Differential, Performance
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 12:20 PM · Owners, Differential, Performance
• coleenmctrevs added a comment to T6479: Manual account creation without Username+Password auth unclear to users and administrators.
Feb 27 2017, 12:17 PM · LDAP, Auth
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 12:06 PM · Owners, Differential, Performance
remusvrm added a comment to T10293: Plan rest of "CoverImage" feature.

The funny thing is that event if I remove the file from Files, the coverage image in the Maniphest is still there. :)

Feb 27 2017, 9:17 AM · Workboards, Projects (v3)
pouyana added a comment to T12002: Set header for CURL query for the Notification server status to HTTP:Upgrade = websocket.

@jmeador I tried your suggested configuration. The system works, but the server/config/cluster/notifications/ gives the following error instead:

Feb 27 2017, 8:15 AM · Bug Report
siepkes awarded T550: Build an SSH conduit client a Like token.
Feb 27 2017, 8:08 AM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
chad added a revision to T10319: Generate unique? profile images for each new user: Unknown Object (Differential Revision).
Feb 27 2017, 4:40 AM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

pasted_file (1×1 px, 328 KB)

Feb 27 2017, 3:12 AM · Feature Request, People

Feb 26 2017

epriestley added a comment to T9805: XHProf will not build on PHP7.

I have a build of this that technically works now (produces profiles, passes tests, does not segfault when gently poked). It's still extremely really rough so I don't know when I'll clean it up enough to push upstream.

Feb 26 2017, 11:45 PM · XHProf
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Sorry, yes I am bad cop sometimes. :(

Feb 26 2017, 11:01 PM · KDE, Differential, Bug Report
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

@bcooksley, feel free to mention that you've talked with me about stuff when filing tasks in the future. Like 90% of what shows up here spontaneously is pretty questionable, so unannounced reports get fairly strict scrutiny.

Feb 26 2017, 11:00 PM · KDE, Differential, Bug Report
epriestley added a project to T12323: Revisions show in Other Revisions when acceptance status is unclear: KDE.

Here's the downstream task: https://phabricator.kde.org/T5406

Feb 26 2017, 10:58 PM · KDE, Differential, Bug Report
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Note that these steps depend on who is viewing the page (or, specifically, who "Responsible Users" are). More concise steps are likely:

Feb 26 2017, 10:58 PM · KDE, Differential, Bug Report
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

T9372 is the main "Differential Buckets" task.

Feb 26 2017, 10:28 PM · KDE, Differential, Bug Report
chad updated subscribers of T12323: Revisions show in Other Revisions when acceptance status is unclear.

My assumption reading through docs and tasks is that "Other" means... well, other. It's been both accepted and rejected and I think it's important to convey it's not completely in one or the other state. If you set sticky-accept to false, then it will always go back for review. Maybe @epriestley has other thoughts. I would swear this came up recently though, but I can't find an absolute duplicate task.

Feb 26 2017, 10:26 PM · KDE, Differential, Bug Report
bcooksley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Yes, sticky-accept is True.

Feb 26 2017, 10:21 PM · KDE, Differential, Bug Report
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Is sticky-accept still set to true then? (I think that's the default).

Feb 26 2017, 10:19 PM · KDE, Differential, Bug Report
bcooksley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

I've now added reproduction steps, including details on customised settings for the Differential application.

Feb 26 2017, 10:17 PM · KDE, Differential, Bug Report
bcooksley updated the task description for T12323: Revisions show in Other Revisions when acceptance status is unclear.
Feb 26 2017, 10:16 PM · KDE, Differential, Bug Report
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Well that's my mistake then! I didn't see it initially.

Feb 26 2017, 10:10 PM · KDE, Differential, Bug Report
bcooksley updated the task description for T12323: Revisions show in Other Revisions when acceptance status is unclear.
Feb 26 2017, 10:10 PM · KDE, Differential, Bug Report
bcooksley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Sorry, you'll need to provide more detail on what's wrong than repeating your comment. I added the version information to the Task Description.

Feb 26 2017, 10:07 PM · KDE, Differential, Bug Report
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Also, we need steps to reproduce. the issue locally. There are setting that affect where revisions go after acceptance. I don't know what your install has those set to.

Feb 26 2017, 10:06 PM · KDE, Differential, Bug Report
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.
In T12323#213451, @chad wrote:

We need version information on all bug reports.

Feb 26 2017, 10:04 PM · KDE, Differential, Bug Report
bcooksley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

This report is against Differential.

Feb 26 2017, 10:00 PM · KDE, Differential, Bug Report
bcooksley updated the task description for T12323: Revisions show in Other Revisions when acceptance status is unclear.
Feb 26 2017, 9:59 PM · KDE, Differential, Bug Report
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

You also mention "raised the concern". Is this report against Audit or Differential?

Feb 26 2017, 9:56 PM · KDE, Differential, Bug Report
chad added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

We need version information on all bug reports.

Feb 26 2017, 9:55 PM · KDE, Differential, Bug Report
bcooksley created T12323: Revisions show in Other Revisions when acceptance status is unclear.
Feb 26 2017, 9:23 PM · KDE, Differential, Bug Report