Page MenuHomePhabricator
Feed Advanced Search

May 23 2019

epriestley edited projects for T9825: Remarkup is rendered literally in Diviner, added: Diviner; removed Remarkup.
May 23 2019, 2:45 PM · Diviner

Dec 17 2018

epriestley renamed T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing] from User documentation on "secure" is occasionally unpublishing to Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
Dec 17 2018, 3:45 PM · Diviner

Oct 31 2018

epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The immediate issue now appears fixed and it seems likely that the root cause is also fixed. We should still hunt down the bad cache behavior in the presence of wonky permissions.

Oct 31 2018, 3:42 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

This cropped up again and the permissions error also resurfaced, even though I previously nuked the directory.

Oct 31 2018, 3:21 PM · Diviner

Oct 5 2018

epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

For now, I just hard-wiped the cache and regenerated the documentation again. ¯\_(ツ)_/¯

Oct 5 2018, 4:15 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The file cache says that these files have already been parsed and contain no atoms, so the rest of the program behavior is expected after that. I'm not sure how this state came to exist.

Oct 5 2018, 4:03 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
  • DivinerPublisher->publishAtoms() is being passed nothing, so it's correctly deleting everything.
  • The graph cache is empty.
  • The actual atom.cache file on disk is empty.
  • The input to the cache is empty.
  • The files aren't being passed to the atomizer rules (although the rules appear to be applying correctly).
Oct 5 2018, 3:36 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

So, so far it looks like the database is in a "good" state but the publish workflow incorrectly deleted all the articles. From previous efforts, I believe dropping the cache fixes this issue.

Oct 5 2018, 3:26 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

But note that the graphHash and nodeHash columns are 0, which I believe is a signal that these nodes have been deleted (I haven't touched this code in a while).

Oct 5 2018, 3:21 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

Oh, the contrib stuff got separated into a different book and has fully unpublished:

Oct 5 2018, 1:27 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The "Contributor Introduction" document, specifically, seems to have unpublished. Let me see what I can dig up about the current database state.

Oct 5 2018, 1:14 PM · Diviner

Sep 27 2018

epriestley triaged T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing] as Normal priority.
Sep 27 2018, 1:01 PM · Diviner

Jan 26 2018

epriestley added a comment to T8533: Allow Diviner to fall back to (or link directly to) the Symbol index.

I think a reasonable path forward here is for Diviner to have a {symbol} sort of syntax which executes a symbol index query. The symbol index can already be configured to know how to offer links to external documentation.

Jan 26 2018, 3:14 PM · Restricted Project, Symbols, Diviner
epriestley renamed T8533: Allow Diviner to fall back to (or link directly to) the Symbol index from Allow linking to external documentation to Allow Diviner to fall back to (or link directly to) the Symbol index.
Jan 26 2018, 3:07 PM · Restricted Project, Symbols, Diviner

Jan 24 2018

epriestley closed T8536: Merge symbols and Diviner, a subtask of T4558: Make Diviner useful for third-parties, as Wontfix.
Jan 24 2018, 4:42 PM · Diviner
epriestley closed T8536: Merge symbols and Diviner as Wontfix.

Per above, I think the pathway forward here is probably "tighter integration", not "merge/replace", i.e. tools for Diviner to automatically update Symbols, too. I'm just going to conceptually roll this up into T13047.

Jan 24 2018, 4:41 PM · Symbols, Diviner
epriestley closed T8536: Merge symbols and Diviner, a subtask of T8533: Allow Diviner to fall back to (or link directly to) the Symbol index, as Wontfix.
Jan 24 2018, 4:41 PM · Restricted Project, Symbols, Diviner
epriestley added a parent task for T8536: Merge symbols and Diviner: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:25 PM · Symbols, Diviner

Aug 24 2017

chad added a comment to T823: Add image support to Diviner.

Embedding files by alias might be useful

Aug 24 2017, 2:59 PM · Diviner
chad added a comment to T823: Add image support to Diviner.

Oh I see the problem with that

Aug 24 2017, 2:58 PM · Diviner
chad added a comment to T823: Add image support to Diviner.

I've been locally previewing in Phriction.

Aug 24 2017, 2:22 PM · Diviner
epriestley added a comment to T823: Add image support to Diviner.

I'd guess it's several days of work.

Aug 24 2017, 2:21 PM · Diviner
chad added a comment to T823: Add image support to Diviner.

Is this hard to do? Can me accomplish?

Aug 24 2017, 1:55 PM · Diviner

Jul 9 2017

chad set the image for Diviner to F5039273: profile.
Jul 9 2017, 7:32 PM

Apr 25 2017

chad closed T12637: ToC button icon in Diviner and Phriction isn't centered? as Resolved by committing rP279816683b17: Move ToC 4px in documentproview.
Apr 25 2017, 5:50 PM · Phriction, Diviner, Design
chad added a revision to T12637: ToC button icon in Diviner and Phriction isn't centered?: D17790: Move ToC 4px in documentproview.
Apr 25 2017, 5:48 PM · Phriction, Diviner, Design

Apr 24 2017

epriestley created T12637: ToC button icon in Diviner and Phriction isn't centered?.
Apr 24 2017, 4:29 PM · Phriction, Diviner, Design

Apr 7 2017

arielyang updated Q607: How to set help link of self-host Phabricator to local url. from to How to set help link of self-host Phabricator to local url..
Apr 7 2017, 3:08 AM · Diviner

Feb 14 2017

faulconbridge added a comment to T12258: Diviner atom document status inverted when searching.

+1 for random grepping. Thanks for the fix!

Feb 14 2017, 1:00 PM · Diviner, Bug Report
epriestley added a comment to T12258: Diviner atom document status inverted when searching.

(Your diagnosis of the root cause was also correct.)

Feb 14 2017, 12:05 PM · Diviner, Bug Report
epriestley added a comment to T12258: Diviner atom document status inverted when searching.

I deployed D17346 and rebuilt the indexes on this install with bin/search index --type DivinerLiveSymbol and behavior now seems correct. Thanks for the report!

Feb 14 2017, 12:05 PM · Diviner, Bug Report

Feb 13 2017

epriestley closed T12258: Diviner atom document status inverted when searching as Resolved by committing rP6f37685a7589: Fix flipped open/closed status for Diviner atoms in search index.
Feb 13 2017, 9:12 PM · Diviner, Bug Report
epriestley added a project to T12258: Diviner atom document status inverted when searching: Diviner.
Feb 13 2017, 9:08 PM · Diviner, Bug Report

Dec 14 2016

epriestley closed T12015: Unable to resolve method 'describeAutomaticCapability'. as Resolved by committing rPae0e97a49974: Remove unusual explicit calls to policy capability descriptions from Diviner.
Dec 14 2016, 7:23 PM · Diviner, Bug Report
epriestley added a revision to T12015: Unable to resolve method 'describeAutomaticCapability'.: D17056: Remove unusual explicit calls to policy capability descriptions from Diviner.
Dec 14 2016, 7:04 PM · Diviner, Bug Report
epriestley added a comment to T12015: Unable to resolve method 'describeAutomaticCapability'..

I think the major intent was being able to edit "View Policy" so you could create private documentation, but I don't recall if we got that far.

Dec 14 2016, 7:00 PM · Diviner, Bug Report
chad added a comment to T12015: Unable to resolve method 'describeAutomaticCapability'..

You could tag a project I think, but not sure what that actually did.

Dec 14 2016, 6:18 PM · Diviner, Bug Report
avivey added a project to T12015: Unable to resolve method 'describeAutomaticCapability'.: Diviner.

Basically nobody is using Diviner, and I don't think the "Edit Book" page actually does anything useful.

Dec 14 2016, 6:00 PM · Diviner, Bug Report

Aug 5 2016

eadler added a project to T8533: Allow Diviner to fall back to (or link directly to) the Symbol index: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Symbols, Diviner

Jul 22 2016

lewellyn added a comment to T9042: Diviner fails to create all books, path is error.

I see the same behavior noted by @lianghu in T9042#129510.

Jul 22 2016, 5:15 AM · Diviner

May 12 2016

epriestley closed T10958: Dead Link at Diviner as Resolved by committing rP0faf3dd18d73: Fix "Contributing" misspelling in documentation.
May 12 2016, 3:30 PM · Documentation, Diviner, Bug Report
epriestley added a comment to T10958: Dead Link at Diviner.

Thanks!

May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley claimed T10958: Dead Link at Diviner.
May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley added a revision to T10958: Dead Link at Diviner: D15898: Fix "Contributing" misspelling in documentation.
May 12 2016, 3:19 PM · Documentation, Diviner, Bug Report
Luke081515.2 created T10958: Dead Link at Diviner.
May 12 2016, 2:16 PM · Documentation, Diviner, Bug Report

Mar 18 2016

epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

This is probably very easy to fix, let me spend 3 seconds on it.

Mar 18 2016, 10:49 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Yes, Phurl provides URL shortening. U10 is the root object providing ((prototype)).

Mar 18 2016, 10:48 PM · Phurl, Bug Report
chad added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Yeaaah, I would assume this worked for free with Remarkup, but I guess not. Yeah it's Phurl,

Mar 18 2016, 10:48 PM · Phurl, Bug Report
Krenair added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

So this actually in Phurl (not clear from the link) and not valid itself because Phurl is a prototype?

Mar 18 2016, 10:43 PM · Phurl, Bug Report
chad added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Phurl is a prototype, too.

Mar 18 2016, 10:41 PM · Phurl, Bug Report
Krenair created T10625: Links like "((prototype))" are not expanded properly in email.
Mar 18 2016, 10:40 PM · Phurl, Bug Report

Dec 14 2015

epriestley merged task T6310: Parameters description is not Remarkuped into T9825: Remarkup is rendered literally in Diviner.
Dec 14 2015, 7:00 PM · Remarkup, Diviner

Nov 2 2015

Mnkras added a comment to T9683: Support `@throws` annotation.

+1, especially with all the new types in PHP7 this would be awesome.

Nov 2 2015, 2:14 AM · Diviner
joshuaspence created T9683: Support `@throws` annotation.
Nov 2 2015, 1:57 AM · Diviner

Oct 29 2015

joshuaspence created T9664: Inherit documentation for built-in classes.
Oct 29 2015, 3:09 AM · Diviner

Oct 27 2015

chad closed Q195: Problem with creating a new book at diviner as invalid.
Oct 27 2015, 8:23 PM · Diviner
Luke081515.2 updated Q195: Problem with creating a new book at diviner from to Problem with creating a new book at diviner.
Oct 27 2015, 12:26 AM · Diviner

Oct 19 2015

epriestley placed T9171: old maniphest_custom docs hang around, posisble confusing googlers up for grabs.

Ugh, it's too hacky. I'm just going to put a manual redirect in place for now instead.

Oct 19 2015, 6:28 PM · Diviner
epriestley claimed T9171: old maniphest_custom docs hang around, posisble confusing googlers.

I'm just going to put a redirect map in the book for now. This isn't a great long-term solution but I want to move forward on D13941 in some form.

Oct 19 2015, 6:24 PM · Diviner

Aug 24 2015

FvD added a comment to T4558: Make Diviner useful for third-parties.

To add to the comment of @cburroughs above, it would be useful to cater to existing workflows.

Aug 24 2015, 4:50 PM · Diviner

Aug 21 2015

joshuaspence claimed T9171: old maniphest_custom docs hang around, posisble confusing googlers.
Aug 21 2015, 11:32 AM · Diviner

Aug 18 2015

epriestley added a comment to T9171: old maniphest_custom docs hang around, posisble confusing googlers.

In this case, we should maybe have a way to put a redirect in Diviner, since this atom has legitimately moved here:

Aug 18 2015, 6:10 PM · Diviner

Aug 15 2015

epriestley closed T9193: DivinerGenerateWorkflow::getDivinerAtomWorldVersion has wrong behavior after ClassMapQuery change as Resolved by committing rP8692f4857bed: Fix an issue with ClassMap handling of DivinerAtomizers.
Aug 15 2015, 1:59 PM · Diviner, Phacility
epriestley created T9193: DivinerGenerateWorkflow::getDivinerAtomWorldVersion has wrong behavior after ClassMapQuery change.
Aug 15 2015, 1:54 PM · Diviner, Phacility

Aug 13 2015

joshuaspence added a comment to T9171: old maniphest_custom docs hang around, posisble confusing googlers.

I guess that we should return a 404 (or even 410)

Aug 13 2015, 9:14 PM · Diviner
chad added a project to T9171: old maniphest_custom docs hang around, posisble confusing googlers: Diviner.
Aug 13 2015, 7:35 PM · Diviner

Aug 12 2015

joshuaspence added a comment to T8311: Allow Diviner to import documentation.

Yeah. I will probably end up just writing my own NodeJS script to parse and interpret the CSS documentation.

Aug 12 2015, 10:33 PM · Diviner
epriestley added a comment to T8311: Allow Diviner to import documentation.

That looks like it could be pretty complicated to do safely.

Aug 12 2015, 10:32 PM · Diviner
joshuaspence added a comment to T8311: Allow Diviner to import documentation.

Ah yeah, I'm not really talking about HTML within the comments themselves (although I'm sure we will have to deal with that as well). Specifically, this is the tool that has I have been referred to: https://github.com/kss-node/kss-node

Aug 12 2015, 10:23 PM · Diviner
epriestley added a comment to T8311: Allow Diviner to import documentation.

Ah, interesting. The cases I'm familiar with are Javadoc, like this lovely example from Oracle:

Aug 12 2015, 10:22 PM · Diviner
joshuaspence added a comment to T8311: Allow Diviner to import documentation.

Yeah, agreed on avoiding it if possible. I just got asked about CSS documentation which I have no idea about but there are existing tools which spit out HTML. I will look into what would be involved to parse the HTML.

Aug 12 2015, 10:18 PM · Diviner
epriestley added a comment to T8311: Allow Diviner to import documentation.

My guess is that we can satisfy this by parsing a small, safe subset of HTML (bold, italics, tt, links).

Aug 12 2015, 10:17 PM · Diviner
joshuaspence added a comment to T8311: Allow Diviner to import documentation.

What about the ability to publish arbitrary HTML into Diviner? This is not ideal, but it means that any documentation system can be integrated.

Aug 12 2015, 10:13 PM · Diviner

Aug 10 2015

epriestley closed T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock as Resolved.

I don't think there's anything specifically actionable here. If your build server has direct access to the Phabricator database (it never should) I think we get this for free as soon as "lease host + build working copy + run command" is reliable.

Aug 10 2015, 2:24 PM · Harbormaster, Diviner
epriestley closed T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock, a subtask of T4558: Make Diviner useful for third-parties, as Resolved.
Aug 10 2015, 2:24 PM · Diviner

Aug 3 2015

chad added a project to T9042: Diviner fails to create all books, path is error: Diviner.
Aug 3 2015, 4:30 PM · Diviner

Jul 23 2015

joshuaspence claimed T8555: Fix static publishing for Diviner.
Jul 23 2015, 9:01 AM · Diviner
joshuaspence claimed T8711: Allow Diviner paths to be specify as includes rather than excludes.
Jul 23 2015, 8:51 AM · Diviner

Jul 21 2015

Judge closed T8899: Add upstream Diviner and Phriction content to Phabricator default install as Resolved.

Great, thank you! :)

Jul 21 2015, 8:43 AM · Documentation, Phriction, Diviner

Jul 20 2015

epriestley added a comment to T8899: Add upstream Diviner and Phriction content to Phabricator default install.

We aren't going to ship with the Phriction content.

Jul 20 2015, 11:47 AM · Documentation, Phriction, Diviner
Judge created T8899: Add upstream Diviner and Phriction content to Phabricator default install.
Jul 20 2015, 10:54 AM · Documentation, Phriction, Diviner

Jul 16 2015

epriestley renamed T8667: Don't index Diviner sub-atoms in global search from Search should allow "Not" functions when selecting document types to Don't index Diviner sub-atoms in global search.
Jul 16 2015, 3:25 PM · Diviner

Jul 3 2015

epriestley closed T8618: Symbol collision in Diviner publisher as Resolved.

Seems fixed.

Jul 3 2015, 4:22 PM · Diviner
chad changed the visibility for T2284: Make Diviner namespace aware.
Jul 3 2015, 4:19 AM · Documentation, Diviner
chad changed the visibility for T1089: Use information from assert_instances_of() in generated documentation.
Jul 3 2015, 4:19 AM · Diviner
chad changed the visibility for T823: Add image support to Diviner.
Jul 3 2015, 4:19 AM · Diviner

Jul 1 2015

joshuaspence added a comment to T8729: Removing a Diviner book does not delete the documentation.

It seems counterintuitive to me.

Jul 1 2015, 8:50 PM · Diviner
epriestley added a comment to T8729: Removing a Diviner book does not delete the documentation.

This behavior seems fairly expected/reasonable to me.

Jul 1 2015, 2:00 PM · Diviner
joshuaspence created T8729: Removing a Diviner book does not delete the documentation.
Jul 1 2015, 8:59 AM · Diviner

Jun 29 2015

joshuaspence added a subtask for T4558: Make Diviner useful for third-parties: T8711: Allow Diviner paths to be specify as includes rather than excludes.
Jun 29 2015, 8:42 PM · Diviner
joshuaspence added a parent task for T8711: Allow Diviner paths to be specify as includes rather than excludes: T4558: Make Diviner useful for third-parties.
Jun 29 2015, 8:42 PM · Diviner
joshuaspence created T8711: Allow Diviner paths to be specify as includes rather than excludes.
Jun 29 2015, 8:42 PM · Diviner

Jun 21 2015

joshuaspence closed T8626: Diviner book is linked to an unknown object as Resolved by committing rPf9e838024c71: Hide repository from atom view if it hasn't been set.
Jun 21 2015, 1:09 AM · Diviner
joshuaspence added a revision to T8626: Diviner book is linked to an unknown object: D13370: Hide repository from atom view if it hasn't been set.
Jun 21 2015, 12:04 AM · Diviner

Jun 20 2015

joshuaspence added a comment to T6951: Linter for Diviner.

I think that the warnings generate by Diviner (I don't believe these are surfaced in the UI currently) should be moved to a Diviner linter.

Jun 20 2015, 11:42 PM · Lint, Diviner
joshuaspence created T8626: Diviner book is linked to an unknown object.
Jun 20 2015, 11:40 PM · Diviner

Jun 19 2015

epriestley added a comment to T8618: Symbol collision in Diviner publisher.

@joshuaspence, pretty sure that's the right fix but yell if it looks suspicious?

Jun 19 2015, 4:04 PM · Diviner
epriestley added a comment to T8618: Symbol collision in Diviner publisher.

Hitting this locally too, and using --clean may have been inadvisable since it nuked all the docs.

Jun 19 2015, 3:55 PM · Diviner
epriestley claimed T8618: Symbol collision in Diviner publisher.
Jun 19 2015, 3:54 PM · Diviner
epriestley added a comment to T8618: Symbol collision in Diviner publisher.

(Similar trace with --clean.)

Jun 19 2015, 3:41 PM · Diviner