Paths

Table of Contentst

Differential D21061

Update DivinerAtomController for a long-ago change to the docblock parser API
ClosedPublic
Actions

Authored by epriestley on Apr 6 2020, 6:21 PM.

Tags

None

Referenced Files

	F19083217: D21061.id50179.diff
	Dec 2 2025, 12:32 PM

	F18985383: D21061.id50178.diff
	Nov 17 2025, 1:00 PM

	F18811685: D21061.diff
	Oct 20 2025, 4:20 AM

	F18772617: D21061.id50179.diff
	Oct 9 2025, 3:22 AM

	F18752016: D21061.id.diff
	Oct 4 2025, 1:43 PM

	F18734190: D21061.id.diff
	Sep 30 2025, 10:49 PM

	F18627613: D21061.diff
	Sep 16 2025, 4:24 AM

	F18627196: D21061.id50178.diff
	Sep 16 2025, 3:27 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given"
Commits: rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API

Summary

Ref T13505. See that task for discussion.

Test Plan

Ran diviner generate locally, found a page fataling on this strlen(), applied patch, got a sketchy but not-broken page.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 6 2020, 6:21 PM

Harbormaster completed remote builds in B23997: Diff 50178.Apr 6 2020, 6:22 PM

epriestley requested review of this revision.Apr 6 2020, 6:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2020, 6:31 PM

Closed by commit rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API.

epriestley mentioned this in T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".Apr 6 2020, 6:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

controller/

DivinerAtomController.php

4 lines

Diff 50179

src/applications/diviner/controller/DivinerAtomController.php

Loading...