Page MenuHomePhabricator
Feed Advanced Search

Apr 19 2022

epriestley committed rARC1fc4439ca5ff: Fix a PHP 8.1 issue with "phutil_console_strlen()" (authored by epriestley).
Fix a PHP 8.1 issue with "phutil_console_strlen()"
Apr 19 2022, 9:55 PM
epriestley requested review of D21758: Fix a PHP 8.1 issue with "phutil_console_strlen()".
Apr 19 2022, 9:55 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21758: Fix a PHP 8.1 issue with "phutil_console_strlen()".
Apr 19 2022, 9:55 PM · Infrastructure
epriestley updated the diff for D21757: Improve some PHP 8.1 behavior in "bin/auth recover".
  • Also fix some unit test behaviors.
Apr 19 2022, 9:54 PM
epriestley requested review of D21757: Improve some PHP 8.1 behavior in "bin/auth recover".
Apr 19 2022, 9:48 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21757: Improve some PHP 8.1 behavior in "bin/auth recover".
Apr 19 2022, 9:48 PM · Infrastructure
epriestley closed T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()" as Resolved.

This was resolved by D21452. PHI1880 has some unrelated additional plans.

Apr 19 2022, 9:31 PM · Daemons
epriestley closed T13661: Give Phame configurable interact policies as Resolved.

I deployed this and it seems to be working properly.

Apr 19 2022, 9:07 PM · Phacility, Phame
epriestley closed T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts as Resolved.

Hey, it worked once. Good enough for me!

Apr 19 2022, 5:55 PM · Phacility
epriestley added a comment to T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts.

No dice. We need bin/upgrade to run before mysql because it has to mount the data volume. So now I'm trying this:

Apr 19 2022, 5:48 PM · Phacility
epriestley added a comment to T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts.

... service ... start rather than service ... restart ...

Apr 19 2022, 5:27 PM · Phacility
epriestley added a comment to T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts.

...probably tested...

Apr 19 2022, 5:22 PM · Phacility
epriestley triaged T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts as Low priority.
Apr 19 2022, 4:30 PM · Phacility

Apr 14 2022

epriestley closed T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation as Resolved.

I deployed this everywhere in the Phacility cluster yesterday and things have been quiet, so I'm assuming it worked until evidence arises to the contrary.

Apr 14 2022, 1:49 PM · Git, Security
epriestley updated the task description for T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.
Apr 14 2022, 1:47 PM · Git, Security

Apr 13 2022

epriestley added a comment to T11908: Support an "overlay" database connection mode where multiple applications share a single connection.

With max_connections at 1024, the server above still looks fine after ~14 days:

Apr 13 2022, 7:43 PM · Infrastructure
epriestley committed rARCe1db75547897: (stable) Promote 2022 Week 15 (authored by epriestley).
(stable) Promote 2022 Week 15
Apr 13 2022, 7:41 PM
epriestley committed rP8659a50383bb: (stable) Promote 2022 Week 15 (authored by epriestley).
(stable) Promote 2022 Week 15
Apr 13 2022, 7:41 PM
epriestley closed D21743: Fix a PHP 8.1 issue in lint rendering.
Apr 13 2022, 7:38 PM
epriestley committed rARC21c44d6bed02: Fix a PHP 8.1 issue in lint rendering (authored by epriestley).
Fix a PHP 8.1 issue in lint rendering
Apr 13 2022, 7:38 PM
epriestley edited the content of 2022 Week 15 (Mid April).
Apr 13 2022, 7:09 PM
epriestley edited the content of 2022 Week 15 (Mid April).
Apr 13 2022, 7:08 PM
epriestley edited the content of Changelog.
Apr 13 2022, 7:04 PM
epriestley created an object: 2022 Week 15 (Mid April).
Apr 13 2022, 7:03 PM
epriestley committed rP3125d7a5f48d: In Git, always "sudo" to the daemon user if a daemon user is configured (authored by epriestley).
In Git, always "sudo" to the daemon user if a daemon user is configured
Apr 13 2022, 6:40 PM
epriestley closed D21756: In Git, always "sudo" to the daemon user if a daemon user is configured.
Apr 13 2022, 6:40 PM
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

D21756 effectively makes all Git pathways call setSudoAsDaemon(true).

Apr 13 2022, 6:31 PM · Git, Security
epriestley requested review of D21756: In Git, always "sudo" to the daemon user if a daemon user is configured.
Apr 13 2022, 6:23 PM
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

Just for visibility, the error messages you'll see if you're affected by this issue look something like this:

Apr 13 2022, 6:06 PM · Git, Security
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

...maybe this is an actual bug in Phabricator where some pathways are just missing the "sudo" wrapper?

Apr 13 2022, 6:06 PM · Git, Security
epriestley triaged T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation as Normal priority.
Apr 13 2022, 5:48 PM · Git, Security

Apr 1 2022

epriestley added a comment to T11908: Support an "overlay" database connection mode where multiple applications share a single connection.

Elsewhere, I compacted Phacility free instances onto a small number of database servers. I attempted to "fill up" these servers, and succeeded, sort of, but maybe too much -- they eventually fall over and need to be rebooted.

Apr 1 2022, 8:35 PM · Infrastructure
epriestley committed rP4dae3e7e1fbf: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT (authored by epriestley).
Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT
Apr 1 2022, 7:53 PM
epriestley closed D21755: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT.
Apr 1 2022, 7:53 PM
epriestley closed D21754: Give Phame blog posts configurable interact policies, with a default policy of "Same as Blog".
Apr 1 2022, 7:53 PM
epriestley closed D21751: Give Phame blogs mutable interact policies.
Apr 1 2022, 7:53 PM
epriestley closed D21752: Fix a PHP 8.1 unit test failure in Projects.
Apr 1 2022, 7:53 PM
epriestley closed D21753: Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts.
Apr 1 2022, 7:53 PM
epriestley committed rPf555fbcb50db: Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts (authored by epriestley).
Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts
Apr 1 2022, 7:53 PM
epriestley committed rPaae23f020476: Give Phame blog posts configurable interact policies, with a default policy of… (authored by epriestley).
Give Phame blog posts configurable interact policies, with a default policy of…
Apr 1 2022, 7:53 PM
epriestley committed rPc25595417f8a: Give Phame blogs mutable interact policies (authored by epriestley).
Give Phame blogs mutable interact policies
Apr 1 2022, 7:53 PM
epriestley committed rPa9822a37aa5a: Fix a PHP 8.1 unit test failure in Projects (authored by epriestley).
Fix a PHP 8.1 unit test failure in Projects
Apr 1 2022, 7:53 PM
epriestley closed D21750: Fix double-bordered breadcrumbs in Phame blogs.
Apr 1 2022, 7:53 PM
epriestley committed rP6c2c80a3731c: Remove ancient Remarkup constants from Phame and Maniphest (authored by epriestley).
Remove ancient Remarkup constants from Phame and Maniphest
Apr 1 2022, 7:53 PM
epriestley committed rP5ce7f803f90e: Fix double-bordered breadcrumbs in Phame blogs (authored by epriestley).
Fix double-bordered breadcrumbs in Phame blogs
Apr 1 2022, 7:53 PM
epriestley closed D21749: Remove ancient Remarkup constants from Phame and Maniphest.
Apr 1 2022, 7:53 PM
epriestley committed rP28b12fb3cdaf: Make Phame blog policies non-nullable (authored by epriestley).
Make Phame blog policies non-nullable
Apr 1 2022, 7:53 PM
epriestley closed D21748: Make Phame blog policies non-nullable.
Apr 1 2022, 7:53 PM
epriestley added a comment to T13661: Give Phame configurable interact policies.

This has some rough edges that I'm not going to deal with for now:

Apr 1 2022, 7:52 PM · Phacility, Phame
epriestley requested review of D21755: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT.
Apr 1 2022, 7:49 PM
epriestley added a revision to T13661: Give Phame configurable interact policies: D21755: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT.
Apr 1 2022, 7:49 PM · Phacility, Phame
epriestley added a revision to T13661: Give Phame configurable interact policies: D21754: Give Phame blog posts configurable interact policies, with a default policy of "Same as Blog".
Apr 1 2022, 7:41 PM · Phacility, Phame
epriestley requested review of D21754: Give Phame blog posts configurable interact policies, with a default policy of "Same as Blog".
Apr 1 2022, 7:41 PM
epriestley requested review of D21753: Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts.
Apr 1 2022, 7:16 PM
epriestley added a revision to T13661: Give Phame configurable interact policies: D21753: Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts.
Apr 1 2022, 7:16 PM · Phacility, Phame
epriestley updated the diff for D21752: Fix a PHP 8.1 unit test failure in Projects.
  • Found a few more.
Apr 1 2022, 7:13 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21752: Fix a PHP 8.1 unit test failure in Projects.
Apr 1 2022, 7:08 PM · Infrastructure
epriestley requested review of D21752: Fix a PHP 8.1 unit test failure in Projects.
Apr 1 2022, 7:08 PM
epriestley requested review of D21751: Give Phame blogs mutable interact policies.
Apr 1 2022, 7:05 PM
epriestley added a revision to T13661: Give Phame configurable interact policies: D21751: Give Phame blogs mutable interact policies.
Apr 1 2022, 7:05 PM · Phacility, Phame
epriestley added a revision to T13661: Give Phame configurable interact policies: D21750: Fix double-bordered breadcrumbs in Phame blogs.
Apr 1 2022, 6:48 PM · Phacility, Phame
epriestley requested review of D21750: Fix double-bordered breadcrumbs in Phame blogs.
Apr 1 2022, 6:48 PM
epriestley added a revision to T13661: Give Phame configurable interact policies: D21749: Remove ancient Remarkup constants from Phame and Maniphest.
Apr 1 2022, 6:46 PM · Phacility, Phame
epriestley requested review of D21749: Remove ancient Remarkup constants from Phame and Maniphest.
Apr 1 2022, 6:46 PM
epriestley requested review of D21748: Make Phame blog policies non-nullable.
Apr 1 2022, 6:43 PM
epriestley added a revision to T6203: Adjust nullability of various questionable columns: D21748: Make Phame blog policies non-nullable.
Apr 1 2022, 6:43 PM · Infrastructure
epriestley added a revision to T13661: Give Phame configurable interact policies: D21748: Make Phame blog policies non-nullable.
Apr 1 2022, 6:43 PM · Phacility, Phame

Mar 24 2022

epriestley added a comment to T13658: How to rebrand Phabricator.

Will this work will with Phabricator?

Mar 24 2022, 6:06 PM

Mar 15 2022

epriestley added a comment to T13672: Arcanist: Exceptions when using Mercurial ~6.0/6.1.

GitHub was refusing mirror pushes with a credential issue (see also T12896, vaguely). I'm not entirely sure which side of things changed, but the config was set up in a previous-generation way anyway (through a "bot" account instead of a "Deploy Key") so I updated things. Looks like mirroring is back online now and this change has propagated.

Mar 15 2022, 5:01 PM

Mar 11 2022

epriestley accepted D21747: Update arc-hg to support mercurial 6.1.
Mar 11 2022, 6:09 PM

Jan 11 2022

vhbit awarded D21743: Fix a PHP 8.1 issue in lint rendering a Party Time token.
Jan 11 2022, 4:34 PM

Dec 19 2021

epriestley closed T11230: Phacility: Private Clusters as Wontfix.

See T12847. All the technical parts of this are now solved except for billing, but since Phacility is winding down I no longer plan to pursue it.

Dec 19 2021, 8:45 PM · Phacility
epriestley closed T8688: Attach and initialize backup volumes during `remote deploy` workflow as Resolved.

I resolved this in rCORE320b2854.

Dec 19 2021, 8:43 PM · Phacility
epriestley closed T12847: A Pathway Towards Private Clusters as Wontfix.

After T13630:

Dec 19 2021, 8:39 PM · Plans, Ops, Phacility
epriestley closed T12847: A Pathway Towards Private Clusters, a subtask of T11230: Phacility: Private Clusters, as Wontfix.
Dec 19 2021, 8:39 PM · Phacility
epriestley closed T13601: Support "SCA" / "3D Secure 2" in billing workflows as Wontfix.

Only one instance was impacted by this and I just credited them until 2099. I don't currently expect to pursue this.

Dec 19 2021, 8:26 PM · Phacility, Phortune
epriestley closed T13610: Support per-node billing for hosted Phacility instances as Wontfix.

I no longer expect to pursue this.

Dec 19 2021, 8:25 PM · Phortune, Phacility
epriestley closed T13618: When a Phacility "rbak" device does not exist, backups can run twice and converge to a "successful" but inconsistent state as Wontfix.
  • Hosts in the repo class are now build by Piledriver (see T13630), which automatically creates the rbak device entries, so this error isn't likely to occur again.
  • I also don't expect to launch any more hosts.
Dec 19 2021, 8:25 PM · Phacility
epriestley closed T13654: Wind Down Phacility Operations as Resolved.

I compacted secure onto new hardware (T13671) and shut down saux001 ("Land Revision") and sbuild001 (Harbormaster remote builds). I think all the remaining work is covered under T13630 (largely, just a handful of large database migrations remain).

Dec 19 2021, 8:23 PM · Phacility
epriestley closed T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware as Resolved.

I just swapped configs over without merging the LBs, since it wasn't immediately obvious to me what the Application vs Classic state of the world is and swapping was good enough.

Dec 19 2021, 7:35 PM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

The aphlict/notify stuff still needs to be tweaked. I think the snlb + slb setup can be merged into a single slb with "TCP (Secure)" forwarding now.

Dec 19 2021, 4:19 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

Databases are moved and secure is out of read-only mode. I'm going to adjust repository configuration, then I should be able to tear down secure001.

Dec 19 2021, 4:11 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I'm going to put secure back into read-only mode now and move the databases to the new host.

Dec 19 2021, 12:08 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I brought up the new host and pointed the slb001 load balancer at it. The database is still on the old host, and the new host doesn't have repositories yet, but the basics seem to be working.

Dec 19 2021, 12:07 AM · Phacility

Dec 18 2021

epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

Merging 003 into 001 worked fine with a few expected tricks (e.g., when secure is in read-only mode, you can't push a change to take it out of read-only mode, since pushing is a write). Next up is launching a modern m4.large secure-pool host and then migrating the data.

Dec 18 2021, 7:57 PM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I'm putting secure into read-only mode now, with the intent of completing steps 1-5 above.

Dec 18 2021, 7:13 PM · Phacility
epriestley committed rPdec95228a241: Add a "--database <name> ..." flag to "bin/storage dump" (authored by epriestley).
Add a "--database <name> ..." flag to "bin/storage dump"
Dec 18 2021, 7:11 PM
epriestley closed D21745: Add a "--database <name> ..." flag to "bin/storage dump".
Dec 18 2021, 7:11 PM
epriestley updated the diff for D21745: Add a "--database <name> ..." flag to "bin/storage dump".
  • Fix missing variable initialization.
Dec 18 2021, 7:09 PM
epriestley requested review of D21745: Add a "--database <name> ..." flag to "bin/storage dump".
Dec 18 2021, 7:07 PM
epriestley added a revision to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware: D21745: Add a "--database <name> ..." flag to "bin/storage dump".
Dec 18 2021, 7:06 PM · Phacility

Dec 17 2021

epriestley triaged T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware as Low priority.
Dec 17 2021, 7:32 PM · Phacility

Dec 16 2021

epriestley committed rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration (authored by epriestley).
Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
Dec 16 2021, 11:24 PM
epriestley closed D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
Dec 16 2021, 11:24 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix another random PHP 8.1 issue.
Dec 16 2021, 11:21 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a PHP 8.1 issue in application search code.
Dec 16 2021, 11:17 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a PHP 8.1 check in local disk storage engine code.
Dec 16 2021, 11:15 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a PHP 8.1 issue in user querying.
Dec 16 2021, 11:15 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a piece of user initializing code for PHP 8.1.
Dec 16 2021, 11:13 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Correct behavior in query clause construction.
Dec 16 2021, 11:11 PM