Page MenuHomePhabricator
Feed Advanced Search

Jul 25 2017

epriestley added a comment to T12929: Tasks created via email don't get "created" feed stories. They say "renamed".

There's also bin/mail receive-test but that only accepts mail --to an existing object, not a random email address, right now. We could make that more flexible to make testing a little easier (raw_mail.txt must be a full piece of mail with proper headers and encoding, but bin/mail receive-test accepts just the plain text of a body and simulates all the headers/encoding/envelope stuff).

Jul 25 2017, 8:31 PM · Mail, Bug Report, Maniphest
epriestley added a comment to T12929: Tasks created via email don't get "created" feed stories. They say "renamed".

Something like:

Jul 25 2017, 8:29 PM · Mail, Bug Report, Maniphest
epriestley closed T12934: "Support" can produce a bogus "0 to 0" mana cost transaction as Resolved by committing Restricted Diffusion Commit.
Jul 25 2017, 3:19 PM · Support
epriestley added a revision to T12934: "Support" can produce a bogus "0 to 0" mana cost transaction: Unknown Object (Differential Revision).
Jul 25 2017, 2:09 PM · Support
epriestley updated the task description for T12935: Automatically detect merge-ability in Differential.
Jul 25 2017, 2:03 PM · Customer Impact, Harbormaster, Drydock, Differential
epriestley created T12935: Automatically detect merge-ability in Differential.
Jul 25 2017, 2:02 PM · Customer Impact, Harbormaster, Drydock, Differential
epriestley created T12934: "Support" can produce a bogus "0 to 0" mana cost transaction.
Jul 25 2017, 1:01 PM · Support
epriestley closed T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories as Resolved by committing Restricted Diffusion Commit.
Jul 25 2017, 12:12 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12933: Legalpad "Updated" date is wrong.

I think you're innocent and that it never worked but I only looked at it for like 2 minutes.

Jul 25 2017, 12:51 AM · Restricted Project, Bug Report

Jul 24 2017

epriestley added a comment to T12933: Legalpad "Updated" date is wrong.

There may be a bug with the body versioning (maybe it got broken by accident when we swapped to ModularTransactions, or maybe it never worked), but if there is we should fix that bug. The creation date and modification date of a body should always be the same, like they are for a Phriction document body.

Jul 24 2017, 11:51 PM · Restricted Project, Bug Report
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
Jul 24 2017, 11:31 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

Maybe I'll put it on A, I guess ("Toggle All"), so it's sort of near q, which is similar (collapse/expand).

Jul 24 2017, 9:48 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

If it's a toggle, what do you expect us to do if you press it with some inlines hidden and others visible?

Jul 24 2017, 8:59 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories: Unknown Object (Differential Revision).
Jul 24 2017, 6:43 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

See PHI14 for priority.

Jul 24 2017, 4:26 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T3626: Detection of language for some file types isn't good.

And one more.

Jul 24 2017, 4:23 PM · Customer Impact, Restricted Project, Differential
epriestley added a comment to T12929: Tasks created via email don't get "created" feed stories. They say "renamed".

The easiest fix is probably to add a TYPE_CREATE transaction into ReplyHandler or MailReceiver alongside the other creation transactions.

Jul 24 2017, 4:06 PM · Mail, Bug Report, Maniphest
epriestley added a project to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Customer Impact.

This is now formally prioritized (see PHI14).

Jul 24 2017, 4:03 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T12932: GC old Differential changesets into File storage.

Only db001 and db002 are anywhere close to having problems with this and they still have a large amount of headroom, and we can bin/storage optimize at least some amount of additional headroom into existence, so this isn't "we're about to fall off a cliff" urgent or anything, but would be nice to tackle sooner than later.

Jul 24 2017, 3:53 PM · Files, Differential, Phacility, Ops
epriestley created T12932: GC old Differential changesets into File storage.
Jul 24 2017, 3:47 PM · Files, Differential, Phacility, Ops
epriestley renamed T12929: Tasks created via email don't get "created" feed stories. They say "renamed" from Sample to Tasks created via email don't get "created" feed stories. They say "renamed".
Jul 24 2017, 3:36 PM · Mail, Bug Report, Maniphest
epriestley added a comment to T3626: Detection of language for some file types isn't good.

We've had two customers hit this (both for Kotlin, although a config workaround is available).

Jul 24 2017, 3:35 PM · Customer Impact, Restricted Project, Differential
epriestley added a project to T3626: Detection of language for some file types isn't good: Customer Impact.
Jul 24 2017, 3:30 PM · Customer Impact, Restricted Project, Differential
epriestley added a comment to T12929: Tasks created via email don't get "created" feed stories. They say "renamed".

Is this a test or a bug report? If it's a bug report, how can I reproduce it?

Jul 24 2017, 3:00 PM · Mail, Bug Report, Maniphest

Jul 21 2017

epriestley edited the content of Changelog.
Jul 21 2017, 10:52 PM
epriestley edited the content of 2017 Week 29 (Late July).
Jul 21 2017, 10:52 PM
epriestley added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

That is, my expectation when you have set "Default Branch" to "mmmmmmmmmmmmm" and visit the repository page is just:

Jul 21 2017, 10:16 PM · Feature Request, Diffusion
epriestley added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

This is what it did in March 2016: T3607#163684

Jul 21 2017, 10:11 PM · Feature Request, Diffusion
epriestley added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

Where is the exception coming from?

Jul 21 2017, 9:37 PM · Feature Request, Diffusion
epriestley added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

I believe the issue here is:

Jul 21 2017, 5:41 PM · Feature Request, Diffusion
epriestley renamed T12931: Fallback for incorrect default branch in Diffusion could be nicer from Diffusion doesn't render tabs if master isn't present in git to Diffusion doesn't render tabs if a repository has commits and a "Default Branch" set to a branch which does not exist.
Jul 21 2017, 5:38 PM · Feature Request, Diffusion
epriestley added a comment to T12847: A Pathway Towards Private Clusters.

I think the minimum size is 2 hosts, in separate AZs, in one region. e.g., everything1 in us-west-1a and everything2 in us-west-1c, so that assumption is sound.

Jul 21 2017, 4:34 PM · Plans, Ops, Phacility
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
Jul 21 2017, 3:10 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

Well, I'm half mistaken. What you're seeing is a bug.

Jul 21 2017, 3:07 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

(Oh, no, I'm mistaken.)

Jul 21 2017, 2:52 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

That's supposed to leave an "Undo" bar, still want us to fix the bug?

Jul 21 2017, 2:42 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 21 2017, 2:38 PM · Phacility, Support
epriestley edited the content of Planning.
Jul 21 2017, 1:17 PM
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 21 2017, 11:35 AM · Phacility, Support
quark.zju awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Like token.
Jul 21 2017, 2:57 AM

Jul 20 2017

epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 20 2017, 10:27 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 20 2017, 10:07 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 20 2017, 10:07 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 20 2017, 9:33 PM · Phacility, Support
epriestley updated the task description for T12904: Support Pact Errata.
Jul 20 2017, 9:31 PM · Phacility, Support
epriestley added a revision to T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index: Unknown Object (Differential Revision).
Jul 20 2017, 4:10 PM · Customer Impact, Search
epriestley is attending E1584: Spider-Man: Homecoming.
Jul 20 2017, 12:28 AM · Phacility

Jul 19 2017

epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 19 2017, 10:51 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 19 2017, 10:34 PM · Phacility, Support
epriestley added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

I think (?) this reproduces for me, too:

Jul 19 2017, 9:41 PM · Firefox, Bug Report
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 19 2017, 8:43 PM · Phacility, Support
epriestley added a project to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Customer Impact.

See PHI11. This has material impact when using PhabricatorRepositoryRefCursorQuery to query landing targets, and likely impacts the logic in DifferentialRevisionOperationController.

Jul 19 2017, 8:18 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 19 2017, 7:22 PM · Phacility, Support
epriestley added a comment to T12847: A Pathway Towards Private Clusters.

I'll look at the pricing breakdown and I might do some perf testing just to see if there's any real difference.

Jul 19 2017, 5:43 PM · Plans, Ops, Phacility
epriestley created T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index.
Jul 19 2017, 3:08 PM · Customer Impact, Search
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 19 2017, 2:34 PM · Phacility, Support

Jul 18 2017

epriestley added a comment to T12847: A Pathway Towards Private Clusters.

22280->22280 for aphlict (or we could possibly use path-based routing on the ALB instead of opening up a 2nd port?)

Jul 18 2017, 8:29 PM · Plans, Ops, Phacility
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 18 2017, 7:40 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 18 2017, 6:37 PM · Phacility, Support
chad awarded U15 New Bug Report a Heartbreak token.
Jul 18 2017, 6:32 PM
epriestley added a revision to T12922: Update Bug Report docs: Unknown Object (Differential Revision).
Jul 18 2017, 5:48 PM · Public & Media Relations
epriestley changed the destination URL U15 New Bug Report from https://secure.phabricator.com/maniphest/task/edit/form/3/ to https://discourse.phabricator-community.org/c/bug.
Jul 18 2017, 5:45 PM
epriestley added a revision to T12922: Update Bug Report docs: Unknown Object (Differential Revision).
Jul 18 2017, 5:41 PM · Public & Media Relations
epriestley closed T12927: Private Clusters: VPN Notes as Resolved.

Cool, that all sounds like it's roughly what I expected. Thanks!

Jul 18 2017, 5:37 PM · Clusters, Ops
epriestley closed T12926: Document the existence of the LB `/status/` endpoint as Resolved by committing Restricted Diffusion Commit.
Jul 18 2017, 4:08 PM · Infrastructure, Setup, Documentation
epriestley added a revision to T12926: Document the existence of the LB `/status/` endpoint: Unknown Object (Differential Revision).
Jul 18 2017, 3:58 PM · Infrastructure, Setup, Documentation
epriestley added a revision to T10769: Read-Only Mode Errata: Unknown Object (Differential Revision).
Jul 18 2017, 3:51 PM · Clusters
epriestley closed T12916: Email Settings and Email Preferences should maybe be the same panel as Wontfix.

Let's just take another look at this during/after T10448? I think that's happening soon enough and this is minor enough that it's probably not worth fixing separately.

Jul 18 2017, 3:20 PM
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 18 2017, 2:51 PM · Phacility, Support
epriestley added projects to T12927: Private Clusters: VPN Notes: Ops, Clusters.
Jul 18 2017, 11:50 AM · Clusters, Ops
epriestley created T12927: Private Clusters: VPN Notes.
Jul 18 2017, 11:49 AM · Clusters, Ops
epriestley created T12926: Document the existence of the LB `/status/` endpoint.
Jul 18 2017, 9:41 AM · Infrastructure, Setup, Documentation
epriestley updated the task description for T10769: Read-Only Mode Errata.
Jul 18 2017, 9:41 AM · Clusters

Jul 17 2017

epriestley edited the content of Changelog.
Jul 17 2017, 2:26 PM
epriestley edited the content of 2017 Week 28 (Mid July).
Jul 17 2017, 2:24 PM
epriestley edited the content of 2017 Week 29 (Late July).
Jul 17 2017, 2:24 PM
epriestley created 2017 Week 29 (Late July).
Jul 17 2017, 2:23 PM
epriestley created 2017 Week 28 (Mid July).
Jul 17 2017, 2:21 PM
epriestley added a comment to T12904: Support Pact Errata.

Inbound mail seems to be working now.

Jul 17 2017, 2:19 PM · Phacility, Support
epriestley added a comment to T12854: Clean up resources for decommissioned `repo012`.

This is very minor, but blue-underneathie is still active even though repo012 is dead, which is causing the queue to spawn impossible backup jobs that sit there retrying forever. They should fix themselves once the instance is suspended. I'll likely pursue the remaining cleanup here shortly since we haven't seen any issues in a few weeks.

Jul 17 2017, 2:10 PM · Ops, Phacility
epriestley added a comment to T12904: Support Pact Errata.

Inbound mail later bounced. I think the issue is that we have a *.phacility.com MX record, but an admin.phacility.com A record. I can't recite all the wildcard vs nonwildcard DNS rules offhand, but I think the A record is shadowing the MX record, e.g. dig mx admin.phacility.com does not produce the right results. I've added an admin.phacilty.com MX record which might sort things out once it propagates.

Jul 17 2017, 2:07 PM · Phacility, Support

Jul 16 2017

• tomekj2ee awarded T2849: Implement alternate markup engines (Markdown, reStructuredText, ...) a Dislike token.
Jul 16 2017, 8:49 PM · Remarkup
MrSchaal awarded T3569: Make Phrequent somewhat usable a Like token.
Jul 16 2017, 7:22 PM · Phrequent
epriestley closed T12134: Develop a Nuance-based Phabricator reporting/support flow as Resolved.

The new paid support application is now in closed beta. This will become publicly available in the relatively near future, then become then channel for SAAS support after that. It may later become the channel for some types of free/community support (most likely bug reports, per above) but this probably won't happen for a while.

Jul 16 2017, 11:23 AM · Abuse
epriestley added a comment to T12922: Update Bug Report docs.

Community and us can both use the normal task form to report bugs -- the "bug report" form just had extra instructions.

Jul 16 2017, 11:11 AM · Public & Media Relations

Jul 15 2017

michaeljs1990 awarded T12681: Upcoming Support Product / End of Paid Prioritization a Yellow Medal token.
Jul 15 2017, 8:58 PM · Guides, Phacility
epriestley added a comment to T12922: Update Bug Report docs.

That is, the flow would be one of these:

Jul 15 2017, 5:59 PM · Public & Media Relations
epriestley added a comment to T12922: Update Bug Report docs.

Let's just do Discourse for now? I don't plan to get anything up on admin for at least a while.

Jul 15 2017, 5:53 PM · Public & Media Relations
xiaogaozi awarded T10038: Plan the mid-term pathway for unit-test/linter bindings a Love token.
Jul 15 2017, 10:29 AM · Lint, Arcanist

Jul 14 2017

epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 14 2017, 7:04 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 14 2017, 6:59 PM · Phacility, Support
epriestley added a comment to T12904: Support Pact Errata.

Using @mentions in issue comments hits a policy exception because of the slightly odd way pact policy filtering works.

Jul 14 2017, 6:40 PM · Phacility, Support
epriestley added a comment to T12904: Support Pact Errata.

This works now: PHI1

Jul 14 2017, 4:20 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 14 2017, 4:07 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 14 2017, 3:52 PM · Phacility, Support
epriestley added a comment to T12904: Support Pact Errata.

Test mail from the console now gets routed/accepted properly but real mail still doesn't. I'm going to write this off as possibly being a route propagation issue for a little bit and see if it fixes itself.

Jul 14 2017, 3:47 PM · Phacility, Support
epriestley added a comment to T12904: Support Pact Errata.

Email replies don't actually work since mail gets routed to the web tier (mail.phacililty.com) which can't hit admin. I think I can fix this with a mail route.

Jul 14 2017, 3:37 PM · Phacility, Support
epriestley added a comment to T12904: Support Pact Errata.

Some stuff I'm thinking of doing in the short term:

Jul 14 2017, 3:25 PM · Phacility, Support
epriestley closed T12681: Upcoming Support Product / End of Paid Prioritization as Resolved.

This is entering some kind of closed beta shortly, I'll follow up in T12904 for actual feature improvements to the Support application.

Jul 14 2017, 3:14 PM · Guides, Phacility
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 14 2017, 3:13 PM · Phacility, Support