Page MenuHomePhabricator
Feed Advanced Search

Dec 9 2016

epriestley added a comment to T11990: Outline is invisible on submit buttons.

Okay, it does look invisible in Firefox. Is Firefox the browser you're using?

Dec 9 2016, 11:18 PM · Design, Bug Report
epriestley added a comment to T11990: Outline is invisible on submit buttons.

I can't reproduce tab order differing from visual order, either.

Dec 9 2016, 11:16 PM · Design, Bug Report
epriestley added a comment to T11990: Outline is invisible on submit buttons.

I can't reproduce this:

Dec 9 2016, 11:15 PM · Design, Bug Report
avivey added a comment to T11990: Outline is invisible on submit buttons.

isn't that outline provided by the browser?

Dec 9 2016, 10:51 PM · Design, Bug Report
tgr created T11990: Outline is invisible on submit buttons.
Dec 9 2016, 10:49 PM · Design, Bug Report
epriestley closed T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as Resolved by committing Restricted Diffusion Commit.
Dec 9 2016, 4:35 PM · Config, Bug Report
epriestley added a revision to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site: Restricted Differential Revision.
Dec 9 2016, 4:22 PM · Config, Bug Report
epriestley reopened T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as "Open".

That's similar but not directly related.

Dec 9 2016, 4:18 PM · Config, Bug Report
nickhutchinson added a comment to T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.

Thanks for pointing me in the right direction -- this was indeed pilot error. Switching to rewrite as stated in the install guide fixes the error.

Dec 9 2016, 4:01 PM · Bug Report
epriestley closed T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as Resolved by committing Restricted Diffusion Commit.
Dec 9 2016, 3:51 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Getting another instance of what looks to be a similar issue but for a different function, specifically

Dec 9 2016, 2:22 PM · Config, Bug Report
epriestley closed T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character as Invalid.

I'm going to close this since it isn't reproducible (e.g., the link above works fine) and I'm fairly confident that this is a configuration problem in how you've adjusted nginx to work, deviating from the upstream instructions.

Dec 9 2016, 1:50 PM · Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

The "Public" vs "All Users" stuff is sort of a confusing behavior on our part (the workflow is what set "Public", which doesn't really make sense given the rest of your config) but I think it's largely mooted by the fix in D17011, and to be more clear about it we'd have to make this one particular file magical somehow (we can't choose either "users" or "public" as the policy unambiguously, because the install may change the value of policy.allow-public later without also updating the logo).

Dec 9 2016, 1:01 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Oh. No - no it doesn't.

Dec 9 2016, 12:52 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

No problem -- we gave you a false start in Q528 and this behavior is pretty hard to guess at if you don't know the internals.

Dec 9 2016, 12:43 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

OK, after removing the custom logo (even though it's Public) I can't replicate any more.

Dec 9 2016, 12:39 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Same file.

Dec 9 2016, 12:34 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Specifically, this is the PHID you're looking for in the UI:

Dec 9 2016, 12:33 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

If you do this:

Dec 9 2016, 12:32 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Well, the fact that the logo isn't restricted:

Dec 9 2016, 12:31 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

When you say "fail hard", you specifically mean that you get an exception message beginning with this text?

Dec 9 2016, 12:27 PM · Config, Bug Report
epriestley added a revision to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site: Restricted Differential Revision.
Dec 9 2016, 12:24 PM · Config, Bug Report
jonathon updated the task description for T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.
Dec 9 2016, 12:24 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Um. That's a different bug to the one I'm reporting. The custom logo I have set is visible to Public.

Dec 9 2016, 12:22 PM · Config, Bug Report
epriestley added a project to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site: Config.
Dec 9 2016, 12:18 PM · Config, Bug Report
epriestley renamed T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site from Site unavailable after cache purge to Preventing users from seeing your custom logo prevents them from seeing the whole site.
Dec 9 2016, 12:18 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

(Actually, I'm just going to respect the file policy but ignore policy failures.)

Dec 9 2016, 12:16 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Here are more reliable reproduction steps:

Dec 9 2016, 12:15 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Ick. I could replicate it three times with those steps (without typing into the comment box - only a click; I need to check what happens with typing). I wonder if it needs a service restart somewhere in the mix (my update script is in Q528). Let me do some more testing.

Dec 9 2016, 12:12 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

I can't reproduce this. Here's what I did:

Dec 9 2016, 12:03 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

I'm going to attempt to reproduce this as written, but I will be shocked if these steps work to reproduce the issue you describe.

Dec 9 2016, 11:52 AM · Config, Bug Report
jonathon created T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.
Dec 9 2016, 11:49 AM · Config, Bug Report

Dec 8 2016

epriestley added a comment to T11978: Storage Tools Not Actually Upgrading Database.

You can use bin/storage upgrade --apply phabricator:2016... to reapply a specific patch explicitly, even if it has previously been marked as applied. You can get the full names of patches from bin/storage status.

Dec 8 2016, 10:54 PM · Bug Report (Needs Information)
mbishopim3 created T11978: Storage Tools Not Actually Upgrading Database.
Dec 8 2016, 10:38 PM · Bug Report (Needs Information)
epriestley added a comment to T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.

Your config looks very little like the config we recommend. Why are you using try_files instead of rewrite?

Dec 8 2016, 1:30 PM · Bug Report
epriestley closed T11966: sdtyhftuyhf as Invalid.
Dec 8 2016, 1:19 PM · Community, Bug Report
epriestley closed T11963: Company name is missing in the home page as Invalid.
Dec 8 2016, 1:19 PM · Bug Report
epriestley closed T11965: Colour is same as the Title as Invalid.
Dec 8 2016, 1:19 PM · Bug Report
epriestley closed T11964: check the banner as Invalid.
Dec 8 2016, 1:19 PM · Bug Report
epriestley closed T11962: fgyokh as Invalid.
Dec 8 2016, 1:18 PM · Bug Report
nileshgr added a comment to T11827: ssh-auth hangs on FreeBSD.

I upgraded my installation to

commit ad65d933fa75a2c417ba23f3684f0109de0f6ace
Merge: cfcc3b8 f0bf041
Author: epriestley <git@epriestley.com>
Date:   Sat Dec 3 02:39:57 2016 -0800
Dec 8 2016, 10:13 AM · Diffusion, Bug Report
• 123456789 created T11966: sdtyhftuyhf.
Dec 8 2016, 10:01 AM · Community, Bug Report
nickhutchinson added a comment to T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.

We use nginx:

Dec 8 2016, 7:42 AM · Bug Report
• 123456789 added a comment to T11965: Colour is same as the Title.

1.open the app
2.go to the index
3.check the list

Dec 8 2016, 7:35 AM · Bug Report
• 123456789 created T11965: Colour is same as the Title.
Dec 8 2016, 7:35 AM · Bug Report
• 123456789 added a comment to T11964: check the banner.

1.check the banner colur

Dec 8 2016, 7:27 AM · Bug Report
• 123456789 created T11964: check the banner.
Dec 8 2016, 7:26 AM · Bug Report
• 123456789 added a comment to T11963: Company name is missing in the home page.

check the home page, banner is missing.

Dec 8 2016, 6:47 AM · Bug Report
• 123456789 created T11963: Company name is missing in the home page.
Dec 8 2016, 6:46 AM · Bug Report
• 123456789 added a comment to T11962: fgyokh.

zdfhcvbn
xcgjcvhjcvgjcvj

Dec 8 2016, 6:44 AM · Bug Report
• 123456789 created T11962: fgyokh.
Dec 8 2016, 6:44 AM · Bug Report

Dec 7 2016

epriestley added a comment to T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.

Can you show me:

Dec 7 2016, 10:35 PM · Bug Report
nickhutchinson created T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.
Dec 7 2016, 10:28 PM · Bug Report
epriestley closed T11959: Cluster/Databases doc page contains broken link as Resolved by committing Restricted Diffusion Commit.
Dec 7 2016, 9:33 PM · Documentation, Bug Report
epriestley added a revision to T11959: Cluster/Databases doc page contains broken link: Restricted Differential Revision.
Dec 7 2016, 8:30 PM · Documentation, Bug Report
epriestley added a comment to T11959: Cluster/Databases doc page contains broken link.

The intended target of the link is Cluster: Databases.

Dec 7 2016, 8:29 PM · Documentation, Bug Report
fooishbar created T11959: Cluster/Databases doc page contains broken link.
Dec 7 2016, 2:17 PM · Documentation, Bug Report

Dec 6 2016

nornagon added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

Purely organizational. I don't believe there's anything technically that Phabricator can't do, but we're just trying it out and don't want to move everything over before we're ready to commit.

Dec 6 2016, 12:47 AM · Diffusion, Herald, Bug Report
epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

What are the barriers you face to hosting on Phabricator instead of on GitHub?

Dec 6 2016, 12:14 AM · Diffusion, Herald, Bug Report
epriestley closed T11952: Daemons don't notice changes to global default settings as Resolved.
Dec 6 2016, 12:01 AM · Bug Report

Dec 5 2016

nornagon added a comment to T11952: Daemons don't notice changes to global default settings.

Sounds like this can safely be closed as PEBKAC

Dec 5 2016, 11:59 PM · Bug Report
nornagon added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

FWIW, in this particular case our repository is hosted on GitHub, so lovely automagic in Phabricator wouldn't solve my specific case.

Dec 5 2016, 11:58 PM · Diffusion, Herald, Bug Report
epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

Generally, I am leaning toward splitting the "Commit" rule into two rules, "Commit" and "Ref Update".

Dec 5 2016, 11:45 PM · Diffusion, Herald, Bug Report
epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

We have some spooky magic around "autoclose" which might make the behavior for "Is on autoclose branch" different than "Is on <specific, named branch>". That said, I'm not sure if it's actually materially different, and these likely end up being more-or-less the same thing when we actually fix them.

Dec 5 2016, 11:29 PM · Diffusion, Herald, Bug Report
nornagon added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

I think it is the same as T6522?

Dec 5 2016, 11:24 PM · Diffusion, Herald, Bug Report
epriestley reopened T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) as "Open".
Dec 5 2016, 11:22 PM · Diffusion, Herald, Bug Report
epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

Oh, maybe this isn't quite the same as T6522. Pushing another commit to the branch probably fires the rule?

Dec 5 2016, 11:22 PM · Diffusion, Herald, Bug Report
epriestley merged task T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) into T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.
Dec 5 2016, 11:20 PM · Diffusion, Herald, Bug Report
nornagon created T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).
Dec 5 2016, 11:19 PM · Diffusion, Herald, Bug Report
epriestley added a comment to T11952: Daemons don't notice changes to global default settings.

We also made some changes to this recently (D16936, D16983) and it could conceivably be a version issue, but neither of those changes replaced a static cache with a RequestCache or similar, and D16936 is correctly using the RequestCache (which is cleared when the taskmaster de-queues a new task).

Dec 5 2016, 10:35 PM · Bug Report
epriestley added a comment to T11952: Daemons don't notice changes to global default settings.

I can't reproduce this in the Phacility cluster, either. Here's what I did:

Dec 5 2016, 10:32 PM · Bug Report
nornagon added a comment to T11952: Daemons don't notice changes to global default settings.

Your logic there w/ dumping the prefs is definitely convincing. Perhaps I hallucinated this and it was actually that I did something in a different order, e.g. I disabled "A commit is created", then restarted the daemons, then disabled "A commit has auditors added" and misattributed causality (where the real issue was that disabling "A commit is created" is not sufficient to stop receiving emails when a commit is created that you're an auditor on).

Dec 5 2016, 10:32 PM · Bug Report
epriestley added a comment to T11952: Daemons don't notice changes to global default settings.

I'm not immediately able to reproduce this. Here's what I did:

Dec 5 2016, 10:23 PM · Bug Report
chad added a comment to T11952: Daemons don't notice changes to global default settings.

Why does the mail say you received it, see /mail/

Dec 5 2016, 10:22 PM · Bug Report
chad added a comment to T11952: Daemons don't notice changes to global default settings.
Dec 5 2016, 10:10 PM · Bug Report
nornagon updated the task description for T11952: Daemons don't notice changes to global default settings.
Dec 5 2016, 10:07 PM · Bug Report
nornagon created T11952: Daemons don't notice changes to global default settings.
Dec 5 2016, 10:04 PM · Bug Report
nevogd added a comment to T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0.

We have updated to Git 2.11 and updated to master pull/push works for us. Thank you as always. :)

Dec 5 2016, 9:25 PM · Bug Report
epriestley added a comment to T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0.

I believe this is now resolved at HEAD of master. Let us know if you're still seeing issues after updating.

Dec 5 2016, 8:48 PM · Bug Report
epriestley closed T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0 as Resolved by committing Restricted Diffusion Commit.
Dec 5 2016, 8:45 PM · Bug Report
epriestley added a revision to T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0: Restricted Differential Revision.
Dec 5 2016, 8:13 PM · Bug Report
epriestley closed T11946: Global default settings only apply to logged-out users on public installs as Resolved by committing Restricted Diffusion Commit.
Dec 5 2016, 7:00 PM · Config, Bug Report
epriestley updated subscribers of T11943: Search results for Differential Revisions contains a displayed Date which can be confusing which date it is.

I think we're currently consistent about showing updated date (Diffusion, Differential, Maniphest, Phriction index view).

Dec 5 2016, 5:19 PM · Feature Request
epriestley claimed T11946: Global default settings only apply to logged-out users on public installs.
Dec 5 2016, 5:04 PM · Config, Bug Report
epriestley added a revision to T11946: Global default settings only apply to logged-out users on public installs: Restricted Differential Revision.
Dec 5 2016, 4:59 PM · Config, Bug Report
hach-que added a comment to T11947: Unable to push commits to hosted repositories.

This issue is now fixed in the Docker image, which now uses an older version of Git and checks to ensure that it does not install 2.11 when the image is being prepared. If you're affected by this issue, run docker pull hachque/phabricator.

Dec 5 2016, 2:54 AM · Bug Report

Dec 4 2016

MatanUbe added a comment to T11947: Unable to push commits to hosted repositories.

Brilliant! As T11940 mentions, downgrading to git 2.10.2 fixes the problem. Thanks guys.

Dec 4 2016, 9:09 PM · Bug Report
epriestley closed T11947: Unable to push commits to hosted repositories as Invalid.

As above, we don't support installs that don't follow our guide.

Dec 4 2016, 8:36 PM · Bug Report
• aHa updated the task description for T11946: Global default settings only apply to logged-out users on public installs.
Dec 4 2016, 8:29 PM · Config, Bug Report
chad closed T11948: Facebook as Invalid.
Dec 4 2016, 7:35 PM · Bug Report
MatanUbe added a comment to T11947: Unable to push commits to hosted repositories.

Hi Chad, thanks for the quick response. That's unfortunate, I use to run setup using the "Installation Guide" a while back. That server died a few months ago and I decided to docker everything. My previous setup use to check for updates every 30 minutes and I never had any issues. Thus, I let this docker update every time it restarts, probably shouldn't have done that. :)

Dec 4 2016, 7:28 PM · Bug Report
• TattooDaniel0420 created T11948: Facebook.
Dec 4 2016, 7:21 PM · Bug Report
MatanUbe updated the task description for T11947: Unable to push commits to hosted repositories.
Dec 4 2016, 7:13 PM · Bug Report
chad added a comment to T11947: Unable to push commits to hosted repositories.

You're welcome to spin up a test instance on Phacility or do a installation from our guide, but we don't accept bug reports that include "use third party installer" to reproduce.

Dec 4 2016, 7:05 PM · Bug Report
MatanUbe created T11947: Unable to push commits to hosted repositories.
Dec 4 2016, 6:59 PM · Bug Report
• aHa renamed T11946: Global default settings only apply to logged-out users on public installs from Global default settings only apply to logged in users on non public installs to Global default settings only apply to logged-out users on public installs.
Dec 4 2016, 4:27 PM · Config, Bug Report
• aHa created T11946: Global default settings only apply to logged-out users on public installs.
Dec 4 2016, 4:25 PM · Config, Bug Report

Dec 2 2016

cspeckmim added a comment to T11943: Search results for Differential Revisions contains a displayed Date which can be confusing which date it is.

Sorry I accidentally hit Ctrl+Enter and submitted before completing the form

Dec 2 2016, 10:54 PM · Feature Request
cspeckmim updated the task description for T11943: Search results for Differential Revisions contains a displayed Date which can be confusing which date it is.
Dec 2 2016, 10:53 PM · Feature Request
cspeckmim created T11943: Search results for Differential Revisions contains a displayed Date which can be confusing which date it is.
Dec 2 2016, 10:49 PM · Feature Request