Page MenuHomePhabricator
Feed Advanced Search

Nov 1 2016

epriestley added a revision to T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions: Restricted Differential Revision.
Nov 1 2016, 8:22 PM · Calendar
epriestley added a revision to T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions: Unknown Object (Differential Revision).
Nov 1 2016, 8:07 PM · Calendar
epriestley closed T7931: Create Calendar triggers which notify users before meetings, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Nov 1 2016, 5:47 PM · Restricted Project, Prioritized, Calendar
epriestley closed T7931: Create Calendar triggers which notify users before meetings as Resolved.

These are very much proof-of-concept for now, but should technically work after D16784. Expected behavior now:

Nov 1 2016, 5:47 PM · Calendar
epriestley added a revision to T7931: Create Calendar triggers which notify users before meetings: Unknown Object (Differential Revision).
Nov 1 2016, 5:40 PM · Calendar
epriestley added a revision to T7931: Create Calendar triggers which notify users before meetings: Unknown Object (Differential Revision).
Nov 1 2016, 4:35 PM · Calendar

Oct 31 2016

epriestley closed T11804: Straighten out canceling and editing instanced events in Calendar as Resolved by committing Restricted Diffusion Commit.
Oct 31 2016, 11:38 PM · Calendar
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 10:18 PM · Calendar
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 9:12 PM · Calendar
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 8:43 PM · Calendar
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 8:40 PM · Calendar
epriestley closed T11803: Calendar doesn't show last day of period of "All Day Events" as Resolved.

I guess we're just accepting Calendar bugs in general now since I don't have a ton of known broken stuff left on my radar. I was aware of this one; D16777 should fix it.

Oct 31 2016, 6:56 PM · Calendar, Bug Report
epriestley claimed T7924: Unprototype Calendar (v1).
Oct 31 2016, 6:22 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11326: Improve Calendar v1 Design/UI/UX, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Oct 31 2016, 6:21 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11326: Improve Calendar v1 Design/UI/UX as Resolved.

I got 12 quest points. Level up!

Oct 31 2016, 6:20 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 6:20 PM · Design, Calendar
epriestley created T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions.
Oct 31 2016, 6:20 PM · Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 6:18 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 31 2016, 6:18 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 5:51 PM · Design, Calendar
epriestley created T11804: Straighten out canceling and editing instanced events in Calendar.
Oct 31 2016, 5:51 PM · Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 31 2016, 5:14 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 4:14 PM · Design, Calendar
epriestley closed T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth as Resolved by committing Restricted Diffusion Commit.
Oct 31 2016, 3:23 PM · OAuthServer, Bug Report
epriestley added a member for Community: wrl.
Oct 31 2016, 3:21 PM
epriestley edited this Badge.
Oct 31 2016, 3:21 PM
chad awarded T11801: Calendar: ICS Import Errata a Baby Tequila token.
Oct 31 2016, 1:38 PM · Bug Report, Calendar
adam93 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Oct 31 2016, 10:08 AM · Workboards (v3), Restricted Project

Oct 30 2016

epriestley moved T11801: Calendar: ICS Import Errata from Backlog to Unprototype (v1) on the Calendar board.
Oct 30 2016, 5:57 PM · Bug Report, Calendar
epriestley created T11801: Calendar: ICS Import Errata.
Oct 30 2016, 5:56 PM · Bug Report, Calendar
epriestley closed T10747: Import and export ICS from Calendar, a subtask of T7929: Integrate Calendar with external systems, as Resolved.
Oct 30 2016, 5:45 PM · Calendar
epriestley closed T10747: Import and export ICS from Calendar as Resolved.

Duplicate thing filed in T11800.

Oct 30 2016, 5:45 PM · Restricted Project, Prioritized, Calendar
epriestley created T11800: When duplicate events are imported into Calendar, show viewers only the best version.
Oct 30 2016, 5:45 PM · Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

I'm going to file the duplicate import thing as a separate task since it probably won't come up for a while and close this out.

Oct 30 2016, 5:43 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

(Google API integration is covered by T2334 -- you can already interact with Google Calendar via ICS files, but that will add support for using the API instead.)

Oct 30 2016, 4:29 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 30 2016, 4:21 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 30 2016, 4:21 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 30 2016, 4:17 PM · Design, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 30 2016, 4:13 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

The Gmail/ICS integration seems to actually work OK in practice, here's an event from this install working (modulo some stuff like us not exporting a host/organizer yet):

Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 30 2016, 3:22 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 30 2016, 3:14 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11799: Garbage tool complains about invalid translation on 'set-policy' command.

This should be fixed in HEAD of master. Thanks for the report!

Oct 30 2016, 12:13 AM · Bug Report
epriestley closed T11799: Garbage tool complains about invalid translation on 'set-policy' command as Resolved by committing Restricted Diffusion Commit.
Oct 30 2016, 12:12 AM · Bug Report
epriestley added a revision to T11799: Garbage tool complains about invalid translation on 'set-policy' command: Unknown Object (Differential Revision).
Oct 30 2016, 12:01 AM · Bug Report

Oct 29 2016

epriestley added a comment to T7607: Invoicing emails probably need some work.

We can probably just use the merchant name for now. I could maybe imagine some "International Business Machines, Inc" vs "IBM" stuff down the line, but no immediate issue for "Phacility".

Oct 29 2016, 5:05 PM · Phortune, Phacility
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

...and here are foreseeable issues with this mess occurring in the wild:

Oct 29 2016, 12:49 AM · OAuthServer, Bug Report
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

Broadly, I want to avoid implementing things that don't have good technical justifications.

Oct 29 2016, 12:30 AM · OAuthServer, Bug Report

Oct 28 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 28 2016, 11:01 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

OK I imported some real great events:

Oct 28 2016, 10:51 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 28 2016, 10:44 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 28 2016, 10:16 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

Is "GitHub-specific OAuth" just normal OAuth with client_id / client_secret as parameters instead of in an "Authorization" header? The GitHub OAuth documentation seems to suggest passing these as parameters, too.

Oct 28 2016, 9:31 PM · OAuthServer, Bug Report
epriestley added a comment to T11792: Remove "No Highlighting" mode from Diffusion.

I think the textarea predates using JS magic to make "copy" work. I think we could probably remove the "disable highlighting" mode now; I can't really imagine any legitimate reason to intentionally disable it in modern code, except maybe not realizing that "copy" will work correctly via magic.

Oct 28 2016, 7:39 PM · Diffusion, Bug Report
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

I don't think we have a "client password" in this case -- I believe that refers to a mode that no one uses for anything (well, maybe a mode that Concourse uses, I guess), where the flow is actually handling normal user passwords?

Oct 28 2016, 7:36 PM · OAuthServer, Bug Report
epriestley edited the content of Changelog.
Oct 28 2016, 7:14 PM
epriestley created 2016 Week 44 (Very Late October).
Oct 28 2016, 7:13 PM
kontextbewusst awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 28 2016, 1:41 PM · Workboards (v3), Restricted Project

Oct 27 2016

epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 27 2016, 9:34 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 27 2016, 8:08 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T11790: "VALARM" in ics makes phabricator fail parsing: Unknown Object (Differential Revision).
Oct 27 2016, 8:08 PM · Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 27 2016, 6:34 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 27 2016, 6:32 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley added a comment to T7607: Invoicing emails probably need some work.

We can, but all styles need to be inline. DifferentialInlineCommentMailView is an example of an arbitrary-HTML-generating rendering class used in mail.

Oct 27 2016, 4:04 PM · Phortune, Phacility
epriestley closed T11790: "VALARM" in ics makes phabricator fail parsing as Invalid.

Calendar is a prototype application, and we don't accept bug reports against prototypes. See User Guide: Prototype Applications and Contributing Bug Reports.

Oct 27 2016, 4:02 PM · Bug Report
epriestley closed T11789: Hide username/password in ical import url as Invalid.

See Contributing Feature Requests for a detailed breakdown of what a feature request needs to have before we'll accept it.

Oct 27 2016, 4:01 PM · Feature Request
epriestley merged T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Restricted Project, Harbormaster, Bug Report
epriestley merged task T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Bug Report
epriestley merged task T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Bug Report
epriestley merged T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T11788: Harbormaster build step "Make HTTP request" don't trim URL field .

I'm going to merge this into T10510, which discusses improving Harbormaster error behavior.

Oct 27 2016, 12:17 PM · Bug Report
stevex awarded T10215: Provide tools to combat and recover from abuse a Love token.
Oct 27 2016, 9:51 AM · Abuse

Oct 26 2016

epriestley added a comment to T11002: permit wildcards in OWNERs paths.

@pingpongboss, in T11787 it looks like you actually want to wildcard the repository names, not the paths?

Oct 26 2016, 10:44 PM · FreeBSD, Owners, Feature Request
epriestley merged task T11787: Allow Owners to set path based on string match into T11002: permit wildcards in OWNERs paths.
Oct 26 2016, 10:38 PM · Owners, Feature Request
epriestley merged T11787: Allow Owners to set path based on string match into T11002: permit wildcards in OWNERs paths.
Oct 26 2016, 10:38 PM · FreeBSD, Owners, Feature Request
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 26 2016, 9:13 PM · Design, Calendar
epriestley closed T11638: "Create Event" from day view does not default to visible day as Resolved by committing Restricted Diffusion Commit.
Oct 26 2016, 8:10 PM · Calendar
epriestley closed T11733: Calendar custom forms with modified start date / end date defaults don't work properly as Resolved by committing Restricted Diffusion Commit.
Oct 26 2016, 8:10 PM · Calendar
epriestley added a revision to T11638: "Create Event" from day view does not default to visible day: Unknown Object (Differential Revision).
Oct 26 2016, 7:52 PM · Calendar
epriestley added a revision to T11733: Calendar custom forms with modified start date / end date defaults don't work properly: Unknown Object (Differential Revision).
Oct 26 2016, 7:38 PM · Calendar
epriestley added a comment to T11733: Calendar custom forms with modified start date / end date defaults don't work properly.

I'm just going to "fix" this by just preventing you from hiding/locking/defaulting these fields, since it doesn't seem useful to create a "New Event on January 3, 2013" sort of form anyway.

Oct 26 2016, 7:25 PM · Calendar
epriestley added a comment to T7931: Create Calendar triggers which notify users before meetings.

D16752 was approximately the same thing but I think this is a little complicated -- both in general, and for recurring events. I'm also not really sure this should use the trigger system at all.

Oct 26 2016, 7:10 PM · Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 26 2016, 6:52 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 26 2016, 6:51 PM · Restricted Project, Prioritized, Calendar
• st_we awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 26 2016, 2:22 PM · Workboards (v3), Restricted Project
rabahmeradi awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Oct 26 2016, 1:56 PM · Workboards (v3), Restricted Project
nhitze awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 26 2016, 8:11 AM · Workboards (v3), Restricted Project
epriestley created T11786: Loop/degenerate behavior in RepositoryGraphCache.
Oct 26 2016, 12:26 AM · Performance, Diffusion
epriestley added a project to T11050: Allow resigning from a review you are not directly responsible for: Prioritized.
Oct 26 2016, 12:20 AM · Prioritized, Restricted Project, Differential, Feature Request

Oct 25 2016

epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 25 2016, 6:27 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 25 2016, 5:32 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 25 2016, 5:18 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 25 2016, 5:10 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 25 2016, 5:02 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7607: Invoicing emails probably need some work.

If you do Merchants, you could add sendFromEmailAddress or whatever and maybe shortNameForEmailSubjectLines (perhaps with less-awful names) and I can hook them up at some point so this:

Oct 25 2016, 4:46 PM · Phortune, Phacility