Page MenuHomePhabricator
Feed Advanced Search

Mar 18 2016

chad added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Phurl is a prototype, too.

Mar 18 2016, 10:41 PM · Phurl, Bug Report
Krenair created T10625: Links like "((prototype))" are not expanded properly in email.
Mar 18 2016, 10:40 PM · Phurl, Bug Report
chad closed T10624: Unable to disable email notifications for calendar events as Invalid.

See Prototype.

Mar 18 2016, 10:32 PM · Wikimedia, Calendar, Bug Report
Krinkle added a project to T10624: Unable to disable email notifications for calendar events : Wikimedia.
Mar 18 2016, 10:06 PM · Wikimedia, Calendar, Bug Report
Krinkle created T10624: Unable to disable email notifications for calendar events .
Mar 18 2016, 10:06 PM · Wikimedia, Calendar, Bug Report
chad closed T10615: Very large commit spacing seems off as Resolved.
Mar 18 2016, 7:07 PM · Diffusion, Bug Report
chad added a revision to T10615: Very large commit spacing seems off: Restricted Differential Revision.
Mar 18 2016, 7:07 PM · Diffusion, Bug Report
epriestley added a comment to T10614: Images in Diffusion don't register as such in BrowseTable.

(There is also a different type of cache from <object hash -> metadata> we could build in Git, but that's kind of a lot of work.)

Mar 18 2016, 2:43 PM · Diffusion, Bug Report
epriestley added a comment to T10614: Images in Diffusion don't register as such in BrowseTable.

In SVN, we can use a different icon because we have prebuilt cache of file types (and must have this cache for other reasons, and can build this cache efficiently, and SVN distinguishes between binary and text files).

Mar 18 2016, 2:40 PM · Diffusion, Bug Report
Mnkras added a comment to T10612: Editing a panel causes it to duplicate in dashboard.

I had this same issue, I had to dig into the db to remove the duplicate phids

Mar 18 2016, 1:54 AM · Dashboards (v2), Bug Report

Mar 17 2016

cinek added a comment to T10610: ExecFuture does not kill child processes on timeout.

Yes, the problem is also mentioned there, thank you. I wasn't able to find it somehow.

Mar 17 2016, 9:49 PM · libphutil, Bug Report
chad closed T10616: Audit timeline icons could be better as Resolved by committing Restricted Diffusion Commit.
Mar 17 2016, 9:19 PM · Audit, Bug Report
chad added a revision to T10616: Audit timeline icons could be better: Restricted Differential Revision.
Mar 17 2016, 8:39 PM · Audit, Bug Report
chad claimed T10616: Audit timeline icons could be better.
Mar 17 2016, 7:14 PM · Audit, Bug Report
chad created T10616: Audit timeline icons could be better.
Mar 17 2016, 7:14 PM · Audit, Bug Report
chad claimed T10615: Very large commit spacing seems off.
Mar 17 2016, 7:12 PM · Diffusion, Bug Report
chad created T10615: Very large commit spacing seems off.
Mar 17 2016, 7:12 PM · Diffusion, Bug Report
chad created T10614: Images in Diffusion don't register as such in BrowseTable.
Mar 17 2016, 7:10 PM · Diffusion, Bug Report
ofbeaton created T10612: Editing a panel causes it to duplicate in dashboard.
Mar 17 2016, 5:46 PM · Dashboards (v2), Bug Report
r0bbie added a project to T10611: No option to specify a Space when editing a Project's visibility policy: Spaces.
Mar 17 2016, 4:05 PM · Projects, Restricted Project, Feature Request, Spaces
r0bbie updated the task description for T10611: No option to specify a Space when editing a Project's visibility policy.
Mar 17 2016, 4:05 PM · Projects, Restricted Project, Feature Request, Spaces
r0bbie updated the task description for T10611: No option to specify a Space when editing a Project's visibility policy.
Mar 17 2016, 4:05 PM · Projects, Restricted Project, Feature Request, Spaces
r0bbie updated the task description for T10611: No option to specify a Space when editing a Project's visibility policy.
Mar 17 2016, 4:04 PM · Projects, Restricted Project, Feature Request, Spaces
r0bbie updated the task description for T10611: No option to specify a Space when editing a Project's visibility policy.
Mar 17 2016, 4:03 PM · Projects, Restricted Project, Feature Request, Spaces
r0bbie created T10611: No option to specify a Space when editing a Project's visibility policy.
Mar 17 2016, 4:02 PM · Projects, Restricted Project, Feature Request, Spaces
epriestley added a comment to T10264: git clone using http hangs after update.

D15483 changes the constant to 47 (15 window size + 32 for gzip + zlib), which should accept and decode the broadest possible range of inputs. If this somehow breaks something, 31 (15 window size + 16 for gzip only) is probably the next thing to try. See that change for discussion.

Mar 17 2016, 3:34 PM · Bug Report, Diffusion
epriestley added a comment to T10610: ExecFuture does not kill child processes on timeout.

This is probably a variant on T4551.

Mar 17 2016, 3:00 PM · libphutil, Bug Report
cinek created T10610: ExecFuture does not kill child processes on timeout.
Mar 17 2016, 2:40 PM · libphutil, Bug Report
• test1212 added a project to T10608: Arc diff failing to generate diff with svn 1.9.3: Arcanist.
Mar 17 2016, 11:04 AM · Arcanist, Bug Report
• test1212 created T10608: Arc diff failing to generate diff with svn 1.9.3.
Mar 17 2016, 10:49 AM · Arcanist, Bug Report
chad added a comment to T10606: To submit inline comments you must submit a mock-level comment.

(See also T2636 for previous discussion).

Mar 17 2016, 3:08 AM · Pholio, Bug Report
chad added a comment to T10606: To submit inline comments you must submit a mock-level comment.

Pholio itself is getting fairly old, not sure when it'll get re-visited, maybe 6-12 months?

Mar 17 2016, 1:08 AM · Pholio, Bug Report
chad closed T10606: To submit inline comments you must submit a mock-level comment as Invalid.

This is consistent with inline comments across all of Phabricator.

Mar 17 2016, 12:31 AM · Pholio, Bug Report
awfy created T10606: To submit inline comments you must submit a mock-level comment.
Mar 17 2016, 12:27 AM · Pholio, Bug Report

Mar 16 2016

eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

We'll try that in our next upgrade. Thanks for the help!

Mar 16 2016, 10:05 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Here's a diff to make bin/storage adjust always run ANALYZE on every table after it makes other adjustments, but I'm not really sure if that's actually helpful or not (e.g., from the documentation, it sounds like the good analysis can be immediately overwritten by a bad one in some cases?):

Mar 16 2016, 10:01 PM · Infrastructure
epriestley added a revision to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Restricted Differential Revision.
Mar 16 2016, 9:50 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I think so. Sorry for the originally misleading claim.Sorry for the originally misleading claim.

Mar 16 2016, 9:48 PM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Should we get rid of the <commitID, isDirect, changeType> key, then?

Mar 16 2016, 9:43 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Well, the docs suggest not doing that:

Mar 16 2016, 9:29 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Should we get rid of the <commitID, isDirect, changeType> key, then?

Mar 16 2016, 9:24 PM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

The discrepancy between staging + production is almost certainly caused by the size of the data.

You do not need to create a secondary index on changeId as that is the leftmost part of the primary key. The secondary index just points to the primary index where the data is stored.

The underlying cause of the slowness is because the stats were completely off in the production table (was showing cardnality of 18 for changeId).

Mar 16 2016, 9:13 PM · Infrastructure
urzds added a comment to T10427: Errors when adding person to subproject.

I can confirm that, too.

Mar 16 2016, 7:09 PM · Projects
epriestley added a revision to T10264: git clone using http hangs after update: Restricted Differential Revision.
Mar 16 2016, 5:51 PM · Bug Report, Diffusion
epriestley closed T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs as Resolved.
Mar 16 2016, 2:49 PM · Installing & Upgrading, Bug Report
• jlvillapalos added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

@epriestley, first time I tried I just wasn't lucky enough to navigate to Config->Versions.
By the way I updated my Phabricator version and it works fine.

Mar 16 2016, 2:48 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

@jlvillapalos, can you shed some light on why you didn't include that information in the first place or how we could improve the process?

Mar 16 2016, 1:49 PM · Installing & Upgrading, Bug Report
epriestley closed T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery". as Resolved.

bin/remove destroy gives you a huge scary red skull-and-crossbones ASCII art for good reason, and you're accepting that issues like this may occur when you confirm the prompt.

Mar 16 2016, 1:40 PM · Audit, Diffusion, Bug Report
• tinytiongson added a project to T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery".: Audit.

The problem was encountered when we have deleted the existing repository with audits because we wanted to include not just the trunk but all its branches. The thing was that the deleted repository in Diffusion was not the first one to be imported again.

Mar 16 2016, 1:30 PM · Audit, Diffusion, Bug Report
epriestley merged task T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」 into T5214: Add Conduit API methods for workboards.
Mar 16 2016, 11:49 AM · Bug Report
epriestley added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

This transaction can only create a task into a column, it can't move a task. That's why the documentation says "Create into a workboard column.".

Mar 16 2016, 11:48 AM · Bug Report
• jlvillapalos added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

This is the version information, but it will be very useful to give instructions of where to look to get it.

Mar 16 2016, 7:39 AM · Installing & Upgrading, Bug Report
AmyLewis added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

@chad Probably the same purpose.

Mar 16 2016, 2:54 AM · Bug Report
chad added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

Is this different than T5214?

Mar 16 2016, 2:51 AM · Bug Report
AmyLewis created T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.
Mar 16 2016, 2:44 AM · Bug Report
epriestley closed T10597: Custom Project query results in . url which nginx blocks as Resolved.

We'll consider adding a setup issue if we see other users having issues with this. Previously, we haven't, so we presume users having or uncommenting these blocks in the wild to be very rare.

Mar 16 2016, 2:05 AM · Bug Report
ofbeaton added a comment to T10597: Custom Project query results in . url which nginx blocks.

I'd be OK with that. I already got our admin to resolve the problem for my install, so I only raised this thinking it would help others. A server configuration warning would also have worked to have me fix this before users encountered it.

Mar 16 2016, 2:00 AM · Bug Report
chad added a comment to T10597: Custom Project query results in . url which nginx blocks.

The correct solution for us would be to detect the servers misconfiguration and raise a setup issue asking the admin to resolve.

Mar 16 2016, 1:56 AM · Bug Report
ofbeaton added a comment to T10597: Custom Project query results in . url which nginx blocks.

You already gave one @chad, on Ubuntu if the sysadmin uncomments that section, then any link starting with .ht would be blocked.

Mar 16 2016, 1:52 AM · Bug Report
chad added a comment to T10597: Custom Project query results in . url which nginx blocks.

Also, we link to . files elsewhere in Phabricator, so if we change Project URLs, this webserver config would still break other parts of Phabricator, like linking to .gitignore in your repository.

Mar 16 2016, 12:35 AM · Bug Report
chad added a comment to T10597: Custom Project query results in . url which nginx blocks.

This is what I see on Ubuntu for default conf files for nginx, it's both commented out and restricted to .ht:

Mar 16 2016, 12:31 AM · Bug Report
chad added a comment to T10597: Custom Project query results in . url which nginx blocks.

It is extremely common to have nginx configuration

Mar 16 2016, 12:20 AM · Bug Report

Mar 15 2016

ofbeaton created T10597: Custom Project query results in . url which nginx blocks.
Mar 15 2016, 11:55 PM · Bug Report
rbalik added a comment to T10427: Errors when adding person to subproject.

Ok, I was able to add the user to the project by adding him to one of the subprojects. I guess that works for us. Thanks for your help.

Mar 15 2016, 9:42 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

Oh, I totally misunderstood what you said.

Mar 15 2016, 9:40 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

I have also archived both subprojects in an attempt to workaround this and I still can't add users to the parent project.

Mar 15 2016, 9:34 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

Both subprojects are set to "All Users" for their permissions

Mar 15 2016, 9:29 PM · Projects
chad added a comment to T10427: Errors when adding person to subproject.

I still can't add users to the parent project though

Mar 15 2016, 9:28 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

I was calling it a zombie because I couldn't join it or change any of the settings on it even though it said I had permissions to do so. Maybe not the best description.

Mar 15 2016, 9:27 PM · Projects
chad added a comment to T10427: Errors when adding person to subproject.

What is a "zombie" subproject and how can we reproduce this?

Mar 15 2016, 9:25 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

Ok, I was able to join the subproject by setting permissions on the parent project to allow joining by "All Users"
I still can't add users to the parent project though

Mar 15 2016, 9:24 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

The original error message seems to be improved, btw, but I also seem to have a zombie subproject now.

Mar 15 2016, 9:10 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

Upgraded to 121e68e3 and the problem is still there

Mar 15 2016, 9:05 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

Oh and we're at 31984a78ee at the moment. I may run an upgrade here in a bit just to see if the newer version fixes anything.
It looks like any project with subprojects has the "Add Member" link grayed out.

Mar 15 2016, 9:03 PM · Projects
rbalik added a comment to T10427: Errors when adding person to subproject.

Hi guys, any update on this? It looks like I can't add members to the parent project either so subprojects seems to be making a mess of things at the moment.

Mar 15 2016, 9:02 PM · Projects
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Interesting (and weird). Thanks for the update -- and good luck figuring things out.

Mar 15 2016, 8:54 PM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Quick update here. We've found that adding FORCE INDEX (primary) results in 79.4ms in production even without the key_history index.

Mar 15 2016, 8:42 PM · Infrastructure
epriestley added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

The issue you're experiencing is because you're out of date.

Mar 15 2016, 5:02 PM · Installing & Upgrading, Bug Report
swisspol added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

I've rebooted the Windows VM and haven't seen this issue in a few days. So we're good. Thanks for the help.

Mar 15 2016, 3:52 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T10593: test.

(That was a race, not me separately correcting the status, if it wasn't obvious.)

Mar 15 2016, 3:50 PM · Bug Report
epriestley added a comment to T10593: test.

Truly, we have closed this task.

Mar 15 2016, 3:50 PM · Bug Report
chad updated subscribers of T10593: test.

time well spent, @epriestley

Mar 15 2016, 3:50 PM · Bug Report
epriestley added a comment to T10591: viewing D8084 on this install results in InvalidArgumentException.

That is a cool looking bug.

Mar 15 2016, 3:50 PM · Bug Report
epriestley changed the status of T10593: test from Invalid to Spite.
Mar 15 2016, 3:49 PM · Bug Report
chad closed T10593: test as Invalid.
Mar 15 2016, 3:49 PM · Bug Report
chad added a comment to T10591: viewing D8084 on this install results in InvalidArgumentException.

bug report.png (1×1 px, 1 MB)

Mar 15 2016, 3:48 PM · Bug Report
AmyLewis created T10593: test.
Mar 15 2016, 3:47 PM · Bug Report
epriestley closed T10591: viewing D8084 on this install results in InvalidArgumentException as Resolved by committing Restricted Diffusion Commit.
Mar 15 2016, 3:19 PM · Bug Report
epriestley added a revision to T10591: viewing D8084 on this install results in InvalidArgumentException: Restricted Differential Revision.
Mar 15 2016, 3:17 PM · Bug Report
cburroughs created T10591: viewing D8084 on this install results in InvalidArgumentException.
Mar 15 2016, 3:12 PM · Bug Report
chad updated the task description for T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.
Mar 15 2016, 2:27 PM · Installing & Upgrading, Bug Report
chad added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

General questions about using Phabricator are best in Ponder or IRC. If this is actually a bug report, you must provide full steps that we may locally reproduce the issue. Thanks!

Mar 15 2016, 2:26 PM · Installing & Upgrading, Bug Report
• jlvillapalos created T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.
Mar 15 2016, 12:28 PM · Installing & Upgrading, Bug Report
valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

OK, after installing all the necessary extensions and changing the php.ini as recommended by phabricator everything works nice.

Mar 15 2016, 12:19 PM · Setup, Bug Report
valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

OK, I'm going to switch to php7 and see if it goes.

Mar 15 2016, 11:48 AM · Setup, Bug Report
epriestley merged task T10586: Call to undefined function mysql_real_escape_string() into T2383: Run PHP environment checks from CLI.
Mar 15 2016, 11:47 AM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

T9640 is tracking PHP7 compatibility. We haven't extensively tested Phabricator on PHP7 yet, but I believe several users are running it without any issues. We're happy to fix issues you encounter with PHP7 if you report them.

Mar 15 2016, 11:46 AM · Setup, Bug Report
valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

@epriestley that is from PHP 5.6.17

Mar 15 2016, 11:43 AM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

Is that output from the version of PHP with a problem, or from PHP 5.6.17?

Mar 15 2016, 11:13 AM · Setup, Bug Report
valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

The issue is not comming from missing php-extentions. mysqli was installed and present in fpm and cli so that was not the issue.
The actual function is missing, as @eadler said in the previous comment.

Mar 15 2016, 11:12 AM · Setup, Bug Report