Page MenuHomePhabricator
Feed Advanced Search

Jul 23 2015

epriestley closed T8935: Add possibility to add user access to repository via shell as Resolved.

Cool. Let us know if you're still having issues.

Jul 23 2015, 5:20 PM · Policy, Diffusion
epriestley added a comment to T8916: How to set server default language.

It is always English (US).

Jul 23 2015, 12:31 PM · User Preferences, Config, Documentation
epriestley added a comment to T8935: Add possibility to add user access to repository via shell.

You can use bin/policy unlock <object> to open up the policies on an object. For example, bin/policy unlock rXYZ.

Jul 23 2015, 12:20 PM · Policy, Diffusion
epriestley updated subscribers of T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException").
Jul 23 2015, 2:03 AM · Diffusion
epriestley merged task T8933: Grep with no results ends with Unhandled Exception into T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException").
Jul 23 2015, 2:03 AM · Diffusion
chad awarded V28: Is the inline-porting feature a net improvement to Differential? a Haypence token.
Jul 23 2015, 1:03 AM

Jul 22 2015

epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Walking through some use cases, roughly in increasing order of complexity, and general behaviors -- this is all me just imagining things, not necessarily the best way forward:

Jul 22 2015, 9:39 PM · Phurl
epriestley added a comment to T8929: Arcanist glitch for `arc help ---full`.

Does this fix it?

Jul 22 2015, 7:00 PM · Arcanist
epriestley added a comment to T8929: Arcanist glitch for `arc help ---full`.

If you type this:

Jul 22 2015, 6:54 PM · Arcanist
epriestley added a comment to T2495: Improve whitespace expansion of tab literals.

This is the task for it.

Jul 22 2015, 4:27 PM · Restricted Project, FreeBSD, Diffusion, Differential
epriestley added a comment to T4830: Applications with Public permissions requiring users to login.

Yeah, I'm mostly concerned about future changes (offhand: phone numbers, emails, messenger handles, oncall schedules, events/availability).

Jul 22 2015, 2:52 PM · Facts, Policy, People
epriestley renamed T8926: Issues configuring external auth providers from Issues implementing external auth providers to Issues configuring external auth providers.
Jul 22 2015, 2:15 PM · Auth
epriestley changed the status of T8908: Don't show admin apps to non-admins from Duplicate to Resolved by committing Restricted Diffusion Commit.
Jul 22 2015, 2:15 PM · Applications
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Okay, can you file a separate issue for that and I'll try to reproduce it? That's bad and not the expected queue behavior.

Jul 22 2015, 2:13 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

Would roles be able to have a list of default Projects (or Space?) which members of the role are added to? Or should we expect to migrate to role-based permissions?

Jul 22 2015, 1:38 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

commits without UTF8 data in them effectively block the queue.

Jul 22 2015, 1:36 PM · Restricted Project, Auth, Conduit
epriestley triaged T8921: arc diff failing due to "invalid type" error as Normal priority.
Jul 22 2015, 1:30 PM · Arcanist
epriestley triaged T8918: Header shows number of notifications and various other controls on the 2FA auth screen as Normal priority.
Jul 22 2015, 1:29 PM · Security, Auth
epriestley claimed T8918: Header shows number of notifications and various other controls on the 2FA auth screen.

there could be info in saved searches

Jul 22 2015, 1:29 PM · Security, Auth
epriestley added a comment to T8918: Header shows number of notifications and various other controls on the 2FA auth screen.

Is this really a case of information being useful to an attacker?

Jul 22 2015, 1:28 PM · Security, Auth
epriestley added a comment to T8926: Issues configuring external auth providers.

To address two things immediately:

Jul 22 2015, 1:22 PM · Auth

Jul 21 2015

epriestley added a comment to T8920: 'Another Herald rule matches' is being displayed as a raw PHID.

This one is a bit magical and needs some adjustments after changes from T8726.

Jul 21 2015, 6:43 PM · Herald
epriestley added a parent task for T8920: 'Another Herald rule matches' is being displayed as a raw PHID: T8726: Modularize Herald fields and actions.
Jul 21 2015, 6:42 PM · Herald
epriestley added a subtask for T8726: Modularize Herald fields and actions: T8920: 'Another Herald rule matches' is being displayed as a raw PHID.
Jul 21 2015, 6:42 PM · Herald
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

(I did so.)

Jul 21 2015, 6:39 PM · Differential
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

That change doesn't fix things retroactively. I can delete draft 315073 if you really don't like that specific bubble.

Jul 21 2015, 6:38 PM · Differential
epriestley added a comment to T8918: Header shows number of notifications and various other controls on the 2FA auth screen.

Can you construct a plausible scenario where this information is substantially useful to an attacker?

Jul 21 2015, 6:38 PM · Security, Auth
epriestley closed T8917: Diff says it has unsubmitted comments, but I can't find them as Resolved by committing Restricted Diffusion Commit.
Jul 21 2015, 6:36 PM · Differential
epriestley added a comment to T8908: Don't show admin apps to non-admins.

I would argue that showing stuff to users that cannot be used is a UX bug.

Jul 21 2015, 6:35 PM · Applications
epriestley assigned T8911: Calendar List view sorting happens after limits are applied to lpriestley.

(I haven't tried to reproduce this.)

Jul 21 2015, 6:18 PM · Calendar
epriestley closed T8915: Typo in arc's `help tasks` output as Resolved by committing Restricted Diffusion Commit.
Jul 21 2015, 6:14 PM · Arcanist
epriestley added a comment to T8916: How to set server default language.

There is no way to do this right now. T4103 will provide a way.

Jul 21 2015, 6:14 PM · User Preferences, Config, Documentation
epriestley merged T8916: How to set server default language into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Jul 21 2015, 6:13 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley merged task T8916: How to set server default language into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Jul 21 2015, 6:13 PM · User Preferences, Config, Documentation
epriestley added a revision to T8917: Diff says it has unsubmitted comments, but I can't find them: Unknown Object (Differential Revision).
Jul 21 2015, 6:13 PM · Differential
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

Repro instructions are:

Jul 21 2015, 6:09 PM · Differential
epriestley claimed T8917: Diff says it has unsubmitted comments, but I can't find them.
Jul 21 2015, 6:09 PM · Differential
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

For my own reference:

Jul 21 2015, 5:54 PM · Differential
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

(or posting, I tried just submitting and it wouldn't let me)

Jul 21 2015, 5:48 PM · Differential
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

Specifically, I would expect the comment to appear in the preview at the bottom of the page, but not be visible inline in the diff itself.

Jul 21 2015, 5:25 PM · Differential
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

It looks like you have an unsubmitted inline on line 70 of PhabricatorBadgesRemoveRecipientsController.php with this text:

Jul 21 2015, 5:24 PM · Differential
epriestley added a comment to T8917: Diff says it has unsubmitted comments, but I can't find them.

If you scroll to the bottom of the screen, is there a saved value for "Action"?

Jul 21 2015, 5:12 PM · Differential
epriestley triaged T8902: Add policy to mailing list users for settings as Wishlist priority.
Jul 21 2015, 11:26 AM · FreeBSD, Policy, People, Mailing Lists
epriestley added a comment to T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly.

This reproduces locally for me.

Jul 21 2015, 11:25 AM · Maniphest
epriestley triaged T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly as Normal priority.
Jul 21 2015, 11:21 AM · Maniphest
epriestley edited projects for T8904: Make tag bubbles clickable in text field popovers, added: Typeahead; removed PHUI.
Jul 21 2015, 11:17 AM · Typeahead
epriestley added a comment to T8904: Make tag bubbles clickable in text field popovers.

I didn't get as far as implementing this, but my intention was to make clicking the token eventually take you to the object's page (for example, the project's detail page or the user's profile page), not select the token.

Jul 21 2015, 11:16 AM · Typeahead
epriestley updated subscribers of T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Jul 21 2015, 11:09 AM · Restricted Project, Restricted Project, Custom Fields
epriestley merged task T8905: Allow Herald to assign a task back to original author into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Jul 21 2015, 11:09 AM · Maniphest, Herald
epriestley added a comment to T8905: Allow Herald to assign a task back to original author.

Based on context (in T8906) and previous discussion, my guess is that you're trying to make the "Projects" field required. I'm going to merge this into T6030, which discusses solving that root issue (among other related issues).

Jul 21 2015, 11:08 AM · Maniphest, Herald
epriestley renamed T8913: be able to config PytestTestEngine from RFE: be able to config PytestTestEngine to be able to config PytestTestEngine.
Jul 21 2015, 11:04 AM · Arcanist
epriestley updated subscribers of T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Jul 21 2015, 11:04 AM · Restricted Project, Restricted Project, Custom Fields
epriestley merged task T8906: Allow Herald to add comments to tasks into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Jul 21 2015, 11:03 AM · Maniphest, Herald
epriestley added a comment to T8906: Allow Herald to add comments to tasks.

We'd prefer to solve this by letting you make the "Projects" field required, since that's the actual root issue. I'm going to merge this into T6030, which is the general blocker for that.

Jul 21 2015, 11:02 AM · Maniphest, Herald
epriestley added a revision to T8908: Don't show admin apps to non-admins: Unknown Object (Differential Revision).
Jul 21 2015, 10:59 AM · Applications
epriestley added a comment to T8908: Don't show admin apps to non-admins.

I haven't seen any reports of actual users experiencing real confusion. If and when we do, I'd prefer to tailor any solution here to their actual confusion (e.g., what were they expecting to see, what were they trying to do, why did they find this confusing), and imagine that hiding these applications is probably not the best solution (offhand, another solution might be marking these applications as admin-only instead). In legal jargon, this issue isn't "ripe".

Jul 21 2015, 10:32 AM · Applications
epriestley updated the task description for T8909: Provide ability to hide all inline or done comments.
Jul 21 2015, 10:13 AM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley edited projects for T8909: Provide ability to hide all inline or done comments, added: Differential; removed Maniphest.
Jul 21 2015, 10:13 AM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley reopened T8905: Allow Herald to assign a task back to original author as "Open".

This isn't quite the same as T7804, see T7804#127310 for discussion.

Jul 21 2015, 10:12 AM · Maniphest, Herald
epriestley added a comment to T7804: Implement an "Acting User" Herald condition.

These aren't quite the same. One is a new condition/field, which would let you write rules like this ("mail me about all zebra stuff, except if I took the action"):

Jul 21 2015, 10:11 AM · Restricted Project, Herald, Mail
epriestley added a comment to T8900: Copying contents from Phriction history diff doesn't work.

In any case, is it expected that line numbers are being copied in the unified diff case?

Jul 21 2015, 3:22 AM · Restricted Project, Infrastructure, Differential, Phriction
epriestley closed T6859: It is difficult to keep track of used PhabricatorEdgeType IDs as Resolved by committing Restricted Diffusion Commit.
Jul 21 2015, 12:08 AM · Infrastructure
epriestley added a comment to T8900: Copying contents from Phriction history diff doesn't work.

Do you have an example where copying the right side of a diff currently does not work like you expect/want it to?

Jul 21 2015, 12:05 AM · Restricted Project, Infrastructure, Differential, Phriction
epriestley added a revision to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs: Unknown Object (Differential Revision).
Jul 21 2015, 12:04 AM · Infrastructure

Jul 20 2015

epriestley added a comment to T8900: Copying contents from Phriction history diff doesn't work.

When copying from Phriction and transaction diffs (for example, the diff shown in "Show Details" on a transaction like "alincoln edited the description for this task."), you're also copying out of a diff which we've inserted artificial linebreaks into. These linebreaks are inserted prior to diffing, and these diffs are generally of very low quality. There's some discussion in T3353 of improving these diffs to be word-based instead of character-based, which is likely to substantially mitigate issues around linebreaks and the generally low quality of these diffs.

Jul 20 2015, 11:21 PM · Restricted Project, Infrastructure, Differential, Phriction
epriestley added a comment to T8900: Copying contents from Phriction history diff doesn't work.

In 1-up, there's no ambiguity and we can improve this behavior.

Jul 20 2015, 11:14 PM · Restricted Project, Infrastructure, Differential, Phriction
epriestley assigned T8893: Provide user-friendly modal when a non-administrator attempts to uninstall an application to lpriestley.
Jul 20 2015, 7:39 PM · Applications
epriestley added a comment to T8881: Ask 2nd confirmation when disabling instance on Phacility.

No, it's enabled for your accounts only.

Jul 20 2015, 6:34 PM · Phacility
epriestley added a comment to T8897: "Attending" in Calendar list view shows all users, not just attending users.

I destroyed F641702 and F641705.

Jul 20 2015, 12:13 PM · Calendar
epriestley updated the task description for T8897: "Attending" in Calendar list view shows all users, not just attending users.
Jul 20 2015, 12:13 PM · Calendar
epriestley added a comment to T8899: Add upstream Diviner and Phriction content to Phabricator default install.

We aren't going to ship with the Phriction content.

Jul 20 2015, 11:47 AM · Documentation, Phriction, Diviner
epriestley updated subscribers of T8898: Amazon Logo in Bitbucket Provider button.
Jul 20 2015, 11:46 AM · Auth
epriestley changed the visibility for T8897: "Attending" in Calendar list view shows all users, not just attending users.
Jul 20 2015, 11:44 AM · Calendar
• lavahot awarded T3993: Build a global menu item showing the current Phrequent stack a Like token.
Jul 20 2015, 6:48 AM · Phrequent
epriestley closed T8896: add button to set reasonable email defaults as Invalid.

Reasonable defaults are set by default.

Jul 20 2015, 2:38 AM · Mail
epriestley added a comment to T8881: Ask 2nd confirmation when disabling instance on Phacility.

That change adds a "safe mode" for specific accounts, which prevents them from using the console to disable instances and instructs them to contact support instead:

Jul 20 2015, 12:08 AM · Phacility
epriestley added a revision to T8881: Ask 2nd confirmation when disabling instance on Phacility: Unknown Object (Differential Revision).
Jul 20 2015, 12:08 AM · Phacility
epriestley added a revision to T8879: Prompt user to enter instance name when disabling instance on Phacility: Unknown Object (Differential Revision).
Jul 20 2015, 12:08 AM · Phacility

Jul 19 2015

epriestley added a comment to T8881: Ask 2nd confirmation when disabling instance on Phacility.

However, here's another suggestion: don't allow people to disable instance outside of Phacility conservative work hours. This way it's guaranteed that in case of a mistake, one can reach support immediately.

Jul 19 2015, 11:46 PM · Phacility
epriestley added a comment to T8881: Ask 2nd confirmation when disabling instance on Phacility.

I don't know what the reasoning is to prevent people from doing this, but

Jul 19 2015, 7:54 PM · Phacility

Jul 18 2015

epriestley closed T8890: releeph: Call to undefined method PHUIObjectItemListView::getActions() as Resolved.

Restart Apache or PHP-FPM, according to the upgrade guide:

Jul 18 2015, 9:43 PM · Releeph
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 18 2015, 1:07 PM · Herald
epriestley added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

That isn't a great solution - it should be possible to set a max ram used, rather than max percent free

Jul 18 2015, 12:20 PM · Search, Daemons
epriestley added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

Shouldn't we do something similar by default?

Jul 18 2015, 12:17 PM · Search, Daemons
epriestley added a comment to T8879: Prompt user to enter instance name when disabling instance on Phacility.

This is the dialog you had trouble with, right?

Jul 18 2015, 2:49 AM · Phacility
epriestley closed T8882: Convert "serious business" mode to a locale as Wontfix.

Then we'd need serious + non-serious locales in every language.

Jul 18 2015, 2:48 AM · Localization
epriestley added a comment to T8881: Ask 2nd confirmation when disabling instance on Phacility.

Just to make sure, this is the dialog you confirmed your way through by accident?

Jul 18 2015, 2:47 AM · Phacility

Jul 17 2015

epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 17 2015, 5:31 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

I'll try to make this more clear after T8726.

Jul 17 2015, 5:03 PM · Herald
epriestley renamed T8876: Fix weird object name on Fund Initiatives from Fix weird object name on initiatives to Fix weird object name on Fund Initiatives.
Jul 17 2015, 4:48 PM · Fund
epriestley created T8876: Fix weird object name on Fund Initiatives.
Jul 17 2015, 4:47 PM · Fund
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 17 2015, 3:19 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

Note that in this case and in the T8863 case, mail recipients must now be able to see objects (e.g., revisions and repositories) to receive email about them. It's possible that that's the source of this issue.

Jul 17 2015, 2:34 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

I can't reproduce this. Here's a rule I wrote:

Jul 17 2015, 2:32 PM · Herald
epriestley added a comment to D13639: Prevent 'Start or Wait for Build Plan' from running disabled build plans.

I think this scenario would be better handled with a "Skip" or "Pass" build step than treating disabled plans as automatic passes. That behavior seems very unintuitive to me.

Jul 17 2015, 1:59 PM
epriestley triaged T8875: V4 support for Phabricator's S3 File backend as Wishlist priority.
Jul 17 2015, 1:57 PM · Files
epriestley closed T8864: Arcanist staleness control as Invalid.

We already have such a mechanism.

Jul 17 2015, 1:57 PM · Arcanist
epriestley closed T8867: Add "Editable by" field to top-level project details page as Wontfix.

You can click "Edit Project" to figure out what the policy is (it will either show you or tell you). This request doesn't really describe a problem.

Jul 17 2015, 1:56 PM · Projects
epriestley closed T8866: PhutilJSONParserException error when access phabricator/T2050 page. as Resolved.
Jul 17 2015, 1:50 PM · Maniphest
epriestley added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

Use --autoscale-reserve to prevent them from autoscaling past some amount of memory. For example, this will prevent autoscaling if less than 25% of RAM is free:

Jul 17 2015, 1:49 PM · Search, Daemons