Page MenuHomePhabricator
Feed Advanced Search

Mar 31 2015

epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 31 2015, 1:47 PM · Typeahead
epriestley added a comment to T7707: Implement a read-through cache layer.

Quite possibly we should just denormalize profileImageURI and calendarStatus + calendarStatusTTL onto PhabricatorUser, since we almost always need those anyway and mixing real object queries with a read-through cache isn't a great v0 feature.

Mar 31 2015, 1:05 PM · Performance
epriestley moved T7708: Improve performance of chat column from Backlog to v2 on the Conpherence board.
Mar 31 2015, 1:01 PM · Conpherence
epriestley added a subtask for T7708: Improve performance of chat column: T7707: Implement a read-through cache layer.
Mar 31 2015, 1:01 PM · Conpherence
epriestley added a parent task for T7707: Implement a read-through cache layer: T7708: Improve performance of chat column.
Mar 31 2015, 1:01 PM · Performance
epriestley created T7708: Improve performance of chat column.
Mar 31 2015, 1:00 PM · Conpherence
epriestley created T7707: Implement a read-through cache layer.
Mar 31 2015, 12:02 PM · Performance
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

FWIW, I was pretty skeptical of the icons before we had them but I kind of like them now. :o

Mar 31 2015, 12:11 AM · Wikimedia, Conpherence
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

Yeah, this is really the only part that feels bad to me:

Mar 31 2015, 12:06 AM · Wikimedia, Conpherence
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

I prefer retaining titles for threads, a lot of mine are pretty meaningful. They're also meaningful when things convert up to email.

Mar 31 2015, 12:02 AM · Wikimedia, Conpherence

Mar 30 2015

epriestley created T7705: "See More" in Conpherence sidebar under "Rooms" has outdated link.
Mar 30 2015, 11:49 PM · Conpherence
epriestley added a comment to T7584: Add an ApplicationSearch UI for rooms to Conpherence.

That makes sense to me. I think D12215 is generally a good smooth intro to letting users do everything without overcommitting to tons of JS.

Mar 30 2015, 11:29 PM · Conpherence
epriestley added a comment to T1460: Add "Done" link to an inline comment.

(At the same time, I hesitate a bit because having the icons up there be totally different for every comment is also weird.)

Mar 30 2015, 11:26 PM · User Delight, Differential
epriestley added a comment to T1460: Add "Done" link to an inline comment.

At first actual-real-use, this state feels a little weird to me (the "Not Done", specifically). Maybe we should just hide the checkbox element on drafts, now that we aren't letting you pre-check your own comments?

Mar 30 2015, 11:22 PM · User Delight, Differential
epriestley added a comment to T7004: Don't send email whilst online.

Note that you always receive a notification. Going to Notifications will always show you everything.

Mar 30 2015, 11:19 PM · Notifications, Mail
epriestley triaged T7703: Policy checks may execute incompletely for non-viewers as Normal priority.
Mar 30 2015, 11:12 PM · Policy, Herald, Flags
epriestley closed T7702: Unread notification counter not working? as Wontfix.

In any case, we're very unlikely to ever put time delays on mail.

Mar 30 2015, 11:12 PM
epriestley added a comment to T7702: Unread notification counter not working?.

See also T7004.

Mar 30 2015, 11:09 PM
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

We are doing a policy check here, but it's an unusual check and it's not fully effective.

Mar 30 2015, 11:08 PM · Policy, Herald, Flags
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

The expectation is that the rule will fail to run when the user can't see the object. The code is consistent with this expectation, looking into it..

Mar 30 2015, 10:44 PM · Policy, Herald, Flags
epriestley claimed T7703: Policy checks may execute incompletely for non-viewers.
Mar 30 2015, 10:43 PM · Policy, Herald, Flags
epriestley added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

It looks like this is probably not a bug then, and D12211 is a fairly reasonable fix.

Mar 30 2015, 9:58 PM · Firefox, Differential
epriestley added a revision to T7441: Support OAuth providers in the cluster: Unknown Object (Differential Revision).
Mar 30 2015, 9:40 PM · Auth, Phacility
epriestley added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

I narrowed it down a bit more, although this is in Safari and the behavior is generally super inconsistent/crazy across browsers: I see scrollbars in Safari and Firefox for your reduced case, but not Chrome. I see scrollbars in Safari and Chrome for my reduced case, but not Firefox (all on OSX).

Mar 30 2015, 9:36 PM · Firefox, Differential
epriestley claimed T7441: Support OAuth providers in the cluster.
Mar 30 2015, 9:18 PM · Auth, Phacility
epriestley added a comment to T7701: Surface Code/File search better in Diffusion.

See also T7472.

Mar 30 2015, 9:04 PM · Restricted Project, Design, Diffusion
epriestley added a comment to T7701: Surface Code/File search better in Diffusion.

T6670

Mar 30 2015, 9:04 PM · Restricted Project, Design, Diffusion
epriestley created T7700: DarkConsole doesn't work properly with Quicksand.
Mar 30 2015, 8:50 PM · Quicksand
epriestley added a comment to T7699: Busy spinner should be in body content, not chat column.

haha

Mar 30 2015, 8:49 PM · Conpherence
epriestley added a comment to T7699: Busy spinner should be in body content, not chat column.

Here's that screenshot with more context so it's less confusing given my super hip cool localization:

Mar 30 2015, 8:48 PM · Conpherence
epriestley created T7699: Busy spinner should be in body content, not chat column.
Mar 30 2015, 8:46 PM · Conpherence
epriestley closed T7119: Find another workaround for the "dumb terminal" warnings which doesn't hang as Resolved by committing Restricted Diffusion Commit.
Mar 30 2015, 8:02 PM · Mercurial
btrahan awarded T7689: Load handles just-in-time a Doubloon token.
Mar 30 2015, 7:53 PM · Typeahead
epriestley closed T7690: Unnecessary scroll bars for changesets in Firefox as Resolved by committing Restricted Diffusion Commit.
Mar 30 2015, 7:06 PM · Firefox, Differential
epriestley added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

This was the old ligature block:

Mar 30 2015, 6:52 PM · Firefox, Differential
epriestley added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

I'll try to do this and cross-link the Bugzilla ticket here if that's it. Sounds good?

Mar 30 2015, 6:44 PM · Firefox, Differential
epriestley added a revision to T7690: Unnecessary scroll bars for changesets in Firefox: Unknown Object (Differential Revision).
Mar 30 2015, 6:42 PM · Firefox, Differential
epriestley added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

In particular, the .differential-changeset is the thing picking up the scrollbar -- not the .changeset-view-content -- but adding overflow-y: hidden to either element removes the scrollbar.

Mar 30 2015, 6:41 PM · Firefox, Differential
epriestley added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

Er, sorry, I can reproduce it.

Mar 30 2015, 6:40 PM · Firefox, Differential
epriestley added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

I can reproduce this on Firefox 36 on Windows 7.

Mar 30 2015, 6:40 PM · Firefox, Differential
epriestley added a comment to T7697: Drag and drop a text fragment to top-right search box adds it to the placeholder.

Yeah, I'm pretty sure I've only ever used this by accident.

Mar 30 2015, 3:35 PM · Firefox
epriestley added a comment to T7697: Drag and drop a text fragment to top-right search box adds it to the placeholder.

I can reproduce the report only in Firefox; Chrome and Safari work fine for me.

Mar 30 2015, 3:28 PM · Firefox
epriestley added a comment to T7697: Drag and drop a text fragment to top-right search box adds it to the placeholder.

Here's how I do it in Safari:

Mar 30 2015, 3:26 PM · Firefox
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 3:25 PM · Typeahead
epriestley added a comment to T7697: Drag and drop a text fragment to top-right search box adds it to the placeholder.

I can't reproduce this in Safari 8.0.4 on OSX.

Mar 30 2015, 3:23 PM · Firefox
epriestley added a comment to T7693: Allow users to leave threads with members who are invalid or have been destroyed.

Objects which are attributed to that user could be re-attributed to a dummy

Mar 30 2015, 2:58 PM · Conpherence
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 2:47 PM · Typeahead
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 2:40 PM · Typeahead
epriestley added a comment to T7692: Support for pure AnonymousUser LDAP binds.

I assume that was handled by the password envelope

Mar 30 2015, 2:22 PM · LDAP, libphutil
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 2:05 PM · Typeahead
epriestley closed T7692: Support for pure AnonymousUser LDAP binds as Wontfix.

I assume my patch does not change current behaviour for others

Mar 30 2015, 2:01 PM · LDAP, libphutil
epriestley added a revision to T7061: Some UIs activate dialogs incorrectly when Quicksand is active: Unknown Object (Differential Revision).
Mar 30 2015, 1:37 PM · Quicksand
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 1:24 PM · Typeahead
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 12:51 PM · Typeahead
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 12:51 PM · Typeahead
epriestley added a project to T7696: Add a button on comment/description editor interface for quote blocks: Remarkup.
Mar 30 2015, 12:31 PM · Remarkup
epriestley closed T7695: Test as Resolved.
Mar 30 2015, 12:25 PM
epriestley added a comment to T7693: Allow users to leave threads with members who are invalid or have been destroyed.

I filed bin/remove support in T7694.

Mar 30 2015, 12:17 PM · Conpherence
epriestley created T7694: Allow Conpherence threads to be destroyed.
Mar 30 2015, 12:16 PM · Conpherence
epriestley raised the priority of T7693: Allow users to leave threads with members who are invalid or have been destroyed from Normal to Needs Triage.

I haven't reproduced this myself, although I saw one other similar report so I suspect it will reproduce easily.

Mar 30 2015, 12:15 PM · Conpherence
epriestley added a subtask for T7571: Conpherence v2 Errata: T7693: Allow users to leave threads with members who are invalid or have been destroyed.
Mar 30 2015, 12:15 PM · Conpherence
epriestley added a parent task for T7693: Allow users to leave threads with members who are invalid or have been destroyed: T7571: Conpherence v2 Errata.
Mar 30 2015, 12:15 PM · Conpherence
epriestley renamed T7693: Allow users to leave threads with members who are invalid or have been destroyed from Delete Conpherence Threads to Allow users to leave threads with members who are invalid or have been destroyed.
Mar 30 2015, 12:14 PM · Conpherence
epriestley added a comment to T7693: Allow users to leave threads with members who are invalid or have been destroyed.

We won't be adding this to the UI. Like with most other objects and applications, it is intentional that objects can not be permanently destroyed from the web UI. Among other things, this severely limits the damage a malicious or compromised user can cause.

Mar 30 2015, 12:13 PM · Conpherence
epriestley added a comment to T7692: Support for pure AnonymousUser LDAP binds.

It is expected that this block will handle the case you describe, note the comment about rebinding with anonymous credentials and the actual rebind lower down.

Mar 30 2015, 12:10 PM · LDAP, libphutil
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 30 2015, 1:27 AM · Typeahead
epriestley created T7689: Load handles just-in-time.
Mar 30 2015, 12:27 AM · Typeahead
epriestley created T7688: Move token rendering into TypeaheadDatasource.
Mar 30 2015, 12:16 AM · Typeahead
epriestley added a comment to T5750: Implement typeahead browse mode.

Here's my v0 plan for this:

Mar 30 2015, 12:12 AM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest
epriestley renamed T5750: Implement typeahead browse mode from Design magic Typeahead to Implement typeahead browse mode.
Mar 30 2015, 12:03 AM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest
epriestley updated subscribers of T5750: Implement typeahead browse mode.
Mar 30 2015, 12:02 AM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest
epriestley merged task T6634: Typeahead default should maybe be more than 5 into T5750: Implement typeahead browse mode.
Mar 30 2015, 12:02 AM · Typeahead, Maniphest
epriestley merged task T1906: Add projects list when creating new task into T5750: Implement typeahead browse mode.
Mar 30 2015, 12:01 AM · Typeahead, Wikimedia, Maniphest
epriestley updated subscribers of T5750: Implement typeahead browse mode.
Mar 30 2015, 12:01 AM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest

Mar 29 2015

epriestley added a project to T4100: Support query parameterization in typeaheads: Typeahead.
Mar 29 2015, 11:56 PM · Typeahead, User Delight, Maniphest
epriestley added a project to T6616: Typeahead uses locale-specific comparison: Typeahead.
Mar 29 2015, 11:55 PM · Typeahead, PHUI
epriestley added a project to T5750: Implement typeahead browse mode: Typeahead.
Mar 29 2015, 11:55 PM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest
epriestley added a project to T6634: Typeahead default should maybe be more than 5: Typeahead.
Mar 29 2015, 11:54 PM · Typeahead, Maniphest
epriestley added a project to T1906: Add projects list when creating new task: Typeahead.
Mar 29 2015, 11:54 PM · Typeahead, Wikimedia, Maniphest
epriestley added a project to T7255: Typeahead shows Source classes for uninstalled applications: Typeahead.
Mar 29 2015, 11:53 PM · Typeahead, Infrastructure

Mar 28 2015

epriestley closed T7061: Some UIs activate dialogs incorrectly when Quicksand is active as Resolved by committing Restricted Diffusion Commit.
Mar 28 2015, 10:45 PM · Quicksand
epriestley closed T7061: Some UIs activate dialogs incorrectly when Quicksand is active, a subtask of T7014: Annouce Persistent Chat option in Conpherence, as Resolved.
Mar 28 2015, 10:45 PM · Conpherence
epriestley closed T7061: Some UIs activate dialogs incorrectly when Quicksand is active, a subtask of T7573: Ship Quicksand, as Resolved.
Mar 28 2015, 10:45 PM · Quicksand, Conpherence
epriestley added a revision to T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width: Unknown Object (Differential Revision).
Mar 28 2015, 10:44 PM · Quicksand
epriestley added a revision to T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width: Unknown Object (Differential Revision).
Mar 28 2015, 10:20 PM · Quicksand
epriestley added a revision to T7061: Some UIs activate dialogs incorrectly when Quicksand is active: Unknown Object (Differential Revision).
Mar 28 2015, 9:49 PM · Quicksand
epriestley closed T3669: Make it easier to remember to submit inline comments when updating a diff as Resolved.

The draft state is now communicated very clearly. Presuming this is resolved at HEAD until we see more reports.

Mar 28 2015, 9:36 PM · Design, Differential
epriestley closed T3669: Make it easier to remember to submit inline comments when updating a diff, a subtask of T7447: Bring inline comments forward across revision updates, as Resolved.
Mar 28 2015, 9:36 PM · Prioritized, Differential
epriestley closed T7558: Conpherence doesn't scroll to bottom in Durable Column regularly as Resolved by committing Restricted Diffusion Commit.
Mar 28 2015, 3:35 PM · Conpherence (v4)
epriestley closed T7558: Conpherence doesn't scroll to bottom in Durable Column regularly, a subtask of T7572: Ship Durable Chat Column, as Resolved.
Mar 28 2015, 3:35 PM · Conpherence
epriestley created T7681: Main Conpherence UI should use JX.Scrollbar.
Mar 28 2015, 3:30 PM · Conpherence
epriestley added a revision to T7558: Conpherence doesn't scroll to bottom in Durable Column regularly: Unknown Object (Differential Revision).
Mar 28 2015, 3:21 PM · Conpherence (v4)
epriestley claimed T7558: Conpherence doesn't scroll to bottom in Durable Column regularly.
Mar 28 2015, 3:17 PM · Conpherence (v4)
epriestley created T7680: Quicksand does not update `pageObjects` correctly.
Mar 28 2015, 2:39 PM · Quicksand
epriestley closed T7058: Quicksand gets confused if you manually navigate to the original page, a subtask of T7014: Annouce Persistent Chat option in Conpherence, as Resolved.
Mar 28 2015, 2:38 PM · Conpherence
epriestley closed T7058: Quicksand gets confused if you manually navigate to the original page as Resolved by committing Restricted Diffusion Commit.
Mar 28 2015, 2:38 PM · Quicksand
epriestley closed T7058: Quicksand gets confused if you manually navigate to the original page, a subtask of T7573: Ship Quicksand, as Resolved.
Mar 28 2015, 2:38 PM · Quicksand, Conpherence
epriestley added a revision to T7058: Quicksand gets confused if you manually navigate to the original page: Unknown Object (Differential Revision).
Mar 28 2015, 2:29 PM · Quicksand
epriestley closed T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width as Resolved by committing Restricted Diffusion Commit.
Mar 28 2015, 1:54 PM · Quicksand
epriestley closed T7063: Comment previews don't work in Quicksand as Resolved by committing Restricted Diffusion Commit.
Mar 28 2015, 1:54 PM · Quicksand