Page MenuHomePhabricator
Create Task
Maniphest T7584

Add an ApplicationSearch UI for rooms to Conpherence
Closed, ResolvedPublic
Actions

Description

For v0:

  • Add a standard ApplicationSearch UI to Conpherence somewhere. This could be a hidden URL, like /conpherence/room/ (tee hee hee).
  • By default, it should show only threads with the isRoom flag (maybe an ApplicationSearch option lets you search for "all threads chad was on" as an advanced use case -- see also T3165 for content search).
  • We should make this work no matter where we go with the UI eventually, because it makes it possible to build dashboards.
  • This UI should let you make a "New Room" instead of a "New Message". This is similar to "New Message", except you specify:
    • Name of the room.
    • View and join policy.
    • Edit policy (default: you).
    • When created, the thread gets an isRoom flag.

For v1:

  • Figure out how this integrates into full UI and column UI.

Revisions and Commits

rP Phabricator
D12232rPfa673dde35ef Conpherence - finish basic application search
D12215rP89fe35cb0ecb Conpherence - add application search in a few more places.
D12113rP014bb720505f Conpherence - add "room" search UI and create UI

Related Objects
Search...

StatusAssignedTask
 OpenNoneT7569 Support Feed/Notifications in Conpherence
 ResolvedbtrahanT7565 Ship Conpherence v2
 ResolvedbtrahanT7572 Ship Durable Chat Column
 OpenNoneT7589 Decide on pinning, sorting, and notification behaviors in icon switcher
 WontfixchadT7588 Provide UI to let users switch to threads/rooms other than the 6 most recent
 OpenNoneT7577 Improve username mention rules for Conpherence
 ResolvedbtrahanT7578 Render username mentions in Conpherence in a disabled style if the user can not see the thread
 OpenNoneT7579 Notify users if their name is mentioned in a Conpherence thread they can see but are not a member of
 OpenNoneT7580 Alert users to username mentions in Conpherence threads they are members of
 OpenNoneT7567 Support sound in Conpherence
 ResolvedepriestleyT5369 Phabricator should play lots of sounds all the time to give the experience of an elusive, ineffable richness
 ResolvedchadT7380 Build icon-based room switcher for persistent chat pane
 DuplicateNoneT7014 Annouce Persistent Chat option in Conpherence
 ResolvedepriestleyT7529 Durable Column scrollbars be runnin wild (desktop)
 ResolvedbtrahanT7539 Dragging a file into Durable Column on /home/ triggers full upload
 ResolvedepriestleyT7058 Quicksand gets confused if you manually navigate to the original page
 ResolvedepriestleyT7063 Comment previews don't work in Quicksand
 ResolvedNoneT7061 Some UIs activate dialogs incorrectly when Quicksand is active
 ResolvedbtrahanT7064 Hi-Sec doesn't work properly with Quicksand
 ResolvedepriestleyT7059 Quicksand and the JX.busy navigation bar don't interact properly
Restricted Maniphest Task
 ResolvedbtrahanT7566 Implement "Rooms" in Conpherence
 ResolvedbtrahanT7584 Add an ApplicationSearch UI for rooms to Conpherence

Event Timeline

epriestley created this task.Mar 16 2015, 9:07 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Conpherence.
epriestley added subscribers: joshuaspence, epriestley, btrahan, chad.
epriestley mentioned this in T7566: Implement "Rooms" in Conpherence.Mar 16 2015, 9:13 PM
epriestley moved this task from Backlog to v2 on the Conpherence board.Mar 16 2015, 9:41 PM
btrahan claimed this task.Mar 17 2015, 10:54 PM
chad moved this task from v2 to v3 on the Conpherence board.Mar 19 2015, 3:08 PM
btrahan added a revision: D12113: Conpherence - add "room" search UI and create UI.Mar 19 2015, 9:49 PM
btrahan added a commit: rP014bb720505f: Conpherence - add "room" search UI and create UI.Mar 24 2015, 8:04 PM
btrahan mentioned this in T7585: Implement view/join rules for rooms.Mar 25 2015, 10:33 PM

Did we end up with a specific vision on the "Figure out how this integrates into full UI and column UI." bit? I think I have the rest of this done now. I know this is in V3 but it feels like I need it to do much of anything with rooms.

chad added a comment.Mar 25 2015, 11:24 PM

Search
There is a mock for full-ui in T7566, which feels pretty complete. I think for column we could just add a menu item to the title bar - Join a Room... Or something.

New Room
Probably just add it along with "New Message" in Conpherence Full. I don't think we need it in the column.

btrahan added a revision: D12215: Conpherence - add application search in a few more places..Mar 30 2015, 11:18 PM
btrahan added a comment.Mar 30 2015, 11:24 PM

D12215 adds search as the mock in T7566 specifies, and then goes off book and adds a little search button as the mysterious 7th icon in the icon bar that takes you to the application search.

Currently, new rooms can only be created via the application search. I kind of like this property as I think the product is better if there's not a bunch of duplicate rooms. (Also, I think we want to avoid the business of merging rooms / threads.) Relatedly, you can only create rooms from the application search (which is reasonable for now since you can only search rooms as well.)

I think I will consider this fixed once I add the ability to also search threads, and not just rooms. I like how it defaults funnels torwards rooms but I think you need to be able to search threads here too.

btrahan added a commit: rP89fe35cb0ecb: Conpherence - add application search in a few more places..Mar 30 2015, 11:25 PM
epriestley added a comment.Mar 30 2015, 11:29 PM

That makes sense to me. I think D12215 is generally a good smooth intro to letting users do everything without overcommitting to tons of JS.

btrahan added a revision: D12232: Conpherence - finish basic application search.Mar 31 2015, 11:35 PM
btrahan closed this task as Resolved by committing rPfa673dde35ef: Conpherence - finish basic application search.Apr 1 2015, 10:48 PM
btrahan added a commit: rPfa673dde35ef: Conpherence - finish basic application search.
Phabricator · Built by Phacility