Page MenuHomePhabricator
Feed Advanced Search

Aug 29 2017

chad created D18489: Align first nav item in settings.
Aug 29 2017, 4:38 PM

Aug 28 2017

chad committed rP81f42b834366: Align sidenavs better, use sky to highlight (authored by chad).
Align sidenavs better, use sky to highlight
Aug 28 2017, 11:36 PM
chad closed D18488: Align sidenavs better, use sky to highlight.
Aug 28 2017, 11:36 PM
chad created D18488: Align sidenavs better, use sky to highlight.
Aug 28 2017, 11:09 PM
chad accepted D18487: Make Ferret indexing more robust (UTF8, exception handling).
Aug 28 2017, 10:49 PM
chad committed rP0609133f4564: Limit notifications to latest 10, instead of 15 (authored by chad).
Limit notifications to latest 10, instead of 15
Aug 28 2017, 10:15 PM
chad closed D18486: Limit notifications to latest 10, instead of 15.
Aug 28 2017, 10:15 PM
chad created D18486: Limit notifications to latest 10, instead of 15.
Aug 28 2017, 10:12 PM
chad committed rPed75250f1a9d: Update notification UI a little (authored by chad).
Update notification UI a little
Aug 28 2017, 9:53 PM
chad closed D18485: Update notification UI a little.
Aug 28 2017, 9:52 PM
chad closed T8944: Unread vs read notifications are difficult to distinguish when viewed at an indirect angle on a 13" Macbook Air as Resolved by committing rPed75250f1a9d: Update notification UI a little.
Aug 28 2017, 9:52 PM · PHUI, Notifications
chad accepted D18484: Build a prototype fulltext engine ("Ferret") using only basic MySQL primitives.
Aug 28 2017, 9:49 PM
chad created D18485: Update notification UI a little.
Aug 28 2017, 9:49 PM
chad added a revision to T8944: Unread vs read notifications are difficult to distinguish when viewed at an indirect angle on a 13" Macbook Air: D18485: Update notification UI a little.
Aug 28 2017, 9:49 PM · PHUI, Notifications
chad closed T7843: Marking all notifications as read - action flow tedious as Resolved.
Aug 28 2017, 8:50 PM · Notifications
chad added a revision to T7843: Marking all notifications as read - action flow tedious: D18483: Don't prompt to mark notifications as read if we don't need to.
Aug 28 2017, 8:50 PM · Notifications
chad added a task to D18483: Don't prompt to mark notifications as read if we don't need to: T7843: Marking all notifications as read - action flow tedious.
Aug 28 2017, 8:50 PM
chad added a comment to D18483: Don't prompt to mark notifications as read if we don't need to.

I can't believe how much time I've spent on this....

Aug 28 2017, 8:16 PM
chad accepted D18483: Don't prompt to mark notifications as read if we don't need to.
Aug 28 2017, 7:52 PM
chad added a comment to D18482: Clarify language when Autoclose is disabled for a repository.

Hall of Heroes here I come.

Aug 28 2017, 7:03 PM
chad committed rPb8b701faf734: Clarify language when Autoclose is disabled for a repository (authored by chad).
Clarify language when Autoclose is disabled for a repository
Aug 28 2017, 7:00 PM
chad closed D18482: Clarify language when Autoclose is disabled for a repository.
Aug 28 2017, 7:00 PM
chad closed T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting." as Resolved by committing rPb8b701faf734: Clarify language when Autoclose is disabled for a repository.
Aug 28 2017, 7:00 PM · Diffusion
chad added a comment to D18482: Clarify language when Autoclose is disabled for a repository.

No I want the leaderboard karma.

Aug 28 2017, 7:00 PM
chad updated the test plan for D18482: Clarify language when Autoclose is disabled for a repository.
Aug 28 2017, 6:44 PM
chad added a revision to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.": D18482: Clarify language when Autoclose is disabled for a repository.
Aug 28 2017, 6:43 PM · Diffusion
chad created D18482: Clarify language when Autoclose is disabled for a repository.
Aug 28 2017, 6:43 PM
chad committed rP37843127e94a: Widen blame age line in blame view (authored by chad).
Widen blame age line in blame view
Aug 28 2017, 6:32 PM
chad closed D18481: Widen blame age line in blame view.
Aug 28 2017, 6:32 PM
chad added a reviewer for D18481: Widen blame age line in blame view: avivey.
Aug 28 2017, 6:05 PM
chad created D18481: Widen blame age line in blame view.
Aug 28 2017, 5:57 PM
chad closed T12824: Redesign Diffusion as Resolved.

The bulk of the work here is finished, no plans on approaching a re-design for diffusion home this pass.

Aug 28 2017, 5:57 PM · Design, Diffusion
chad closed T12804: Diffusion pre-redesign UI feedback (June 2017) as Resolved.

Closing out, thanks for all the feedback. Will follow up with individual tasks not addressed.

Aug 28 2017, 5:56 PM · Diffusion, Design
chad closed T12804: Diffusion pre-redesign UI feedback (June 2017), a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 28 2017, 5:56 PM · Design, Diffusion
chad closed T7701: Surface Code/File search better in Diffusion as Resolved.

New search shipping with last week's stable release.

Aug 28 2017, 5:46 PM · Restricted Project, Design, Diffusion
chad added a comment to D18479: Add a setting for 'mark all read' notifications.

This approach seemed cleaner as simpler than my last over-engineered attempt. It just reloads the page after it sends the request off. Is this a decent approach? I'll follow up with adding a checkbox directly on the dialog for the setting. As for the button on /notifications/ I'm having some issue finding a clean solution since search results always want a PHUIButtonView and not a form. I'll think more about the best approach there, but I don't think it's any priority.

Aug 28 2017, 5:41 PM

Aug 27 2017

chad merged task T12972: Ignoring missing version information on binaries doesn't seem to work into T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Aug 27 2017, 4:05 PM · Mercurial, Diffusion
chad merged T12972: Ignoring missing version information on binaries doesn't seem to work into T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Aug 27 2017, 4:05 PM · Diffusion (v3)
chad added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

Ah, it sounded like a regression from the report. I haven't tried to bisect to determine if that was true.

Aug 27 2017, 4:05 PM · Mercurial, Diffusion
chad committed rPHUdfced13a45f3: Fix binary translation text (authored by chad).
Fix binary translation text
Aug 27 2017, 3:59 PM
chad closed D18480: Fix binary translation text.
Aug 27 2017, 3:59 PM
chad created T12972: Ignoring missing version information on binaries doesn't seem to work.
Aug 27 2017, 3:58 PM · Mercurial, Diffusion
chad created D18480: Fix binary translation text.
Aug 27 2017, 3:53 PM
chad added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

it shouldn't have changed, just now a border. I don't know how to update the colors since it some sort of strange math only engineers know.

Aug 27 2017, 4:27 AM · Diffusion, Design

Aug 25 2017

chad updated the summary of D18479: Add a setting for 'mark all read' notifications.
Aug 25 2017, 11:52 PM
chad updated the diff for D18479: Add a setting for 'mark all read' notifications.
  • fix race condition
Aug 25 2017, 11:41 PM
chad planned changes to D18479: Add a setting for 'mark all read' notifications.

Let me test this some more.

Aug 25 2017, 11:18 PM
chad updated the summary of D18479: Add a setting for 'mark all read' notifications.
Aug 25 2017, 11:15 PM
chad updated the diff for D18479: Add a setting for 'mark all read' notifications.
  • make it all work
Aug 25 2017, 11:12 PM
chad created D18479: Add a setting for 'mark all read' notifications.
Aug 25 2017, 9:11 PM
chad committed rP750be1c92a66: Minor spacing clean up on search button (authored by chad).
Minor spacing clean up on search button
Aug 25 2017, 4:41 PM
chad closed D18477: Minor spacing clean up on search button.
Aug 25 2017, 4:41 PM
chad created D18477: Minor spacing clean up on search button.
Aug 25 2017, 4:35 PM
chad added a comment to D18133: Remove dialog from "Mark All Read" notifications.

I'll add a setting, since we just cleaned up the Notifications panel

Aug 25 2017, 4:26 PM
chad abandoned D18133: Remove dialog from "Mark All Read" notifications.
Aug 25 2017, 4:25 PM
chad commandeered D18133: Remove dialog from "Mark All Read" notifications.
Aug 25 2017, 4:25 PM
chad added a comment to D18133: Remove dialog from "Mark All Read" notifications.

Yeah I’ve just never felt I needed to undo an "Mark all as read” action.
The list is still present, so the risk seems…. very low. It’s not like
deleting a comment.

Aug 25 2017, 4:22 PM
chad added a comment to D18133: Remove dialog from "Mark All Read" notifications.

I'm going to take this back and complete. Do you feel a setting needed for this?

Aug 25 2017, 4:15 PM
chad committed rP79c6b5004914: Fix fatal on logged out Phame Post (authored by chad).
Fix fatal on logged out Phame Post
Aug 25 2017, 3:48 PM
chad closed D18475: Fix fatal on logged out Phame Post.
Aug 25 2017, 3:48 PM
chad updated the summary of D18475: Fix fatal on logged out Phame Post.
Aug 25 2017, 3:37 PM
chad updated the diff for D18475: Fix fatal on logged out Phame Post.
  • remove phame views
Aug 25 2017, 3:31 PM
chad created E1663: Dentist.
Aug 25 2017, 3:25 PM
chad accepted D18476: Add a missing (int) cast to diff IDs for new "transaction.search" method.
Aug 25 2017, 2:31 PM
chad planned changes to D18475: Fix fatal on logged out Phame Post.

I'll just remove the transaction in the morning.

Aug 25 2017, 4:33 AM
chad created D18475: Fix fatal on logged out Phame Post.
Aug 25 2017, 3:39 AM
chad added a comment to D18474: Fix bad tables in diffusion blame.

635886798091790126-2105902932_10519861.gif (216×500 px, 2 MB)

Aug 25 2017, 3:03 AM
chad committed rP94cad30ac3f0: Fix bad tables in diffusion blame (authored by chad).
Fix bad tables in diffusion blame
Aug 25 2017, 3:02 AM
chad closed D18474: Fix bad tables in diffusion blame.
Aug 25 2017, 3:02 AM
chad created D18474: Fix bad tables in diffusion blame.
Aug 25 2017, 2:53 AM
chad committed rP12ae08b6b1a1: Move differential revision to its own table column in blame view (authored by chad).
Move differential revision to its own table column in blame view
Aug 25 2017, 2:36 AM
chad closed D18473: Move differential revision to its own table column in blame view.
Aug 25 2017, 2:36 AM
chad committed rPc49896f7c5a7: Some header tag icons are too small (authored by chad).
Some header tag icons are too small
Aug 25 2017, 2:30 AM
chad closed D18472: Some header tag icons are too small.
Aug 25 2017, 2:30 AM
chad created D18473: Move differential revision to its own table column in blame view.
Aug 25 2017, 2:28 AM
chad created D18472: Some header tag icons are too small.
Aug 25 2017, 2:11 AM
chad committed rP336fe5cdc525: Dont send an email when someone views a Phame post (authored by chad).
Dont send an email when someone views a Phame post
Aug 25 2017, 2:00 AM
chad closed D18471: Dont send an email when someone views a Phame post.
Aug 25 2017, 2:00 AM
chad added a comment to D18471: Dont send an email when someone views a Phame post.

It's straight copy/pasta from shouldPublishFeed

Aug 25 2017, 1:59 AM
chad added a reviewer for D18471: Dont send an email when someone views a Phame post: avivey.
Aug 25 2017, 1:56 AM
chad created D18471: Dont send an email when someone views a Phame post.
Aug 25 2017, 1:54 AM
chad added a comment to Blog Post: Projects in Policy Controls: No Longer Total Garbage.

hi

Aug 25 2017, 1:48 AM · Policy, Projects
chad added a comment to Blog Post: Advanced Internet Usage (Experts ONLY!).

it's cascading. I'll fix

Aug 25 2017, 1:46 AM
chad added a comment to Blog Post: Advanced Internet Usage (Experts ONLY!).

I presume people aren't editing this?

Aug 25 2017, 1:39 AM

Aug 24 2017

chad accepted D18467: Allow ModularTransactions to opt in to providing data to Conduit.
Aug 24 2017, 10:21 PM
chad accepted D18469: Provide some more detailed information about inline comments in "transaction.search".
Aug 24 2017, 10:20 PM
chad accepted D18468: Slightly simplify logic for determining if an inline comment has an effect.
Aug 24 2017, 10:18 PM
chad accepted D18466: Add the skeleton for a "transaction.search" Conduit API method.
Aug 24 2017, 9:50 PM
chad accepted D18464: Remove rows for personal saved builtin queries.
Aug 24 2017, 8:52 PM
chad accepted D18465: Prevent Differential changeset HTML anchors from colliding with comment anchors.
Aug 24 2017, 8:52 PM
chad closed T12971: Add a management dropdown to list of instances as Resolved.
Aug 24 2017, 8:51 PM · Phacility
chad committed rPec88917dd71e: Remove hover state from labels in action list (authored by chad).
Remove hover state from labels in action list
Aug 24 2017, 8:00 PM
chad closed D18463: Remove hover state from labels in action list.
Aug 24 2017, 8:00 PM
chad created D18463: Remove hover state from labels in action list.
Aug 24 2017, 7:39 PM
chad committed rP66613240fa05: Have text-less dropdown buttons look better (authored by chad).
Have text-less dropdown buttons look better
Aug 24 2017, 7:37 PM
chad closed D18461: Have text-less dropdown buttons look better.
Aug 24 2017, 7:37 PM
chad committed rP0a013341721f: Fix float issue on diffusion blame view (authored by chad).
Fix float issue on diffusion blame view
Aug 24 2017, 7:05 PM
chad closed D18462: Fix float issue on diffusion blame view.
Aug 24 2017, 7:05 PM
chad created D18462: Fix float issue on diffusion blame view.
Aug 24 2017, 7:01 PM
chad updated the diff for D18461: Have text-less dropdown buttons look better.
  • Add some uiexamples
Aug 24 2017, 6:58 PM