Page MenuHomePhabricator

Slightly simplify logic for determining if an inline comment has an effect
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:16 PM.
Tags
None
Referenced Files
F17925002: D18468.id44371.diff
Wed, Jul 30, 10:50 AM
F17755079: D18468.id44363.diff
Tue, Jul 22, 11:52 AM
F17727140: D18468.id44363.diff
Sat, Jul 19, 12:41 AM
F17720397: D18468.id44371.diff
Fri, Jul 18, 6:24 AM
F17713416: D18468.diff
Thu, Jul 17, 1:43 PM
Unknown Object (File)
May 30 2025, 2:26 AM
Unknown Object (File)
May 7 2025, 8:55 AM
Unknown Object (File)
Apr 30 2025, 1:14 AM
Subscribers
None

Details

Summary

Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan

Made inlines, tried to submit empty comments. Behavior unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable