Page MenuHomePhabricator

Slightly simplify logic for determining if an inline comment has an effect
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:16 PM.
Tags
None
Referenced Files
F13126527: D18468.diff
Tue, Apr 30, 4:48 PM
Unknown Object (File)
Sat, Apr 27, 5:12 AM
Unknown Object (File)
Mar 28 2024, 5:40 PM
Unknown Object (File)
Feb 21 2024, 12:41 PM
Unknown Object (File)
Feb 3 2024, 4:32 PM
Unknown Object (File)
Jan 24 2024, 3:41 AM
Unknown Object (File)
Dec 28 2023, 8:58 AM
Unknown Object (File)
Dec 19 2023, 3:49 AM
Subscribers
None

Details

Summary

Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan

Made inlines, tried to submit empty comments. Behavior unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable