Page MenuHomePhabricator

Slightly simplify logic for determining if an inline comment has an effect
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 30, 2:26 AM
Unknown Object (File)
Wed, May 7, 8:55 AM
Unknown Object (File)
Apr 30 2025, 1:14 AM
Unknown Object (File)
Apr 28 2025, 9:42 AM
Unknown Object (File)
Apr 27 2025, 10:02 AM
Unknown Object (File)
Apr 26 2025, 6:56 AM
Unknown Object (File)
Apr 23 2025, 4:13 PM
Unknown Object (File)
Apr 9 2025, 5:18 PM
Subscribers
None

Details

Summary

Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan

Made inlines, tried to submit empty comments. Behavior unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable