Page MenuHomePhabricator

Slightly simplify logic for determining if an inline comment has an effect
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:16 PM.
Tags
None
Referenced Files
F14093129: D18468.diff
Mon, Nov 25, 9:39 AM
Unknown Object (File)
Thu, Nov 21, 11:31 AM
Unknown Object (File)
Sat, Nov 16, 8:16 PM
Unknown Object (File)
Wed, Oct 30, 4:47 AM
Unknown Object (File)
Sun, Oct 27, 6:11 AM
Unknown Object (File)
Oct 27 2024, 2:50 AM
Unknown Object (File)
Oct 17 2024, 6:59 AM
Unknown Object (File)
Oct 17 2024, 6:56 AM
Subscribers
None

Details

Summary

Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan

Made inlines, tried to submit empty comments. Behavior unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable