Page MenuHomePhabricator

Allow ModularTransactions to opt in to providing data to Conduit
ClosedPublic

Authored by epriestley on Aug 24 2017, 9:50 PM.

Details

Summary

Ref T5873. See PHI14. I don't want to just expose internal transaction data to Conduit by default, since it's often: unstable, unusable, sensitive, or some combination of the three.

Instead, let ModularTransactions opt in to providing additional data to Conduit, similar to other infrastructure. If a transaction doesn't, the API returns an empty skeleton for it. This is generally fine since most transactions have no real use cases, and I think we can fill them in as we go.

This also probably builds toward T5726, which would likely use the same format, and perhaps simply not publish stuff which did not opt in.

This doesn't actually cover "comment" or "inline comment", which are presumably what PHI14 is after, since neither is modular. I'll probably just put a hack in place for this until they can modularize since I suspect modularizing them here is difficult.

Test Plan

Ran transaction.search on a revision, saw some transactions (title and status transactions) populate with values.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 24 2017, 9:50 PM
chad accepted this revision.Aug 24 2017, 10:21 PM
This revision is now accepted and ready to land.Aug 24 2017, 10:21 PM
This revision was automatically updated to reflect the committed changes.