Page MenuHomePhabricator

Don't prompt to mark notifications as read if we don't need to
ClosedPublic

Authored by epriestley on Aug 28 2017, 7:18 PM.
Tags
None
Referenced Files
F15463322: D18483.diff
Tue, Apr 1, 10:28 PM
F15449351: D18483.diff
Fri, Mar 28, 9:39 AM
F15447878: D18483.id44401.diff
Fri, Mar 28, 2:08 AM
F15446855: D18483.id44402.diff
Thu, Mar 27, 8:31 PM
F15441191: D18483.id.diff
Wed, Mar 26, 4:52 PM
F15424400: D18483.diff
Mar 22 2025, 10:03 PM
F15417406: D18483.id44401.diff
Mar 20 2025, 4:56 PM
Unknown Object (File)
Mar 2 2025, 1:24 AM
Subscribers
None

Details

Summary

Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan
  • Generated notifications from a test account.
  • Clicked "Mark All" from dropdown menu, no prompt.
  • Clicked "Mark All" from notifications screen, no prompt.
  • Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable