Page MenuHomePhabricator

Don't prompt to mark notifications as read if we don't need to
ClosedPublic

Authored by epriestley on Aug 28 2017, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 1:24 AM
Unknown Object (File)
Tue, Feb 25, 8:21 AM
Unknown Object (File)
Feb 13 2025, 6:25 PM
Unknown Object (File)
Feb 8 2025, 2:36 AM
Unknown Object (File)
Feb 1 2025, 5:50 PM
Unknown Object (File)
Jan 27 2025, 7:48 AM
Unknown Object (File)
Jan 21 2025, 11:20 AM
Unknown Object (File)
Jan 18 2025, 10:48 AM
Subscribers
None

Details

Summary

Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan
  • Generated notifications from a test account.
  • Clicked "Mark All" from dropdown menu, no prompt.
  • Clicked "Mark All" from notifications screen, no prompt.
  • Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable