Page MenuHomePhabricator

Don't prompt to mark notifications as read if we don't need to
ClosedPublic

Authored by epriestley on Aug 28 2017, 7:18 PM.
Tags
None
Referenced Files
F18566410: D18483.id.diff
Tue, Sep 9, 2:36 PM
F18501457: D18483.diff
Thu, Sep 4, 9:45 PM
F18404557: D18483.id44401.diff
Fri, Aug 29, 10:39 PM
Unknown Object (File)
May 1 2025, 8:34 AM
Unknown Object (File)
May 1 2025, 8:34 AM
Unknown Object (File)
May 1 2025, 8:34 AM
Unknown Object (File)
Apr 30 2025, 1:04 PM
Unknown Object (File)
Apr 29 2025, 2:46 PM
Subscribers
None

Details

Summary

Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan
  • Generated notifications from a test account.
  • Clicked "Mark All" from dropdown menu, no prompt.
  • Clicked "Mark All" from notifications screen, no prompt.
  • Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable