Page MenuHomePhabricator

Don't prompt to mark notifications as read if we don't need to
ClosedPublic

Authored by epriestley on Aug 28 2017, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 3:49 PM
Unknown Object (File)
Thu, Apr 11, 10:55 AM
Unknown Object (File)
Feb 24 2024, 2:01 PM
Unknown Object (File)
Feb 20 2024, 5:27 PM
Unknown Object (File)
Feb 3 2024, 4:33 PM
Unknown Object (File)
Jan 25 2024, 12:33 AM
Unknown Object (File)
Jan 16 2024, 5:43 PM
Unknown Object (File)
Jan 12 2024, 5:38 PM
Subscribers
None

Details

Summary

Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan
  • Generated notifications from a test account.
  • Clicked "Mark All" from dropdown menu, no prompt.
  • Clicked "Mark All" from notifications screen, no prompt.
  • Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable