Page MenuHomePhabricator

Remove rows for personal saved builtin queries
ClosedPublic

Authored by epriestley on Aug 24 2017, 8:19 PM.

Details

Summary

Ref T12956. After this change, individual users will no longer be able to modify builtin queries on a user-by-user basis: they will always appear at the bottom of the list, under their personal queries, and can only be managed by administrators.

To support this, clean up the old rows which could be hanging around from before: delete any personal saved queries where the saved query is a builtin query.

To ease this transition, try to pin the query we're deleting if the user had reordered things to put it on top.

Test Plan
  • Ran the migration, saw no changes in the UI but fewer rows.
  • Went back to master, reordered queries to put a builtin one on top.
  • Ran the migration.
  • Saw that builtin one drop to the bottom (since it can't be on top anymore) but be pinned, preserving the behavior of /maniphest/.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 24 2017, 8:19 PM
chad accepted this revision.Aug 24 2017, 8:52 PM
This revision is now accepted and ready to land.Aug 24 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.