Page MenuHomePhabricator
Differential D18469

Provide some more detailed information about inline comments in "transaction.search"
ClosedPublic
Actions

Authored by epriestley on Aug 24 2017, 10:19 PM.
Tags
None
Referenced Files
F15555400: D18469.id.diff
Mon, Apr 28, 11:12 AM
F15552592: D18469.diff
Sun, Apr 27, 9:36 PM
F15548458: D18469.id.diff
Sat, Apr 26, 11:53 PM
F15548192: D18469.id44372.diff
Sat, Apr 26, 10:23 PM
F15488460: D18469.id44364.diff
Thu, Apr 10, 10:33 PM
F15462629: D18469.id44372.diff
Apr 1 2025, 4:25 PM
F15453243: D18469.id44372.diff
Mar 29 2025, 10:25 AM
F15451483: D18469.diff
Mar 28 2025, 10:20 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges
Commits
rPfa5bcf5d9478: Provide some more detailed information about inline comments in "transaction.
Summary

Ref T5873. This provides paths and line numbers for inline comments.

This is a touch hacky but I was able to keep it mostly under control.

Test Plan
  • Made inline comments.
  • Called API, got path/line information.

Screen Shot 2017-08-24 at 3.14.22 PM.png (508×631 px, 90 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
xaction/
53 lines
transactions/
conduit/
23 lines

Diff 44372

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php

Loading...
View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility