Set closed status to say "Archived".

• linty things
• correctly set field specification to phid

• capitalization
• keep herald's name field the same length, shorten index
• use PhabricatorPeopleUserFunctionDatasource in the initiator datasource

Yeah I have a diff incoming, looks like it's working.

It is fine as is.

Oh no, I confused myself terribly.

I believe this will allow someone to issue a pause command to an already paused build.

Oh wait, I almost snuck something past you, but I think it's correct to change this? Previously "paused" was considered a status that would indicate a build was "completed". This doesn't make sense semantically.

rebase?

I was thinking of moving the status stuff into a constants class too?

This is brittle but it works if your objects all use the native storage.

Yeah, unit messages are stored in a different table.

Oh, my mistake! Apologies.

Is this going to break again when he tries to land it?

I'm a corporate user and I love hiding things :(

Related to T11344

Not sold on this approach although I have had this exact problem a few times and this papers over the ugly about as well as you can I think?

I'm trying to figure out if I destroyed our files this weekend by migrating them or by using purge / compress.

Actually....

Do modular transactions make this more feasible now?

Ok cool.

I was thinking custom field that just pings a callback url was what I was thinking.

I guess this is customfieldable already, isn't it? There will be weirdness with checking state in the field / the interface doesn't explicitly support it, but I'm pretty sure it's doable.

See edit for clarification.

Is this not a modularizable thing?

I'm not sure if I"m just abusing this class?

It's causing a lot of pain mostly because we don't have good visibility into it happening, and we don't have any good way to react to it once we get close to fully saturated.

(broken wiki links everywhere)

+1 we just discovered this issue and ended up here

final class PhavNoUnitCustomArgument extends ICCustomArcanistArgument {

I emailed evan a "print page" pdf of the ticket off of our install.

14.04

INLINE COMMENTS BRAD

I think that this has only ever happened on Chrome on Ubuntu, and to boot, we've seen client side Ubuntu bugs pop up in the past. (Brad do you remember where?)

• Entirely unset mysql.host
• Configure a master and a replica in cluster.databases
• Go to /config/database/

(not that adding the feature would harm us, just my 2 cents)

We have a particularly opinionated set of developers here (when I say "opinionated", I mean roughly, nobody ever agrees on anything) and we've managed to successfully argue in favor of just using "plan changes" rather than opting for some other intermediary or distinct state. It correctly communicates to reviewers what you should want them to know: you're not done with the revision yet. Far and away the largest reason why this is our accepted workflow, rather than pushing on upstream to implement a "Not Yet Ready for Review" state is very tightly coupled to the entire concept of why Phabricator does review the way it does:

Developers do run the test suite locally if they suspect they probably broke things though, it's not "never", it's just "infrequently".

Yes we use arc unit as the chokepoint for "consistently run unit tests as far as phabricator is concerned", and use the --target flag when harbormaster is running the tests.

Thanks!

We haven't yet enabled, but will be enabling MFA this week.

The best way to describe this request from our perspective is "third party requirement", which falls under your definition of a policy compliance change, mostly.

I'll start doing this, I guess it makes me a little uncomfortable since the first thing I do is typically make sure nothing is broken once the daemons restart, but then again, nothing has ever been broken during a deployment. So maybe I will assume I am as smart as our past deployments have indicated I am, issue the reload, go to sleep, and then check in the morning.

There is no trickery involved in our repository edit field, it might as well be a datasource field.

test