Page MenuHomePhabricator

horribly fix plain-text email for modular transactions
ClosedPublic

Authored by avivey on Jul 8 2016, 12:03 AM.

Details

Summary

This is the quickest and dirtiest fix I could come up with.

PhabricatorApplicationTransaction::getTitleForMail() is using clone $this, which doesn't actually effect implementation.
Ref T9789.

Test Plan

update paste comment, get plaintext mail.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

avivey updated this revision to Diff 39091.Jul 8 2016, 12:03 AM
avivey retitled this revision from to horribly fix plain-text email for modular transactions.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey updated this object.Jul 8 2016, 12:03 AM
avivey edited edge metadata.
epriestley accepted this revision.Jul 8 2016, 12:06 AM
epriestley added a reviewer: epriestley.

(The clone might be in case the method throws? Doesn't seem like a big deal either way.)

This revision is now accepted and ready to land.Jul 8 2016, 12:06 AM
This revision was automatically updated to reflect the committed changes.
chad awarded a token.Jul 8 2016, 12:38 AM